- 24 Mar, 2020 40 commits
-
-
Lan Wei authored
After we finish the scroll unification, the scrolls happens mainly on the compositor thread, and the scroll code in the main thread will be removed. eventSender sends the scroll events to main thread, so it would not work after the scroll unification. We should replace eventSender.continuousMouseScrollBy with gpuBenchmarking.smoothScrollBy in scroll tests in fast/scroll-behavior/smooth-scroll/. Bug: 1047176 Change-Id: I3a2a153c2f1632167e06ce8e1f6b9600f1c54313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083341 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#753047}
-
Mila Green authored
Bug: 1055876 Change-Id: I6029d745092577314094e472d2528e52447e7a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118217 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#753046}
-
Lei Zhang authored
GetPageBounds() takes a 1-indexed page number. Test that it works and fix error handling for GetPageBounds(0). Change-Id: I8d771fb3f281864b54eca9905cee8b6699a635e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118572 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#753045}
-
Caroline Rising authored
Both the BubbleDialogDelegateView and the MenuButtonController were handling the ink drop highlight for the ExtensionsToolbarButton which caused the highlight to not appear when MenuButtonController::Activate() is used to show a popup rather than a menu. This change lets the ExtensionsToolbarButton observe the widget and take the lock. It also prevents ExtensionsMenuView from updating the ink drop a second time. This bug is specific to showing a popup, instead of a menu, anchored to the button. Bug: 1046422 Change-Id: I6f35d1415e66b603d8498c5950f15acc03cde8b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083673 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#753044}
-
Chong Gu authored
These tests have been stable on our FYI bot, so moving to CI. Bug: 1058255 Change-Id: Icd96d28379683375933288c74cf7460e93a1bcd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118571Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#753043}
-
Daniel Libby authored
Based on the referenced bug, it appears that the compositing query asserts were coming from ScrollableArea code a long time ago. There are more scoped disablers in that code (also tracked as part of crbug.com/1007989), but this one is no longer necessary. Bug: 1007989 Change-Id: Ia2b491ca9bd4bba68563772da1c971dcd35f31c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118215Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#753042}
-
Peter Kotwicz authored
This CL deletes code which reads the CustomTabIntentDataProvider#EXTRA_IS_OPENED_BY_WEBAPK intent extra. The intent extra is no longer set as a result of https://chromium-review.googlesource.com/c/chromium/src/+/1986123 BUG=None R=peconn TBR=yfriedman (fro trivial change in LaunchIntentDispatcher.java) Change-Id: I35d6e20acb8011b5dbc93d456245091e856cc67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113910 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#753041}
-
Armando Miraglia authored
As indicated by olka@, Media.AudioOutputResampler.OpenLowLatencyStream might be needed for an indefinite amount of time. This CL extends the histogram by one year. Fixed: 1055413 Change-Id: Ic5373584352e6ad25ccb0a59b4bf6556f4adaad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118090Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#753040}
-
Xing Liu authored
Image loader classes can be moved to internal, the ImageFetcher can be injected from query tiles factory. TBR=rhalavati@chromium.org Bug: 1058534 Change-Id: I3948c8809167f4c00824b26cf4fefc8aaf3a7bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118223 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#753039}
-
Tommy C. Li authored
We regressed setting the calculator answer icon's size correctly in April 2019 with this CL. (I was the reviewer, and missed it): https://chromium-review.googlesource.com/c/chromium/src/+/1557416 Most of the time, it has no negative affect, but in the unusual case where a Rich Entity sets the icon size, and then there's a calculator answer shortly after, the calculator answer icon will be shaped funny. This CL fixes that bug. Bug: 1063922 Change-Id: Ie98952bd44801df0b7b11e277fa06b3c87981c66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118914Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#753038}
-
Meredith Lane authored
Updates background, text and link colours to match Figma mocks, and also fix some colour contrast issues. Bug: 1025300 Change-Id: I1fca11a04863718ffa1676fe978538a2ebacd6c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114475Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#753037}
-
Noel Gordon authored
When files app is in html.col-resize, don't override its global resize cursor if the cursor is hovered over the breadcrumb custom element, or any child element of the breadcrumb. Bug: 1062902, 1035691 Change-Id: I12951cdd555dde2213658e633b0356cfe274e2ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117934Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#753036}
-
btolsch authored
This change pulls the heartbeat message handling and timers out into a new class that is separate from the CastTransport::Delegate responsibilities of KeepAliveDelegate. This will allow reuse with libcast CastSocket. Bug: 1050913 Change-Id: I463a5b7279a1120759506a776706ac5e85967282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108283 Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#753035}
-
Michael Li authored
When force uninstalling, filter chrome/nacl processes to kill by path prefix so other channels' instances are not killed. Bug: 812898 Change-Id: I7b1d19d3cc86d7847550efb9750b8cf98eb800b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083865 Auto-Submit: Michael Li <michli@microsoft.com> Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#753034}
-
Ryan Sleevi authored
These tests don't need to force disable CT, as they use a locally-trusted certificate. Bug: 1064391 Change-Id: Ib561c1e8bde794bc0b04ab809db1d76e07ce1a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117327 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Auto-Submit: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#753033}
-
tby authored
This adds presubmit validation coverage to the new projects section of the structured.xml file. As well as checking owners etc., it also ensures that all events reference either no project or a valid project. This is also implicitly checked by the fact that chrome won't compile otherwise, but two checks don't hurt :) Bug: 1034842 Change-Id: Idd73483c37a5976cf1173eb029d45cc8d46a0aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114770 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#753032}
-
nancy authored
The App info menu item should keep consistency with AppManagement. When the app is not shown in Appmanagement, don't show the App info menu item. Based on arc app pref, if the app is not launchable, it's not shown in launcher, then the app is not shown in AppManagement. So modify ARC shelf context menu, for not launchable app, don't show the App info item: https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc?l=1942 https://cs.chromium.org/chromium/src/chrome/browser/apps/app_service/arc_apps.cc?l=1005 b:152019364 Change-Id: If1610e91b63a431e5794575e68569f2edee6f65d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117550Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#753031}
-
Chris Lu authored
The PageLoad event has a policy of confining how its metrics are called to within the page_load_metrics codebase. This change moves the DidCommit metric to a new MainFrameNavigation event so it does not conflict with that. Bug: 1006357 Change-Id: Ifea3e3e7ae0d0b6eca9468c67e15b862872c9c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116940 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#753030}
-
nancy authored
Modify app id to get the app_id from the instance for the window first. If there is an app_id, reuse that app_id. Because some Chrome apps, e.g. google photos, might change the app_id and get the app_id from URL, which might cause app_id inconsistent issue. BUG=1011235 Change-Id: I7e3d73fe6b92d9d90591a4f60d066902e1f864b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115855 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#753029}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8f41598abfd6..d682fa4e329a git log 8f41598abfd6..d682fa4e329a --date=short --first-parent --format='%ad %ae %s' 2020-03-24 sokcevic@google.com Add support for git_hyper_blame for Windows Created with: gclient setdep -r src/third_party/depot_tools@d682fa4e329a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ibfd0423dbe71d0a7333d0fe574ad031f6f38a8c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117879Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753028}
-
Rohit Rao authored
Init() was originally using BrowserPolicyConnector::GetPolicyProviders() to retrieve a list of policy providers, but this method does not return providers that are overridden for testing. As a result, the BrowserState-level PolicyService did not include test providers. The code has been updated to additionally call BrowserPolicyConnector::GetPlatformProvider(), which does include overridden test providers. BUG=1024115 Change-Id: Ic81ac780df16007d7797024bd0398ade74447da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116918 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#753027}
-
Abhijeet Singh authored
This change fixes a bug where a Quick Answer is returned by the Search Parser despite a parse failure. This leads to unpredictable layout changes and inconsistent UX. Bug: b:152110565 Test: ChromeOS VM. Change-Id: I53b5f1bb73bda8d5a10b619630c294198575a601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118578Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Cr-Commit-Position: refs/heads/master@{#753026}
-
evliu authored
This CL updates the broker client permission for the SODA sandbox. The SODA service requires read access to the SODA component directory in order to determine the path to the latest version of the SODA component. Bug: 1039824 Change-Id: I1078d7c3e6b5da3f37c3cef1ddea5f3a2b2f2867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112965Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#753025}
-
Antonio Gomes authored
This CL moves css3/flexbox/column-flex-child-with-overflow-scroll.html to WPT directory. The test itself ensures the 'height' of flex children with 'overflow: scroll' do not shrink (commonly by the size of the scrollbar height). Original CL: https://codereview.chromium.org/417153003 BUG=1063749 R=dgrogan@chromium.org, robertma@chromium.org Change-Id: I30d1893d4d75125f68bb7b8daddb848597703ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118631Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#753024}
-
Robert Ogden authored
Description kept intentionally vauge. Bug: 1023485 Change-Id: I24162e40bc0108cd30a38bb7fdc3bfe49c8cbb8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118399 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#753023}
-
Lukasz Anforowicz authored
This CL migrates ContentScriptWithLegacyCorsBehaviorApiTest.CrossOriginXhr to the CrossOriginReadBlockingExtensionAllowlistingTest test suite (into a new test, called FromProgrammaticContentScript_UnloadedExtension). This way the test covers the following setup aspects: - CorbAllowlistAlsoAppliesToOorCors feature is enabled or disabled - Extension is allowlisted or not - OOR-CORS vs InBlinkCors After this CL the old test can be deleted. Note that the old test always tested with: - CorbAllowlistAlsoAppliesToOorCors disabled - Non-allowlisted extension - The default OOR-CORS state (enabled by default since r728462) Bug: 1061567, 1062043 Change-Id: Iaa85e84ebbcfde77d81f05949e1107280f35d373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105464Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#753022}
-
John Lee authored
This CL starts off a series of CLs to remove the --cr-section mixin. The mixin was in charge of aligning elements across a flex row, adding padding, and adding a border. For custom elements such as <extensions-toggle-row> that already assign their own padding and flex, only the hr class is needed. https://imgur.com/a/XZ3TfUs Bug: 973674 Change-Id: I7348334dc3d1922caa1b0664675cd77991477fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116536 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#753021}
-
Aaron Krajeski authored
Bug: 1052491 Change-Id: I30fc502cd00c8dc4d7528ddc8423c3c2643850c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110522 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#753020}
-
Kyle Horimoto authored
Some Mojo resources which were specific to OS settings were part of browser_resources.grd. This CL moves them within os_settings_resources.grd and os_settings_resources_vulcanized.grd. Change-Id: Ib24b8ccea01b95113f83037616577168e699c7f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109260 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#753019}
-
Adrienne Walker authored
This patch should have no behavior impact in Chrome at the moment. The goal is to give developers the ability to test Chrome with AppCache removed using runtime-enabled feature flags. It's also important to note that this feature flag does not fully remove AppCache usage. The <html manifest> attribute is still honored, and existing caches will still be used to load from even if this flag is disabled. Bug: 1055010, 582750 Change-Id: I0e0c38a2ba2aba6dce4c9057b27d1a5bd7f4ecfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116893 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#753018}
-
Scott Violet authored
This patch includes 'android_weblayer' as a possible platform when building the testing config on android. Without this switch, the testing config doesn't include 'android_weblayer' so that any configs targeted at 'android_weblayer' won't be configured correctly. BUG=1049426 TEST=test only change Change-Id: Ie34ea173545322b3e2b3f13f091c4dc901f23dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115878 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#753017}
-
Avi Drissman authored
Each SxS-capable Chrome channel can have a different brand code, so update the Keystone glue to know that. This can be tricky because the old, non-SxS-capable Chromes are still built from this code, so be sure to handle that case. Overview plan at https://docs.google.com/document/d/1MVANxDLPPeN1x-NsfgsLSjbX8twzQi69Wb1iPK-owaU/edit This is a re-landing of https://crrev.com/c/2102642, but without an extra std::move that was unnecessary and that caused compile issues. Bug: 1061486 Change-Id: I4007918bcc36d9512d60307b9b422fbe10f943f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118570 Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#753016}
-
Xianzhu Wang authored
We should allow decomposite blend mode effect when there is no backdrop, if other conditions allow. Bug: 765003 Change-Id: I4a5c8cb1139330d9894de6afa03843957bc8e9be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117293 Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#753015}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I1b0c9e25b4cecfc82ff9138519dfb4345a48de4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117326Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753014}
-
Dominique Fauteux-Chapleau authored
The issue was introduced by https://crrev.com/c/2092062 when it changed UploadFileForDeepScanning(data_.paths[index], std::move(request)); to request->GetRequestData(base::BindOnce(OnGotFileInfo, ...)); in DeepScanningDialogDelegate. That change is correct in context, but it makes the response asynchronous since the file is now opened in tests. This introduces a race condition with this test since it's not using ScopedFeatureList correctly. The fix is to only set the feature in the test ctor (as recommended by base/test/scoped_feature_list.h) and to never re-set it in the tests to avoid races. Bug: 1063080 Change-Id: Ie965c158f39e0cca697e59899f2b15232a1cba2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111905Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#753013}
-
Brandon Jones authored
Bug: 1064083 Change-Id: I1ea95efe830ad621f3b365d8f66ff64a43a4989f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117017 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#753012}
-
Kevin Ellis authored
The logic for handling CSSTransition and CSSAnimation event is largely the same. This patch switches to a shared implementation for the two types of animations. Bug: 1059968 Change-Id: Ic6f107f87e27c2d41dc21b0a4c536f1756f5956e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112904Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#753011}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a82c3f66e59a..b7bdc932613d Created with: gclient setdep -r src-internal@b7bdc932613d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1059401 Tbr: jbudorick@google.com Change-Id: I1c647d902d878da4af8085ae9cd0342e8eb22347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118473Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753010}
-
Andrew Grieve authored
This reverts commit 85316e3a. Reason for reland: Fixed missing target in clank/03922de Original change's description: > Revert "Enable resource_sizes_trichrome_google on chromium.perf" > > This reverts commit f79b470a. > > Reason for revert: build failures on perf bots: https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/167605 > > Original change's description: > > Enable resource_sizes_trichrome_google on chromium.perf > > > > Bug: 1059928 > > Change-Id: I321f38615ea64c3a9577ea5516e199ece6bb9b4b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112232 > > Reviewed-by: John Budorick <jbudorick@chromium.org> > > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#752443} > > TBR=agrieve@chromium.org,crouleau@chromium.org,jbudorick@chromium.org > > Change-Id: I46adb2675413b6f14faa897ec379479003396949 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1059928 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115872 > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752448} TBR=sadrul@chromium.org,agrieve@chromium.org,crouleau@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1059928 Change-Id: I0f4d02ac001a849d5e1c850631b8b728a9bb4b79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117648Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#753009}
-
Scott Violet authored
The return value is always true, and not needed. BUG=none TEST=none Change-Id: Ic7cde551d048a5e1ec24340e739e3a1ba7d4ec81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116919 Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#753008}
-