- 02 Apr, 2020 40 commits
-
-
behdad authored
OnFinishImplFrame call might happen when the corresponding frame is in a stage rather than BeginImpl or BeginMain. This change checks for the other reporters as well. Bug: chromium:1067245 Change-Id: I9b30c78ed5d43397f94ec627c2f7bd099a92f522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133868Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#755844}
-
David Jean authored
Bug: 1045454 Change-Id: I99904af6881daa31cf6bb401f7ea29116cfe5bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132406 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#755843}
-
Yue Zhang authored
Since TabGridPanelToolbarCoordinator only handles layout inflation and PropertyModel creation, this CL removes this class and moves related logic back to TabGridDialogCoordinator. Bug: 1067080 Change-Id: I188d3de5a8d1baf064ddd22f857a110b815ba4e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133077Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#755842}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I14dbec1680af528f3f7ca40bf88f01059c927fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134351Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755841}
-
Rushan Suleymanov authored
When the client receives BookmarkSpecifics with a legacy title field only it will fill in new field and commit changed data to the server again in future. Reupload of updated specifics may be done after receiving of initial merge data or after browser restart. Bug: 1061411 Change-Id: Id7efe057208dc5482b4fdd6773ac561ef79d9640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105335 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#755840}
-
Aaron Leventhal authored
Add a DCHECK that will be triggered only on address sanitizer builds, but importantly, will trigger on clusterfuzz builds. The hope is that we clusterfuzz will file bugs on us with test pages that will reproduce the problem. If this technique works, we can look at adding it in other helpful places, such as for some of the DCHECKs in ax_selection. Bug: None Change-Id: I643ec0fb6c40f4063d437f62384211483bb50868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133027 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#755839}
-
Ben Mason authored
Updated the iOS UI test. This reverts commit 9033a96c. Original change's description: > Revert "Update TOS" > > This reverts commit f88c2f7c. > > Reason for revert: Widespread ios bot failures. auto-rollers are blocked. > > Original change's description: > > Update TOS > > > > Bring chrome://terms in line with > > https://www.google.com/chrome/terms/ > > > > Bug: 1060545 > > Change-Id: I823aa5bdf51c55488777ebb18406b79f9887e6b9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120046 > > Reviewed-by: Mike Pinkerton <pinkerton@chromium.org> > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > Reviewed-by: Ben Mason <benmason@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#755585} > > TBR=pinkerton@chromium.org,tedchoc@chromium.org,benmason@chromium.org > > Change-Id: Ibb4b4c39eff4b9a4276a4e3d64e5ae8552b47452 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1060545, 1067086 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132554 > Reviewed-by: Trent Apted <tapted@chromium.org> > Cr-Commit-Position: refs/heads/master@{#755690} TBR=tapted@chromium.org,pinkerton@chromium.org,tedchoc@chromium.org,benmason@chromium.org Change-Id: I27b47f7f79a00e9f5e3275e7e3de285c1234cc87 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1060545, 1067086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133873 Commit-Queue: Ben Mason <benmason@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Cr-Commit-Position: refs/heads/master@{#755838}
-
Eric Seckler authored
A couple of refactorings that aim to make startup tracing setup and timeout more robust: 1) Move startup tracing timeout from TraceEventDataSource into PerfettoProducer, so that it also affects other data sources. 2) Support aborting startup tracing in TracingSamplerProfiler. 3) Resolve the startup tracing target buffer reservation on abort in TraceEventDataSource. 4) Plumb the timeout through PerfettoTracedProcess to ensure no other concurrent tracing session is active (e.g. system tracing). 5) Move setup of TraceLog from trace_startup.cc into TraceEventDataSource. Bug: 1006753 Change-Id: Ic6afb4ccc71fa960eb4db86d39450bc7c4c39992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130353 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#755837}
-
Nina Satragno authored
When a relying party sends an empty pubKeyCredParams, default to a list containing ES256 and RS256 instead of returning an error. See https://w3c.github.io/webauthn/#sctn-createCredential step 8. This also touches up WPTs exercising this behaviour. Fixed: 1064689 Change-Id: I599fd57f9eccea5aa26144e10e41009980fda79c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132644 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#755836}
-
Devlin Cronin authored
The "action" key is restricted to trunk, so we need to override the current channel for these tests. Tbr: lazyboy@chromium.org (trivial test fix) Bug: 1067187, 893373 Change-Id: Iabb96a414e532a457007ca3cd453838cf3ea73aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133874Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#755835}
-
Nohemi Fernandez authored
This CL clarifies the intent of the sign-out options by making two UI tweaks suggested by our UI designer: 1. Ensure that popover is anchored to the button requesting it. 2. Ensure that long text wraps instead of cutting off. Bug: 1043949 Change-Id: I8483b51634ba21516b58314a11cfeb29757f8ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134367Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#755834}
-
Mohamed Amir Yosef authored
This is to avoid dependency cycle when including it in PasswordForm Bug: 1032992 Change-Id: Ia60052bd8caef4f5488f8d2fcd18c6b95e9e1cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133968Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#755833}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e7fb30eb. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 2688e49a "De-flake two lazyload WPT tests." 8fa00285 "[webauthn] Fix resident key credentials.get() WPT" edb8adb1 "Implement and ship RTCRtpSendParameters.degradationPreference" 2fb88bb8 "Use integer coordinates for Actions.pointerMove." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor rego@igalia.com: external/wpt/css/css-ui xlai@chromium.org, jinho.bang@samsung.com, hs1217.lee@samsung.com: external/wpt/css/geometry NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I09329bd6e43f30cc73b6cf2dd7e46d91ff169d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133906Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755832}
-
Maksim Sisov authored
This CL configures the testers to run viz_unittests Bug: 1029240 Change-Id: Ia46bf071050f61398bedf09f864a89852bc374d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124261Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#755831}
-
John Budorick authored
Bug: 1060280 Change-Id: I058840f16302b473b206ac9b074107baaf29f412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133232Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#755830}
-
Dave Tapuska authored
Remove more tests that are passing consistently. BUG=626703 Change-Id: I65d54aebe19c4ee6aa5177eb63318ed3810d428c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127514 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#755829}
-
Ehimare Okoyomon authored
Add android to the supported list for BlockThirdPartyCookies and enable the corresponding SiteSettings tests. Bug: 1066492 Change-Id: I7b7ef8381d0de84e1d7c579d7fddd9a3ece4d110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129550Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#755828}
-
Javier Ernesto Flores Robles authored
Bug: N/A Change-Id: If034bce7252f5b8bdb304628360a844fa652cb1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134129 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Andrey Zaytsev authored
Deleting the existing histograms because there is no data for them, so it should be safe. This makes the histograms names consistent across settings pages and with the JS frontend. The start action is removed since it is now handled on the frontend. Bug: 1015841 Change-Id: Ief352a2b5e3272c41252e17dcf1327eda8f7d7a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132211Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#755826}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/338f5dcaf77a..586f781bd78b git log 338f5dcaf77a..586f781bd78b --date=short --first-parent --format='%ad %ae %s' 2020-04-02 ilkos@google.com Anonymous memory predicate for profilers Created with: gclient setdep -r src/third_party/perfetto@586f781bd78b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:151315848 Tbr: perfetto-bugs@google.com Change-Id: I4a9a818244a3fa484976f0408dfcf6a3d571386d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133812Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6f402f991ec3..c6b2f34f358b git log 6f402f991ec3..c6b2f34f358b --date=short --first-parent --format='%ad %ae %s' 2020-04-02 brandtr@webrtc.org Revert "Let WebRtcVideoChannel::ResetUnsignaledRecvStream delete all default streams." 2020-04-02 saza@webrtc.org Make transient suppression optionally excludable via defines 2020-04-02 marinaciocea@webrtc.org [InsertableStreams] Don't include the header in the transformable payload. 2020-04-02 saza@webrtc.org Support forcing field trial in audioproc_f simulator 2020-04-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6bc2e353..b2379606 (755432:755766) 2020-04-02 danilchap@webrtc.org Delete deprecated RtpFrameObject constructor 2020-04-02 danilchap@webrtc.org Add AV1 to default video encoder factory 2020-04-02 mbonadei@webrtc.org Fix errors C2238, C2248 and C2059 on MSVC bots. 2020-04-02 brandtr@webrtc.org Let WebRtcVideoChannel::ResetUnsignaledRecvStream delete all default streams. 2020-04-02 jonaso@webrtc.org Extend rtc::AdapterType with 2g, 3G, 4G & 5G enum values. 2020-04-02 saza@webrtc.org Correct int16 audio frame setup in audioproc_f Created with: gclient setdep -r src/third_party/webrtc@c6b2f34f358b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1052765 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifd0736d902e6e58f2b9c1732cb0716e00f0e19cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133811Reviewed-by:
-
Takuto Ikuta authored
This is to include crrev.com/c/2133333 Fixed: 1067133 Change-Id: I22db14bc35b56cb1d447005b91204edee6fa6adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132660Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#755823}
-
Victor Hugo Vianna Silva authored
This enables the bubble introduced in crrev.com/c/2112360 by adding a new state to password_manager_ui.h and setting it whenever ManagePasswordsUIController is notified. Change-Id: I0e0ac5e53c5566cf7a3954e0f955cbba526a214e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132263Reviewed-by:
-
Scott Violet authored
This function is responsible for starting a timer to fetch the seed. BUG=1025612 TEST=none Change-Id: I56664acd17f32d0fbcef85e2135506b56e1e8e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129986Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#755821}
-
Justin Donnelly authored
This will be used to run a holdback study where all new features are disabled. Change-Id: Id6522092183c9d0fdc0aee7aa75efacc78a53934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132641 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#755820}
-
Xi Han authored
Currently, the background session tracker starts when full browser is launched. If Chrome is launched in reduced mode, we lost the duration from reduced mode to full Chrome is launched. This CL starts the tracker in early startup. Bug: 954310 Change-Id: Idff9b36ffe0ab6a663293f853a3a59bf9794fb00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130779Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
Hailey Wang authored
This CL adds a feature to control whether the priority of the video capture service is BEST_EFFORT or USER_BLOCKING. The goal is to verify the hypothesis that running the video capture service at BEST_EFFORT priority causes jank. This hypothesis comes from the analysis of traces uploaded via Slow Reports. Bug: 1066137 Change-Id: I113cd9edf2bb5f088ad7ccb3f9e460c7fe587e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124973Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#755818}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I14decf4d8c93fd6fbd8caa4273743fadc6f6d4fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134186Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755817}
-
Renato Silva authored
Updated the current string and added a new one. Bug: 1023370 Change-Id: Ia9114cb595f55da653856824b9ced7520d5405e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132453Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Renato Silva <rrsilva@google.com> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#755816}
-
Peter Kasting authored
These overrides all just do the same thing the superclass does. No behavioral change. Bug: none Change-Id: I1c3bb832f50875d0e2f76778f79354f2315f9465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133422Reviewed-by:
-
Colin Blundell authored
Cf. feedback on https://chromium-review.googlesource.com/c/chromium/src/+/2130277. Bug: 1031465 Change-Id: I389df36d86c42f26639bd0779ca2c4aa3b38bd6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132157 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#755814}
-
Peter Kasting authored
Bug: none Change-Id: I5ac27a683356c7077dfedf12617fd7a954059b2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129206 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Hajime Hoshi authored
There is no caller of TrackPossibleClickBurst, and there is no implementation of it. Change-Id: I9899ced69e6902f88e9fdeb85b0007107bf50bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134026Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#755812}
-
Daniel Vogelheim authored
This adds several test cases specifically for the SVG script element. Bug: 1066791 Change-Id: If6037549a35c478e0942f4ed65bb0f6db04385bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130550Reviewed-by:
Yifan Luo <lyf@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#755811}
-
Gabriel Charette authored
As a simpler alternative for tests that want to manage lock-step execution via WaitableEvents but currently need to add allowances and worry about the side-effects of the ScopedBlockingCalls those Wait() instantiate. This also gets rid of the need for WaitWithoutBlockingObserver() in base/task/thread_pool/test_utils.h Migrated base/task/thread_pool to it and cleaned up some old paradigms. Prerequisite for the upcoming ScopedBlockingCallIOJankMonitoringTest R=fdoray@chromium.org Bug: 1064645 Change-Id: I94fe15c787fc27636b20a06d216a4d110b08b751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132834 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
-
Clemens Arbesser authored
This CL also fixes an issue where field index 26 in the proto overlapped with a backend-only field. Since the client field was not yet surfaced in the backend, changing the field client-side is safe. Bug: b/150841085 Change-Id: Ia90ee6dac4527533e0157a07ee222d664fd4fc42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132801Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#755809}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/84b6e0d90e07..75a2ee30c3ec git log 84b6e0d90e07..75a2ee30c3ec --date=short --first-parent --format='%ad %ae %s' 2020-04-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 1fff36235504..0b66fa3b62cb (1 commits) Created with: gclient setdep -r src/third_party/angle@75a2ee30c3ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I1c66b0cc2064d76fb6bdd76e91d0726f760598e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133810Reviewed-by:
-
Lutz Vahl authored
This is a roll-back to V8.3. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. R=hablich@chromium.org,liviurau@chromium.org Change-Id: I420deae368aad46fd2cf9f659eb60d4290de30e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132335 Commit-Queue: Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#755807}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6c51bf61e283..8ce842d38d0b git log 6c51bf61e283..8ce842d38d0b --date=short --first-parent --format='%ad %ae %s' 2020-04-02 csmartdalton@google.com Fix the CanvasKit viewer build Created with: gclient setdep -r src/third_party/skia@8ce842d38d0b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: michaelludwig@google.com Change-Id: I679a98a328a04390adb2d21e340b43e66b5c0b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133808Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0916f4887515..792d24ae70ef Created with: gclient setdep -r src-internal@792d24ae70ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1009812,chromium:1061193,chromium:1065749,chromium:1067167 Tbr: jbudorick@google.com Change-Id: Id189fc837f2d2683ac935f3eb82bf2b0d9208165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133807Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755805}
-
