- 30 Jan, 2020 40 commits
-
-
John Lee authored
These methods will soon be used elsewhere to determine if a drag should be allowed or not. Bug: 1005560 Change-Id: Ief93fdf35c034301f310bf519859f3e8dafcb8b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030045 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#737075}
-
John Chen authored
virtual/threaded/http/tests/devtools/tracing/timeline-js/timeline-js-line-level-profile-end-to-end.js, which is known to timeout occasionally on Mac 10.13, has been observed to timeout on Mac 10.14 as well. TBR=wangxianzhu@chromium.org Bug: 1018064, 1028242 Change-Id: Ic0d054a960ec5866adf9e9142d444956fd3ddf46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032010Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#737074}
-
Nick Harper authored
Remove the Extensions.Messaging.IncludeChannelIdBehavior histogram and the code around it. includeTlsChannelId is left on the public API for now, so we can audit whether removal would cause significant breakage. Change-Id: I738f1df33627629a62fc5a945ec7b116a2111f97 Bug: 1016425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015777 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#737073}
-
alex linker authored
Dummy placeholder |kUnknown| representing the category of app which was the source of the URL being opened as a part of intent handling metrics. BUG=1044710 TEST= ran IntentHandlingMetrics.* unit tests Change-Id: I4fd9b5047dbb8ff578211ebeb59cb984cdb41a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023709 Commit-Queue: Alex Linker <ajlinker@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#737072}
-
Yulun Wu authored
Bug: 1047288 Change-Id: I55fec25ad936033cccdacc3880b341ac02c6374b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031868Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737071}
-
Ahmed Fakhry authored
The flag is expiring in M-81, and the feature launched in M-78. It is time to remove the flag and the associated base::Feature. This simplifies the code greatly. BUG=1043361 TEST=Should compile and all tests should pass. Change-Id: Id400f11c2bcc2810beda42336e4a1d026586ed27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029067 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#737070}
-
Michael Spang authored
This script does not work currently: Traceback (most recent call last): File "build/fuchsia/exe_runner.py", line 36, in <module> sys.exit(main()) File "build/fuchsia/exe_runner.py", line 32, in main args.package_dep, args.child_args, run_package_args) AttributeError: 'Namespace' object has no attribute 'package_dep' Fix it to account for changes to the package runner. Change-Id: I292bdd3af4e72add1001d54cbb14e1aa3bdc8ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031993 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#737069}
-
Kenichi Ishibashi authored
The purpose of this change is to reduce ServiceWorkerContextCore dependency from ServiceWorkerStorage. Adding the wrapper moves ScheduleDeleteAndStartOver() call from ServiceWorkerStorage to ServiceWorkerRegistry. Bug: 1039200 Change-Id: I82d06c283c06f373842ee8d6a975f6364086ef93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026907 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#737068}
-
Andres Calderon Jaramillo authored
This CL modifies GLOutputSurfaceBufferQueue to handle the case where GetOverlayTextureId() and SwapBuffers() are called without first calling BindFramebuffer(): this indicates that the client didn't draw but still wants to swap. Prior to CL:1977969, on such case, GetOverlayTextureId() would return the texture that was obtained in the last call to BindFramebuffer(). This CL is intended to do the same: if GetOverlayTextureId() is called, and we know that the client is not currently drawing, we still return the last texture that was attached to the framebuffer. Additionally, this CL ensures that we end access to a shared image prior to emitting the command buffer command to swap the buffers to avoid synchronization issues. Android Q no longer produces flickering. Inspecting a page using added a unit test for empty swaps. Bug: 1046055 Test: Visiting https://www.funwithmama.com/bento-boxes-for-kids/ on chrome: //inspect on Android Q no longer causes a DCHECK crash. Also Change-Id: I86dc72f920a97b598028023f203aa5be4da2a840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024177Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#737067}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8e998f17e0ce..be99ee8f17f9 git log 8e998f17e0ce..be99ee8f17f9 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 terelius@webrtc.org Add more options for tuning the RobustThroughputEstimator through field trial. 2020-01-30 srte@webrtc.org Revert "Inlines NullAudioPoller functionality into AudioState class." 2020-01-30 srte@webrtc.org Inlines NullAudioPoller functionality into AudioState class. Created with: gclient setdep -r src/third_party/webrtc@be99ee8f17f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I65b4b67b289d7136b80864653e7e6a8c0ff4f2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031692Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737066}
-
Regan Hsu authored
* Copy and clean SearchInSettings strings from Browser to OS. * Add searchNoOsResultsHelp with it's own URL. Bug: 967888 Change-Id: I824bd4385c123bdeace61ef89386818108afac10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013644Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#737065}
-
Stefan Zager authored
This CL is meant to test two hypotheses: that the local root document's lifecycle changes between the end of UpdateAllLifecyclePhases and the hit test; and that the LocalFrame containing the iframe element has a null page_. For details see comment #6 on the bug. BUG=1041252 Change-Id: I8ac48062a5c87b7e9424e24a616657610c1af807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028747Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#737064}
-
Clark DuVall authored
This also required moving the kBlockPromptsIfDismissedOften and kBlockPromptsIfIgnoredOften features to //components/permissions. Since HostContentSettingsMapFactory is a //chrome concept, I added an Initialize() method on PermissionDecisionAutoBlocker to initialize with the correct HostContentSettingsMap. Bug: 1025609 Change-Id: Ie8e6f963e310c2f6284078ded7dcf88e85de937e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025874Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
-
David Black authored
It is potentially unsafe to destroy AssistantWebViewImpl during handling of suppressed navigation events. This was not previously an issue for Assistant as the Content Service backed implementation notified handlers of this event over mojo, so destruction was performed after the suppression sequence had completed. Note that this is currently only affecting proactive suggestions as only proactive suggestions currently uses target="_blank" for its links in conjunction w/ the destruction sequence which triggers code path [1] as opposed to code path [2]. [1] http://shortn/_H18kMl1jSt [2] http://shortn/_J5ss5Vjirn Bug: b:148484855 Change-Id: I9e42c371a3f53e16c6112bd4f7506ea2de749f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026689Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#737062}
-
James Hollyer authored
The discovering property in bluez is often delayed in updating. This has caused issues in the past. This change ensures that that property is only used in testing so that it will no longer cause any bugs. Bug: 1013678 Change-Id: I8afbdef6385189d62b1d47ceee16474da06d2caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003355 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#737061}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e702867eed40..08f1abcc5bb0 git log e702867eed40..08f1abcc5bb0 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 pfaffe@chromium.org Fix two issues in debugger plugins Created with: gclient setdep -r src/third_party/devtools-frontend/src@08f1abcc5bb0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia4550afd5e21cb56f544a5cd1ed5b28437c87a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031633Reviewed-by:
-
Brian Sheedy authored
Switches the SkiaRenderer Dawn builders to use the 'gpu_tests' mixin instead of 'gpu_fyi_tests', as the FYI version causes them to attempt to build ANGLE conformance tests. These tests aren't necessary on this configuration, and are currently failing to build. Bug: 1046947 Change-Id: I7aed86f11f359de966bc47a896c392f247812246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028739 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#737059}
-
Jeroen Dhollander authored
In |AssistantInteractionController::OnOpenAppResponse| we forgot to call the callback if it is invoked outside of a valid conversation. This blocks the entire |AssistantInteractionSubscriber| mojom pipeline, causing the Assistant UI to become unresponsive. The fix was easy (call the callback), but I used this opportunity to add the first unittests for the |AssistantInteractionController|. Bug: b/146227377 Change-Id: I705aed3d4cabf3761de339d7d1c8a1ce6178b90d Tests: New ash_unittests AssistantInteractionController* Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029607Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d9884d3e7123..c8e486b1df0d git log d9884d3e7123..c8e486b1df0d --date=short --first-parent --format='%ad %ae %s' 2020-01-30 ynovikov@chromium.org Roll chromium_revision e1633af6..8ffb18d0 (724302:736949) Created with: gclient setdep -r src/third_party/angle@c8e486b1df0d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: Ie5d433148187528c00f1f4642fcc7b1444e97e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032004Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/305542ea70b1..ae510e8f08e8 git log 305542ea70b1..ae510e8f08e8 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 fmayer@google.com Do not crash for non URL (i.e. SSH) remotes. Created with: gclient setdep -r src/third_party/depot_tools@ae510e8f08e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I75445faa3de41db326a865689ac32cca4c13ddd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031618Reviewed-by:
-
Kai Ninomiya authored
Bug: 985142, 1046865 Change-Id: I19ef1095fdd9af8e3d05b0f5d024fe424a8b779a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029169 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#737055}
-
John Rummell authored
IsInsecureCapturingInProgress() will now report capturing in progress if the whole desktop, the window for Chrome, or the specific tab is being captured. Adds UpdateTarget() to specify the actual target being captured, so that the code can check if the tab this is being called for is actually the target, not just the tab doing the recording. Default target is still the tab doing the recording. Also updates Clear Key CDM so that every response to QueryOutputProtectionStatus() generates a 'keychange' event for a dummy key ID. If capturing reported, then the key status is 'output-protected'. If no capturing reported, key status is 'usable'. Adds additional output protection tests that use the fake UI to select capturing of the monitor, window, or browser window. Previous tests ran with kUseFakeUIForMediaStream not specified, which defaulted to "any". Bug: 856276 Test: new EME browser_tests pass, capturing tested manually as well Change-Id: I50df86380cfc115a218d92ba54027294f6bb3b54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987271 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#737054}
-
Bailey Berro authored
This change introduces a system modal dialog that is displayed when a user changes the resolution of an external display. The majority of the logic is encapsulated in a more generic DisplayChangeDialog so that behavior can be reused for a future RefreshRateChangeDialog. Mocks: go/cros-displays-split Test: ash_unittests Change-Id: Iaca64bbabbe4f831a3578012aac148fee95f3066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979137 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#737053}
-
Austin Eng authored
These tests are no longer flaky conformance/ogles/GL/exp2/exp2_001_to_008.html (WebGL 1 and 2) conformance2/textures/canvas/tex-3d-rg16f-rg-float.html Bug: 923080 Change-Id: Ibc0e4b488779a0843a787acacac6c9544e34c50f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029260 Auto-Submit: Austin Eng <enga@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Mohamed Heikal authored
bundletool.py calls the java bundle tool but also prints its output to stdout. This is noise in the build log [1] which should only contain errors and warning and should be empty otherwise. [1] eg: building monochrome_public_minimal_apks outputs the entire bundle manifest to stdout. Change-Id: I2449c7bb5c93398afc18204932566801e385e4e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031965Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#737051}
-
Demetrios Papadopoulos authored
Specifically add BUILD.gn boilerplate (generated with a local script) for: - Auto-generating Polymer 3 versions for each file. - Type checking auto-generated files. Known issues: 1) Generated code is not yet included in the build. This will happen at later stages along with porting tests to Polymer 3. 2) js_type_check() targets are commented out, because JS type checking is not passing yet. 3) Some polymer_modulize(), js_modulize() target are commented out because they cause the auto-generation tools to throw errors. 2 and 3 will be fixed in follow up CLs, either by modifying the auto-generation tools, or by modifying the source code. Bug: 1026426 Change-Id: I6e90ec6af32ce59242795bb7d5e8aa6486f0de55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021191 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#737050}
-
Thomas Guilbert authored
This CL changes video fullscreen tests to wait on one frame being painted, in an attempt to make them more reliable. The CL also updates the test expectations. Bug: 1025291 Change-Id: I80de51215b1d009f6e5ae99e2808c9223cb89ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025932Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#737049}
-
Danyao Wang authored
Before this CL, autofill payment apps are always ranked below other types of payment apps, including just-in-time installable (but not yet installed) service-worker based pyament handler. This CL introduces a new payment app ranking order behind a feature flag such ranks payment apps first by types: 1. Installed 3rd-party payment handlers 2. Complete autofill instruments 3. Just-in-time installable 3rd-party payment handlers 4. Incomplete autofill instruments Within each group, payment apps are sorted by frecency as before. Bug: 1046875 Change-Id: I34ed0fec1f7b6fc4fbf8c6984d0893c3fad73443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028740 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#737048}
-
Mikel Astiz authored
There are various "indices" and hence the name |index_| is somewhat ambiguous. Instead, let's be consistent with the class type it refers to, which is TitledUrlIndex. Change-Id: I0f2c38fdfe7b0a98d9d0b63c2526605c82bfaf40 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030769Reviewed-by:
-
Xiaoqian Dai authored
if mohnstrudel (#webui-tab-strip) is enabled. Mohnstrudel (#webui-tab-strip) will enabled on krane from M81 and other boards from M82. So window dragging from top and tab dragging will be disabled on krane from M81 and other boards from M82. Bug: 1041928 Change-Id: I1b071a190a669374906ff6ec16493dbec879d2d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031668Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/60ca7defc0eb..cf899c949229 git log 60ca7defc0eb..cf899c949229 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 tsepez@chromium.org Remove unused CPDF_TextState::GetShearAngle(), GetFontSizeV() 2020-01-30 tsepez@chromium.org Null out CXFA_FF* layout item reference in layout item dtor. Created with: gclient setdep -r src/third_party/pdfium@cf899c949229 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042915 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I9caf79477e70d79c4558e69ec3f17b7840bed12f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031611Reviewed-by:
-
Dominic Mazzoni authored
On Android, the virtual views in web content mimic their corresponding Android classes, and that includes returning the name of an Android class name as a string. This change fixes the class name for a static text node - it should correspond to an android.widget.TextView. That will enable the Accessibility Scanner to detect color contrast issues. Bug: 1046651 Change-Id: Ia579b83dafa0ce814be059282c594136a37bf33d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026670Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#737044}
-
Chris Hamilton authored
This migrates all of the code in chromecast/ to use blink::WebMessagePort instead of directly manipulating Mojo pipes, and manually encoding messages. It preserves the existing APIs so that downstream dependents can migrate. A further CL will rip out the deprecated API. BUG=803242 Change-Id: I6f3b03dd982e4093804a63f8ad6086f14c2b58b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028148 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#737043}
-
Roger McFarlane authored
Bug: 1006806 Change-Id: I8cf16db179f7fc215db5f2a1bec81ce982663b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031670Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#737042}
-
Weiliang Chen authored
When OverlayProcessorAndroid tries to create the gpu thread part of processor, wait at the initialization to make it synchronous. R=khushal Bug: 979788, 1044671 Change-Id: I6f9c65a6710d7af30a096958b471f250b156722f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025643 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
-
Xinghui Lu authored
Currently on Android, there is only one button on the password reuse warning dialog, so only saved passwords are supported. It can be expanded to other types of passwords after another button is added. Bug: 1045495 Change-Id: I0570a3907c0ed3ef91228119ca5e73281198aaf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026593Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737040}
-
Nicolas Ouellet-Payeur authored
Previously, CQ would pass if extractor.py failed at parsing the C++ declaration. With this CL, parsing errors make CQ turn red (to avoid committing code that will make linux-annotator-rel fail). Also, always rerun extractor.py when there's an error to get stderr contents. Previously, when running with --error-resilient, it wouldn't re-run the Clang tool. This saved several minutes on CQ, but didn't report a useful error message. Since extractor.py is _much_ faster, the tradeoff is different: the error message is more important than the couple of seconds saved. Finally: slightly improve extractor.py's error reporting when it fails to parse the annotation declaration. This makes it more actionable and gives better context to the CL author. TESTED=traffic_annotation_auditor_unittests, extractor_test.py, annotation_tokenizer_test.py Bug: 1046794 Change-Id: Id397dcfcced39fbebf72ffcdc6d6549c66c2910f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028707 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#737039}
-
Theodore Dubois authored
Ties are broken between rules with the same priority based on the action type. Add a test for this. Bug: 1026733 Change-Id: Ie5fcdad3c8843ba535619b0cb3ac4956bdd5a818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025082 Commit-Queue: Theodore Dubois <tbodt@google.com> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#737038}
-
Ben Pastene authored
Bug: 1047347 Change-Id: I0a2579e3c8458541b5800af9c1d45c2190296b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031558 Auto-Submit: Ben Pastene <bpastene@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#737037}
-
Xiaocheng Hu authored
Two WPT use CSSNumericValue.parse() to parse CSS pixel values, which makes the tests basically Chrome-only. This patch changes them to use parseFloat() directly so that other browsers can pass. Bug: 441925 Change-Id: I01d6d2999cf4266bd6d3bda521d2bdfc8732ab7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031932Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#737036}
-
