- 04 May, 2018 40 commits
-
-
Matthew Jones authored
This patch updated the toolbar swipe tests to not depend on criteria helpers and operate on about:blank pages rather than the ntp. Most importantly, this fixes an issue where we assert tab selection before waiting for the callback. Bug: 813584 Change-Id: I1e743291add6398bc3eebc06c03c6c69cefc21f9 Reviewed-on: https://chromium-review.googlesource.com/1044538Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#556240}
-
Ben Pastene authored
Magically, this is the only failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-amd64-generic-rel-vm-tests/1864 TBR=dpranke@chromium.org, nednguyen@google.com Bug: 836447 Change-Id: Iccce216208b418ea7b34b1793a902400ed084c97 Reviewed-on: https://chromium-review.googlesource.com/1044877Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#556239}
-
Emil A Eklund authored
The supplied test case, line-layout-repeat-append.html, measures inline- layout performance by appending 100 lines of text, triggering layout for each line, to a container. Each line is a number followed by one of five panagrams. Given that very limited the number of strings this represents a best-case scenario for the legacy inline layout implementation. The reason for this being that text shaping is by far the most expensive part of line layout. The legacy implementation achieves acceptable shape performance by segmenting text by word and caching the results. Thus for this test case a low number of words (<150) are shaped once and then re- used repeatedly. The total number (<150) is well below the cache limit. LayoutNG on the other hand does not use a shape cache, instead retaining shape results for the individual layout objects. Removing an object thus also removes the shape results. Thus no shape results are shared between test runs. Given that, this particular test case represents something of a worst-case scenario for LayoutNG. Results on my local machine, HP Z840, running tip of tree: Legacy layout: 110 runs/s LayoutNG w/o patch: 0.1 runs/s LayoutNG with patch: 120 runs/s With this patch LayoutNG is now slightly *faster* than legacy layout for this test case even though it was written specifically to take advantage of the performance characteristics of our current legacy implementation. Note that further optimizations are possible as other stages of the pre- layout pipeline may be bypassed for retained items as well. Design doc: https://docs.google.com/document/d/1saBKHRrIJaKSN1sHWnBY253zY8rbLFzhm_2fS0Eaxcw/ Bug: 636993 Test: perf_tests/layout/line-layout-repeat-append.html Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I9ea4da582dd545a7e21e13a3ffc8ccd4687d5ff2 Reviewed-on: https://chromium-review.googlesource.com/986982Reviewed-by:Ned Nguyen <nednguyen@google.com> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#556238}
-
Patrick Noland authored
Bug:837340 Change-Id: I41b6b4e3164e2fd5ca555afba0dec9b5e15ed447 Reviewed-on: https://chromium-review.googlesource.com/1038731 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#556237}
-
Sadrul Habib Chowdhury authored
Notable changes: . Introduce CLANG_COVERAGE define if use_clang_coverage gn arg is set. . For child processes to be able to correctly write the coverage profile during teardown, it is necessary to allow them to shut-down cleanly. So avoid terminating the processes from ~ChildProcessLauncher() when CLANG_COVERAGE is set. . Child processes can do fast-shutdown by calling _exit(0). So force the profile file to be written from the child process before calling that. With both changes, it is still necessary to run with --no-sandbox, since otherwise the child processes are not able to write to the profile file. BUG=838582, 834781 Change-Id: I742521e756a7dead983f40462798f7c4dac2ac02 Reviewed-on: https://chromium-review.googlesource.com/1041271Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Icae023384449260073d9c04f4e05b2ec07b063bb Reviewed-on: https://chromium-review.googlesource.com/1045515 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556235}
-
Bill Orr authored
BUG=835039 Change-Id: If61cc049fd0f8d18de7bdd7df7ff71a9dd8f699b Reviewed-on: https://chromium-review.googlesource.com/1041217 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556234}
-
Tarun Bansal authored
If the client hint header value is a double with magnitude < 1, prepend at least one character (0 in this case) before the period. Change-Id: Ia7197d5efc3e4eba44f8d5d32ccb3ba474ecf80e Bug: 838958 Reviewed-on: https://chromium-review.googlesource.com/1038738 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#556233}
-
Devlin Cronin authored
The error console shows errors that were reported across all the different contexts an extension runs in (e.g., content scripts, background pages, etc). It should ignore logs, though, so as to avoid being overly noisy. Keep reporting warnings for now. Add a unittest for the same. Bug: 837401 Change-Id: I4a0d89f85f2cfd31f2cb3a29051b8598bd78fafc Reviewed-on: https://chromium-review.googlesource.com/1043156Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556232}
-
Daniele Castagna authored
This patch was originally reverted: crrev.com/c/1043228 The issue might have been that correction_matrix was empty, we now check that before trying to create the blob. Original CL description: On some devices we don't have a per-CRTC color transform matrix, but we do have a per-plane CTM that is currently not used. This CL emulates a per-crtc CTM on those devices. Bug: 749250,839672 Tbr: dnicoara, afakhry, mcasas Test: Night light on RK3399 Change-Id: Id5b61203df3b5953cf4530b087a381a8d4a970b8 Reviewed-on: https://chromium-review.googlesource.com/1044900 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#556231}
-
Mike Dougherty authored
With the #context-menu-element-post-message flag enabled, the requestID is returned as part of the response even if no image or link element was found under the user’s touch. The request ID needs to be removed from the response dictionary because the CRWContextMenuController assumes an element was found if the dictionary is not empty. Bug: 838611 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie800f113f1f88649a1164e5f017683bc510c10da Reviewed-on: https://chromium-review.googlesource.com/1040674 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#556230}
-
John Budorick authored
is_chromecast=true builds default to symbol_level=2, even in release. this seems gratuitous on the Cast Audio Linux builder. Bug: 790121 Change-Id: Ifbce85025741ed4d85f699aef1b69c6de97e47a3 Reviewed-on: https://chromium-review.googlesource.com/1044776Reviewed-by:
-
James Hawkins authored
R=hansberry@chromium.org Bug: 839667 Test: none Change-Id: I2c5b269bb1c526d73e3282ccd9c384e59b8b81b1 Reviewed-on: https://chromium-review.googlesource.com/1045165 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#556228}
-
Biao She authored
This is a reland of 4f02e64d TBR=piman Original change's description: > Add GPU time trace for VrShellGl browser rendering path > > > Bug: 837647 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I9c07ca3bfe5df595b9973b6ab0b18d3e629cd6eb > Reviewed-on: https://chromium-review.googlesource.com/1035208 > Commit-Queue: Biao She <bshe@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555430} Bug: 837647 Change-Id: I7395a44384f67be6f8d70546c8dc9413be717148 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1045005Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#556227}
-
Scott Violet authored
BUG=none TEST=none Change-Id: I36c010b94779843534c41e18c3defa53fdd10b34 Reviewed-on: https://chromium-review.googlesource.com/1045144Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#556226}
-
gogerald authored
Bug: 829965 Change-Id: Ie5873ca649ca0f2e80ef88ef2d8108dc3e8f275e Reviewed-on: https://chromium-review.googlesource.com/1033476 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#556225}
-
Becca Hughes authored
Add a 'DisplayCutoutAPI' feature that will switch on the viewport-fit code (and the in future css safe-area-* code). BUG=838400 Change-Id: I6a8f95b1a4cef33349787779ff2993a0f0453bff Reviewed-on: https://chromium-review.googlesource.com/1043078 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#556224}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b9a1e688fd9c..694ebb348a44 $ git log b9a1e688f..694ebb348 --date=short --no-merges --format='%ad %ae %s' 2018-05-04 halcanary SkSinglyLinkedList: use unique_ptr to manage ownership 2018-05-04 fmalita [skottie] Switch to RapidJSON 2018-05-04 fmalita Fuzz should observe the optional Skottie flag. 2018-05-04 herb Add missing header from core.gni Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: Ib8ac3fcd439c78d5580682188dd25c4e7dc39a07 Reviewed-on: https://chromium-review.googlesource.com/1045103Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556223}
-
David Benjamin authored
Change-Id: Ib4569a8a28883226ed65df37d43ae92ae0337803 Reviewed-on: https://chromium-review.googlesource.com/1044896 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#556222}
-
Fadi Meawad authored
This is a reland of 686a5f7b Relanding as is as the failure recovered before the revert did. Original change's description: > [PageLifecycle] Update the TabManager with the page freezing state > > In this CL, each frame updates its FrameResourceCoordinator with any > updates the lifecycle state. If the main frame lifecycle state is > updated, then the page inherit the new state. > > The PageSignalGeneratorImpl then updates the state in TabLifecycleUnit > which is used by the chrome:://discards UI. > > The CL also disables freezing a Tab that is already frozen. > > Bug: chromium:804976 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: Iba82286a06af17ccb74a7f6fac18cdb7914c003a > Reviewed-on: https://chromium-review.googlesource.com/942022 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > Reviewed-by: Shubhie Panicker <panicker@chromium.org> > Commit-Queue: Fadi Meawad <fmeawad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556084} Bug: chromium:804976 Change-Id: If64bd40453211d40aef584c20f6055f0679732b1 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation TBR=dcheng@chromium.org, chrisha@chromium.org, fdoray@chromium.org, panicker@chromium.org Change-Id: If64bd40453211d40aef584c20f6055f0679732b1 Reviewed-on: https://chromium-review.googlesource.com/1044728Reviewed-by:
Fadi Meawad <fmeawad@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Fadi Meawad <fmeawad@chromium.org> Cr-Commit-Position: refs/heads/master@{#556221}
-
Tom Anderson authored
When using dual monitors on Linux, the behavior of Widget::CenterWindow() was to place the window in the middle of the combined screen space, so that the window would be half on one monitor and half on the other. This was seen on the task manager, the first run dialog, and more recently the confirm-to-quit bubble. This CL changes the behavior to match other platforms: the window is centered on the closest monitor. R=sky BUG=243164 Change-Id: I844332c12e14d8b3d5ad017164009dfb7e14fb8e Reviewed-on: https://chromium-review.googlesource.com/1044541Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#556220}
-
Eugene But authored
This handler will be used for EG and ios_web_inttests error pages tests. Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibd7fc021c5ed5d2c76c63e465e988eb81b913037 Reviewed-on: https://chromium-review.googlesource.com/1045108Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#556219}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/38bb3f4b..2839e685 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ib92853d67e332c4699082b2768a39c65ae38bf8d Reviewed-on: https://chromium-review.googlesource.com/1044885Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#556218}
-
Abhishek Arya authored
R=mmoroz@chromium.org Bug: 826305 Change-Id: I3e3c196ad0f792a3aa94b3cb31fbe8d8df8fb5e1 Reviewed-on: https://chromium-review.googlesource.com/1044952 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
-
Pedro Amaral authored
Bug: 814528 Change-Id: I5a272f73c3289e7d574d9ef4c508844d88248a1b Reviewed-on: https://chromium-review.googlesource.com/1043329Reviewed-by:
-
Ian Clelland authored
This is an experiment to visualize the effects of only allowing CSS animations and transitions which occur on the GPU. Other animated properties are rendered noninterpolable, so that they will simply snap between keyframes. This CL allows GPU-driven animations to work when the feature is disabled, by not modifying CompositorAnimations::CheckCanStartEffectOnCompositor. Future work in this space will allow those animations to be disabled as well. Change-Id: I5a8669d8a5b94bc55e1a313452b07a90ba440c98 Reviewed-on: https://chromium-review.googlesource.com/976390 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#556215}
-
Pedro Amaral authored
Bug: 814528 Change-Id: I8713c31da41812150105d15489e9eebdfb88a244 Reviewed-on: https://chromium-review.googlesource.com/1043391Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#556214}
-
Ben Pastene authored
Instead, it just pulls the file from the VM directly, which was added in CL:1021531. Bug: 828607 Change-Id: I6c71f557bf91dafc8c5f638d0c07c49bde728ed4 Reviewed-on: https://chromium-review.googlesource.com/1044755Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#556213}
-
Matthew Jones authored
Change-Id: I28a80338176cea42958912a2904e1b62db475295 Reviewed-on: https://chromium-review.googlesource.com/1045169Reviewed-by:
-
Antonio Gomes authored
This is a follow up of https://crrev.com/c/1031450 that migrated c/b/search/one_google_bar from URLFetcher to SimpleURLLoader. TBR=dullweber@chromium.org (for chrome/browser/extensions/api/web_request/web_request_apitest.cc) TEST=covered by existing tests. BUG=773295 Change-Id: I2a88dcbdba5186c044e5b7325841596af2eff344 Reviewed-on: https://chromium-review.googlesource.com/1043285 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#556211}
-
erikchen authored
This CL is a refactor with no intended behavior change. Bug: 832879 Change-Id: I5d2d04d37f03f8ccbaef28695bc29a6b24b2e089 Reviewed-on: https://chromium-review.googlesource.com/1040592 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#556210}
-
Sean Topping authored
The CastWebView interface declares some non-virtual methods, so we need to build the definitions file alongside the header. Bug: None Test: CQ Change-Id: I62af73be8be736aca072bb29be755ffc68dd5b77 Reviewed-on: https://chromium-review.googlesource.com/1045249Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#556209}
-
Peter K. Lee authored
We stopped using this key/value pair in Experimental.plist since http://crrev/c/927457. Bug: 839738 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I93f91da8fdfa37e314047515c0d6784432ce18b2 Reviewed-on: https://chromium-review.googlesource.com/1044287Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#556208}
-
Daniele Castagna authored
This CL adds UMA stats to keep track of how many times overlay strategies attempts succeed. Bug: Nope Test: Nope Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Idedfe90c647932b987723af6ef4a07c0923b5d0a Reviewed-on: https://chromium-review.googlesource.com/1024776 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#556207}
-
James Cook authored
Multiple chrome os developers have been tripped up by this, so improve the error message. Bug: none Change-Id: Ic91237bda734648bcc28e0df9b1c05317ea3bfd8 Reviewed-on: https://chromium-review.googlesource.com/1044494Reviewed-by:
-
Joel Einbinder authored
Apparently run_layout_tests.py is being moved Change-Id: I2ff85e0203d87d8dde8b0937830593fe1a1fb849 Reviewed-on: https://chromium-review.googlesource.com/1045177Reviewed-by:
-
Ran Ji authored
Bug: 839964 Change-Id: I4fe48a721a878be716cc3fd2cc38fcf9ac3075a4 Reviewed-on: https://chromium-review.googlesource.com/1044953Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Ran Ji <ranj@chromium.org> Cr-Commit-Position: refs/heads/master@{#556204}
-
danakj authored
TBR=danakj@chromium.org Change-Id: I2d169b1bdd145e6a3a2471ac81e9cd8d4e7d8e73 Reviewed-on: https://chromium-review.googlesource.com/1045089 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#556203}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/53d9b3ced389..870dc3a4f6b3 $ git log 53d9b3ced..870dc3a4f --date=short --no-merges --format='%ad %ae %s' 2018-05-04 dtu [pinpoint] Add `--benchmarks` argument for performance_test_suite. Created with: roll-dep src/third_party/catapult BUG=chromium:836037 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ic8df92913ae7d940a624b339e5cf1048ce54c2ae Reviewed-on: https://chromium-review.googlesource.com/1044778Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556202}
-
Raymond Toy authored
These checks aren't needed because the dictionary members are required so the binding layer makes sure they exist before reaching the code. Hence the checks are dead. Bug: 838636 Change-Id: I467639134a813346c8857726de78a463d0468057 Reviewed-on: https://chromium-review.googlesource.com/1038150Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#556201}
-
