- 21 Jun, 2018 40 commits
-
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a58d69e90b91..cd70aa422ce6 git log a58d69e90b91..cd70aa422ce6 --date=short --no-merges --format='%ad %ae %s' 2018-06-20 ynovikov@chromium.org Always depend on libandroid for angle_util. 2018-06-20 geofflang@chromium.org Release the current context's surface before making the next context current. 2018-06-20 jmadill@chromium.org Vulkan: Remove obsolete TODO. 2018-06-20 lucferron@chromium.org GLES: Add skip for failing test 2018-06-20 fjhenigman@chromium.org Vulkan: get vertex formats from format table. 2018-06-20 lfy@google.com Reland "GLES1: Point rasterization (partial implementation)" 2018-06-20 jmadill@chromium.org Vulkan: Fix counting for shader texture bindings. Created with: gclient setdep -r src/third_party/angle@cd70aa422ce6 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I66953490c4df1f0385615b3c44911a8940192cc5 Reviewed-on: https://chromium-review.googlesource.com/1109417Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569150}
-
Koji Ishii authored
The implementation was missing. Includes rebaseline due to 1px position differences. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I6520129899d8d9d7940cb06b55e49302ed477327 Reviewed-on: https://chromium-review.googlesource.com/1104618 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#569149}
-
Kenichi Ishibashi authored
Before this CL we haven't recorded following UMA in S13nSW path: - ServiceWorker.ActivatedWorkerPreparationForMainFrame.Type This CL adds recording this UMA. Bug: 852664 Change-Id: Iba8701e2a17dc857f26c5cc80ae5dc1075170c1f Reviewed-on: https://chromium-review.googlesource.com/1101606 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#569148}
-
Dirk Pranke authored
Currently the Mac10.13 Tests bot runs the layout tests on 10.12; this is done because we didn't have enough capacity on 10.13 to run them. This CL is one of a series that is attempting to fix this. In this particular CL, this switches the test step from 100% 10.12 to 50% 10.13, and also updates the chromium.clang ToTMac and 'Chromium Mac 10.13' bots to get around the unneeded hacks. A subsequent CL will ramp this to 100% (non-experimental) once we're sure we have the capacity. BUG=853356 Change-Id: I4a772f4bd82f427fde1931417dd60d0f80a8d40a Reviewed-on: https://chromium-review.googlesource.com/1109458Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#569147}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ibfa312ac5be05773e1c7a8c087a1190d3ec9a093 Reviewed-on: https://chromium-review.googlesource.com/1109499Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#569146}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/081487b9fb06..a28b14f12246 git log 081487b9fb06..a28b14f12246 --date=short --no-merges --format='%ad %ae %s' 2018-06-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@a28b14f12246 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Icddc4e2fb771f9df0bcac2f70accd5b14fcb03af Reviewed-on: https://chromium-review.googlesource.com/1108861Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569145}
-
Darren Shen authored
We replace instances of KeyboardController::container_ with the keyboard UI contents window. In most cases, we can directly replace them, but there are still some special considerations: - Container used to be created in the ctor, but Contents is created when we load the keyboard UI. So some operations used to be valid when we haven't loaded the UI, but now are not valid. In practice, this doesn't matter as we always preload the keyboard UI when we enable it. However, we should still figure out a sensible lifetime for the keyboard UI. - KeyboardLayoutManager used to be attached to the (old) Container, where we could guarantee that the only child is the contents window. Now it's attached to the (real) container, where we might want to have multiple children in the future. So some changes need to be made there. Change-Id: Ic2b42523565c2acf186ae66f43837ca28888be41 Bug: 849980 Reviewed-on: https://chromium-review.googlesource.com/1098753 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#569144}
-
Kenichi Ishibashi authored
Record the UMA in ServiceWorkerNewScriptLoader as it uses ServiceWorkerCacheWriter when S13nServiceWorker is enabled. Bug: 852667 Change-Id: I82007bcb8d6b1daee118d39e96570b1ba6921353 Reviewed-on: https://chromium-review.googlesource.com/1103432 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Joshua Peraza authored
edc8084c3bdc Roll mini_chromium to d5523a7 [fuchsia] Update to zx_cprng_draw_new fa47143c8c62 [fuchsia] Move to zx_take_startup_handle 85565c545cb1 Doc update for GN build 0a665e3c81a1 Suppress output when generating test server key 2771ebf805ae fuchsia: Package test cert and key when running in Fuchsia tree 639cba075c8d Use new Fuchsia kernel API to suspend threads c0a0d70a2b7a Increase max annotations size Change-Id: Id16830d847a07880c6b2750d0b5245da985b8996 Reviewed-on: https://chromium-review.googlesource.com/1109210Reviewed-by:Scott Graham <scottmg@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#569142}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5831b835bc15..0d22d3fa3ae1 git log 5831b835bc15..0d22d3fa3ae1 --date=short --no-merges --format='%ad %ae %s' 2018-06-21 moragues@google.com chromeos_config: Add sign_types to nocturne release Created with: gclient setdep -r src/third_party/chromite@0d22d3fa3ae1 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6f5ab2ca93c9cade98b5033cd206bea6973e627f Reviewed-on: https://chromium-review.googlesource.com/1109318Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569141}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/825622bd..160d2815 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I0005e6204b00408347a12579143e239cfd064dab Reviewed-on: https://chromium-review.googlesource.com/1108962Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569140}
-
Matt Menke authored
Mostly around downloads, which no longer use NetLog, but also some others as well. Bug: None Change-Id: Ia323d8486a4e8a35ce461aaa37ad910d6c09499d Reviewed-on: https://chromium-review.googlesource.com/1106218Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#569139}
-
codeimpl authored
The spec[1] says that the boundingBox attribute should be DOMRectReadOnly instead of DOMRect. [1] https://wicg.github.io/shape-detection-api/#detectedbarcode Bug: 852838 Change-Id: Ic38665031b6e91b77f6251613b1e7ffdf072945c Reviewed-on: https://chromium-review.googlesource.com/1102444 Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#569138}
-
Ryan Tseng authored
Bug: 815386, 790297 TBR: tandrii Change-Id: I60fd795bee0c0bf9d4b1ae9f0252de9d9624cbad Reviewed-on: https://chromium-review.googlesource.com/1109440Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#569137}
-
Sebastien SG authored
This Cl adds autofill metrics based on the security level. The goal is to see whether the security level impacts the CTR of autofill suggestions or the card save rate. Bug: 853347 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I75ce8c6b924d7fd90e80e518af46509bb6bccde2 Reviewed-on: https://chromium-review.googlesource.com/1103218 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#569136}
-
Mustafa Emre Acer authored
This CL generalizes and moves TrieWriter code from transport_security_state_generator to huffman_trie. It makes TrieWriter an abstract class whose WriteEntry() method must be provided by its users. Bug: 843361 Change-Id: Ib2f0b56c5eb3366086a8ade88ab226d89465da1c Reviewed-on: https://chromium-review.googlesource.com/1101510 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#569135}
-
Fan Yang authored
R=rch@chromium.org Change-Id: Ia7c7977a7e1be03bdc9a91625f2ecaf0be1332d2 Reviewed-on: https://chromium-review.googlesource.com/1108757Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#569134}
-
crystallambert@chromium.org authored
bug: none Change-Id: I331ccff02d4100dfc8c11a3a22de58c80a9356a7 Reviewed-on: https://chromium-review.googlesource.com/1086159Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Cr-Commit-Position: refs/heads/master@{#569133}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/cc4802edc4fa..d9fb538bc08c git log cc4802edc4fa..d9fb538bc08c --date=short --no-merges --format='%ad %ae %s' 2018-06-20 rharrison@chromium.org Remove duplicate method for generating alerts Created with: gclient setdep -r src/third_party/pdfium@d9fb538bc08c The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I59392e7c5596a0fda09d91152e19c2f8083ce80d Reviewed-on: https://chromium-review.googlesource.com/1108898 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569132}
-
Chris Lu authored
This broke the page because of a DCHECK for what kind of item was being added as a footer. Change-Id: Id6b871b814c32a8579f74b4274167326fcde5178 Reviewed-on: https://chromium-review.googlesource.com/1109415Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#569131}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/99525875794b..2db95136c551 git log 99525875794b..2db95136c551 --date=short --no-merges --format='%ad %ae %s' 2018-06-21 simonhatch@chromium.org Dashboard - Use isinstance() instead of type() Created with: gclient setdep -r src/third_party/catapult@2db95136c551 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I42d7c0b2772818d7e6a0bcaa08850f62b2620858 Reviewed-on: https://chromium-review.googlesource.com/1108778Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569130}
-
Xing Liu authored
Currently we access disks on Android main thread to pull download directories, which can cause Android to skip over 100 frames during rendering, or even totally bust the rendering and show a black screen. When try to build download location UI, it may stuck a few seconds(ANR). This CL moves all disk access operation to background thread, so UI will be fast and smooth. Bug: 844107 Change-Id: Icba6db01a4a638cdc62b2e1d207e73981af15dca Reviewed-on: https://chromium-review.googlesource.com/1107041Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#569129}
-
Jared Saul authored
The ordering of functions in autofill_table.cc is *completely* out of order with what's listed in autofill_table.h, and keeping them consistent seems to be our standard. This CL makes only two changes: 1) Moves functions in autofill_table.cc around (no changes; don't let the diff tell you otherwise!) 2) Removes InitDatesTable() from the .h file, which apparently doesn't exist in the .cc file (or anywhere else in the repo) Change-Id: If091c89fc41bd53bd5c2aaccece0da175ff4937e Reviewed-on: https://chromium-review.googlesource.com/1109402 Commit-Queue: Jared Saul <jsaul@google.com> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#569128}
-
Alexander Alekseev authored
TBR=emaxx@chromium.org Bug: 828996 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iac0401f02a225ff4b75a2b0277a6b90ca2d1116b Reviewed-on: https://chromium-review.googlesource.com/1108748Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#569127}
-
Joshua Peraza authored
Bug: crashpad:30 Change-Id: I3b306c40bdd41bd1536e00a82a712bacf60199a2 Reviewed-on: https://chromium-review.googlesource.com/1107843Reviewed-by:
-
Hitoshi Yoshida authored
This reverts commit c09fc457. Reason for revert: This CL breaks MSAN build https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/8439 Original change's description: > Roll src/third_party/libaom/source/libaom/ cc92258a0..c5a56b99d (3832 commits) > > https://aomedia.googlesource.com/aom.git/+log/cc92258a08d9..c5a56b99df86 > > $ git log cc92258a0..c5a56b99d --date=short --no-merges --format='%ad %ae %s' > (...) > > Created with: > roll-dep src/third_party/libaom/source/libaom > > As part of the roll we must update the colorspace signaling. > > Originally added to libaom in > commit 9e69463febe0ee8525cb5a99ee5f9f11286581f1 > Author: Andrey Norkin <anorkin@netflix.com> > Date: Thu Dec 21 18:50:57 2017 -0800 > > CICP colorspace signaling > > Monochrome is signaled outside of CICP: > commit f340fece2c18f068dc3c0c9219b2e5a5eee7ba79 > Author: Debargha Mukherjee <debargha@google.com> > Date: Wed Jan 10 18:12:22 2018 -0800 > > No colorspace for mono-video f/ CICP compatibility > > BUG=aomedia:1673 > > And remove references to the deadline parameter. > > BUG=aomedia:13 > > Updates bear-av1.webm and disables bear-av1.mp4 test. > ffmpeg muxing of av1 in mp4 has not been upstreamed yet. > The webm file was generated with the av1 tree in this > update. > vpxdec media/test/data/bear-vp9.webm -o bear.y4m > aomenc -o bear-av1.webm -p 2 --target-bitrate=150 \ > bear.y4m > > The I frame for the AV1 test is generated with: > aomenc -o bear-av1.webm -p 2 --target-bitrate=150 \ > bear.y4m --limit=1 --ivf > > And then a hex editor is used to remove the 32 byte > file header and 12 byte frame header. > > BUG=chromium:783519 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I0b89285155e286f921448b221a491f9ed24cfd6e > > NOPRESUBMIT=true (due to presubmit confusion about relative paths in DEPS) > > Change-Id: I0b89285155e286f921448b221a491f9ed24cfd6e > Reviewed-on: https://chromium-review.googlesource.com/1101705 > Commit-Queue: Johann Koenig <johannkoenig@google.com> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Tom Finegan <tomfinegan@chromium.org> > Reviewed-by: Fredrik Hubinette <hubbe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569100} TBR=dalecurtis@chromium.org,jschuh@chromium.org,tomfinegan@chromium.org,hubbe@chromium.org,johannkoenig@google.com,tdaede@mozilla.com Change-Id: Iea0ad8d1bff6db507eac0be065f3dfe0ba248e5f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: aomedia:1673, aomedia:13, chromium:783519 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1109557Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#569125}
-
Dan Beam authored
R=sky@chromium.org BUG=none Change-Id: Ia0447eae8c7bfbf6646981fd2dda592c25a95f89 Reviewed-on: https://chromium-review.googlesource.com/1098024Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#569124}
-
Yafei Duan authored
'#' will be in the json which will be parsed to get the navigation URL. This should make things better for both server and client side. Bug: NONE Change-Id: I503352ab7970ed55d9e9ab3e786e3c0675d7d471 Reviewed-on: https://chromium-review.googlesource.com/1109379Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#569123}
-
Tetsui Ohkubo authored
Night Light button is no-op when not logged in. There's no harm but it's better to hide the button to avoid confusion. TEST=manual BUG=819957 Change-Id: I28fa1629dea1c19340d6eabcb1bca51b1fea28f0 Reviewed-on: https://chromium-review.googlesource.com/1107533Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#569122}
-
Philip Rogers authored
This is rather surprising: IntSize(1, 33553177) != RoundedIntSize(IntSize(1, 33553177)) This is because we use RoundedIntSize(const DoubleSize&) due to the implicit DoubleSize(const IntSize&) constructor, which rounds the size to 1x33553176 because doubles do not have perfect precision. This removes a RoundedIntSize from CollectDrawableLayersForLayerListRecursively which incorrectly resulted in rounding the layer bounds. This patch also makes the DoubleSize(const IntSize&) constructor explicit to prevent this mistake in the future, because the conversion is lossy. The corresponding FloatSize constructor is already explicit. Bug: 854194 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I71ecc68eeaa39e602ba7e415222eafea2e706047 Reviewed-on: https://chromium-review.googlesource.com/1107203 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#569121}
-
Alex Newcomer authored
Properly calculate container MenuItemView widths. Bug: 801015 Change-Id: I467a39ed35a821f231042481e4c85b426dc793e6 Reviewed-on: https://chromium-review.googlesource.com/1106967Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#569120}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7c2b573628be..393d20a8e911 Created with: gclient setdep -r src-internal@393d20a8e911 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=mmoss@chromium.org Change-Id: Ic6cc63bb38bac9824e3404ba63ae63464909e414 Reviewed-on: https://chromium-review.googlesource.com/1108858Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569119}
-
David Trainor authored
This CL adds the following capabilities to the new downloads home: - A separate basic coordinator responsible for showing download deletion undo snackbars. - A DeletionController responsible for determining if deletion is allowed or not. - A file deletion queue that will erase a single file at a time on a background thread. - The proper code to the current downloads home list and glue to put it all together. BUG=850584,850583 Change-Id: I464c9aa49ea297a03b32ed65ce42bca4bb7f0dbc Reviewed-on: https://chromium-review.googlesource.com/1092015 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#569118}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 25737a75. With Chromium commits locally applied on WPT: 03ef65db "Update existing WebUSB WPT to be multi-global" 89102421 "Reland "Multi-global WebUSB WPT for window and worker"" 4d3c444f "Async Cookies: Expose additional cookie attributes." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19940 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jrummell@chromium.org: external/wpt/encrypted-media ortuno@chromium.org: external/wpt/bluetooth TBR=robertma No-Export: true Change-Id: Ifa2c545a91f5e926d423418496e867fe539f0cdf Reviewed-on: https://chromium-review.googlesource.com/1108917 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#569117}
-
Scott Chen authored
cr-input and settings-textarea contains textbox, but they are not the textbox themselves, so they should not have role="textbox". This CL removes such role so that chromevox can navigate to the contained <input> and <textarea> correctly. Bug: 853576 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I2aa886e34cd8d36c631ff6b1b5a6b392b8df7199 Reviewed-on: https://chromium-review.googlesource.com/1107301Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#569116}
-
Dominic Mazzoni authored
In r566622 (crrev.com/c/1083854), I rewrote the code to compute the ARIA colindex and rowindex. The "computed" part is that you can set the colindex on the first column in a row and it propagates linearly to the rest of the cells in that row, e.g. 10, 11, 12, 13, ... The implementation was causing O(n^2) loops because each cell was checking each previous cell. Instead, cache the computed colindex and rowindex to avoid that issue. Large tables were hanging Chrome completely. Later on I'd like to move this out of Blink too - but this is a simpler fix for the moment. Bug: 852574 Change-Id: Ib011755ff256733136ba382b83b0a0100607ca49 Reviewed-on: https://chromium-review.googlesource.com/1108919 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#569115}
-
Xiaohui Chen authored
Bug: None Test: Locally build Change-Id: I110dcd953372737156882f8067e7c9188760946e Reviewed-on: https://chromium-review.googlesource.com/1109299Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#569114}
-
Alexey Baskakov authored
ChromeBrowserMainParts::PostMainMessageLoopRun() calls ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() to destroy all Ash objects before BrowserProcessImpl::StartTearDown(). Extensions perform shutdown in BrowserProcessImpl::StartTearDown(). This change allows extensions to remove observers from TabletModeClient. Bug: 812056 Change-Id: I0c96a9cee72c01ab0e4122ee811eb0535e80e7d2 Reviewed-on: https://chromium-review.googlesource.com/1107031 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
Paul Meyer authored
This option allows filtering of the types of reports that will be observed. https://wicg.github.io/reporting/#dom-reportingobserveroptions-types Bug: 731810 Change-Id: I027aab9f753440ba2249da027a2781baa0a1dee5 Reviewed-on: https://chromium-review.googlesource.com/1106292 Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#569112}
-
Wez authored
Bug: 750756 Change-Id: I6fac894ec5aa6ba2cb7aab58b8b1aa03769adadf Reviewed-on: https://chromium-review.googlesource.com/1108502 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
-
