- 01 Dec, 2020 40 commits
-
-
Sebastien Lalancette authored
Reused UKM logging functions from the common shared_highlighting component to log UKM events when a link with text fragments has been opened and its fragments have been processed (LinkOpened event) and also when a link-to-text has been generated for the user (LinkGenerated event). Validated that the events show up on chrome://ukm. Bug: 1148807,1153990 Change-Id: Ibcab06305a31ee6c4d280a65a64f0b21af093209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553002 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#832386}
-
Michael Lippautz authored
... when compiling with the Oilpan library. - Fixes issues with include-what-you-use - Use the right WTF trait in WebPrivatePtr - Add stub for TraceWrapperV8Reference write barrier Bug: chromium:1056170 Change-Id: I53421f1b3f05a9c0b553bbf22731f3dcf0eb5ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567213 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#832385}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a1ebb44f6150..831a5a10f4f9 2020-12-01 bungeman@google.com Fix DWrite axis design parameters. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: Icf0193946fe3f3b86309d766456eae5d03eddd42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568014Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832384}
-
David Roger authored
This CL removes the classes "fade-in" and "action-link" from the buttons in the signin promo. These classes are not defined in this scope and have no effect. Bug: None Change-Id: I939e0fbe3392b2f8f2fac86edd68906bb2e961df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567773Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#832383}
-
Nazerke authored
This CL adds the functionality to each of the close buttons in the tab strip. Bug: 1128249 Change-Id: I8f1357e2d13bb46319f4b59b5d6720964ddd1e9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564642 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#832382}
-
Yoav Weiss authored
Bug: 1138257 Change-Id: I576212baedde2f10cee96469200cd1e3c7d4bdfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567911Reviewed-by:
Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#832381}
-
Anatoliy Potapchuk authored
This changelist adds a new Web API which will be exposed only to web apps with the highest degree of trust. It will be used to bridge some to-be deprecated Chrome App APIs to the web. See DD: go/web-api-navigator-device-dd Change-Id: I750b5d737ae3aa2e706ab7a95287d50c07771760 Bug: 1136088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442535 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#832380}
-
Kramer Ge authored
Directly passing bounds_px will shift opaque region by surface location. This happens to WaylandAuxiliaryWindow. Use region_px instead for correctness. Change-Id: I48180cc5b9da3864f497e6a1d1a4f0b8ce7c0b23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563361Reviewed-by:
Maksim Sisov (GMT+2) <msisov@igalia.com> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#832379}
-
Raphael Kubo da Costa authored
TBR=robertma Change-Id: Id6b2205e0e0008737655eb689d0814a1f8c6c67a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566996Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#832378}
-
Andres Medina authored
Flow for windows based shared object is different. Currently no need to have grpc build as a library on windows. Moving it to a regular static build. Bug: 1152807 Test: CQ Change-Id: I1436b85411618a72edd69e382f06a53267fdb69d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566718 Commit-Queue: Andres Medina <medinaandres@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: Andres Medina <medinaandres@chromium.org> Cr-Commit-Position: refs/heads/master@{#832377}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I30f1e87e0e5e67927c47442d7ca90df404fb2d0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566725Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#832376}
-
Bo Liu authored
The fallback was to make skia renderer work without shared images. This is not a configuration we ship to users, and looks like it's already broken anyway. Remove the fallback path, which is triggering a NOTREACHED in tests when there are shared image errors. Bug: 1153376 Change-Id: I9eae48576d43fc692fcd6ae40ed44e960a2f2914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564950Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#832375}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202012010600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/BBiRmOh9So_xSPEf3Yuzn6hQ2VvWpMYkzK4Gf2U-_aUC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/173476743 Tbr: help-app@grotations.appspotmail.com Change-Id: I7353d98ca6f6ed6604a3f75a63a5ffac2ccff9a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568012Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832374}
-
Dylan Cutler authored
private. This is part of a larger update to clean up the creation of CanonicalCookie instances and make the default constructor private. I verified the tests pass when the default constructor is private by changing canonical_cookie.h when building/running net_unittests. Bug: 1102874 Change-Id: I21e6a53d521025cd485d0abff482184143d1bf12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564942Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#832373}
-
Mike Jackson authored
As part of the work to support PWA's running at OS login, I noticed that the call to RemoveFromLoginItems was failing with errSecParam (-50). The reason appears to be that the original LSSharedFileListRef is being destroyed, and a new one is created. This change factors the code so that we always operate on the same LSSSharedFileListRef which allows the operation to succeed. Tested: Manually by mjackson on MacOS 11.0 Bug: 897302 Change-Id: I8d24495b9f3cae3d7df0341a5c5d0cb951e96176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522876 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#832372}
-
Clemens Arbesser authored
By default, proactive help is only offered if MSBB is turned on. This CL adds a new feature flag that allows disabling the link. Proactive help can still be offered to users so long as no communication to a remote backend is required. Specifically, base64-injected trigger scripts can be shown even in the absence of MSBB. Actual communication with a remote endpoint remains gated by MSBB, the feature flag merely changes the appearance of the settings. Bug: b/174125596 Change-Id: I9f5f1cfc801d9ae12340a1c4a43c42a2accc8484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562665 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#832371}
-
Andres Calderon Jaramillo authored
This CL makes the following UMAs have the same expiration date since they're all related: DrmUtil.CreateDisplaySnapshot.BitsPerChannel DrmUtil.CreateDisplaySnapshot.HasEdidBlob DrmUtil.CreateDisplaySnapshot.IsHDR DrmUtil.GetColorSpaceFromEdid.ChecksOutcome Bug: 1153737 Change-Id: I2d426c9a5946e48b79e4badb97b5f0620231cdc3 Test: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565660 Auto-Submit: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#832370}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9cfe927efca2..b11a9129408b 2020-12-01 kimanh@chromium.org [LMI] Bind lifetime of Uint8Array to Linear Memory Inspector 2020-12-01 tvanderlippe@chromium.org [module.json extensions] browser_debugger views 2020-12-01 tvanderlippe@chromium.org Disable @typescript-eslint/no-unused-vars 2020-12-01 yiorsi@gmail.com Fixed copy declaration(context menu) with no space after colon 2020-12-01 tvanderlippe@chromium.org Speed up running NPM analysis commands 2020-12-01 szuend@chromium.org Implement dark mode for ReportView component 2020-12-01 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-12-01 jacktfranklin@chromium.org [Dark mode] land new theme colors 2020-12-01 szuend@chromium.org Roll deps from Chromium into DevTools If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110202,chromium:1126824,chromium:1134103,chromium:1152391,chromium:1152736 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iade7d01451e5949f45cfd053741509bbe9f03de2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568010Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832369}
-
Martin Šrámek authored
Bug: 1153758 Change-Id: Ied62101dc6458c883380cbba0235c37a54464584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565426Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#832368}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012010600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/9Aak3tK4oVEWWOriZzuRXEUPGWU0lUrVTTcsG4FucPgC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138543581,b/147599135,b/172520996,b/174442020,b/174536568,b/174536897 Tbr: media-app@grotations.appspotmail.com Change-Id: Ic4c15954bde61a466290c0e18f8bcf768ee01b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567936Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832367}
-
Gavin Williams authored
Use ellipsis to denote overflow in the scan settings dropdowns. http://screen/BZLsjMBQpV6FFTZ Bug: 1059779 Change-Id: I7b7c9b6ac7b03f5640ad38181dddb364b0ec6b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566882Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#832366}
-
Steven Bennetts authored
This feature was expected to launch in M-86, but due to unanticipated dependencies in update_engine was disabled until those dependencies can be addressed. BUG=971704 Change-Id: I3312633ffaa1004aecb3043dfc5ed98bece5624f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567031 Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#832365}
-
Bartek Nowierski authored
This reverts commit 53003343. Reason for revert: Perf regressions https://chromeperf.appspot.com/group_report?rev=832242 Original change's description: > [PartitionAlloc] Make pages inaccessible when decommitting > > Change-Id: If8ffec8205961a2213dfe7150d374a828320c2c4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548104 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Chris Palmer <palmer@chromium.org> > Commit-Queue: Bartek Nowierski <bartekn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832242} TBR=palmer@chromium.org,haraken@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,bartekn@chromium.org Change-Id: Id673b2c3d9bbc19c98a44cb8a4780f99c0e7476b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567282 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#832364}
-
Gauthier Ambard authored
This CL makes sure that the ErrorPageHelper and the new error workflow plays nicely with the framework bundle. It adds the CRW prefix to the class and changes the bundle in which the error page HTML files are search to the bundle containing the helper class. Bug: 1152364 Change-Id: Ibb6e07d5143bb7527d7f9ad74a59b20599e38899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563667 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#832363}
-
Natalie Chouinard authored
This reverts commit 87d3589b. Reason for revert: Caused downstream compile failures https://ci.chromium.org/ui/p/chrome/builders/ci/android-internal-chromium-tot/73706/overview Original change's description: > [WebLayer] Remove isServerAutofillInstrument > > Context: > isServerAutofillInstrument, mHideServerAutofillCards are not being used > and so should be removed. This will make a less complicated > BrowserPaymentRequest#notifyPaymentUiOfPendingApps because pendingApps > is no longer filtered. > > Changes: > * Removed the related code of isServerAutofillInstrument. > * Removed the related code of mHideServerAutofillCards. > > Bug: 1025619 > Change-Id: I2b836226802cbaa2e464f8f1c94d59fbba4b848d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565450 > Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> > Reviewed-by: Nick Burris <nburris@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832352} TBR=maxlg@chromium.org,nburris@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I8c730d589f3b4b3e11dc578708356eba651f4c36 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1025619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567815Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#832362}
-
Morten Stenshorne authored
Bug: 1153517 Change-Id: I9f79bb90041fc8527f2add1121d664de9759c5e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567152Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#832361}
-
Javier Ernesto Flores Robles authored
Experiment caused problems on iOS 12 and 14. On iOS 12 input accessory views had a bug where they were not being added most of the time. On iOS14 a divergence on some usage was observed in UMA, but there is no clear explanation for this. Bug: 816427 Change-Id: I98441836d208a30e5ea270c84e23f50b320eba52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565696Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Javier Flores <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#832360}
-
Yunke Zhou authored
Bug: 1145539 Change-Id: I1e75c7517e56a858478d6fd3681d3dfccad3779d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563474Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#832359}
-
Jeremy Roman authored
Rather than copy to the heap to make a dynamically modifiable flat_map, we can build the map into .data.rel.ro at compile time. To support current static_assert, base::flat_tree::size is made constexpr if the underlying collection is, as it is for fixed_flat_map and fixed_flat_set (specifically, std::array). For consistency, max_size and empty are similarly updated. Bug: None Change-Id: Ia21850b48e928e328f9cb85702b561925cca2d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566034Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#832358}
-
Benoit Lize authored
Allocate multiple objects at a time for the thread at a time. This is meant to amortize allocation costs. Bug: 998048 Change-Id: I837216fcb3cb76302a6d09e7890b52313ebf8fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562302 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#832357}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/4654f2b60f7a..e50a1d65fa41 2020-12-01 jophba@chromium.org Add LICENSE file checking If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Iff8644f91ac55906b166a6cb1cc779b038b4c002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568011Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832356}
-
Roman Sorokin authored
Small cleanup Bug: none Change-Id: Ifce493d3c876fa1d067900fe8cba00c77582fb26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563462 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#832355}
-
Yuki Shiino authored
Implements accessor functions of new IDL unions. Also implements constructors and 'Clear' member function. Bug: 839389 Change-Id: I4d51261e96a23b63c33ac3c43553a779e978053e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522861Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#832354}
-
Arthur Hemery authored
It has been the case several times now that this CHECK fails for speculative SiteInstance selection. It should not be an issue since the SiteInstance choice will be reevaluated with all information available. In this specific case: - We have a cross-origin isolated page from origin A with an iframe from origin B. The iframe opens a new window from origin A with COOP and COEP. - Because the iframe is from origin B, we should consider the window.open a no-opener. Doing so we force the new about:blank document to have an "unsafe-none" COOP. Done in RenderFrameHost::CreateWindow. - We then rely on the COOP mismatch mechanism to identify that we should swap browsing instances. This happens at response time. - During the speculative creation of the RFH, before receiving the response, we haven't yet processed the COOP part. We think no swap is required. Bug: 1150938 Change-Id: I9cf9bcb6393f298d669635a36e71ae8c3f6c7b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558610Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#832353}
-
Liquan (Max) Gu authored
Context: isServerAutofillInstrument, mHideServerAutofillCards are not being used and so should be removed. This will make a less complicated BrowserPaymentRequest#notifyPaymentUiOfPendingApps because pendingApps is no longer filtered. Changes: * Removed the related code of isServerAutofillInstrument. * Removed the related code of mHideServerAutofillCards. Bug: 1025619 Change-Id: I2b836226802cbaa2e464f8f1c94d59fbba4b848d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565450 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#832352}
-
Harald Alvestrand authored
Since oauth is now part of webrtc-extensions, the test for it should be in that directory. This is preparatory to reviewing the rest of the iceServer tests. Bug: chromium:1044901 Change-Id: I588a3469ab62c6c7866c4fc80a654bcd155f8661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567872Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#832351}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1606759191-849e6110591039c862ea10277c9aceb1aa0b28d5.profdata to chrome-win32-master-1606802354-2e3be99fee27d60bc23828ee78c917e6dcb3614e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic4b0623780915b9bca570be8346d3ac3f846ca2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567666Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832350}
-
Carlos Knippschild authored
Change-Id: Ifc9ec865d8046bc11e0cf6c22a1a33d2dfb349d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565735Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#832349}
-
Jan Krcal authored
This CL refactors tests for startup browser creator so that (more of) the real production startup code is exercised. This change is needed by CL 2547040 and splits off refactoring and behavioral change. Bug: 1150330 Change-Id: Ia81dc71ea092ad12001d355c93557f77ee5d7c4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563548Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#832348}
-
Changhao Han authored
Temporarily disable this test to allow incoming change: DevTools Frontend CL: https://crrev.com/c/2560322 Bug: chromium:1150797 Change-Id: I6388873df89cff308c265a3b71a45e2fcf4340c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567154 Commit-Queue: Changhao Han <changhaohan@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Auto-Submit: Changhao Han <changhaohan@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#832347}
-