- 29 May, 2019 40 commits
-
-
Lan Wei authored
When the user activation state is active, we should only allow one full screen. This is a simply change to do an experiment to see if any web page breaks. Intent to ship link is https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Y58tbs-TSgE Bug: 852645 Change-Id: Iebef20ba197ecd09e7067986073999e334b07498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594805Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#664292}
-
Xianzhu Wang authored
This reverts commit b3730ee8. Reason for revert: Probably just needs a rebaseline. Original change's description: > Revert "More physical coordinates in LayoutText and LayoutInline" > > This reverts commit 8d639cb7. > > Reason for revert: failing test on macos10: http/tests/devtools/elements/highlight/highlight-node-vertical-rl.js > > Original change's description: > > More physical coordinates in LayoutText and LayoutInline > > > > This further reduces back-and-forth flipping for LayoutNG, and makes it > > clear that inspector highlight always uses physical coordinates. > > > > Change-Id: Iecec0c03c2a1a14d8ad2aeb29f61f3a912d5d670 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625876 > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#663927} > > TBR=wangxianzhu@chromium.org,pdr@chromium.org > > Change-Id: I1179b65f14a0e3f73454d1d271986e81acf7dbf2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633292 > Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org> > Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664040} TBR=wangxianzhu@chromium.org,pdr@chromium.org,jeffreycohen@chromium.org Change-Id: I88862950e040c5a7bde5d684eb68a4a49aefa28a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633469 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#664291}
-
Lindsay Pasricha authored
Add eg2 test suites. Change-Id: I08cee3de2675a48bdb7a5ccb52dedc718fcbafa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632002Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#664290}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: Ic360daeaf226f8f0fb7f36313cfd4c6500749915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627351Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#664289}
-
Sylvain Defresne authored
The callback passed to SafeJsonParser will only be invoked once, so change the definition of the callbacks to be base::OnceCallback<> to make this explicit. Convert client code to use base::BindOnce() when interacting with SafeJsonParser instead of base::Bind() or base::BindRepeating(). TBR=sky@chromium.org Bug: 842655, 964232, 714018 Change-Id: Id948c848f5c193959cc0da2c8eadb21cc55a841c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624810Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#664288}
-
Koji Ishii authored
This patch changes GetOffsetMapping to return nullptr if |NeedsLayout()| is set. Before this change, we had DCHECK, which we changed to CHECK to avoid reading unexpected memory, but the number of crashes seem high enough to consider failing gracefully, similar to what we do for |PrimaryFont()|. This may need to add to some callers to handle |nullptr|, but at worst this change turns CHECK to null-deref at each caller. Bug: 946004, 967984, 955678 Change-Id: I0989963711c1db1f9f61c07383bf771bd6a778fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634590Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#664287}
-
Ehsan Karamad authored
Before a MimeHandlerViewContainer is created, the chrome layer records the PDFLoadStatus (main frame vs embedded) in chrome/ layer. This CL adds the count for frame-based MimeHandlerView. Essentially, * The metric is counted in the browser after MimeHandlerView is and has an embedder frame. * Adds tests to verify the metric is collected for both frame-based and BrowserPlugin-based MHV. The reason for collecting the metrics in the browser process is that the method ChromeContentRendererClient::MaybeCreateMimeHandlerView is currently called twice per PDF load: once when an <embed> is appended to DOM (with PDF type) (in which case it is navigated to the PDF resource) and once when the injected <embed> from the browser is updated (this one is used to attach GuestView). Bug: 659750 Change-Id: Ide39660464c0e9ab4cc2b9357c4887841df700a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632426 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#664286}
-
Lutz Justen authored
Exposes the Kerberos daemon's D-Bus method ClearAccounts(). It will be triggered by Chrome when the kerberos.enabled flag is turned off to remove all existing accounts. Chrome could also be done by calling ListAccounts() and then RemoveAccount() multiple times, but that's rather cumbersome due to the asynchronous nature of each call. BUG=chromium:952239 TEST=None Change-Id: I86555386fd58c90ca2644ba05d8b26c7926fe938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617454 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#664285}
-
Roman Sorokin authored
for the SAML password change dialog. Bug: 930109 Change-Id: I4f2fb367d1b3d47b3e59f293dddc434169f02d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634834Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
A Olsen <olsen@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#664284}
-
Morten Stenshorne authored
Remove an unnecessary check for border+padding logical height. No need to test that separately, as border+padding is part of logical height, which we would already have found to be positive at this point in that case. After re-layout, NGBlockNode::CopyFragmentDataToLayoutBox() would update self-collapsedness (UpdateIsSelfCollapsing()), but the percentage based padding would be resolved against the old size of the containing block, as LayoutNG hasn't gotten around to updating that yet (doesn't happen until we finish layout of the containing block). Note that the test included used to pass with NG (if we bypassed the DCHECK failure, that is). Bug: 967193 Change-Id: I9f35b598ea251ed2f7e1d5b44c1364f1aca17dbe Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634691 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#664283}
-
Alexander Timin authored
InheritPriority method sets the priority only when the priority wasn't explicitly set before. Also unlike UpdatePriority it doesn't set |priority_was_set_explicitly_| to true to enable us to distinguish cases when inherited priority later when looking at the traces. R=gab@chromium.org,fdoray@chromium.org CC=carlscab@chromium.org BUG=937336 Change-Id: Ic1c7b94fb01d681b075401f8e3553533906dfac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634881 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#664282}
-
Elly Fong-Jones authored
This doc outlines how I practice sheriffing and how I encourage others to do so, along with links and advice for how to deal with specific sheriffing tasks. Bug: None Change-Id: I2eaa3217ea3c38f1cee977a03060aca281fb401b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632569 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#664281}
-
Mohammad Refaat authored
The last method from didChangeTab which was used to update tab title and update the loading spinner. Instead of using TabModelObserver didChangeTab, use WebStateObserver to monitor all webStates and use didStartLoading/didStopLoading to update the spinner. Also use WebStateObserver didChangeTitle to update the tabview title. Bug: 911350 Change-Id: Ie1b0bfc77d7dca39e27e6efb6e8478aaaf9e9a4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630628 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#664280}
-
Jordan Demeulenaere authored
Change-Id: Iceb49a975735c34da9b1303a435c1d77de577232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635254Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#664279}
-
Eric Seckler authored
Includes tracing service changes for startup trace writer registry refactoring. -- Roll src/third_party/perfetto 21362a5cf0dc..7f727d4068ec (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/21362a5cf0dc..7f727d4068ec git log 21362a5cf0dc..7f727d4068ec --date=short --no-merges --format='%ad %ae %s' 2019-05-29 eseckler@google.com Merge "startup writer: Refactor returning of writers to registry" --- Bug: 966307 TBR: oysteine@chromium.org Change-Id: I641eeb9df3f315436e3199dc8d87a416612e2422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634829Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#664278}
-
Zentaro Kavanagh authored
- Add use-search-click-for-right-click flag which when enabled makes search+click remap to right click instead of the current behavior of Alt+Click. - Part of plan to transition to this as default behavior BUG=chromium:248762 Change-Id: I5ca40faf761de320427af4bb2e1913efdd1907af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602973 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#664277}
-
Maksim Ivanov authored
Remove the usage of Polymer's |this.$$()| in favor of using standard DOM methods. The Polymer's |$$| method is deprecated and is removed in Polymer 2.0: https://polymer-library.polymer-project.org/2.0/docs/upgrade#dollardollar Bug: 964069 Change-Id: Id0725dbd427cf58a6ec9dba3207bf012864206ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627376 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#664276}
-
Vladislav Kuzkokov authored
This change is expected to have no effect on most compiled code so it's better separated from any functional change. It also eliminates the danger of the referenced object being deleted while the function is running. Bug: 968109 Change-Id: I9f8e9755be2ed2bf147340f77f314f2fd9567718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628752 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#664275}
-
Ehsan Karamad authored
This CL makes sure that Ctrl+P and other sources of print only work for a full-page MimeHandlerView. This means MimeHandlerViewGuest will be considered full page only if it is in a main frame. Bug: 967950 Change-Id: I0bc359f56adf9475fd450c12359ab4fae7b539b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633631Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#664274}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f59507fccef1..da94a1109604 Created with: gclient setdep -r src-internal@da94a1109604 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: I1c199aef5916122cb1194322f0a79ef99c0d3e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634412Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664273}
-
Yeol Park authored
In order to better convey property object ownership, changed MakeButtonsInState() to returning two unique_ptr<MdTextButton>s. Bug: 948287 Change-Id: I29bb117ba9ad7215c1be92435f4b622bb83dc1aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628639 Commit-Queue: Yeol Park <peary2@gmail.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#664272}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bfa8767bb25c..29e013deb476 git log bfa8767bb25c..29e013deb476 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 brianosman@google.com Interpreter: Fix construction of Matrices 2019-05-29 bsalomon@google.com Change async rescale and read GM to test diff number of x/y bicubic steps Created with: gclient setdep -r src/third_party/skia@29e013deb476 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Change-Id: Iac0d4dd23c4ff68ddf68e11a0a190cb98f06cf4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634413Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664271}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e8e7d7b0bc10..2f5554dae54d git log e8e7d7b0bc10..2f5554dae54d --date=short --no-merges --format='%ad %ae %s' 2019-05-29 nisse@webrtc.org Make KeyFrameRequestSender injectable in RtpVideoStreamReceiver Created with: gclient setdep -r src/third_party/webrtc@2f5554dae54d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I86f9615d8beccbf13cf3bb5cb27ace4a0435eb15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634411Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664270}
-
Yoav Weiss authored
When responsive images are not cached in the memory cache (due to `no-store` or devtools settings) and the viewport is being resized, that triggers spurious downloads. This CL fixes that, by aligning to the spec (somewhat) and making sure that viewport changes that don't modify the image URL do not trigger a resource load. Bug: 960633 Change-Id: I8105bcf5dbef99767ac704872800f4d417caf8b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622168Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#664269}
-
Sylvain Defresne authored
Bump expiration date of Signin.AccountTracker.CountOfLoadedAccounts and Signin.AccountTracker.GaiaIdMigrationState by four releases (or about six month). Bug: 960028 Change-Id: Ie168fb5cc5b972555a92e41073c34679900037bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634741 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#664268}
-
Alexei Svitkine authored
The parameters were not really being used. VariationsService has been using its own separate expiry logic. This should also speed up start up, as we no longer have to do any time function calls when a field trial gets created by VariationsService. With this change, FieldTrialList no longer calls some time functions as part of start up, which was being relied on by libc time function interception in sandboxed child processes. This change makes the interception an explicit part of child process start time rather than something that gets triggered by the first use of libc time functions. This is needed as otherwise the first time function call would be too late and would crash due to sandbox restrictions. TBR=rohitrao@chromium.org,spang@chromium.org,hansberry@chromium.org,mathp@chromium.org,jorgelo@chromium.org Bug: 957743 Change-Id: I1ff94df1ffade2b46bc19d984300b2b26dc0a06f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618025 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#664267}
-
jonross authored
conformance/textures/image_bitmap_from_video/tex-2d-rgba-rgba-unsigned_short_5_5_5_1.html has begun to demonstrate the same error as in crbug.com/891456 I'm marking it as RetryOnFailure. TBR=ynovikov@chromium.org Bug: 891456 Change-Id: I557903f2abb983323603c1849e3ff6ed014cfd6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635289Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#664266}
-
Huanzhong Huang authored
Change of strings related to the new Clear Browsing Data dialog. The change is to make these strings aligned with their Desktop/Android counterparts (with the iOS capitalization rules applied). Bug: 642334 Change-Id: I9186a305efe2be1c01d38b8f22f0d078f96a5a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631649Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#664265}
-
Martin Robinson authored
AtkText messages should only be sent when something actually changes. Bug: 961736 Change-Id: I2c53956de0e69ee2caff9b520f8b489158d9a24e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634857Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#664264}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1ad4771e88a5..262e28248477 git log 1ad4771e88a5..262e28248477 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 aleino@nvidia.com Use D3D11 GetDimensions driver workaround for 3D textures Created with: gclient setdep -r src/third_party/angle@262e28248477 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Change-Id: I171e7a61addbd7998612eec98aeb557a0c097fa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634955Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664263}
-
arthursonzogni authored
Check what process is used when a subframe is being navigated to about:blank. The current behavior is to make the new document live in the process of the navigation's initiator. Bug: None. Change-Id: Iaa6184c11975f708a807fd877da05a8625121a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619804 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#664262}
-
Michael Hablich authored
This is a roll-back to 7.6.303. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. TBR=machenbach@chromium.org Change-Id: I8e35e4b5d9793db31fb1001d26ec78f9b915e0e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634836Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#664261}
-
Ben Kelly authored
In order to support moving CacheStorage off the IO thread this CL removes the assumption that all CacheStorageContextImpl::Observer objects are added on the IO thread. This is achieved by using the base::ObserverListThreadSafe class. This CL also refactors the code to store observers in the context even if the manager is still responsible for notifying them. This will allow us to keep all cross-sequence activity in the context and make the manager simpler. Bug: 960012 Change-Id: I7b9c03ac1378d4cdacf77e108d98f815aa6418b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626492Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#664260}
-
Mark Cogan authored
This CL consolidates the use of the existing webui/ directory in //ios/web/public. - All of the files in this directory get their own BUILD file, which is not transitively exposed from //ios/web/public:public. - All necessary BUILD files have their deps updated; in many cases these files were also relying on transitive public deps for //net (!). - .cc files in ios/web/public/webui/ are moved into /ios/web/webui/ - a couple of files in //ios/web/public/ are moved into webui/. Bug: 942244 Change-Id: I3d4be502c4808440d552f9e87e79a4f9f548fa7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634858 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Auto-Submit: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#664259}
-
Nico Weber authored
Ship (and build) fewer archs on mac: - Stop shipping 32-bit intel for maOS, we've only been shipping 64-bit chrome for years. - Stop shipping armv7k, which I think is only used on Apple Watch (?) Build fewer things we don't ship or need: - Don't need to build CRT or XRAY anywhere - Don't need to build builtins lib for linux, win, android - Don't need to build libfuzzer for android, fuchsia - Don't need to build libprofile, sanitizers for fuchsia - Don't need to build ARM and Aarch64 targets for bootstrap compiler on non-mac (This also means we stop shipping the xray headers. Since we don't ship the xray runtime lib, that shouldn't be a problem.) The intention is that this is a non-event. If this disturbs some build configuration I don't know about, please let me know and we can roll parts of this back. On macOS, the main build goes from 7868 to 7200 build steps, package size from 26.54MB to 26.21MB. Stage 1 is unmodified. On Linux, the stage 1 build goes from 2745 to 2586 build steps and stage 1 number of tests go from 38502 to 33398. The main build goes from 4253 build steps to 3924. The numbers on Windows are comparable to Linux (2726 -> 2567, 36495 -> 31633, 3600 -> 3455). Despite the reduction in build steps, builds on the bots don't seem to get noticeably faster. Bug: 959966 Change-Id: I177e06f4d97d811a651acad8af2163589f1c9d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629950 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#664258}
-
Carlos Caballero authored
BEST_EFFORT tasks will not run until after startup and only if there is no critical work pending. This patch should not change the current behaviour. Please double check whether the task being posted via BrowserThread::PostAfterStartupTask really cares about being run after startup or just wants to run after any critical work was completed. If you are fine with it just running after critical work has completed LGTM and keep on with your life. If that is not the case let me know and please explain your reasoning in a comment. More details: https://docs.google.com/document/d/1P8PV1qX2cOR2WRFD6v9CjygJkE_mftCtJ7BoqQHCKZI This CL was uploaded by git cl split. R=gab@chromium.org Bug: 887407 Change-Id: I53590207fdc1ac8e47bce40a2da0f42674c4966e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632223 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#664257}
-
Mohammad Refaat authored
The last observer method in BrowserViewWrangler was didChangeTab. To remove it we need to keep track of current visible url of the active tab for the device share manager (used for handoff feature.). 2 things need to be tracked to achieve that: 1- Switching between the active webState. -> Already done by didChangeActiveWebState of WebStateListObserver 2- Navigations done on the active WebState. (This CL) -> BrowserViewWrangler will implement didFinishNavigation of CRWWebStateObserver to update the device share manager (using CRWWebStateObserverBridge). And attach the observer to the active WebState using the ActiveWebStateObservationForwarder. Bug: 911350 Change-Id: I0c9b52b84978f717a34a186ef7ac531eb4434f45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628007 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#664256}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/633db4db7672..bfa8767bb25c git log 633db4db7672..bfa8767bb25c --date=short --no-merges --format='%ad %ae %s' 2019-05-29 herb@google.com Move source space fallback strike calculations to SkStrikeSpecStorage Created with: gclient setdep -r src/third_party/skia@bfa8767bb25c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Change-Id: I77762a89a23e499b7d0b50a50e192c50390c6e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634953Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664255}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/24c961c98efd..f59507fccef1 Created with: gclient setdep -r src-internal@f59507fccef1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: I84296aa75ea906c424bf6bac6521ad809a3c8336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635210Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664254}
-
Qingsi Wang authored
Bug: None Change-Id: I6df50a94ba15c12652aba3556bd2030d2fe6307b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632668 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#664253}
-