- 16 Mar, 2017 40 commits
-
-
art-snake authored
BUG=606705 Glyph 65535 means that the glyph is not printable. Replacing it with 0 results in a striped glyph that's rendered instead of non-printable glyphs. Just remove old invalid code to fix this. In my testing no Skia asserts were triggered. Without this fix the title in tab of url : https://www.google.ru/trends/yis/2016/RU?autoplay=1 will be incorrect rendered: See https://bugs.chromium.org/p/chromium/issues/detail?id=606705#c4 Review-Url: https://codereview.chromium.org/2756683002 Cr-Commit-Position: refs/heads/master@{#457472}
-
guidou authored
BUG=402805 TBR=enne@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2754093002 Cr-Commit-Position: refs/heads/master@{#457471}
-
eugenebut authored
BUG=389405 Review-Url: https://codereview.chromium.org/2752113002 Cr-Commit-Position: refs/heads/master@{#457470}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/06d36330..f7036b13 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2754823002 Cr-Commit-Position: refs/heads/master@{#457469}
-
sugoi authored
This update disables the debugger wait dialog by default on any build not made using the SwiftShader solution in Visual Studio. TBR=kbr@chromium.org TBR_REASON=SwiftShader DEPS roll BUG=630728 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2751023004 Cr-Commit-Position: refs/heads/master@{#457468}
-
khmel authored
This fixes race condition when Play Store OptIn is started from the shelf, in case default apps list has not been read yet. BUG=b/36279017 TEST=Unit tests extended and manually on device simulating race conditions. Review-Url: https://codereview.chromium.org/2751913004 Cr-Commit-Position: refs/heads/master@{#457467} -
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/a6ae1f7cda07..9e9188f84b15 $ git log a6ae1f7cd..9e9188f84 --date=short --no-merges --format='%ad %ae %s' 2017-03-16 liyuqian Revert "Remove budgeted parameter from SkSurface::makeImageSnapshot" Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=borenet@chromium.org Change-Id: I7a47347bac4e5504317e95552627b11c38b04281 Reviewed-on: https://chromium-review.googlesource.com/456396Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#457466}
-
baxley authored
This test was flaky because it wasn't always reaching the bottom of the page when swiping up. Add a call to grey_scrollToContentEdge to guarantee the bottom edge is reached, making the link tappable. BUG=701104 Review-Url: https://codereview.chromium.org/2752153004 Cr-Commit-Position: refs/heads/master@{#457465}
-
rob.buis authored
Make PaymentRequestImpl work with the newly introduced RenderFrameHost in order to know the (sub)frame that created the payment request. This CL also adds WebContentsStatics which should contain public static methods for WebContents. BUG=620173 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation patch from issue 2681933002 at patchset 100001 (http://crrev.com/2681933002#ps100001) Review-Url: https://codereview.chromium.org/2692023002 Cr-Commit-Position: refs/heads/master@{#457464}
-
samuong authored
BUG=701995 Review-Url: https://codereview.chromium.org/2753763005 Cr-Commit-Position: refs/heads/master@{#457463}
-
estade authored
Delete TrayPopupItemContainer class, which was only used for adding a hover effect that we don't want/use in MD. BUG=687802 Review-Url: https://codereview.chromium.org/2758433002 Cr-Commit-Position: refs/heads/master@{#457462}
-
estade authored
BUG=687803 Review-Url: https://codereview.chromium.org/2755843002 Cr-Commit-Position: refs/heads/master@{#457461}
-
bsheedy authored
Tests were incorrectly using/referring to 'onvrdisplayactivate' and 'onvrdisplaypresentchange' instead of 'vrdisplayactivate' and 'vrdisplaypresentchange'. BUG= Review-Url: https://codereview.chromium.org/2750763006 Cr-Commit-Position: refs/heads/master@{#457460}
-
eugenebut authored
Also removed PendingIndexNavigationDisabled experimental setting. BUG=692331,701717 TEST=Back forward navigation works correctly. Review-Url: https://codereview.chromium.org/2751793002 Cr-Commit-Position: refs/heads/master@{#457459}
-
danakj authored
Make the members direct members of DisplayItemList instead. This was leftover from Blimp design. R=vmpstr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2750683002 Cr-Commit-Position: refs/heads/master@{#457458}
-
michaeldo authored
BUG=none Review-Url: https://codereview.chromium.org/2750293002 Cr-Commit-Position: refs/heads/master@{#457457}
-
guidou authored
Disable flaky SitePerProcessHighDPIExpiredCertBrowserTest.InterstitialLoadsWithCorrectDeviceScaleFactor on Windows. BUG=700150 TBR=wjmaclean@chromium.org Review-Url: https://codereview.chromium.org/2757693002 Cr-Commit-Position: refs/heads/master@{#457456}
-
rockot authored
In test environments it's fairly common for task runners to be torn down without flushing posted tasks. If there's e.g. a binding object on the test function stack that gets destroyed on unwind, this might end up posting a SimpleWatcher notification task that then never runs. Currently we disambiguate watch contexts in SimpleWatcher by retaining a ref to the Context in said notification task and comparing to the currently known Context instance on the SimpleWatcher's thread. This can lead to indirect leaks in the aforementioned testing scenario. This CL instead introduces a sequence number in SimpleWatcher which is incremented every time a new watch is started. This sequence number is used to disambiguate notifications which might have come from a previous watch, thus avoiding the unnecessary ref count on Context. BUG=702180 R=yzshen@chromium.org Review-Url: https://codereview.chromium.org/2754863002 Cr-Commit-Position: refs/heads/master@{#457455}
-
fhorschig authored
Record the number of users that open a completely new NTP. In combination with the metric MobileNTPShown, this can help to figure out how many users potentially see a "snap change" of the contents, caused by screenshots made on leave. BUG=700918 Review-Url: https://codereview.chromium.org/2750503004 Cr-Commit-Position: refs/heads/master@{#457454}
-
samans authored
It's not used anymore. We instead recreate the CompositorFrameSinkSupport object on gpu restart. This is because the CompositorFrameSinkSupport will eventually live in the gpu process and will be destroyed on gpu restart, therefore it can't have a Reset method like SurfaceFactory. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2757563003 Cr-Commit-Position: refs/heads/master@{#457453}
-
zmin authored
2) Create force-sign-in policy cache 3) Trigger ProfileIsSigninRequriedChanged() when profile is locked/unlocked due to force sign in policy. BUG=642059 Review-Url: https://codereview.chromium.org/2712883005 Cr-Commit-Position: refs/heads/master@{#457452}
-
oka authored
BUG=636289 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2751763004 Cr-Commit-Position: refs/heads/master@{#457451}
-
Rebaseline Bot authored
Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/634117 https://chromium.googlesource.com/chromium/src/+/7dd150883791d BUG=702148 TBR=noel@chromium.org Review-Url: https://codereview.chromium.org/2747123006 . Cr-Commit-Position: refs/heads/master@{#457450}
-
timvolodine authored
Add end-to-end browser tests for the 'deviceorientationabsolute' event to have full event coverage in device_sensors/. BUG=702170 Review-Url: https://codereview.chromium.org/2744243006 Cr-Commit-Position: refs/heads/master@{#457449}
-
rockot authored
Makes the lifetime management of the State object a little clearer. This change was supposed to make it into the CL which introduced the new watcher API, but it got dropped somehow. BUG=700171 R=jam@chromium.org Review-Url: https://codereview.chromium.org/2752243002 Cr-Commit-Position: refs/heads/master@{#457448}
-
vabr authored
FormFetcher has a state which indicates whether it is waiting for PasswordStore results. It should be useful to know when the stored data corresponds to some real snapshot of PasswordStore. FormFetcher can be waiting for the PasswordStore either directly, or indirectly through waiting for HttpPasswordMigrator. So far, it only keeps the state as WAITING during the first type of waiting. This CL expands the state WAITING to also mean "waiting for HttpPasswordMigrator". BUG=571580 Review-Url: https://codereview.chromium.org/2745173008 Cr-Commit-Position: refs/heads/master@{#457447}
-
peter authored
Raphael kindly improved the bindings generator to support nested union types, so we can now properly support this! BUG=700370 Review-Url: https://codereview.chromium.org/2758493003 Cr-Commit-Position: refs/heads/master@{#457446}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/0c984a0af309..a6ae1f7cda07 $ git log 0c984a0af..a6ae1f7cd --date=short --no-merges --format='%ad %ae %s' 2017-03-16 ethannicholas wired up SPIR-V validator 2017-03-15 mtklein Support all gradient types in SkColorSpaceXformCanvas. 2017-03-16 bsalomon Outset dst texture bounds by a pixel to fix corruption in dstreadshuffle. 2017-03-16 robertphillips Remove budgeted parameter from SkSurface::makeImageSnapshot 2017-03-15 ccameron Add SK_API to SkCreateColorSpaceXformCanvas 2017-03-16 jvanverth Rename GrAADistanceFieldPathRenderer to GrSmallPathRenderer 2017-03-15 bsalomon Make SkTArray not allocate unless reserve or initial count > 0 Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=borenet@chromium.org Change-Id: I6171bf89ffb54c161088e835e7dcf011cdc9ef01 Reviewed-on: https://chromium-review.googlesource.com/455354Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#457445}
-
ellyjones authored
BUG=699774 Review-Url: https://codereview.chromium.org/2753753006 Cr-Commit-Position: refs/heads/master@{#457444}
-
skobes authored
Previously, animations in WAITING_FOR_DELETION state would only be purged via AnimationPlayer::PushPropertiesTo, which synchronizes impl- and main-thread players. But the player in ScrollOffsetAnimationsImpl has no main-thread copy, so its animations never got deleted after they finished. BUG=701025 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2757453003 Cr-Commit-Position: refs/heads/master@{#457443}
-
olivierrobin authored
Popups are ephemeral views used to send commands. When tab is deselected, they should be dismissed, specially popups relative to the tab (page info). BUG=697506, 697470 Review-Url: https://codereview.chromium.org/2729563003 Cr-Commit-Position: refs/heads/master@{#457442}
-
sullivan authored
Also remove stray print. BUG=702201 TBR=nednguyen@google.com Review-Url: https://codereview.chromium.org/2752043003 Cr-Commit-Position: refs/heads/master@{#457441}
-
fmalita authored
Trivial one-pixel rasterization diffs between Release and Debug builds, Win7-only. Cannot be solved by rebasline. See discussion on http://crbug.com/484370 also. BUG=702176 R=schenney,guidou Review-Url: https://codereview.chromium.org/2751383002 Cr-Commit-Position: refs/heads/master@{#457440}
-
danakj authored
This removes all cases of virtual from DisplayItem, making them into just data types. Makes the fields public like DrawQuads, but also const. R=enne@chromium.org BUG=671440 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2751833007 Cr-Commit-Position: refs/heads/master@{#457439}
-
jif authored
BUG=699587 Review-Url: https://codereview.chromium.org/2752643004 Cr-Commit-Position: refs/heads/master@{#457438}
-
nikhil.sahni authored
Replacing ASSERT and ASSERT_NOT_REACHED in core/style/ with DCHECK_op, NOTREACHED respectively. BUG=697688 Review-Url: https://codereview.chromium.org/2751653003 Cr-Commit-Position: refs/heads/master@{#457437}
-
rhalavati authored
Network traffic annotation is added to network request of chrome/browser/safe_search_api/safe_search_url_checker.cc. BUG=656607 Review-Url: https://codereview.chromium.org/2743923002 Cr-Commit-Position: refs/heads/master@{#457436}
-
sullivan authored
BUG=702194 TBR=nednguyen@google.com Review-Url: https://codereview.chromium.org/2754053002 Cr-Commit-Position: refs/heads/master@{#457435}
-
jfernandez authored
The baseline-position syntax has changed recently, so we need to update the CSS properties using the old syntax. This patch address only the content-alignment (align-content and justify-content). I used this patch to adapt the implementation of the parsing logic for these properties to the new Blink's CSS Parsing Design. The new baseline syntax is "[first | last ]? baseline" which implies modifying the parsing and computed value logic. There are several layout tests affected by this change, so I'll update them accordingly. BUG=565883 Review-Url: https://codereview.chromium.org/2750843002 Cr-Commit-Position: refs/heads/master@{#457434}
-
cwallez authored
BUG=angleproject:1874 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2725873007 Cr-Commit-Position: refs/heads/master@{#457433}
-