- 01 Apr, 2020 40 commits
-
-
Tom Anderson authored
This appends eg "_wayland" to the test name to prevent duplicate tests on the linux-ozone-x11-and-wayland-rel bot. R=msisov,agable BUG=1060273 Change-Id: Ib83c2394653dd1973ba4ff5da38296d7af94f1ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128842Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#755539}
-
Mario Sanchez Prada authored
Add links to the relevant specs and a test assertion describing its purpose, and do some other minor changes as this test can't be migrated to WPT yet, as it tests Blink/WebKit specific behaviour, unfortunately. Bug: 1063749 Change-Id: I1d4048057c1d3d4585efcb0e326e435181b33bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128080 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#755538}
-
Guido Urdaneta authored
This CL wires RTCEncodedAudioFrame to the underlying WebRTC frame. Tests coming up in follow-up CLs that implement the rest of the Insertable Streams API. Bug: 1052765 Change-Id: I833139ad89166673ce48af027879f2755206b5eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130551 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#755537}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/994bed549663..845b83053018 git log 994bed549663..845b83053018 --date=short --first-parent --format='%ad %ae %s' 2020-04-01 kylixrd@chromium.org Fixed goma_ctl.bat to pipe to nul instead of creating a file called null. 2020-04-01 sokcevic@google.com Fix git-* commands when using python3 on Win Created with: gclient setdep -r src/third_party/depot_tools@845b83053018 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1065582,chromium:1066954 Tbr: agable@chromium.org Change-Id: I0052efb1ebb3b05e63c946176e1d8f4e440b6d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132964Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755536}
-
Natalie Chouinard authored
Bug: 1044401 Change-Id: If8aa24a3c036d4367db12b9b2eeeb682677ae9fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132767 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#755535}
-
Viktor Semeniuk authored
Due to new compromised password type i.e. phished and leaked at the same time, sorting should be updated to support showing PHISHED and PHISHED_AND_LEAKED above LEAKED. Bug: 1047726 Change-Id: Ie6776df8fb01d384890bc835ee0a21ef76f3ed70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127367 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#755534}
-
Julie Jeongeun Kim authored
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose and renames it to flex-item-vertical-align.html. Bug: 1063749 Change-Id: I1828355f072ee6c019de79a7ec0e4dafa4555841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131814 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/77cb6e24f164..822963b8b8b3 git log 77cb6e24f164..822963b8b8b3 --date=short --first-parent --format='%ad %ae %s' 2020-04-01 cfijalkovich@google.com Merge "Add the mm_event trace event to Perfetto ftrace config" Created with: gclient setdep -r src/third_party/perfetto@822963b8b8b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib22e52a5cacaed117596462024387a24ef5db558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132862Reviewed-by:
-
wutao authored
This patch adds the Get/Update Settings APIs so that we can show and update it in the Chrome OS Settings ambient mode page, which will be implemented in a follow up cl. Bug: b/148483925 Test: manual Change-Id: Ia74d875813860a6abbfdc01479a67fed0c029fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125685 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#755531}
-
Sorin Jianu authored
base::Bind can now bind __stdcall calls and indirection through lambdas is not needed. Bug: 1053729 Change-Id: Id9381a9370db07319f2e0998827b726a722281c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132932Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#755530}
-
Sunny Sachanandani authored
SkiaRenderer renders washed out colors when using PQ color space with a RGB10A2 surface. This happens in M81 because the default color space and buffer format for HDR was changed to PQ and RGB10A2 on Windows. The root cause is that the default PQ SkColorSpace uses normalized luminance values whereas Chrome needs to output scaled values based on the white point. The fix is to construct a PQish SkColorSpace using the scaling factor. This CL includes pixel tests for HDR10 and scRGB linear. The HDR10 test fails before this fix. The HDR10 test is temporarily suppressed due to infra issues causing the test to run on different Windows versions. Bug: 1058580, 1066979 Change-Id: I5a6b91631377a300010d045aaf44a9375d8ffa55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109254 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#755529}
-
Dave Tapuska authored
User-Agent isn't currently allowed to be set. Mark the TestExceptations against it. BUG=571722 Change-Id: I66e23de22c0cbf4e47c64a2b1f3b0adae9f5d886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132969Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#755528}
-
Julie Jeongeun Kim authored
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose and renames it to flex-item-z-ordering-001.html. Bug: 1063749 Change-Id: I36a4329db16e6cb805ada486ebbebe565a66c97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131550 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
-
Varun Khaneja authored
This CL does the following: a) Add a new enum policy to set the Safe Browsing protection level. This policy is called: SafeBrowsingProtectionLevel b) Drops a policy named SafeBrowsingEnhancedProtection This policy never shipped. c) Deprecates an existing boolean policy named: SafeBrowsingEnabled. The new policy in a) has three values: 0 - Safe Browsing gets disabled. This is equivalent to setting SafeBrowsingEnabled to false. 1 - Safe Browsing gets enabled in standard mode. This is equivalent to setting SafeBrowsingEnabled to true. 2 - Safe Browsing Enhanced Protection gets enabled. This CL also adds a handler class called SafeBrowsingPolicyHandler the purpose of which is to map the policy being deprecated (i.e. SafeBrowsingEnabled) and the policy being introduced (i.e. SafeBrowsingProtectionLevel) to the appropriate prefs. For details, please see: go/crsb-safer-chrome-policy Bug: 1066371, 1056483 Change-Id: I37115f04e07ba190504b9cac85c5e0694f4aec12 Fixed: 1066371 TBR: blundell (for '+components/strings/grit/components_strings.h' DEPS) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129284 Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:Pavol Marko <pmarko@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#755526}
-
Sam Bowen authored
Change-Id: Iecdfb6d697c1aa070618ebe3d9e8d476f746cbc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132675 Commit-Queue: Sam Bowen <sgbowen@google.com> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#755525}
-
Liviu Tinta authored
The 2 tests were failing on wpt.fyi because the coordinates passed to Actions.pointerMove were not integers (like on local run). Since Actions.pointerMove expects integer coordinates, the tests were failing with an exception. Use Math.ceil on coordinates passed to Actions.pointerMove. Apply memory leak fix. Bug: 810882 Change-Id: I399f763fa03ebd98167fd060ad1769e8dd7f9d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132950 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#755524}
-
Gary Kacmarcik authored
BUG: 961064 Change-Id: I14020da7f64f1cc5dd14b4ca89340d554031a82d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130486 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#755523}
-
haozhe authored
The patch adds owning_element to CSSTransition class. Now the CSSTransition have an owning_element and we will clear the owning element if the animation disassociate from the owning_element. The next follow up patches will enable us to use owning element to compare the composite ordering. And a clean-up will required to fixed the previous work-around due to no owning element. As per spec: https://drafts.csswg.org/css-transitions-2/#owning-element Bug: 1043778 Change-Id: Ic034ae25a39bacdab0bddbcc4a2ebab1a8a65a57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121453 Commit-Queue: Hao Sheng <haozhes@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#755522}
-
Brian Sheedy authored
Switches all tests that use Skia Gold to use a mixin instead of individually specifying arguments in each test definition. As a prerequisite, also ensures that all test types that use Skia Gold use the same naming for Gold-related arguments. This is requisite work for adding a universal Gold kill switch in the unlikely event of an outage that can't be fixed quickly, as the switch can just be added to the mixin. Bug: 1057848 Change-Id: Ib57480f374eab088ac3a389637bfbff1ee41e8b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121419 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#755521}
-
Piotr Bialecki authored
Change-Id: I826216ae37c1602081b75fb7f7161a0bfad01951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125237 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#755520}
-
Julie Jeongeun Kim authored
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose and renames it to flexbox_width-change-and-relayout-children.html. Bug: 1063749 Change-Id: I7782b4a7230f6a28872a4eecba544abca89aafcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131786 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
-
Tao Bai authored
The bounds is transformed to viewport coordinates before being pushed to Java side. Bug: 1064420 Change-Id: Ib473e5ee1723c361edcfee39e742274be9a83c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131039Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#755518}
-
zhaoyangli authored
When we process multiple test types' coverage data, profdata files from each test target will be used multiple times for different test types. So these can't be removed after a merge. Bug: 1064785 Change-Id: I28b92ec5d721192b20781a432ec8d90edbad74b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132672 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Sajjad Mirza <sajjadm@chromium.org> Cr-Commit-Position: refs/heads/master@{#755517}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a0afd3158504..373a3ff26ec7 git log a0afd3158504..373a3ff26ec7 --date=short --first-parent --format='%ad %ae %s' 2020-04-01 cwallez@chromium.org Rename GetBindGroupLayout's argument group->groupIndex Created with: gclient setdep -r src/third_party/dawn@373a3ff26ec7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I09a6849fe4afc4ba670a13ef91344bce1f37fe9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132863Reviewed-by:
-
Nate Fischer authored
No change to logic. This swaps out the color of highlight-all-webviews for a paler shade of yellow, and makes it more transparent. This is based on feedback from the test team. Fixed: 1066983 Test: Manual - load http://www.cnn.com/ and compare color filters Change-Id: I27b22cae1f233ea9f4d410d091520c25d74309d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132929 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#755515}
-
Mason Freed authored
Prior to this CL, using the QuickLook feature (hard-press on the touchpad of a Mac) on a popup like the color picker or date picker would cause a crash. TextInputClientMac::GetStringAtPoint() requires a RenderFrame attached to the RenderWidget on the renderer side to do anything, which only is true for main frame and iframes. Prior to [1], this would not do anything either, but after [1] this became a crash. This CL returns the behavior to a no-op for popups. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2006209 Bug: 1065328 Change-Id: I6a1a1cf12898c615ba756d32dd75bb5f87b4cc86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132963 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#755514}
-
Clark DuVall authored
Fixes this TODO before M83 branches. Bug: 1031830 Change-Id: I280cc8378cb1124fdcc12965ff067382d669ef09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132827 Auto-Submit: Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#755513}
-
Florent Castelli authored
Intent: https://groups.google.com/a/chromium.org/g/blink-dev/c/WPvxi5nUK2E/m/Xd0ZzPwxAwAJ Bug: 857041 Change-Id: I3f11c310624d5c2153eefbf9c1e08383d9aad4f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074777 Commit-Queue: Florent Castelli <orphis@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Auto-Submit: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#755512}
-
Felicia Lim authored
Applies patch from https://gitlab.xiph.org/xiph/opus/-/commit/adcb7bc2 Bug: 1061593 Change-Id: I377991d493cfd1cf5bf509fee2deec6207feee56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132634 Auto-Submit: Felicia Lim <flim@chromium.org> Commit-Queue: James Zern <jzern@google.com> Reviewed-by:
James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#755511}
-
chrome://signin-errordpapad authored
This is in preparation of migrating to Polymer3. Specifically: - Adjust icon color in dark mode, previously same color was used in both light and dark mode. - Correctly hide "Learn more" link when it should be hidden. Previously was not correctly hidden because :empty CSS selector was always false. - Add missing icon on 3rd row of profile-blocking-error-message. - Remove unnecessary white space between #normal-error-message and #action-container. In the process of fixing these bugs and paving the way for Polymer3: - Stop using "flattenhtml" to embed icons, instead use same icons from shared cr_elements/icons.html along with iron-icon.html - Extract most UI and logic in a <signin-error-app> element. - Leverage Polymer bindings to determine what to show/hide instead of :empty CSS selectors. Bug: 1012533 Change-Id: Iaed8fdabbeb821f5c4d5b52f76510d477c55fd1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130809Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#755510}
-
Matthew Mourgos authored
This CL does three things: 1) Remove the "swipe up to get started UI and gesture" related code. 2) Make the "Get Started" button on the marketing screen always visible for screen completion/exit. 3) Remove the accessibility link and replace it with an accessibility button to view the accessibility setting page. Bug: 1065487 Change-Id: I0825847d7c4b9e99ada1159eff7f072c9d699e8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127900Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#755509}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c66dad9552ef..cb58662302c8 git log c66dad9552ef..cb58662302c8 --date=short --first-parent --format='%ad %ae %s' 2020-04-01 cwallez@cwallez-macbookpro3.roam.corp.google.com MetalSurface: set layer.device to a ref of the system default device. Created with: gclient setdep -r src/third_party/swiftshader@cb58662302c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I9343f48a4995a098a83160bae0049671cd675d82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132857Reviewed-by:
-
edchin authored
This reverts commit 4edeedc6. Reason for revert: Fixed the error that broke compilation: welcome_to_chrome_view_controller.mm should not have been edited. Original change's description: > Revert "[ios] Remove dead code in first_run_util" > > This reverts commit 721f0aa1. > > Reason for revert: > suspect this is breaking compilation on ios-simulator > > Original change's description: > > [ios] Remove dead code in first_run_util > > > > Removed dead codepaths and marked unused histograms obsolete. > > > > Change-Id: Ie4f5485ebd9c915dcb36c8ac7d14d2d688b200e7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129507 > > Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> > > Reviewed-by: Ilya Sherman <isherman@chromium.org> > > Commit-Queue: edchin <edchin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#755163} > > TBR=isherman@chromium.org,kkhorimoto@chromium.org,mrefaat@chromium.org,edchin@chromium.org > > Change-Id: I1d3d94ce35b28df80626a1838b3c110957b8757d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131354 > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#755166} TBR=isherman@chromium.org Change-Id: Ibb79afe4242978bf9d7271d2b0609cb0013f9d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131215 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#755507}
-
Nick Diego Yamane authored
Bug: 1002674 Change-Id: I01e0daa245231d101425d8ff5a82f7d197f390e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098350 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#755506}
-
Livvie Lin authored
App was crashing when trying to navigate from an interstitial page (forward, backward, back to safety). Remove WebStateObserver in both the destructor and WebStateDestroyed so that both navigations and closing the page are covered. Bug: 1066445 Change-Id: Iace4d26edbaec1ccc26a9b6c410a4de827c5be7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130777 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#755505}
-
Lukasz Anforowicz authored
Tests assume that NOTIFICATION_EXTENSION_HOST_CREATED fires at most once (see BrowserActionInteractiveTest::TearDownOnMainThread which compares the number of "created" vs "destroyed" notifications). This assumption has not been met by the product code, which would fire NOTIFICATION_EXTENSION_HOST_CREATED for every RenderViewReady notification which happens not only for the very first RenderViewHost, but also for possible subsequent RenderViewHost swaps (e.g. when navigating cross-site). This CL fixes ExtensionHost::RenderViewReady, to ensure that the NOTIFICATION_EXTENSION_HOST_CREATED fires at most once per ExtensionHost object. Note that NOTIFICATION_EXTENSION_HOST_CREATED is only listened to by test code (browser_action_interactive_test.cc and management_api_browsertest.cc). This means that this CL should have no effect on production code and product behavior. Fixed: 1066287 Change-Id: I30b26294c9edb18420b7d3d4b8d560c360914a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129230 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#755504}
-
Chris Lu authored
This is needed for Fullscreen to reset itself when a navigation occurs. Bug: 790886 Change-Id: I8ac3cb22679e5f2dfc5f966797513d67e8b08da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132627Reviewed-by:
-
Dominique Fauteux-Chapleau authored
The following legacy policies are read by the manager: DelayDeliveryUntilVerdict BlockLargeFileTransfer AllowPasswordProtectedFiles BlockUnsupportedFiletypes kURLs* policies The manager is not called by chrome code yet since the CL is already quite large and to avoid having this reverted if subsequent code breaks something. Bug: 1062348 Change-Id: I4708a9a8a3bab8e559536b426bc4759705f48395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124856Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#755502}
-
Dave Tapuska authored
These issues were open against a WPT test that was written but the patch was reverted in blink, implementation is still pending. BUG=922618 Change-Id: I33ade6c7805a7d3ec55fc3e6b1f1f3747b192657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132860Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/e5b4b11496a0..07dc402b0545 git log e5b4b11496a0..07dc402b0545 --date=short --first-parent --format='%ad %ae %s' 2020-04-01 rwkeane@google.com Add Hashing functions to Util Created with: gclient setdep -r src/third_party/openscreen/src@07dc402b0545 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Icee3acde6623b2fe0eca14b5ed4475f736e985fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132856Reviewed-by:
-
