GitLab

Breaks out one of the most complex media/ targets into its
own BUILD.gn file for improved readibility and targetting.

BUG=none
TEST=media_unittests

Review URL: https://codereview.chromium.org/396793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284314 0039d316-1c4b-4281-b951-d872f2087c98

This change writes (flushes) compacted data to disk resulting in
changes, which would previously only be flushed the next db close/open
cycle, to be written immediately.

BUG=329347

Review URL: https://codereview.chromium.org/397323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284313 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349436

Review URL: https://codereview.chromium.org/387003008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284312 0039d316-1c4b-4281-b951-d872f2087c98

This patch is the second part of ensuring that recycle tree does not
contain any unshared tiles.

This is done by removing recycle tree tilings when active tree removes
those tilings.

BUG=393802
R=danakj

Review URL: https://codereview.chromium.org/400633004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284311 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393360

Review URL: https://codereview.chromium.org/397483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284310 0039d316-1c4b-4281-b951-d872f2087c98

BUG=389697

Review URL: https://codereview.chromium.org/405623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284309 0039d316-1c4b-4281-b951-d872f2087c98

(these tests changed names when they went from TEST_P to
 TEST_F in r283700).

Fix spelling error in three test names.

Eliminate memory error suppressions that were put in as fixes:
* Revert "[MemSheriff] Suppress unreadable mem access"
* This reverts commit a9226086.
* (aka svn r283943)

* Revert "[MemSheriff] Disable failing tests"
* This reverts commit 565a8552.
* (aka svn r284133)

BUG=394957,395172,389132,389098

Review URL: https://codereview.chromium.org/401073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284308 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/402993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284307 0039d316-1c4b-4281-b951-d872f2087c98

. There is only X11 implementation of IsTouchpadEvent(), and it is used
  by DeviceUMA. But DeviceUMA also talks to DeviceDataManagerX11. So
  remove ui::IsTouchpadEvent(), and directly query DDMX11 whether the
  event is a touchpad event.

. Remove SetNaturalScroll() and IsNaturalScrollEnabled() since nothing uses
  these anymore (and there are no implementations of these either).

BUG=none
R=derat@chromium.org

Review URL: https://codereview.chromium.org/405683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284306 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/401713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284305 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160586

Review URL: https://codereview.chromium.org/390233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284304 0039d316-1c4b-4281-b951-d872f2087c98

BUG=382931
TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/399643008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284303 0039d316-1c4b-4281-b951-d872f2087c98

[Chromium] XMLTreeViewer should load resources from blink_resources.grd instead of relying upon xxd.py

This is chromium side changes required for moving XMLViewer resources in grd file here [1]

[1] https://codereview.chromium.org/391963002/

BUG=312586

Review URL: https://codereview.chromium.org/395833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284302 0039d316-1c4b-4281-b951-d872f2087c98

Moves hotwording checkbox to new 'Voice' section.

BUG=390086

Review URL: https://codereview.chromium.org/382123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284301 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284298 0039d316-1c4b-4281-b951-d872f2087c98

BUG=321868

Review URL: https://codereview.chromium.org/331713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284297 0039d316-1c4b-4281-b951-d872f2087c98

The old method of using a timer to set the closeHandler was messy and harder
to unit-test. The new method uses stopPropagation, which is cleaner and makes
the unit-tests simpler.

Review URL: https://codereview.chromium.org/401623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284295 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284294 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178454:178494&mode=html
TBR=abarth@chromium.org,johnme@chromium.org
BUG=

Review URL: https://codereview.chromium.org/405433012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284293 0039d316-1c4b-4281-b951-d872f2087c98

On the Settings page, when you change a slider (input type="range") by
touch, we don't save the associated preference.

Listen to touchend and touchcancel, and add a test for this.

BUG=394938
R=estade@chromium.org

Review URL: https://codereview.chromium.org/400993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284292 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284291 0039d316-1c4b-4281-b951-d872f2087c98

b72977f  Build with exceptions enabled on Windows too.
98a44a1  Fix the potential integer overflow from "offset + size".
5ffacd6  Fix bounds checking in CJS_PublicMethods::MakeRegularDate().

BUG=393831,382667
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/401883005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284290 0039d316-1c4b-4281-b951-d872f2087c98

Seeing this almost certainly indicates a bug in the "user's" code.
Arguably, this should be a MOJO_DCHECK instead, but I'm keeping it as a
MOJO_CHECK since it'll make tests crash-fail on bots instead of hanging
(and then timing out).

(We'll see this failure due to the bugs listed below.)

R=yzshen@chromium.org
BUG=394884,394886

Review URL: https://codereview.chromium.org/401963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284289 0039d316-1c4b-4281-b951-d872f2087c98

BUG=382931
R=mark@chromium.org

Review URL: https://codereview.chromium.org/404893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284288 0039d316-1c4b-4281-b951-d872f2087c98

This is intended to add personell who can do harfbuzz rolls
when needed. Bashi and I mostly did them recently, we should be able 
to commit them after review.

R=eae,eseidel,behdad
BUG=

Review URL: https://codereview.chromium.org/407583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284287 0039d316-1c4b-4281-b951-d872f2087c98

This fix changes representation of some disabled datatypes on about:sync page.
There are two special cases supported by this fix:
1) When a datatype needs to be disabled due to configuration constraints,
   for example, when sync to need to disable delete directives when
   encryption is enabled.
2) When a datatype isn't ready to start yet (was disabled with
   SyncError::UNREADY_ERROR).

To implement the fix, SyncError class was extended with severity() property,
which is based on the error type. The purpose of severity is to determine
logging severity of the error and the representation on about:sync page.
Sync errors of UNREADY_ERROR and DATATYPE_POLICY_ERROR types are logged with
LOG_INFO level rather than LOG_ERROR. In the UI errors of these types are
displayed on gray background rather than red.

DATATYPE_POLICY_ERROR is a new error type used for a few cases when a type
is disabled by policy (i.e. configuration constraints). Other than its
severity it is treated the same as DATATYPE_ERROR.

I added an overload for DisableDatatype function which allows to specify
an error type. By default, the error type is DATATYPE_ERROR which is
consistent with the current implementation.

BUG=380446,392110

Review URL: https://codereview.chromium.org/388003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284286 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284285 0039d316-1c4b-4281-b951-d872f2087c98

This roll:
- Allows libwebm to build using clang-cl.
- Allows removal of a workaround from libwebm's BUILD.gn.

R=thakis

Review URL: https://codereview.chromium.org/403063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284284 0039d316-1c4b-4281-b951-d872f2087c98

Preivously we relied on the SyncBackendRegistrar's last configured types to
decide which types have been recently disabled. Now we just purge all disabled
types that exist in the directory, as recorded by their progress markers (which
should never be deleted unless the type has been purged).

BUG=386778

Review URL: https://codereview.chromium.org/398813005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284283 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284281 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=tree
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/400303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284280 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/408493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284279 0039d316-1c4b-4281-b951-d872f2087c98

Expose enabling and disabling record whole document behavior as a public
webview api. The default is still record whole document for
compatibility.

BUG=390702

Review URL: https://codereview.chromium.org/406683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284278 0039d316-1c4b-4281-b951-d872f2087c98

We use experimental app-list view for centered layout, and then
use athena's own view for bottom view.

BUG=387227
R=oshima@chromium.org, sadrul@chromium.org, xiyuan@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/397343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284275 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/408543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284274 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395187
TBR=erikchen@chromium.org

> mac: Load the system hotkeys after launch.
>
> Shortly after launch, the system hotkeys are loaded and parsed. If a hotkey is
> reserved by the system, it is not passed to the renderer. This allows system
> hotkeys like (cmd + `) to work even if a flash plugin is selected.
>
> Add a histogram to ensure that the system hotkey plist is being correctly
> loaded and parsed.
>
> BUG=383558
> TEST=Open 2 Chrome windows. Navigate one to www.twitch.tv. The site should
> include a flash plugin that automatically starts playing a video. Select the
> flash plugin. The hotkey combination (cmd + `) should switch between the open
> windows. The hotkey combination (cmd + L) should have no effect (it is a Chrome
> hotkey, not a browser hotkey).
>
> Review URL: https://codereview.chromium.org/370293004

Review URL: https://codereview.chromium.org/406693005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284273 0039d316-1c4b-4281-b951-d872f2087c98

I think someone added a usage of athena_resources after I did the patch
and then I missed this on rebase.

BUG=None
TEST=None
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/405753004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284271 0039d316-1c4b-4281-b951-d872f2087c98

This also goes and changes a lot of "if (obj.get())" to "if (obj)".

BUG=394639

Review URL: https://codereview.chromium.org/405653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284269 0039d316-1c4b-4281-b951-d872f2087c98

That way we free a slot for when we add an athena_resources.grd.

BUG=None
TEST=None
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/404683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284268 0039d316-1c4b-4281-b951-d872f2087c98

Split up the monstrously large platform_crypto_nss.cc, platform_crypto_openssl.cc into multiple files.

-----------
Overview:
-----------

* algorithm_implementation.h:

This defines a base class AlgorithmImplementation, which has virtual methods for synchronous encrypt/decrypt/generatekey. All of the information about an algorithm is now encapsulated by an AlgorithmImplementation. So for instance the JWK specific knowledge, key usages for each key type are pulled into this interface.

* algorithm_registry.cc:

Contains a mapping from WebCryptoAlgorithmID --> AlgorithmImplementation, stored by a singleton.

* algorithm_dispatch.cc:

Given parameters from Blink, looks up the appropriate AlgorithmImplementation in the registry and dispatches the operation. Also implements wrap/unwrap in terms of encrypt/decrypt.

* structured_clone.cc:

Contains the code related to structured cloning (which still needs some cleanup, and is implemented in terms of import/export).

* nss/*, openssl/*:

Contains the AlgorithmImplementation concrete classes for each algorithm.

This reorganization also unintentionally fixes a few bugs.

  * ExportKey() for spki/pkcs8/raw uses the already serialized key data rather than re-exporting
  * Some exception codes were fixed.

BUG=389325,389342,389327,374912
R=jochen@chromium.org, rsleevi@chromium.org

Review URL: https://codereview.chromium.org/379383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284267 0039d316-1c4b-4281-b951-d872f2087c98