- 15 Nov, 2019 40 commits
-
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /chrome/browser/search This CL was uploaded by git cl split. R=kmilka@chromium.org Bug: 1018667 Change-Id: I6006941d3c12b2a041306d5dfd0e25b20348ef52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917507 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#715712}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ad0250cefb22..246e1a35f069 git log ad0250cefb22..246e1a35f069 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 fmayer@google.com Merge "Manually maintain stack for heap graph walk." Created with: gclient setdep -r src/third_party/perfetto@246e1a35f069 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Id49c6fba5365ecca7df236d397935a723486563f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919267Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715711}
-
kylechar authored
Update code where NULL or 0 is assigned to a scoped_refptr to reset it. Just call reset() instead. If operator=(std::nullptr_t) is added these assignments become ambiguous. This CL was uploaded by git cl split. R=raymes@chromium.org Bug: 1024981 Change-Id: Ia3973b95ed896197678e47de7697f68c3ab2e784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918156 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#715710}
-
Vladimir Levin authored
This patch pushes the flag expiry to M82. At that time, we will re-evaluate what we need to do. Change-Id: Ic4dfcaf0c92e10b1e58a3763907d3e302b2f6fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919321 Commit-Queue: vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Auto-Submit: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#715709}
-
Alex Chau authored
Bug: 1024845 Change-Id: Ia08a00398eb5cbc6809a055423b46b434e0dbe49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917161 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#715708}
-
Michael van Ouwerkerk authored
Bug: 1018138 Change-Id: Ia6ede078dc04cc80fcc21450b22e0513c6da249f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919139 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
-
Sophie Chang authored
Bug: 969558 Change-Id: I8e2f766a02b53c5730dc09696f74e7a9b37e2552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907205Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#715706}
-
Guido Urdaneta authored
Bug: 1025218 Change-Id: I3e357354054f6f96c85ed8d9002d252c3bf619d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862450 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#715705}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7b55818248cc..660c2fff46a7 git log 7b55818248cc..660c2fff46a7 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 herb@google.com Remove indexes from Geometry in the text op Created with: gclient setdep -r src/third_party/skia@660c2fff46a7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: None Change-Id: Ia91404535f367a88af1647fb2ba2886553f913a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919265Reviewed-by:
-
Thomas Lukaszewicz authored
Removed the need to specify FromInputColor/FromOutputColor in ColorTransforms. All references to color are now taken to mean FromOutputColor as we do not currently have a use for FromInputColor in the code. This significantly reduces the verbosity of recipe code. Bug: 1887666 Change-Id: I1fa3816f738e5479eb24ae30b86e6851792913b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918640 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#715703}
-
Marc Grimme authored
HostTemplate in hostname_handler now also supports the ${LOCATION} variable to be resolved to the location set in the policy. This will lead to a dhcp hostname supporting the location autoresolution. R=marcgrimme Bug: 1013220 Change-Id: Iac87db9914985ce3a65c34607977cc4b9d663ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915760Reviewed-by:Sergey Poromov <poromov@chromium.org> Commit-Queue: Marc Grimme <marcgrimme@google.com> Cr-Commit-Position: refs/heads/master@{#715702}
-
Andreas Haas authored
When allocation of backing store data failed, we still set the length of the backing store. This mismatch of no data but length!=0 triggered the crash in the DOMArrayBuffer constructor. R=haraken@chromium.org Bug: chromium:1024787 Change-Id: I11c826a17d18a1bebfa7c127d438700cf759bc56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917534Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#715701}
-
Tina Wang authored
Bug: 1025220 Tbr: rsorokin@chromium.org Change-Id: Ic8896aec0851dbe7a7fd65190ec21753fc39878c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917966Reviewed-by:
Tina Wang <tinazwang@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#715700}
-
Sasha McIntosh authored
Fix stride width computation by passing the stride bytes instead of stride bytes as pixels. Bug: 1024733 Change-Id: Ia383ac4fa5edf9cd84d661311db235d17ec6abd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918200 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#715699}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fe24d1e38c44..42251f9ad57e git log fe24d1e38c44..42251f9ad57e --date=short --no-merges --format='%ad %ae %s' 2019-11-15 mmortensen@google.com BuildAPI: Add remaining unit tests and mocks for Binhost Service. Created with: gclient setdep -r src/third_party/chromite@42251f9ad57e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Id5159cb92207479f6a72231faa8d892dbd494c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919264Reviewed-by:
-
Ross McIlroy authored
This CL was created automatically with tools/perf/update_wpr script R=perezju@chromium.org Change-Id: Ic5b6230cbe6e6125de279356631de74f66f031b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917533Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#715697}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/37dcb894574e..f4d4668529f1 git log 37dcb894574e..f4d4668529f1 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 johnkslang@users.noreply.github.com Merge pull request #1977 from KhronosGroup/no-hlsl-structs Created with: gclient setdep -r src/third_party/glslang/src@f4d4668529f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com,cnorthrop@google.com Bug: None Change-Id: I54a7f850d6b9fd2f4d2734fa63c504a4229abe4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919263Reviewed-by:
-
kylechar authored
This CL tracks if CompositorFrameSinkClients are responding to OnBeginFrame() messages. It appears we can get into a state where the GPU continues to send messages but the client isn't processing them. It appears to have something to do with lock screen. If the client hasn't responded to any of the last 10 OnBeginFrames() then throttle it to 1hz. If the client hasn't responded to any of the last 100 OnBeginFrames() then stop sending to it and wait for some kind of a response. Bug: 1011441 Change-Id: I15ba0dc58faa29d28f5c8b633c1f3880dcce0458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849102Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#715695}
-
Jesse Schettler authored
The flag is being set to on by default for the first time in M80. Extending the flag's expiry milestone to M82 to ensure it can be used in M80 and M81. Change-Id: Ie5f6dff0c539141ef21a1c2e220a175ce286752b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918028 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#715694}
-
Tina Wang authored
Bug: 1025213,1025220 Tbr: xiyuan@chromium.org Change-Id: If2ecef3066504dc40eefe25b5d0c8add170b8b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917964 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
-
kylechar authored
Update code where NULL or 0 is assigned to a scoped_refptr to reset it. Just call reset() instead. If operator=(std::nullptr_t) is added these assignments become ambiguous. This CL was uploaded by git cl split. R=tsepez@chromium.org Bug: 1024981 Change-Id: I99d14551e388b435c67dea3eb6aa2b0a0d4efe8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918147 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
-
Mikhail Khokhlov authored
Tracing agents like atrace produce traces with the '.txt' extension. We need to aggregate them together with all other TBMv2 traces. Bug: 1025037 Change-Id: I2d150a338e42f183f086122d3a49335efa085717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917373Reviewed-by:
-
Gauthier Ambard authored
This CL changes the use of PrefBackBoolean (using a BooleanPrefMember as the backing ivar) to using the Preference directly. This is because the value of the Preference has to be checked when the preference is updated. As PrefMember is also observing the Preference, in some cases the PrefMember is updated after the call in ContentSuggestions. Changing it to Preference directly prevent this issue. Bug: 1023791 Change-Id: Iaa8293d270640007f2e0b1f68b23d76712186752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913255 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#715690}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dad08eab03cc..ad0250cefb22 git log dad08eab03cc..ad0250cefb22 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 lalitm@google.com Merge "ui: switch UI to use track id instead of ref/ref_type" Created with: gclient setdep -r src/third_party/perfetto@ad0250cefb22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I1561b6138eb931b51d29cf0b51ab9ba5f8251d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919262Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6e5f1021ae2c..86e9f140ce37 git log 6e5f1021ae2c..86e9f140ce37 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 alexclarke@chromium.org Allow --webview-embedder-apk to be specified multiple times Created with: gclient setdep -r src/third_party/catapult@86e9f140ce37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:1022812 Change-Id: I41d9638fd8d6d9659ffc611a10e22ee98cfaad61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919261Reviewed-by:
-
kylechar authored
Update code where NULL or 0 is assigned to a scoped_refptr to reset it. Just call reset() instead. If operator=(std::nullptr_t) is added these assignments become ambiguous. This CL was uploaded by git cl split. R=odejesush@chromium.org Bug: 1024981 Change-Id: I24b8ae005c530c473b32745f398319db3fe39dcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918320 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#715687}
-
Natalie Chouinard authored
Change-Id: Ib700829caf0a1e200a7fd8358e8f8f332a7393cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918652 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#715686}
-
Brian Osman authored
Bug: chromium:985500 Change-Id: I0f2c00ac5aac0a939d87a5c0d1e53fd6f53d8313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917621Reviewed-by:
Michael Ludwig <michaelludwig@google.com> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#715685}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3fafc831bc15..7b55818248cc git log 3fafc831bc15..7b55818248cc --date=short --no-merges --format='%ad %ae %s' 2019-11-15 jvanverth@google.com Add flag to Viewer to trigger continuous redraw. 2019-11-15 robertphillips@google.com Revert "Reland "Reland "Reland "Implement sample mask and sample locations support in Vulkan"""" 2019-11-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 1b52f05868c9..5f4db6a76640 (9 commits) 2019-11-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 7ca6de3a..69610187 (8341 commits) 2019-11-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader b2407dd746de..102fd19c65f4 (4 commits) 2019-11-15 csmartdalton@google.com Reland "Reland "Reland "Implement sample mask and sample locations support in Vulkan""" Created with: gclient setdep -r src/third_party/skia@7b55818248cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I1cfe2ee7fbbfb46ae9817d8ebcc54328a800677c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919259Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8415d24c..96915046 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3129a8101bc491669038024a2536f207dbadb952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917094Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715683}
-
kylechar authored
Update code where NULL or 0 is assigned to a scoped_refptr to reset it. Just call reset() instead. If operator=(std::nullptr_t) is added these assignments become ambiguous. This CL was uploaded by git cl split. R=rmcilroy@chromium.org Bug: 1024981 Change-Id: Id9096057c47c70ad94e97ddb42984c71e0ab078e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918319 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#715682}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4207870bcd60..86f651198df2 git log 4207870bcd60..86f651198df2 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 jiawei.shao@intel.com Add android_ndk and catapult to .gitignore Created with: gclient setdep -r src/third_party/angle@86f651198df2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: None Change-Id: I64943acf5dbe1c9bf96c82432dd3472b6b7a912e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918018Reviewed-by:
-
kylechar authored
Update code where NULL or 0 is assigned to a scoped_refptr to reset it. Just call reset() instead. If operator=(std::nullptr_t) is added these assignments become ambiguous. This CL was uploaded by git cl split. R=morlovich@chromium.org Bug: 1024981 Change-Id: Ib65acd19bcf2ce1b2cbb4b167c89a08b3287f494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918323 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#715680}
-
Olivier Robin authored
One of the mocked method is only call in a DCHECK. Tbr: rohitrao Bug: 1024962 Change-Id: I80ee5bd19a7427f9c8362230135d63d72514e8cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917374Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715679}
-
kylechar authored
Update code where NULL or 0 is assigned to a scoped_refptr to reset it. Just call reset() instead. If operator=(std::nullptr_t) is added these assignments become ambiguous. This CL was uploaded by git cl split. R=zmo@chromium.org Bug: 1024981 Change-Id: Ia08fdf19c190da94edeaaaaa2d8811f91fa1b58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918152 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#715678}
-
Javier Ernesto Flores Robles authored
Bug: 1024310 Change-Id: I0a30dc9fe583988b3fcefe5805fc916483a37888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913416 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#715677}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c30a003c. With Chromium commits locally applied on WPT: 788a3004 "Fix failing Fetch Metadata WPT" b16db925 "[Trusted Types] Add test for duplicate names in non-enforcing mode." e83dd93c "Limit backtracking on regexp called from blink." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mlamouri@chromium.org: external/wpt/screen-orientation NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I98ba9afb2b88ac9126ec57e9dbca157e5cdf38a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917047Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715676}
-
Anatoliy Potapchuk authored
We should notify SessionManager before we actually create a new browser window. This is needed to cover one of the bugs related to the splash screen. Bug: 1006230, 939674 Change-Id: I3e7e8b5b639dd1bfec2483869959a50b0acb2053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912360Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
kylechar authored
Update code where NULL or 0 is assigned to a scoped_refptr to reset it. Just call reset() instead. If operator=(std::nullptr_t) is added these assignments become ambiguous. This CL was uploaded by git cl split. R=tbarzic@chromium.org Bug: 1024981 Change-Id: I89753d009772b07bfa017c57155211e4242200be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918155 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#715674}
-
Tobias Sargeant authored
Also rearrange directory structure slightly to group crash-related source files. Change-Id: Iae6bb34c9cb708ac4297cbbeb99be38f1481220a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916826Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#715673}
-
