GitLab

The pin to shelf item now toggles it's state when a "space" or
"enter" keypress is registered.

Bug: 987585
Change-Id: I2f6125ce496dfc32aa0b94be0e779b065a01d9ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718454Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685104}

Mojo JS Lite Bindings were recently renamed to align with the new C++
names. This CL changes usage of the old names with the new ones. See
bug for more details.

Test: On Chrome OS only, open camera app and take a picture.
Bug: 968369
Change-Id: I1085058df341ffae54d1e819786be4a07ecc8b35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743429Reviewed-by: Wei Lee <wtlee@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685103}

The feature flag no longer exists.

Bug: 824858, 985259, 824840
Change-Id: I2a8c7a5021be4927f0b8c620429c720419eb9133
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743295
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685102}

I made Instantiate take source_url as an argument to remove source_url
from ModuleRecord.
It leads to make ModuleRecord and v8::Local<v8::Module> equivalent.

This is a part of removing ModuleRecord.

Bug: 991863
Change-Id: If72d94d5e54248fa7cd76481b2e291463bdd3def
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743287Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Rika Fujimaki <rikaf@google.com>
Cr-Commit-Position: refs/heads/master@{#685101}

This looked like a potential race since
ServiceWorkerNavigationHandleCore is only supposed to be accessed on the
IO thread. So just post to the pointer to the IO thread, and access
it there.

Change-Id: Id4ef0ce1bfade0fc43e5158097018ada5d523c29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743241Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685100}

So callsites don't need to make a RunLoop.

Change-Id: I499166d235446cbe761ba045e2597f01d92abef8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743238
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Auto-Submit: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685099}

This is in preparation for requiring WARN_UNUSED_RESULT on
NavigateToURL() usage in tests.

Bug: 425335
Change-Id: I23137312bd945c012aee424fc43248516595cfbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742772
Auto-Submit: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685098}

This is a reland of 2fd01309

Original change's description:
> [App Management] Enable App Management by default.
>
> Enable App Management by default. Current entry points are about:settings
> and about:app-management.
>
> Bug: 906508
> Change-Id: I0118a4b51eda6e65bc72186e771fc2ede2acb45f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610658
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#659341}

TBR=dominickn@chromium.org

Bug: 906508
Change-Id: I640886f8fae38c1a9399aecca8af97ad2bd61650
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741447Reviewed-by: Jeevan Shikaram <jshikaram@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685097}

AppBannerManagerDesktop::OnWebAppInstalled() was erroneously using
the return value of FindAppWithUrlInScope() to indicate whether the app
has a scope or not to indicate whether the app was installed as a PWA or
shortcut app to indicate whether the app's launch container was set to
open as a window or a tab.
This chain of assumptions was broken because FindAppWindUrlInScope() will
return a non-null value for shortcut apps with no scope.

This CL corrects the mistake by directly testing whether the app launches
in a window or not.
This has the side effect of counting Create shortcut as a windowed app as
the same as a PWA install. This is fine because we intend to remove the
difference between Create shortcut and PWAs anyway.

Bug: 989382
Change-Id: Ib43e307928b3c4bc1675427d23cba27bd4bc16ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731030
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685096}

linux-chromeos-google-rel has 9~11 hours hourly resource usage.
http://shortn/_E7RGR190mb

I will convert some trusty bots to xenial before this CL in
https://chrome-internal-review.googlesource.com/c/infradata/config/+/1591467

Bug: 954450
Change-Id: Iae12fa1244c9c299b7b36a03e7d05537f0bcac77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741327
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685095}

Bug: 934009, 985682
Change-Id: Id1767bd1df5833ab3bff966edca8f0c2158c3348
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732701
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685094}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=lazyboy@chromium.org

Bug: 968047
Change-Id: I563c092b63085e37b372a4993f8b980531856cec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729210
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685093}

Update the Show App Info test for the App List to not run when the
App Management flag is enabled.

Bug: 906508
Change-Id: I29cd10337432fd04580b38656af0a84481c28f40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743430Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685092}

Bug: 991363
Change-Id: Ic0303b638f92076687dceb90afe29451d8642be2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743246
Auto-Submit: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685091}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/71f3bc34cc28..9847116b5a4a


Created with:
  gclient setdep -r src-internal@9847116b5a4a

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I35035079564bd6bd9ef096f4c7c824aa32e30319
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743309Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685090}

Using wpt-import in Chromium 94fa0a4d.
With Chromium commits locally applied on WPT:
329c91e5 "Attempt to make test more stable"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
rouslan@chromium.org, mathp@chromium.org:
  external/wpt/payment-request

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I5f92ea66f36700d688bbb6480158d72695faf912
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743333Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685089}

Bringing up a context menu on the eject button of removable entries
confuses commands as they do not expect canExecute with an event target
of the eject button. Change getCommandEntries to handle this case.

Also add tests to check the context menu on eject buttons.

Bug: 991002
Change-Id: I534a297b7fad57b79f98f77e03248e77be373be6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741746
Commit-Queue: Austin Tankiang <austinct@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685088}

Make a bunch of permission checks in ContentBrowserClient use BrowserContext instead of ResourceContext.

Many of the source of these calls was the UI thread anyways, so there's no need to hop to the IO thread.

Bug: 908955
Change-Id: I63c63491d51182498c511d827fe622d13ee33272
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742806
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685087}

https://quiche.googlesource.com/quiche.git/+log/f35ea98e9c0a..092d8219e053

$ git log f35ea98e9..092d8219e --date=short --no-merges --format='%ad %ae %s'
2019-08-07 bnc Handle closing pending streams.
2019-08-07 renjietang Allow QpackStreamSenderDelegate to be set dynamically.
2019-08-07 fkastenholz Put Google QUIC Connection Close code in the extracted code field

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: I6ec13dbc05e66e0ba4b1e42195b43f1f655f8ec4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741645
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Auto-Submit: Bence Béky <bnc@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685086}

Bug: 986481
Change-Id: Id2b8a83b8accf28d360828c1d340b0e6d28999ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740830
Commit-Queue: Dan Beam <dbeam@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685085}

This CL reduces binary size by 110KB on macOS x64.

Change-Id: I77b9d7d847e62adf5212959578539a5fa7264502
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732676
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685084}

https://chromium.googlesource.com/catapult.git/+log/a01c1215ddbe..0bbcb5b8e80b

git log a01c1215ddbe..0bbcb5b8e80b --date=short --no-merges --format='%ad %ae %s'
2019-08-08 dberris@chromium.org Pinpoint: Support other android-webview names

Created with:
  gclient setdep -r src/third_party/catapult@0bbcb5b8e80b

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=skyostil@google.com

Bug: chromium:989933
Change-Id: I71d1890951a708db1ff360e66520302032631232
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743407Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685083}

A buffer cannot reference itself. We have a DCHECK() for ensuring this
in the decode surface's ToString() method, but this means we won't
perform any check unless the debug level is high enough to have this
method call.

Add a sanity DCHECK() when we set the reference frames of a decode
surface, so such errors are caught in time.

Bug: None
Test: VDA unittest passing on Minnie and Kukui.

Change-Id: Iae1097a6e6992231ed26fdbf088d9c40dd663b8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741747Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685082}

Instead of logging a console message, we now show a toast to the user
for 5 seconds the first time (per session) they focus a Crostini app
while in tablet mode.

./out/Default/unit_tests
for one and only one toast

Bug: chromium:962848
Test: autoninja -C out/Default chrome unit_tests &&
Test: Play around with tablet mode and Crostini on an Eve device, check
Change-Id: Ie70a847372f2a65d3f71fc39e29cb1165992ab3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743232
Auto-Submit: David Munro <davidmunro@google.com>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: David Munro <davidmunro@google.com>
Cr-Commit-Position: refs/heads/master@{#685081}

Bug: 969558
Change-Id: Ie0076160878e5cffdead18afb6aab0dc331c8767
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742726
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685080}

The crash bug was introduced in https://crrev.com/c/1705478 because
ServiceWorkerControlleeRequestHandler::MaybeCreateLoader changed
such that the |context_| check below was removed:

  if (!context_ || !provider_host_) {
    ... return;
  }
  provider_host_->UpdateUrls(...);

The desired behavior is a bit subtle. The only reason |context_| could
be destroyed while the provider host is still alive is if the provider
host transferred contexts using the context copy mechanism we want to
remove per https://crbug.com/877356. In this state, we end up with a
provider host that's fairly useless: it can't serve container host
messages etc., because there are early returns for !IsContextAlive().
However, it seems scary to have an inaccurate URL in the case of a
cross-origin redirect.  The previous behavior before the CL mentioned
earlier would keep the old URL in the normal case, but in the
|skip_service_worker| case it would attempt to update the URL via
NavigationUrlTracker.

This CL makes the decision to update the URL as far as possible, and
just avoid touching |context_| if it's null.

The real solution would be to remove the context copy mechanism.

Bug: 988551, 877356
Change-Id: I692b0c73dd10cf4af24275eb709382b6ebbf73e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743230
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685079}

In the absence of Mus+ash this is no longer particularly useful for
development. Given that it's a developer-facing feature with no active
users, and given that we're moving all services away from Service
Manager, we might as well just delete this instead of porting it.
So...DELETE.

Bug: 977637
Change-Id: I10c690cf290849dbe96a223890d8ead6b89980fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740129
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685078}

As a step to reduce uses of Platform::Current()->GetDataResource,
this CL replaces all uses of Platform::Current()->GetDataResource
with UncompressResourceAsBinary. UncompressResourceAsBinary introduced
by this CL returns a vector of characters to append a decoded IDR resource
to |data| directly.

Additionally, this CL makes GetDataResourceName returns a resource ID
matching the existing file as well as changes the name with GetDataResourceId.

Bug: 983396
Change-Id: Ib8062e5e7958021122ac35d549fa6d9c80f02f2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739238
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685077}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org

Change-Id: I98d192c755ff06da914bfb9fe7e001216561e0a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742808Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685076}

We do not want to mark shards with corrupted profile output as invalid
because doing so could retry "SUCCESS" shards.

Bug: 991725
Change-Id: Ibf0d8c72dad4625fa6502bc408f28ced39bafb27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742852
Commit-Queue: Sajjad Mirza <sajjadm@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685075}

Convert list:
snav-not-below
snav-not-rightof
snav-offscreen-content
snav-overlapping-elements
snav-simple-content-overflow

Bug: 803086
Change-Id: Ib193d14fec20be8d64817ce560613315ef3fdb7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736895
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685074}

DemoExtensionsExternalLoader loads apps from Offline Demo Mode
Resources, then promptly overwrites them with apps it has cached.

This means that if the device is offline and hasn't cached the demo
apps, the apps will become uninstalled shortly after being installed.

As a quick fix, prevent loading from the cache in Offline Demo Mode.
This is intended as a highly mergeable, low-risk fix that we can merge
into Stable. Afterwards, a proper fix would allow us to still use the
cache.

Bug: 991453
Change-Id: I51679f3667191f17c1dc3af3711cc36b6a9a34e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743252Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685073}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/991aed28815f..71f3bc34cc28


Created with:
  gclient setdep -r src-internal@71f3bc34cc28

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I9e563974f72fc6677b6682411c3472f8cc2d8b6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742964Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685072}

-Since Brotli isn't widely used, make grit target optional
-Change compress="true" to indicate gzip instead of brotli

Bug: 826858
Change-Id: I14045669fd69525b13fb95b2ef1b539b4c5e23ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730838
Commit-Queue: Jacques Chen <jacqueschen@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685071}

Using wpt-import in Chromium 2f10e9cb.
With Chromium commits locally applied on WPT:
329c91e5 "Attempt to make test more stable"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
drott@chromium.org:
  external/wpt/css/css-text-decor
rouslan@chromium.org, mathp@chromium.org:
  external/wpt/payment-request

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Id50bd7fa51d2c763b1b9047c369c0e33c7432d52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742119Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685070}

Bug: 974844
Change-Id: If4c07ecfa2e80ab1c0e8122296b3ff36352d8987
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666089
Commit-Queue: Jason Majors <jmajors@google.com>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685069}

Add a wrapper around 'bg-sel-tile-bg' and pull titles out and always
select 'bg-sel-tile-bg' instead of 'bg-sel-tile'.

Bug: 990734, 990946
Change-Id: I0c86318b9cca7abd13bcaac2cbe76701e3df7410
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741310
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685068}

Moves all uses of the Printing Service away from Service Manager APIs
and over to direct service process + mojom usage.

Introduces a GetPrintingService() function in chrome/browser/printing
which returns a Mojo Remote that can control the sandboxed Printing
Service process. The process is started lazily as needed and
automatically shut down when no longer in use.

Bug: 977637
Change-Id: I8bef36947163be3ed05a22eaac473e52e1e11395
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738631
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685067}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I675271adfc283b688de99d41e7eb236e908c0223
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742961Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685066}

Patch IronA11yAnnouncer to prevent a compiler error about assigning a
const to the result of Polymer() when polymer_pass is set to false
(this is the case when compiling Polymer 3 elements, see [1]).

[1] https://cs.chromium.org/chromium/src/third_party/closure_compiler/closure_args.gni

Bug: 965770
Change-Id: I497a6c9197d2034a3f2ef4fac498e2ba87585f99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742841Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685065}