- 21 Jul, 2017 40 commits
-
-
Sergey Ulanov authored
Updated GetPreferredExtensionForMimeType() implementation so it searches uses the same MIME type tables that are used for GetExtensionsForMimeType() and GetWellKnownMimeTypeFromExtension() Previously platform_mime_util_linux.cc and mime_extension_chromeos.cc contained some hardcoded tables to map between mime types and filename extensions. There is no reason these need to be separate from the maps in mime_util.cc. Merged them with the tables in mime_util.cc Bug: 731302 Change-Id: Icdaad51c70cffbf62c404297ad615ac5c6dd33e9 Reviewed-on: https://chromium-review.googlesource.com/578649 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#488556}
-
ananta authored
This is in preparation for adding support in the URLFetcher class to use the network URLLoader in the network service mode. BUG=715632 TBR=jam Review-Url: https://codereview.chromium.org/2978373002 Cr-Commit-Position: refs/heads/master@{#488555}
-
achuith authored
Revert of Add deduplication logic to .pak files (patchset #10 id:180001 of https://codereview.chromium.org/2969123002/ ) Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=747171 Original issue's description: > Add deduplication logic to .pak files > > Now, when multiple entries contain the same content, multiple > table-of-contents entries will be created, but only one data region. > > As of now, en-US.pak has ~3200 entries, and 350 of them are duplicates. > > For MonochromePublic.apk, shrinks uncompressed .pak size by ~130kb, and > compressed .pak size by 32kb. > > BUG=738566 > > Review-Url: https://codereview.chromium.org/2969123002 > Cr-Commit-Position: refs/heads/master@{#488215} > Committed: https://chromium.googlesource.com/chromium/src/+/ade347f539a378fb37500f6d17e8835edc1d8ec0 TBR=flackr@chromium.org,sadrul@chromium.org,agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=738566 Review-Url: https://codereview.chromium.org/2989443002 Cr-Commit-Position: refs/heads/master@{#488554}
-
Bin Zhao authored
Create a CastSocketConfig struct to hold cast socket related settings and clean up CastSocketImpl::OpenSocket() parameters Bug: 734855 Change-Id: I71a9847079a57f5f5c248c3b41354ac5f37bff66 Reviewed-on: https://chromium-review.googlesource.com/575793Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Bin Zhao <zhaobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#488553}
-
Toni Barzic authored
BUG=747157 Change-Id: Ia3aef4d7c88ab53a863ac9a300e288e04dfb0b51 Reviewed-on: https://chromium-review.googlesource.com/580576Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#488552}
-
Wei-Yin Chen (陳威尹) authored
There will be a stricter type checking in UMA_HISTOGRAM_ENUMERATION: if |boundary| is enum, |sample| must be an enum as well. One common type of violation is unnecessary casting to int. This CL fixes them by retaining the types. Bug: 661401 TBR: bartfab@chromium.org,dtrainor@chromium.org,xiyuan@chromium.org,cpu@chromium.org,boliu@chromium.org,piman@chromium.org,msw@chromium.org,sdefresne@chromium.org,mmenke@chromium.org Change-Id: Ib1294421896e73ba89a2c294022697686fee3199 Reviewed-on: https://chromium-review.googlesource.com/575380 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Alexei Svitkine (slow) <asvitkine@chromium.org> Reviewed-by:
Bo Liu <boliu@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#488551}
-
Brett Wilson authored
Previously this used BacktraceStorage::Key which was an iterator into an unordered_map. These iterators are technically invalidated when the size changes, although in practice our current usage is safe. This changes to just a const Backtrace* since this is guaranteed safe and the key indirection wasn't gaining us much. Change-Id: I513b5c0401528e8a87ec20ad8ca8682703678cf4 Reviewed-on: https://chromium-review.googlesource.com/580358 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#488550}
-
rlanday authored
This is a method that takes a text node, a pair of start/end offsets, and a list of MarkerTypes, and tries to find a DocumentMarker in the node of one of those types that intersects the range [start_offset, end_offset]. This is similar to DocumentMarkerController::MarkersIntersectingRange(), which I'm introducing in https://codereview.chromium.org/2948133004, except that this method takes a Text node and offsets instead of taking an EphemeralRange/ EphemeralRangeInFlatTree, and only returns at most one DocumentMarker, instead of returning all of them that match. BUG=707867 Review-Url: https://codereview.chromium.org/2960473002 Cr-Commit-Position: refs/heads/master@{#488549}
-
Peiyong Lin authored
Currently, only RenderFrame has InterfaceProvider and implements GetInterfaceProvider, thus when calling GetInterfaceProvider on other WebFrameClient subclasses, it causes crash on NOTREACHED. This patch adds empty InterfaceProvider to WebFrameClient subclasses to avoid crashing. TBR=scottbyer@chromium.org BUG=743314 Change-Id: I7ea9297c9f30b55f2ad69624e977eee4b3e6c71f Reviewed-on: https://chromium-review.googlesource.com/576370 Commit-Queue: lpy <lpy@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#488548}
-
Valery Arkhangorodsky authored
This was suggested in https://chromium-review.googlesource.com/c/567266/ Make EasyResizeWindowTargeter only extend hit-test region of resizable windows. Make exception for the shelf container that uses expanded hit-test despite the shelf widget being not resizable (this helps with dragging the shelf when it is auto-hidden). Modified ShapedAppWindowTargeterTest.HitTestOnlyForShapedWindow Open music.google.com Use a mini-player (accessible with a pop-out button next to playback controls) Position mini-player next to some other touchable control from a window directly below (e.g. Chrome menu or bookmark bar) Tap outside of the mini-player but close to it The tap should go to the window below. Bug: 741013 Test: Added ToplevelWindowEventHandlerTest.EasyResizerUsedForTopLevel Test: Manual: Change-Id: I6bc6abb603689562eeb498e3741540f4ed3d75e0 Reviewed-on: https://chromium-review.googlesource.com/571953 Commit-Queue: Valery Arkhangorodsky <varkha@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#488547}
-
rlanday authored
We currently have a method DocumentMarkerList::MarkersIntersectingRange() that can be used to retrieve all the DocumentMarkers in the list intersecting a specified offset range. This CL adds another method to DocumentMarkerList, FirstMarkerIntersectingRange(), that can be used to more efficiently get just one marker when there may be multiple markers intersecting a given range. This method will be used to add the method DocumentMarkerController::FirstMarkerIntersectingOffsetRange() in another CL: https://codereview.chromium.org/2960473002 BUG=707867 Review-Url: https://codereview.chromium.org/2982313002 Cr-Commit-Position: refs/heads/master@{#488546}
-
Tatsuhisa Yamaguchi authored
The button was originally the settings button with gear icon. Now we use the same three-dots icon as the button to open context menu of selected files. Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If7d605b0d65ed0096e812fbeb74f6d32771b269c Reviewed-on: https://chromium-review.googlesource.com/580210Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Commit-Queue: Satoru Takabayashi <satorux@chromium.org> Cr-Commit-Position: refs/heads/master@{#488545}
-
Tatsuhisa Yamaguchi authored
The button has more than "share" options which doesn't fit in "OPEN". Bug: 740819 Change-Id: I52a04ab04b010823807bbbda7b49f8aa2b943f4a Reviewed-on: https://chromium-review.googlesource.com/580589Reviewed-by:
-
Yoshifumi Inoue authored
This patch gets rid of unused enum class |SelectionDirectionalMode| for improving code health. Change-Id: Iabd413f436c5fbc6795ef204724fd130f67ffad6 Reviewed-on: https://chromium-review.googlesource.com/579247 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#488543}
-
Alexander Alekseev authored
This CL makes Gaia screen match other OOBE screens design. Bug: 747103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idfb6b58ce7d7721b4a33856280d1123165be4247 Reviewed-on: https://chromium-review.googlesource.com/580615Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#488542}
-
Christopher Cameron authored
Color conversion is not efficient enough to be done during software compositing. Rasterize everything into sRGB for consistency. Bug: 735613 Change-Id: Ib977ace62f6e4b560312e5322afc4d1f6c45601d Reviewed-on: https://chromium-review.googlesource.com/576829Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#488541}
-
Dave Schuyler authored
This CL splits the icon-delete svg into icon-delete-gray and icon-delete-white so that we have two colors to use. TBR=tommycli@chromium.org Bug: 745289 Change-Id: I4d28034520eded8f787ee605bbb0da22f252d698 Reviewed-on: https://chromium-review.googlesource.com/576969 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#488540}
-
Sean Kau authored
Bug: 740727 Change-Id: I1f75fe169e0728c7e5e27a870c1c1cab8e047396 Reviewed-on: https://chromium-review.googlesource.com/580530Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#488539}
-
Anton Vayvod authored
Added org.chromium.chrome.browser.media.router.cast.remoting: - RemotingMediaRouteProvider for observers accounting and URL resolving - RemotingMediaSource for parsing the source (intend to move Cast Web SDK specific parts of router/cast/ to router/cast/sdk/) Implement start/stopObservingMediaSinks there. MediaRouteProvider.Builder changed to Factory so it can add more than one provider to the provider manager. + git cl format induced changes in the moved files. Bug: 517102 Test: existing tests + casting manually Change-Id: Ib5ffe6c52c6f0b449edcf4d677439ea75bc04912 Reviewed-on: https://chromium-review.googlesource.com/520803 Commit-Queue: Anton Vayvod <avayvod@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#488538}
-
xzhan96 authored
Use std::unique_ptr instead of deprecated linked_ptr. BUG=556939 Change-Id: I656bb98d38e4c72983d886742fab8b0f9164a454 Reviewed-on: https://chromium-review.googlesource.com/578655Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Xiaofeng Zhang <xiaofeng.zhang@intel.com> Cr-Commit-Position: refs/heads/master@{#488537}
-
Hidehiko Abe authored
Now we migrated all ArcService classes into KeyedService. So, clean up unused class and code. BUG=672829 TEST=Ran trybot. Change-Id: I280cc3387f8064abbd683de4c3ff62dd586d2b41 Reviewed-on: https://chromium-review.googlesource.com/578827Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#488536}
-
Eugene Ostroukhov authored
Add a capability to view contents of the service worker cache storage. Bug: None Change-Id: I8ff61c78a91884135aad8711c9d404529d0254d9 Reviewed-on: https://chromium-review.googlesource.com/560602 Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#488535}
-
Ryan Ki Sing Chung authored
Make certificate verification errors available to the Cast sender through the Cast channel interface. Increase metric reporting details to get a better picture of any issues out in the field. Bug: 746658 Test: Unittests Change-Id: I568220d3949aa3878b71a1c62c5cc01c79d09dbb Reviewed-on: https://chromium-review.googlesource.com/577114Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
Scott Violet authored
For clients that have not connected directly to mus (such as the renderer), this disallows SetModalType to a system modal window. BUG=none TEST=none Change-Id: Id5353a424d73cab7b4e2956ebc82b9fcb25d3ac0 Reviewed-on: https://chromium-review.googlesource.com/580585Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#488533}
-
Alex Moshchuk authored
This will allow filtering results for the sign-in process isolation trial to users that have actually browsed to accounts.google.com. Bug: 739418 Change-Id: I31c9b36614cbcf1440c692d29450a851a2e29aa3 Reviewed-on: https://chromium-review.googlesource.com/579629 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Lukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#488532}
-
Yash Malik authored
We animate the opacity and visibility properties of the transient url bar to support this. This CL depends on https://chromium-review.googlesource.com/c/579827/ Bug: Change-Id: I3d1f3d33c06dc35cc05876c312a79278d68779f9 Reviewed-on: https://chromium-review.googlesource.com/579870 Commit-Queue: Yash Malik <ymalik@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#488531}
-
Qiang Xu authored
context: Chrome uses http://www.gstatic.com for captive portal check. On Chrome OS, chrome will ping this test url several times (e.g. three times for a network change). Many captive portals will block the google ip addresses if there are too many portal checks in a short period of time. To aovid this problem, use the alt urls: alt1.gstatic.com through alt25.gstatic.com, see b/63033351. shill side change: go/croscl/564664. changes: For Chrome OS portal detection stack, each time a random url inside alt1~alt25 will be used for captive portal detection. Bug: 742437 TEST: verify that portal check still works on Chrome OS. Change-Id: Ie28d8496110d918268fd077e9cd0e62f40030de2 Reviewed-on: https://chromium-review.googlesource.com/570623 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by:
-
Tim Sergeant authored
Bug: 658980 Change-Id: I6b8bb4d75ac2bf5b122405765a4a4e95d3a7e0d5 Reviewed-on: https://chromium-review.googlesource.com/580009Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Tim Sergeant <tsergeant@chromium.org> Cr-Commit-Position: refs/heads/master@{#488529}
-
Yash Malik authored
Bug: None Change-Id: I4079665b9665fa5be38b0c4138dbd2ee4d2d3b1a Reviewed-on: https://chromium-review.googlesource.com/577917 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#488528}
-
Victor Costan authored
BUG= Change-Id: I3f2e1c8b292777e454b5bc641dbe684929ead2a3 Reviewed-on: https://chromium-review.googlesource.com/576808Reviewed-by:
Michael Nordman <michaeln@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#488527}
-
Lei Zhang authored
When loading the print preview PDF for non-PDF content, the initial request loads a single page of the print preview source as the first page in the PDF. Subsequent pages are appended at page index 1 and onwards. Before r487767, ProcessPreviewPageInfo(), which loads the subsequent pages, checked the source page index and did not load if the source page index is less than 1. In r487767, the check changes to make sure the source page index is never negative, and to ignore loads when the source page index is 0. But it turns out that was not 100% correct. What it should have ignored is when the destination page index is 0. e.g. Print preview a 2 page document, and only select page 2. Here, the initial load loads source page index 1 as destination page index 0. ProcessPreviewPageInfo() then gets a request to load source page index 1 as destination page index 0. This is redundant and should be ignored. Though oftentimes, source page index 0 maps to destination page index 0, so it just works out by luck. Fixing this does not change the user observable behavior, but it does make page load counting easier. Change-Id: If6ad8f32f95e04fce86268c6015271978b201fc5 Reviewed-on: https://chromium-review.googlesource.com/580634Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#488526}
-
Miguel Casas-Sanchez authored
This CL removes the LayoutTests from fast/mediacapturefromelement that are duplicated after the GitHub PR [1] got rolled in. N.B.: This CL is complemented by the PR [2] that cleans up a bit the path of the webm files in external/wpt/mediacapture-fromelement (but these two are orthogonal and should not interact). [1] https://github.com/w3c/web-platform-tests/pull/6559 [2] https://github.com/w3c/web-platform-tests/pull/6588 ** No new code, just shuffling things around ** Bug: 619625 Change-Id: Ie3540a57f03ed8ab34f048fa309d5ce1525b7f61 Reviewed-on: https://chromium-review.googlesource.com/576595Reviewed-by:
Jeff Carpenter <jeffcarp@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#488525}
-
spqchan authored
Display credit card items on the touch bar when the credit card autofill popup appears on the screen. This feature is behind the #credit-card-autofill-touchbar flag, which is added in this CL. Tests: autofill_popup_view_cocoa_unittest.mm Bug: 743095 Change-Id: I636cbd193f72e7e1f79c9535d85d5fc5d00ce230 Reviewed-on: https://chromium-review.googlesource.com/572149 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
This patch makes NGInlineNodeData store the offset mapping result when it is computed. In this way, recomputation is avoided if we need to reuse the offset mapping. Bug: 699017 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I01811b7cf8f98b350cb1e3ff7d91fc8e418b77f6 Reviewed-on: https://chromium-review.googlesource.com/577991 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#488523}
-
tengs authored
This class is responsible for displaying and handling all EasyUnlock notifications. Originally, EasyUnlock notifications were shown by a component app, but this app is now deprecated and we are migrating EasyUnlock natively for v2. BUG=726791 Review-Url: https://codereview.chromium.org/2968323002 Cr-Commit-Position: refs/heads/master@{#488522}
-
Fredrik Hubinette authored
10000 runs of H264ParserTest goes from 3327ms to 2370ms. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia64f90f5f1f89e2fc8ccfdec26040cc179112d25 Reviewed-on: https://chromium-review.googlesource.com/580447 Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#488521}
-
Scott Little authored
TBR=mcasas@chromium.org Bug: 747163 Change-Id: I8a28b6ed839c65b75b5244058c3f8c8a6e82f8db Reviewed-on: https://chromium-review.googlesource.com/580340 Commit-Queue: Scott Little <sclittle@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#488520}
-
Bin Zhao authored
- Added PresentationConnectionCallbacks::PresentationConnectionCallbacks(ScriptPromiseResolver*, PresentationConnection*); - In PresentationConnectionCallbacks::onSuccess(), create new m_connection object if m_connection is null. - Remove ExistingPresentationConnectionCallbacks.* files Bug: 684111 Change-Id: Ieaf696cce484d609659062f0b451c8e9510eda0a Reviewed-on: https://chromium-review.googlesource.com/578689Reviewed-by:
-
Robert Hogan authored
When computing the position for an ellipsis we need to ensure any expansion on the linebox is included in the width of the text we use to arrive at the position. Bug: 558283 Change-Id: Ib85acee76c3b97e3fea325412447c01cb9d2d7c2 Reviewed-on: https://chromium-review.googlesource.com/572902Reviewed-by:
-
Derek Cheng authored
Remove some backward compatibility logic that were put in more than a few milestones ago. Change-Id: I34c1959118b7c8fef8ae4e74df465f14af4db079 Reviewed-on: https://chromium-review.googlesource.com/580109 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#488517}
-
