- 22 Oct, 2020 40 commits
-
-
Keishi Hattori authored
Temporarily use CHECK in SetFreelistHead to debug a crash. Should be reverted after a Canary release. Bug: 1137799 Change-Id: I9e01a5cdfafb7da2af76997f8c42716394ac4cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491724Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#819797}
-
Sylvain Defresne authored
Introduce a new mixing 'ios_cpu_x64_x86' used to configure fat builds with "x86_64" and "i386" architecture instead of using two mixins. This will allow changing how fat builds are configured to use a special value for `target_cpu` instead of using two separate variables. This should be a no-op on the bots since the generated args.gn will be identical after the change. Bug: 1040487 Change-Id: I46ebd383ee13449a3ccb1e1b3eccbc486b2fbe9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489907 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#819796}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1603291852-8226e53db1ad923442028152d5859381e4c42533.profdata to chrome-win64-master-1603335567-5b7ae75a80b56b2c3e08e562ca96c9be42987f9c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8584eb98eece32007aab9f354377ca639367a944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490859Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819795}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9be16a326a9b..ef6970472eb9 2020-10-22 landrey@webrtc.org Get rid of redundant async in token state update If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1114055 Tbr: oysteine@google.com Change-Id: Ie8cb2769ff7709c604dc307bcf80ec5593ff2282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491920Reviewed-by:
-
Simon Zünd authored
Various places in Chromium collect and symbolize V8 stack traces. This could be DevTools or heavy ads instrumentation. To get better insights we want to add some trace events around stack trace capturing and symbolization under a new, disabled by default, tracing category. Corresponding V8 CL: https://crrev.com/c/2491028 R=petermarshall@chromium.org Change-Id: I266b0783dcf6266efc512503b7b13044bd8b71c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490044Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#819793}
-
Boris Sazonov authored
Changes AccountPickerBottomSheetCoordinator argument from Context to Activity. This ensures that the view is never inflated using an themeless context. This is a tentative fix for an intermittent issue when AccountPickerBottomSheetView rows don't have a ripple animation. Bug: 1141000 Change-Id: Idc63fdac6dde06e912d57bcf8ef0bc1572ca968d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489904 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#819792}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I17cb6028040ca5e89d806acc85863ccf6e9ad9c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491512Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#819791}
-
Sergey Poromov authored
In order to support partial window screen capture we need to track events when some confidential content appears in the captured area. This is done via observing OcclusionState for the corresponding windows. Bug: 1133324 Change-Id: Ia0ffa3ca79a2b58ccef1902acc8b6772df773b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456606Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#819790}
-
chrome://usb-internalsdpapad authored
Bug: 1028829,1139849 Change-Id: I1ce5bdbd9e48004cec66f60cf952b0d95207c3d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480262 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#819789}
-
Morten Stenshorne authored
When constraining an inner multicol against its definite block-size or max-block-size, we need to subtract the space already consumed in previous fragments. Bug: 1141136 Change-Id: I2fb678549ab967d88ece5b15679986f997bb7859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489893 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#819788}
-
Andrew Grieve authored
Noticed these were missing when doing binary size review. Bug: None Change-Id: I8177a8e2138b58a68c036300a89fa2e4073f11a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484046 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Amr Aboelkher <amraboelkher@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@chromium.org> Cr-Commit-Position: refs/heads/master@{#819787}
-
Keishi Hattori authored
This reverts commit 90815a3a. Reason for revert: Real bug was identified and change is no longer necessary. crbug.com/1108676 Original change's description: > Add extra check for not_loaded_image_resources_ modifications while iterating > > not_loaded_image_resources_ is being modified while iterating. > If this CHECK doesn't catch anything, it means weak processing is triggering while iterating even though it shouldn't be. > > Bug: 1108676 > Change-Id: Iae00862b28fe3e324ac654c1e57834071ce5ddc9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392021 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804078} TBR=haraken@chromium.org,keishi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1108676 Change-Id: Ia46490f0abafafc5afac9b1971740b0afa21b10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490967Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
Changhao Han authored
DevTools frontend CL: https://crrev.com/c/2485087 Bug: chromium:1127956 Change-Id: I7cc7a3db0056bf3978d08cfeeb6bb25e9ec4509d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489641Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Changhao Han <changhaohan@chromium.org> Auto-Submit: Changhao Han <changhaohan@chromium.org> Cr-Commit-Position: refs/heads/master@{#819785}
-
Olesia Marukhno authored
Updated dedicated row buttons background color to match its row background. Added new color for buttons border color (it needs to be distinctly visible on selected row background). Bug: 1137445 Change-Id: Ib5b7cad19034e6e83500197bd9e61d9b28fae512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466241Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Cr-Commit-Position: refs/heads/master@{#819784}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cab003ff2dd9..ded46963acfa 2020-10-22 alexrudenko@chromium.org Enable TypeScript for PaintProfilerView.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I036fe370280fdec2cf32e179cfddb1730c4b8891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491353Reviewed-by:
-
Benoit L authored
This reverts commit aa18dd9f. Reason for revert: Not the cause of breakage, as the bot is still broken. As there was a suspicion this wasn't the culprit to begin with, relanding. Original change's description: > Revert "[base/allocator] Support mallinfo() for PartitionAlloc-Everywhere." > > This reverts commit 98e662e4. > > Reason for revert: this seem to break Win7 builder > https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/85993 > > > > Original change's description: > > [base/allocator] Support mallinfo() for PartitionAlloc-Everywhere. > > > > mallinfo() is used by MallocDumpProvider, and ProcessMemoryMetrics. The > > first one can also use the extended API of PartitionAlloc to report > > data, but the second one uses mallinfo(). To support both, implement > > mallinfo(). > > > > Bug: 998048 > > Change-Id: I9d71cd3a7bbf5c766cfc3771907c2f51ac17cace > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426708 > > Reviewed-by: Will Harris <wfh@chromium.org> > > Commit-Queue: Benoit L <lizeb@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#819010} > > TBR=lizeb@chromium.org,wfh@chromium.org > > Change-Id: Ibfbc278d7057808ce1a66150e2a8f516bdaab230 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 998048 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489626 > Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org> > Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819368} TBR=lizeb@chromium.org,wfh@chromium.org,apotapchuk@chromium.org # Not skipping CQ checks because this is a reland. Bug: 998048 Change-Id: I8b558903c6a1b94c3db472d200472a03c97b8322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489909Reviewed-by:
-
Viktor Semeniuk authored
This change fixes crash when simultaneously editing/deleting the same password on multiple windows. Bug: 1139295, 1139210 Change-Id: I3e3a016f6f41b889e8915feda297bea23f87561a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487127Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#819781}
-
Hajime Hoshi authored
Until committing finishes, |dom_content_loaded_| should represent the old document's state, but this is now reset at CommitNavigation. This means that |dom_content_loaded_| is reset at committing starts. This CL fixes the timing of resetting |dom_content_loaded_| to DidCommitNewDocument so that |dom_content_loaded_| is reset when the committing finishes. Bug: 1137725 Change-Id: I386c9bb855b45a94e4f2ae36e04f3f09b8f20610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483550Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#819780}
-
Henrik Boström authored
This is a simple C++ wrapper of VTPixelBufferTransferSession, which together with PixelBufferPool can easily be set up to do a large range of conversions and scaling directly in the capturer process. The bulk of this CL is testing. This CL: - Implements PixelBufferTransferer. - Adds testing utility methods in the anonymous namespace of the unittest file for creating YUVS buffers from RGB and verifying the RGB color of YUVS buffers. This is done with the help of libyuv. - Add tests for copying, rescaling and verifying the color with YUVS. - Add tests for converting YUVS -> X -> Y -> YUVS and verify we end up with the original color. We do this for all X and Y: YUVS, NV12, UYVY, I420. Starting and ending with YUVS is done so that the test utilities only have to read and set colors based on this format, rather than implement conversions for all formats. // TBR for media/capture/BUILD.gn changes. TBR=guidou@chromium.org Bug: chromium:1132299 Change-Id: If61f05d93dbb419992670d315b78e27f1f287ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438250Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#819779}
-
Daniel Cheng authored
This is needed because wasm-eval is not yet standardized, yet it remains useful for allowing something stricter than unsafe-eval. Bug: v8:7041 Change-Id: I7d45f4b4f2bb930536af56a25082f6a938d4b804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488389 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#819778}
-
Yu-Hsuan Hsu authored
Fix a small type: AudioManagerCras -> AudioManagerCrasBase Change-Id: I17decae7ed93b953c4376a7ce319a8c647c56a43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483543 Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#819777}
-
Arthur Hemery authored
We currently have no tests verifying the cross-origin isolated state of ServiceWorkers, as well as the processes they use for the different combinations. This adds 8 tests: - Installing + starting a service worker * For all combinations of document/SW isolation - 4 cases - Quick starting a service worker * For all combinations of document/SW isolation - 4 cases Bug: 1131404 Change-Id: Ib03980a2aeb78bbd78453813094292f3c31ae310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485216Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#819776}
-
Piotr Tworek authored
The code uses std::unique_ptr so we need memory include. Libcxx somehow pulls it indirectly, but builds using libstdc++ fail. Bug: 957519 Change-Id: I597ddd9d8a5f3bb949b2d2c1c8cb526b752c87d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489521Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Piotr Tworek <ptworek@vewd.com> Cr-Commit-Position: refs/heads/master@{#819775}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2e1091e0ef69..d74754378f09 2020-10-22 syoussefi@chromium.org Vulkan: Support vertex attribute aliasing for matrix types If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I84a36aa9e730a0bd67f54e7c8daac9ee69e77b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491348Reviewed-by:
-
Colin Blundell authored
When the renderer detects that the user's focus on the webpage has changed to no longer be on the current form, it currently sends the browser a notification that the focus is no longer on the current form only if it (the renderer) has registered that the user has interacted with the current form. However, the renderer registers this interaction only when the user submits or saves the form. In the case of WebView and WebLayer, the browser also needs to get this information in the case where the user has focused on a form and then moved focus off (without submitting). Without getting this information, the browser won't trigger autofill if the user taps back on the form (see [1] for details). (Chrome's flow operates differently and isn't subject to this particular problem). This CL loosens the condition under which the renderer sends this notification, sending it whenever focus has moved to a null element (i.e., is definitely not on a form). As Chrome relies on the current semantics of the notification (that it is sent only when the renderer has previously registered an interaction with the current form), we add a |had_interacted_form| boolean to the Mojo method. Chrome uses this parameter to short-circuit out of handling the call from the renderer if there was no previously-interacted form. In the longer term, it would be desirable to eliminate the need for this parameter (e.g., by ensuring that its value always matched that of AutofillManager's |pending_form_data_|). That, however, is beyond the scope of this CL. This CL is thus a no-op for Chrome, while extending WebView/WebLayer to handle the case where focus moves off of a form to a non-form element and then back onto the form. There is an edge case that this CL doesn't handle: when focus moves from a non-interacted form to a distinct form, AutofillAgent still does not send the FocusNoLongerOnForm() call (as it doesn't today). AutofillAgent cannot currently distinguish this case from the case where focus moves from an element in a non-interacted form to a separate element in that same form (when FocusNoLongerOnForm() should definitely *not* be sent). We could make this possible by adding more state to autofill_agent.cc, but that class is sufficiently complex as-is that it's not worth the extra complexity that this would engender. To verify: In Web{Layer, View}Shell, go to any website with a form on it for which autofill will trigger. Focus on a form field and observe the autofill popup trigger. Tap away to cause it to disappear, tap back on the field, and verify that the popup triggers again. [1] https://docs.google.com/document/d/1tyQ5XQLssIoa1AIPJ9WjOnW6-lPZpmpSrxkf5-6HYgc/edit#heading=h.u1hpn0gmjp2e (internal-only, apologies) Bug: 1127339 Change-Id: I2c954f81840ff2fbe010fb730866416d3f10c29b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409297Reviewed-by:Michael Bai <michaelbai@chromium.org> Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#819773}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I7f38264b62d9d9ab8ceca93f4435b15782585443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491199Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8462cfcb03a5..1c5210c268e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC beverloo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1130697 Tbr: beverloo@google.com Change-Id: I5a050a2cac1a84fb1042bd807c957271fb2977fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491663Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819771}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c3fb4c6d3915..9be16a326a9b 2020-10-22 landrey@webrtc.org Use separate entity groups for Token and child measurements If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1128357 Tbr: oysteine@google.com Change-Id: I218c65d1fb341532c682a5fe214847885cc71910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491198Reviewed-by:
-
David authored
Doc: http://go/backlight-better-crash-report#heading=h.wtrp256ggmr3 Context around this change is, we want to not report crash reports in chrome://media-app when devtools has ever been opened. This shouldn't have much of effect on other crashReportPrivate clients: * Non SWAs: VK, Secure shell: users shouldn't be opening devtools. * SWAs: chrome://media-app (wants this), chrome://help-app (probably wants this) Change-Id: I10a0ae94d1facc9533aaca0dc5c2dc9aa35848cb Bug: b/169635499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465407 Commit-Queue: David Lei <dlei@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Auto-Submit: David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#819769}
-
Sylvain Defresne authored
In preparation of supporting arm64 simulator build (for Apple Silicon macs), we need to decouple the fact that a build is a simulator build from the `target_cpu`. This was done by introducing a `target_environment` variable that can be set by the user (the default value is set using the same heuristic based on value of `target_cpu` if unset). Configure setup-gn.py to be explicit about setting the variable. Bug: 1138425 Change-Id: Ic8f84ef260972e542ea456d6e85e43080e81da36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489984 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819768}
-
Paul Lewis authored
The current behavior of the web bindings is to load files from the debug subdirectory of resources/inspector when the debug-devtools flag is set. However, this does not work as the debug build does not include the module information. Additionally, it is not necessary as the version of the DevTools frontend in resources/inspector works just fine for the debug case. This CL, therefore, removes the redirection from resources/inspector to resources/inspector/debug, and in the process allows DevTools developers to run `npm run debug-test` from the DevTools repo successfully. R=tvanderlippe@chromium.org Change-Id: I036697bd99cbc6c010a6be3bd17511fce7ee28d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489628 Auto-Submit: Paul Lewis <aerotwist@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
-
Wojciech Bielawski authored
Summary: Jinja2 already supports python3, but templates must be aware of environment they're run on. This commit fixes: "TypeError: '<' not supported between instances of 'dict' and 'dict'" when template is rendered using python3 Bug: 1138872 Change-Id: I08221a397c9e49f36ac652d5cc274ebcdca953fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485063Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#819766}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e267464b897d..6c5f7774fc2a 2020-10-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 84f5eeb6dd9b to e02d8938821a (3 revisions) 2020-10-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 4bdce889 to 502ec4ce (465 revisions) 2020-10-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from e2147a58a233 to d74754378f09 (16 revisions) 2020-10-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from cca03ca6bfe9 to 22505a5afe1f (9 revisions) 2020-10-22 johnstiles@google.com Reland "Create a basic IRNode pooling system." 2020-10-21 fmalita@chromium.org [svg] Add support for preserveAspectRatio 2020-10-21 johnstiles@google.com Pop the symbol table if compilation fails. 2020-10-21 kjlubick@google.com [canvaskit] Load resources into wasm gms/unit tests. 2020-10-21 egdaniel@google.com In Vk don't set dynamic blend constant on Pipeline if we don't use it. 2020-10-21 tdenniston@google.com [svg] Add gradientUnits attribute, value, and parsing 2020-10-21 jlavrova@google.com Underline decorations with gaps and no text 2020-10-21 bsalomon@google.com Reland "Perform bounding rect-relative calcs in full float in GrRRectBlurEffect" 2020-10-21 brianosman@google.com Add several more visualizations to Skia.natvis If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1138810 Tbr: egdaniel@google.com Test: Test: Test: TransformFeedbackTest.NonExistentTransformFeedbackVaryingWithGLPrefix:/ES3_OpenGLTest: Test: angle_perftests --gtest_filter="*fifa_mobile*"Test: Test: angle_perftests --gtest_filter="*free_fire*"Test: Test: angle_perftests --gtest_filter="*marvel_contest_of_champions*"Test: Test: angle_perftests --gtet_filter="*kartrider_rush*" Change-Id: I8a33e162c6268953559e6902925ed1f6466bdc4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491801Reviewed-by:
-
Hayato Ito authored
Disable WebViewAccessibilityTest.FocusAccessibilityNestedFrame. TBR=dlibby@microsoft.com Bug: 1141313 Change-Id: I2939705a8e0a9ba3c94ba131493a77b1586ed440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491575Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#819764}
-
Felipe Erias authored
The scrollbar-width CSS property allows the author to set the maximum thickness of an element’s scrollbars when they are shown. Its value is one of the keywords "auto", "thin", and "none". This is part of the CSSScrollbars feature (status: test). See the CSS Scrollbars spec for more details: https://drafts.csswg.org/css-scrollbars Bug: 891944 Change-Id: Iddc833d6af877c312a11452a6cfdcb05d45b1a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488947Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Felipe Erias Morandeira <felipeerias@gmail.com> Cr-Commit-Position: refs/heads/master@{#819763}
-
Mugdha Lakhani authored
Expose an API to perform a prerender (implemented using NoStatePrefetch). A browsertest and a javatest have been added to verify the expected behavior. Bug: 1136091 Change-Id: I158b5b954fbbf2e3cb9821180d6afd6aa042abd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470634 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#819762}
-
Kent Tamura authored
Having both of fieldset-percent-height.html and fieldset-percetage-block-size.html is confusing. Merge the new one into the old one. Change-Id: Ibcdf17d744c4cd622a8db33f6706cdc9f65ad416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491573 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#819761}
-
philipel authored
Bug: none Change-Id: I0bb244b3795da211d43a30684a61e079d127a68a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489881Reviewed-by:
-
Kent Tamura authored
We'd like to share the logic with LayoutNG. This CL fixes some failing tests with LayoutNGTextField flag. This CL has no behavior changes for now. Bug: 1040826 Change-Id: I0c5fa3da1eab44b35c0395298c72ba123bdd1ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491700Reviewed-by:
-
Mohamed Amir Yosef authored
This is preparation for adding the functionality of moving multiple passwords from settings view. Mocks are in the linked bug. TBR=karandeepb@chromium.org Bug: 1139263 Change-Id: I8d801c73e5566a9c44c9a69ea099fe2116d8cdde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481124 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#819758}
-
