- 07 Nov, 2018 40 commits
-
-
Roger Tawa authored
When the user enters an old password into the credential provider after a password change, make sure to use an appropriate message. At the same time make sure that all error paths return a valid string otherwise a blank error will be shown. Bug: 902706 Change-Id: I2835f8b11d8f1f116e64333d47515115b642b066 Reviewed-on: https://chromium-review.googlesource.com/c/1323270Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#606179}
-
Dale Curtis authored
Apparently it's in the 96th percentile by size and we haven't a need for it anymore. BUG=902185 TEST=none Change-Id: I12dec552bacb9942eea15ccd4e139527155f77ea Reviewed-on: https://chromium-review.googlesource.com/c/1321587Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#606178}
-
Dale Curtis authored
Extremely high frequency, but apparently useless, so remove. BUG=none TEST=none Change-Id: I6da011e77b724914be1a9829c1464397e3523cf0 Reviewed-on: https://chromium-review.googlesource.com/c/1321790Reviewed-by:
-
Saman Sami authored
There is no reason to keep the surface alive if it's explicitly evicted. Bug: 893793 Change-Id: I95b77abb386345368dbb8a295b695543aa94a749 Reviewed-on: https://chromium-review.googlesource.com/c/1321259 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606176}
-
Jun Mukai authored
TabDragging's PressSecondFingerWhileDetached/0 is still failing, and this fails due to a corner case of focus and visibility handling in the window system; - the test scenario falls into a certain gesture, which will minimize the dragged window https://cs.chromium.org/chromium/src/ash/wm/workspace/workspace_window_resizer.cc?g=0&l=594 - TabDragController restores focus at the end of dragging https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab_drag_controller.cc?g=0&l=1433 On the classic environment, this shows the dragged window and re-activates it, while it fails to activate on Mash, and so it fails at https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc?sq=package:chromium&g=0&l=2576 This CL allows focus directly on the minimized window; - DesktopWindowTreeHostMus shouldn't early-return if the window is invisible because of minimized status - DesktopFocusRules should check the minimized status too, otherwise FocusController can't find the focusable / activatable windows - TestWindowService should take care of synchronizing the window's show state and its visibility. The DesktopWindowTreeHostMusTest's case is changing the window state but not changing the visibility. - sometimes a window is created with minimized status. DesktopWindowTreeHostMus::Show() needs to take care of such situation, otherwise it isn't starting with minimized status. BUG=902598 TEST=the edited test case and unfiltered test case Change-Id: Icae808806ba134a3789b39438179818011379064 Reviewed-on: https://chromium-review.googlesource.com/c/1321859Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#606175}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/39f97da7dc62..1f3ebd2b9a65 Created with: gclient setdep -r src-internal@1f3ebd2b9a65 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic61fca0fbecff9a628b4e545821d25d61515edb3 Reviewed-on: https://chromium-review.googlesource.com/c/1323633Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606174}
-
Tien Mai authored
Fix some missing permissions for the logon stub process needed to be able to run Chrome during winlogon Bug: 887444 Change-Id: Ie6c54855cee2b95ef6cb0de1829251d324548733 Reviewed-on: https://chromium-review.googlesource.com/c/1301850 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#606173}
-
Livvie Lin authored
Bug: 900031 Change-Id: I58e2846c9dd447bed42983db49b1d1ecf0e235b6 Reviewed-on: https://chromium-review.googlesource.com/c/1321671 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#606172}
-
Stephen Martinis authored
This reverts commit 3b04594a. Reason for revert: builder has recovered. Original change's description: > Remove chromeos-amd64-generic-rel from CQ > > The bot is broken at the moment. > > NOTRY=true > > Bug: 902806 > Change-Id: I1ee551c95617444e5ec4edbdb3d8d4fde6d7dc5f > Reviewed-on: https://chromium-review.googlesource.com/c/1324090 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606093} TBR=martiniss@chromium.org,bpastene@chromium.org,jbudorick@chromium.org Change-Id: I6c4f751514d9fc67ccf4004643f2368cc5effc68 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902806 Reviewed-on: https://chromium-review.googlesource.com/c/1324415Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#606171}
-
danakj authored
Why would the browser be changing the page visibility after it has detached the main frame, closing the RenderWidget and destroying the WebView? It wouldn't. R=dcheng@chromium.org Change-Id: Ibc49c8b9ffbcf174819d88423125ca2e47c775d8 Bug: 894899 Reviewed-on: https://chromium-review.googlesource.com/c/1323698 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#606170}
-
Greg Kerr authored
Bug: 902597 Change-Id: I4c9b9866fabfb3e41ee29c8cafc8fab1d4e19526 Reviewed-on: https://chromium-review.googlesource.com/c/1324190Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606169}
-
Geoff Lang authored
The GL_COMMANDS_COMPLETED_CHROMIUM and GL_READBACK_SHADOW_COPIES_UPDATED_CHROMIUM query types are implemented using fences but some fence types are not guarenteed to be marked as complete after a glFinish. Force them to mark the query as completed after a glFinish, the client expects this. BUG=894781 Change-Id: I77517f54ecc557c949ee20a26b54d67fa79cb0d9 Reviewed-on: https://chromium-review.googlesource.com/c/1315689 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#606168}
-
Istiaque Ahmed authored
In all the cases, we require an extension ID to be present to interact with RulesRegistry, so add checks for extension's presence in RulesRunfunction. This handles IPC Fuzzer NPE test case by killing the offending renderer. Bug: 901674 Test: See fuzzer test case. Change-Id: I8bf6e223a38be6da1666c7633d6f0b7ec45e697a Reviewed-on: https://chromium-review.googlesource.com/c/1318532Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#606167}
-
Jonathan Backer authored
TBR=piman@chromium.org Change-Id: I9213cbc82da275f828b79dc50e1e1a339c129ac4 Reviewed-on: https://chromium-review.googlesource.com/c/1323804Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#606166}
-
Boris Sazonov authored
This CL makes ToolbarPhone.mMenuButton private without any changes to the behavior. Bug: None Change-Id: I267a9926dfa63614168ac7ada2a35629591222c0 Reviewed-on: https://chromium-review.googlesource.com/c/1323671Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#606165}
-
Ken Rockot authored
This adds a simple base::Token type which supports random generation OR constexpr construction from fixed values. Trivially changes UnguessableToken to be implemented on top of Token. Token and UnguessableToken are essentially the same data type, with Token having weaker constraints on what qualifies as valid usage. Specifically, it is considered valid and reasonable to construct constexpr Token objects over pre-generated random values. Bug: 895591 Change-Id: I9fdc0eafdb1dd184a4f013c93708bc2136e6095f Reviewed-on: https://chromium-review.googlesource.com/c/1320190 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#606164}
-
Anthony Vallee-Dubois authored
This patch triggers auto translate behavior on navigations started from <a> tags that have an hrefTranslate attribute. It also merges the tests written by Aaron in https://chromium-review.googlesource.com/c/chromium/src/+/1227173. Bug: 900586 Change-Id: I1b8e23651ff839ab8cafadf02e72ac6ceca108de Reviewed-on: https://chromium-review.googlesource.com/c/1315949Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#606163}
-
Vikas Soni authored
This is a reland of 4df3f6e1 with some changes to not seperate out vulkan and GL constructor for RasterDecoderContextState. Original change's description: > Add VulkanContextProvider to RasterDecoderContextState. > > Add VulkanContextProvider to RasterDecoderContextState which is needed > to get VkDevice in shareable image. Refactor RasterDecoderContextState > class to have seperate constructors for Vulkan and GL. > > Bug: 891060 > Change-Id: I0ca7e657d33fdcfa62ab6465f7023a914610b7ce > Reviewed-on: https://chromium-review.googlesource.com/c/1312194 > Commit-Queue: vikas soni <vikassoni@chromium.org> > Reviewed-by: Eric Karl <ericrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605146} Bug: 891060 Change-Id: Id2f4ae194445861f59ea24299f98cc94c477be98 Reviewed-on: https://chromium-review.googlesource.com/c/1320512 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#606162}
-
Dave Tapuska authored
The feature first shipped two stable releases ago in M69. Bug=848890 Change-Id: Id969cf348d9523ec50803d7feadec7071b652730 Reviewed-on: https://chromium-review.googlesource.com/c/1323770Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#606161}
-
Thomas Guilbert authored
This reverts commit 43dcbdf0. Reason for revert: 902871 Original change's description: > Add RemotingAppLauncher and DefaultRemotingApp > > The RemotingAppLauncher instantiates RemotingApps at runtime. It uses > the app manifest to find class names of RemotingApps, and loads them via > reflection. > > The DefaultRemotingApp is a simple wrapper around the default media > receiver application. > > Bug: 790766 > Change-Id: I01f51ebe90de361b947d67fe904a2faddc35f5de > Reviewed-on: https://chromium-review.googlesource.com/c/1306778 > Reviewed-by: Zhiqiang Zhang <zqzhang@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605389} TBR=dtrainor@chromium.org,zqzhang@chromium.org,tguilbert@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 790766 Change-Id: I3995a570a71923053711bb1ea491f9d24521fdea Reviewed-on: https://chromium-review.googlesource.com/c/1324194Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#606160}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d282860c9472..2969d2776054 git log d282860c9472..2969d2776054 --date=short --no-merges --format='%ad %ae %s' 2018-11-07 kjlubick@google.com Autobuild the jsfiddle docker image 2018-11-07 halcanary@google.com SkQP: reduce lib size by 10% 2018-11-07 kjlubick@google.com [fuzzer] Check enum type at compile time 2018-11-07 mtklein@google.com simplify disabling effect deserialization 2018-11-07 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-07 reed@google.com transition to enum class for SkFontHinting 2018-11-07 mtklein@google.com remove -Mini bot, enabled effects in -NoDEPS bot 2018-11-07 fmalita@chromium.org Handle static/single frame images in SkAnimCodecPlayer 2018-11-07 nigeltao@google.com Remove some #ifdef's from SkAndroidCodec 2018-11-07 mtklein@google.com back out SK_CODEC_DECODES_RAW in Google3 2018-11-07 kjlubick@google.com Make the skia-wasm-release image only have the build products 2018-11-07 mtklein@google.com move this define to be with its friends in flutter_defines.gni 2018-11-07 kjlubick@google.com [canvaskit] Update examples after enum name change 2018-11-07 stani@google.com Skottie Android demo app improvements 2018-11-07 mtklein@google.com remove -DSK_DISABLE_RENDER_TARGET_SORTING from Flutter 2018-11-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 26679709b32f..ee5557693416 (1 commits) Created with: gclient setdep -r src/third_party/skia@2969d2776054 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I508d253fb026e20395579a13c0fd6b96de594388 Reviewed-on: https://chromium-review.googlesource.com/c/1324031Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606159}
-
Chase Phillips authored
Crash reports from users indicate we sometimes try to send messages that are too large. We have code to keep this from happening, but the code is brittle and apparently some cases can get through. It would help to know what the relative values are to understand how our estimates are failing, so change this from CHECK() to CHECK_LT(). Bug: 717812 Bug: 901269 Change-Id: Ic511dae1ea5d96dcb9937fff1207976a40a903f2 Reviewed-on: https://chromium-review.googlesource.com/c/1324091Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#606158}
-
Wez authored
- Refactor the QemuTarget selection of CPU to emulate, to allow it to run x64 under software emulated CPU. - Enable software-emulated-CPU fall-back by default, if /dev/kvm is not accessible for reading & writing. - Add a require_kvm parameter to QemuTarget, and wire it to a common --qemu-require-kvm command-line argument. - Add --qemu-require-kvm to the Fuchsia x64 builders, to ensure that we spot any regressions that break KVM on the bots. Bug: 902607 Change-Id: I60f69b7cb7f5458ccf4a0a2d932235d823b6f932 Reviewed-on: https://chromium-review.googlesource.com/c/1318832Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#606157}
-
Matt Mueller authored
Bug: 853228 Change-Id: Iaef40bc62c7b5f6c93f71e8249402c0218605471 Reviewed-on: https://chromium-review.googlesource.com/c/1321584 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#606156}
-
Eric Orth authored
This will hold all the simple host resolution code intended long-term (post-servicification) for direct non-test access outside the network stack and service. For now, moving over dns_protocol.h and dns_util::IsValidDoHTemplate(), two items currently used externally that do not make sense to servicify. Will likely move over more in subsequent CLs. Similar to when //net/dns targets were split off from //net, no attempt was made to detangle circular dependencies with //net. Bug: 846454 Change-Id: I7cc209240f1c6f5ae2789c56faefb20662366230 Reviewed-on: https://chromium-review.googlesource.com/c/1320516Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#606155}
-
gogerald authored
Bug: 806868 Change-Id: Ia918f89c94433b36aeaf9231927c92feaca01a2f Reviewed-on: https://chromium-review.googlesource.com/c/1323410 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#606154}
-
ssid authored
Change-Id: I49e26e74aeff801873b5e40a757c1042dc79fd4c Reviewed-on: https://chromium-review.googlesource.com/c/1321949Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#606153}
-
Nektarios Paisios authored
This adds a missing data file that is required by an accessibility selection test. R=huangdarwin@chromium.org Change-Id: Ieed9ec821ed75ae2ffbd27dd221b8d8117392e10 Reviewed-on: https://chromium-review.googlesource.com/c/1324210Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#606152}
-
Evan Stade authored
Remove from SingleProcessMash filter file since it doesn't seem related to Mash. Bug: 873884 Change-Id: I70dacb5b97fc650046b3d9f87eab8694dd6b0015 Reviewed-on: https://chromium-review.googlesource.com/c/1323900Reviewed-by:
-
Tibor Goldschwendt authored
This works around a Play Core bug where only 64 bit libraries are extracted on 64 bit devices. Bug: 902859,902822 Change-Id: Ifd38850a1a88320860d741c740a754cf7cdf3284 Reviewed-on: https://chromium-review.googlesource.com/c/1324105Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#606150}
-
Istiaque Ahmed authored
WebstoreInstallHelper::Delegate::OnWebstoreParseSuccess passes around unowned DictionaryValue pointers. In two cases in dashboardPrivate and WebstoreStandaloneInstaller, there were leaks. Fix this by changing the method to pass owned pointers instead. Bug: None Test: None Change-Id: I2165aa5cacac0d926cbeb8761ed4dc28a4610047 Reviewed-on: https://chromium-review.googlesource.com/c/1321865Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#606149}
-
Wenzhao Zang authored
Bug: 901211 Change-Id: Ib20f54b9ef5c7170296c65383a0af905e61f5481 Reviewed-on: https://chromium-review.googlesource.com/c/1313878Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#606148}
-
Nektarios Paisios authored
Screen readers want to have a reliable way to know whether a document is still loading so as to ignore events coming from it. The current change can be made irrespective to whether we will mark the document as loaded when HTML parsing has started or when the "interactive" readyState has been entered. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 897177 Change-Id: I5d734ff9d32c53b7ba12a6d5d4eeb74b26ba0a02 Reviewed-on: https://chromium-review.googlesource.com/c/1295769 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#606147}
-
Sam Burnett authored
Bug: 901987 Change-Id: Ic0f758b08afad0462deff8c7283ce1ab1a706dae Reviewed-on: https://chromium-review.googlesource.com/c/1320595Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Douglas Creager <dcreager@chromium.org> Commit-Queue: Sam Burnett <sburnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#606146}
-
Xianda Sun authored
We used to only look at the eventual target iframe's hit test flag to determine whether we need async event targeting. This is fine with v1 set up because all non-trivial iframes have kHitTestAsk flag. But this resulted in a bug in v2 in this situation: When we have nested main_frame->parent_frame->child_frame and only the mid-level parent_frame has kHitTestAsk flag, we will directly dispatch event to child_frame. This is not correct because parent_frame may have overlapping regions with main_frame divs. This patch makes RWHIER always ask when it encouters a mid-level kHitTestAsk flag. Bug: 896786 Change-Id: Ib9c81ad44d562b251515d8f4dcde572db8d1fa1d Reviewed-on: https://chromium-review.googlesource.com/c/1310114Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ria Jiang <riajiang@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#606145}
-
Matt Menke authored
This is a reland of https://chromium-review.googlesource.com/c/1320209, which was reverted for breaking the build in https://chromium-review.googlesource.com/c/1320594. The original CL removed a mojom file, but one file still tryied to include the removed file's mojom.h header. It managed to pass the CQ presumably because the left over mojom.h file wasn't being deleted between builds. This CL fixes the issue. Original change's description: > Move legacy DNS-related net/ mojo interfaces to proxy resolver service. > > Also moves the code that imlepments each side of the interfaces from > net/ over to the location of the single consumer of each of them, in > the proxy_resolver and network services. > > This CL is strictly a move, with no code changes. I will do some cleanup > work in followup CLs. > > Bug: 901419 > Change-Id: I31f6bb91dccc1d250d7c2fd03a07c4173030fc97 > Reviewed-on: https://chromium-review.googlesource.com/c/1320209 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Eric Roman <eroman@chromium.org> > Commit-Queue: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605820} Bug: 901419 Change-Id: If03854352a32b182657b761459dee371d928e5cd Reviewed-on: https://chromium-review.googlesource.com/c/1321090Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#606144}
-
Matt Mueller authored
This reverts commit 712deda1. Reason for revert: Still fails on the waterfall. Original change's description: > Re-enable RenderThreadImplBrowserTest.NonResourceDispatchIPCTasksDontGoThroughScheduler > > Bug: 827318,876947 > Change-Id: I72ead221b797a90c19d7742422d65a29ed5f1741 > Reviewed-on: https://chromium-review.googlesource.com/c/1318849 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Matt Mueller <mattm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605833} TBR=jam@chromium.org,mattm@chromium.org Change-Id: I8181253eef71bad3b5a78e633778a9a110c4695c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 827318, 876947 Reviewed-on: https://chromium-review.googlesource.com/c/1324211Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#606143}
-
Evan Stade authored
Bug: 833144 Change-Id: I5fae6070f992e5cd0873b7172fc1ef009a881742 Reviewed-on: https://chromium-review.googlesource.com/c/1323893Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#606142}
-
danakj authored
Currently RenderFrameImpl "closes" the RenderWidget always when being detached (aka closed). However for a main frame, this "close" of the RenderWidget gets redirected to the RenderViewImpl, which only drops the WebFrameWidget instead. This is done because the RenderWidget has been placed in a swapped out state, as the main frame RenderWidget is part of the RenderView and can not be destroyed/closed. So rather than close the RenderWidget in this case, the WebFrameWidget is dropped, with its reference to the local main frame. We remove 2 indirections here to make this interaction more clear: When detaching a main frame, the RenderFrameImpl tells the RenderViewImpl directly to drop its WebFrameWidget, instead of closing the RenderWidget. Comments and TODOs are added to explain what is going on. A non-main frame RenderFrame could be swapped out also. But importantly this does *not* swap out the RenderWidget also. It will simply detach (close) the frame, which will close the RenderWidget. R=dcheng@chromium.org, piman@chromium.org Change-Id: Ib44bb82b852db637593973f93de61e6135b4ea9e Bug: 419087 Reviewed-on: https://chromium-review.googlesource.com/c/1323708Reviewed-by:
-
Scott Violet authored
No one overrides MultiUserWindowManager::Observer::OnOwnerEntryFinished. BUG=756085 TEST=none Change-Id: If91a4e3fc4c5d63ef762763534b93865466ae833 Reviewed-on: https://chromium-review.googlesource.com/c/1323621Reviewed-by:
-
