- 11 Mar, 2020 40 commits
-
-
Clark DuVall authored
This target had three separate is_android blocks. This combines them all into a single block to make things more clear. Change-Id: Ia836752ff0784dd8a99da104d72a5d881cac01c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099226 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#749409}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ba26b2b503a6..94a9b0c7684f git log ba26b2b503a6..94a9b0c7684f --date=short --first-parent --format='%ad %ae %s' 2020-03-11 jalyn@microsoft.com Prepare ShortcutRegistry for custom shortcuts Created with: gclient setdep -r src/third_party/devtools-frontend/src@94a9b0c7684f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4e4af8cbb19a5b1d6ba5cfbe5b4e521d4640b23e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099305Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749408}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/066e6a62edcc..dad31a0aa440 git log 066e6a62edcc..dad31a0aa440 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 rwkeane@google.com mDNS: Fix bugs found by fuzz tests 2020-03-11 miu@chromium.org Cast Streaming Standalone Sender (1 of 3): SimulatedCapturer 2020-03-11 btolsch@chromium.org Fix various TLS connection issues 2020-03-11 rwkeane@google.com mDNS: Add TODO to MdnsServiceImpl Created with: gclient setdep -r src/third_party/openscreen/src@dad31a0aa440 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I5a5374ff4940a1f2136af92d9675abad5662ab6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099306Reviewed-by:
-
Anastasiia Nikolaienko authored
Add component and strings for welcome screen. ('Get started with a school account') See screenshots: http://go/crb/1043108#c2 Bug: 1043108 Change-Id: I6c3d33b6c7971b00877079e46ece47e898db28af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007740 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#749406}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d0748eb038be..90a8af383cf9 git log d0748eb038be..90a8af383cf9 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 jonahr@google.com Add -rpath entries for non-component builds on Mac 2020-03-11 jonahr@google.com Relax GL_DEPTH_COMPONENT32_OES format support rules Created with: gclient setdep -r src/third_party/angle@90a8af383cf9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: I64ab49f5445b77ed87a4d7aa610a058bae2c42eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099222Reviewed-by:
-
Noel Gordon authored
Some styles need to be avoided if Files app <html> is in a .col-resize CL:1858026 to avoid scrollbars. Detect with simpler class selector. Similar to what was done for directory tree on CL:2094464 Bug: 992821 Change-Id: Id8507beac22461f1423b76a23f769f649652093b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098135 Auto-Submit: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#749404}
-
Orin Jaworski authored
This CL reworks direct mutation of the popup model from OmniboxViewViews. Instead of setting state directly, now the view will inform the model of user intentions and then respect model state changes determined in the model logic itself. In some cases, SetSelection is used to preserve control flow for consistency with existing logic, but even in these cases the popup model is determining the selection instead of the view. New extensible model logic is added in this CL with the intention of migrating uses of SetSelectedLine and SetSelectedLineState to the new StepSelection API. Some OmniboxEditModel refactoring is also started in this CL but OmniboxViewViews is the main focus. Bug: 1046523 Change-Id: I3abbd624439f4e530891c4d3d6036a8ca35c2ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090000 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#749403}
-
Robbie McElrath authored
This CL moves the Java-side definition of the kSafeBrowsingSubresourceFilter Feature from ChromeFeatureList to a new SubresourceFilterFeatureList class that lives in //components/subresource_filter/java. This will allow non-Chrome embedders to query the status of the Feature from Java. Bug: 1058597 Change-Id: If9c618216110c1e005e645a0351ee79577211844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095860 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#749402}
-
dalyk authored
When the system DNS config has unhandled options, no insecure DNS tasks are added and DoH auto-upgrade is not performed. DNS configs containing either Do53 IP addresses or DoH configs are now considered valid. Bug: 1059758 Change-Id: I5ba9ae3c5ca8b7ab260fef8e4aa5ed167934b219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092895 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
-
Philip Rogers authored
Bug: 1058834 Change-Id: I9fbb4ad17f40860e7864cc01693bfc0bb911a3c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099342Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#749400}
-
Zhongyi Shi authored
https://quiche.googlesource.com/quiche.git/+log/ee0079aeee37..1c2d1ab18e85 $ git log ee0079aee..1c2d1ab18 --date=short --no-merges --format='%ad %ae %s' 2020-03-11 fayang gfe-relnote: In IETF QUIC draft 25+, default to 1 packet per PTO, skip a packet number and 1st PTO to be std::max(1.5 * srtt, srtt + 4 * rttvar + ack_delay). Protected by existing gfe2_reloadable_flag_quic_enable_version_draft_25_v3. 2020-03-11 fayang gfe-relnote: In QUIC, send a PING when skipping packet number PTO fires and there is no data to send. Protected by gfe2_reloadable_flag_quic_send_ping_when_pto_skips_packet_number. 2020-03-11 renjietang Disallow sending of MAX_STREAMS and STREAM_BLOCKED frame in QuicStreamIdManager before the session is configured. 2020-03-10 bnc gfe-relnote: Enforce HTTP/3 frame ordering requirements on request and control streams. Protected by gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27. 2020-03-10 dschinazi Remove incorrect QUIC_BUG in QUIC transport parameters 2020-03-10 danzh gfe-relnote: (n/a) fix a tautological-constant-out-of-range-compare error for certain compilers in QUICHE. No behavior change. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I5a936c8bd31f5956415df4def59e56153f348ced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099282 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#749399}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/506142ad..918e2ad1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie0cf788a9ece77fedd94c29dc431dbd1615ce125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098544Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749398}
-
Darren Shen authored
Right now, when the VK is up, the user cannot perform shelf gestures to access the hotseat or overview mode. This patch adds the ability for users to swipe up from the bottom of the VK to perform the normal shelf gestures. It does this by detecting SCROLL_BEGIN gesture events and forwarding them directly to the shelf, so that the rest of the gestures act directly on the shelf. Change-Id: I8d409f8242b4b95f061afb86254c99103de38798 Bug: 1030814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071678Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#749397}
-
Jeroen Dhollander authored
To simplify this method I have done the following: * Replace multiple checks with checks against |UserType|. This reduces the amount of sources used. * Break the method up in helper methods. * Remove unused test specific |if|s. I also added some missing tests. Bug: 1056717 Change-Id: I23e3b56ee2d34aa0e2ae4dd6f7dfcfcd0b333a84 Tests: unittests "ChromeAssistantUtilTest.*" Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091649Reviewed-by:Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
Matt Jones authored
This patch removes the CompositorViewResizer and its infra (also removing a cyclic dependency from the build). In the case of the autofill assistant, the different viewport modes -- RESIZE_LAYOUT_VIEWPORT and RESIZE_VISUAL_VIEWPORT -- are now treated the same way. Bug: 846440, 1048183 Change-Id: I6c31f7d431122e2171e1137e159cc146a3aaaff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097300 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#749395}
-
Sean Topping authored
We perform this check for CWCI::OnInterfaceRequestFromFrame() to prevent UAF crashes. This patch adds the same check for the browser-side interface binders. Bug: None Test: Build/run cast_shell, verify no crash. Change-Id: I3d2f69e1fe5fa42c3ef02a69afd247bf3b3ec6ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099326Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#749394}
-
Xi Han authored
In this CL, we cache more tab switcher related features in the CachedFeatureFlags, so they can be checked before native is initialized. Bug: 1041865 Change-Id: I93f196e722964d712a102831bb5cf6ea9b2b54a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038717Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
-
zhaoyangli authored
- Defined a matrix compound suite in test_suites.pyl for coverage unit tests. - Added required configs to waterfalls.pyl. Bug: 1023979, 943883, 1055164 Change-Id: I09cf31958de032ebc51e39ff9237374b4ba28682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094777Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#749392}
-
Sam Sebree authored
This change adds a web test for details/summary being used in a dark mode web page Bug: 929098 Change-Id: If22399430b739f6c4a3d9bf84c575f7edd96829e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095856 Commit-Queue: Sam Sebree <sasebree@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#749391}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6c08e4b57d48..d8d15937da6d git log 6c08e4b57d48..d8d15937da6d --date=short --first-parent --format='%ad %ae %s' 2020-03-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 03913e7d..da6a45d3 (749124:749241) Created with: gclient setdep -r src/third_party/webrtc@d8d15937da6d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifb34f03dd8cc23d7d14f2bfb74f26bd32307c0bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099304Reviewed-by:
-
Yi Gu authored
This patch integrates ScrollTimeline with cc::Animation. Major changes include: 1. blink::ScrollTimeline is able to create its compositor counterpart 2. cc::ScrollTimeline is attached to cc::AnimationHost upon creation 3. cc::AnimationHost ticks animations based on their timeline type 4. Remove scroll_timeline_ from cc::WorkletAnimation and use the unified animation_timeline_. 5. Added virtual/threaded/external/wpt/scroll-animations/. See [1] for more details. [1] https://docs.google.com/document/d/1RpJrYIDYHvtu0ia1vPv_EhBfan428QZ2sgsFhtnXb20/edit?usp=sharing To sheriffs: if any virtual tests become flaky, please add them to TestExpectation instead of reverting the change. Bug: 1023508 Change-Id: Ib4aa853bda34ce9b2c0abc943be9f99ac81e799a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084088 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#749389}
-
Chris Whelan authored
Cast is not respnsible for uploading crash dumps on Fuchsia, so app_state_tracker needs to work with different annotation storing backends. Bug: b/67907746 Test: Build Change-Id: I5cd6a13f9e642cdbf940cc8ada5dd76663e793e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083956 Commit-Queue: Christopher Whelan <chwhelan@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#749388}
-
edchin authored
We're bringing Chrome Flag Ownership to iOS go/chrome-flags-ios More about flag ownership here: https://chromium.googlesource.com/chromium/src/+/master/docs/flag_ownership.md See announcement here: https://groups.google.com/a/google.com/g/bling-team/c/7YC_3l6yEzo/m/1-iZg1fPAAAJ This CL enables the unit test that enforces flag ownership in iOS. Prior to this being enabled, all iOS flags in //ios/chrome/browser/flags/about_flags.mm must have a corresponding entry in flag-metadata.json. Bug: 1058614 Change-Id: I6fb93f4f10503233caa0934331c2d25fdeaaaa50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095557Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#749387}
-
Kevin Babbitt authored
AXPlatformNodeDelegate::GetFocus() returns the node within the called node's subtree that currently has focus. When an element in web content has focus, and a delegate in Views is asked for focus, that delegate can only reach as far as the web content root. Calling GetFocus() again on the web content root ensures that the platform API returns the currently focused node. Bug: 928811 Change-Id: Ice47eed0a8ea4281beb48624942ac2428fb1950f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099162Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#749386}
-
Robbie McElrath authored
This CL makes WebLayer delete ALL of its data during startup if it detects that it was downgraded to a lower major release since the previous launch. The previous version is maintained in a SharedPreference. Bug: 1043217 Change-Id: I12c90d6705be4563a2e3bf07712f96a1136d96c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052601 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#749385}
-
Hazem Ashmawy authored
This shows WebView Developer UI launcher icon for beta channels for all build variants including standalone WebView, Trichrome and Monochrome. It also make the check to show/hide the icon for Monochrome less frequent by listening to Activity#STARTED instead of RESUMED. Fixed: 1060405 Test: Build beta channels of Trichrome, standalone WebView and see the icon Test: Build beta Monochrome and select it as WebView provider and see the icon Change-Id: I9cb5c57bdf9b8488523caaa6fe8a98a0d46adb41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096959 Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#749384}
-
dpapad authored
Bug: None Change-Id: I68574edf3f94422f9dc87edb9a31fc29b163483f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099027 Commit-Queue: dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#749383}
-
Ahmed Mehfooz authored
Bug: 1056451 Change-Id: Ide133ebd853491aa53b2009bad7fb3208e6b6349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097943Reviewed-by:
-
Pavel Yatsuk authored
This CL moves InfoBarInteractionHandler, InfoBarLayout, InfoBarCompactLayout and related resources to chrome/browser/ui/messages BUG=1056346 R=mdjones@chromium.org Change-Id: Id1000a4d5cfbb7c4e04c3f70284470f728bc0283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088183 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#749381}
-
Henrique Nakashima authored
Also allow any "*InstrumentationTest.java" to depend on chrome/android even if in a module. Bug: 1053463 Change-Id: Idfac74521187a4d8ee923732cbaf8e6bee108b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080579Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#749380}
-
Aaron Leventhal authored
Fixes an apparent coding error to now mirror AXNodeObject::AddChildren(), where the owned children correctly get a parent. Note: the duplication between the 2 methods is disturbing, and the code should be refactored to be less repetitive. Bug: None Change-Id: Ib6bbc20680cdfb017e417de073640742fa15349c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092909Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#749379}
-
dalyk authored
The automatic mode radio button description is broken into two lines. The privacy policy line and custom text field are left-aligned with the dropdown menu. This cl also adds accessibility labels. Bug: 1040145 Change-Id: I4b1d62f91c87e328f5869e2e77740127a9fd196f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087703Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#749378}
-
Sergey Ulanov authored
Moved common code to helper function to reduce code duplication. Change-Id: I5a9eb369e70e2fcf3ef520004089ece479935654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092950 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#749377}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/53effe844c9a..d52eddaad2fb git log 53effe844c9a..d52eddaad2fb --date=short --first-parent --format='%ad %ae %s' 2020-03-11 ehmaldonado@google.com scm: Fix bug when checking for valid revision and add tests. Created with: gclient setdep -r src/third_party/depot_tools@d52eddaad2fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ie812cec6962eccf20282ccd7ba20e3bf40d44b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097842Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7004f998c7ba..71d8ec363794 git log 7004f998c7ba..71d8ec363794 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 rmhasan@google.com [Telemetry] Add general debug and release tags for desktop browsers Created with: gclient setdep -r src/third_party/catapult@71d8ec363794 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1045339 Tbr: eseckler@google.com Change-Id: Iabcdb9d3f58eb496101f080b1c8e4419e864b818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098645Reviewed-by:
-
Jimmy Gong authored
- If a scheme is unspecified, we will default with ipps. - If that fails then we will fallback with ipp with port 631. Bug: 1045651 Test: end to end manual Change-Id: Id25cc700340913c6f3df6a7e508c2341d6913cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086687 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#749374}
-
Ken Rockot authored
This moves Python library code out of mojo/public/tools/bindings/pylib/ and into mojo/public/tools/mojom/. Note that duplicate nested mojom/ directory name is intentional: the repository will be named "mojom" and the top-level directory will contain documentation and scripts, as well as other subdirectories. The "mojom" subdirectory is then the home of the parser's Python modules. This is all in preparation to mirror mojo/public/tools/mojom/ in a read-only repository. Bug: 1060467 Change-Id: I33c32f2c6b402b227408f8e5f1fc8c40be4dd3b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098849 Auto-Submit: Ken Rockot <rockot@google.com> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#749373}
-
Jonathan Ross authored
When running with SkiaRenderer on Windows, this test is flaking. TBR=kylechar@chromium.org skia_renderer_gl_blink_web_tests Test: media/video-controls-visibility-multimodal-mouse-after-touch.html Bug: 1060773 Change-Id: Ib276b749f6f61248a8f5811880e1429005422005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099303Reviewed-by:Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#749372}
-
Nate Chapin authored
This actually changes the structure, so that LocalDOMWindow inherits ExecutionContext, rather than Document. I left as much logic as I could on Document, and had LocalDOMWindow call in to it. A few things needed to move for consistency, and I moved anything where the Document override of a ExecutionContext function was only called through the ExecutionContext interface. Added null-checks and updated code to final format where it was necessary to keep tests passing, otherwise left transitional code/helpers intact. Updated many unit tests that needed an ExecutionContext to use DummyPageHolder instead of just a standalone Document. Bug: 1029822 Change-Id: I8e8a477b5f58569cef5d6fb44ca02299ea3a80d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092560Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#749371}
-
Saman Sami authored
If the first LocalSurfaceId provided by the parent has a child sequence number greater than 1, we should use that number. This is a speculative fix for https://crbug.com/1051625 Bug: 1051625,1043109 Change-Id: I8b5fb86d42aa6e087e64c9e86a1de703e0b74723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092417 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
-
