GitLab

The test says:
  All the vertical-lr cases are off by 4px in the x direction.
  See http://webkit.org/b/71193.

LayoutNG fails these tests because it doesn't have the bug.

This patch fixes expectations for LayoutNG, and add a script
for legacy to pass by adding margins to correct the
unexpected offsets.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ib8f17cae0e12d40ce511886d4ee93dff64d87b57
Reviewed-on: https://chromium-review.googlesource.com/1193865
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586757}

Bug: 852076
Change-Id: Ifd09780228d512f0016fab62803b9117b3999e6c
Reviewed-on: https://chromium-review.googlesource.com/1177716
Commit-Queue: Farah Charab <farahcharab@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586756}

A new CL requires browser windows to have kAppType window property
with AppType::BROWSER, which isn't propagated to ash yet.

Since the value enums are defined in ash/public, this property
registration is done in ash/public/cpp/window_properties.

Also, some part of ash code assumes that this property is set
on the views::Widget of ash -- which is actually the root window
of the browsers. So make it so.

Bug: 878037
Test: manually done
Change-Id: I6da9bf77570c5bcde03df1fe0651103496b55e90
Reviewed-on: https://chromium-review.googlesource.com/1191924Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586755}

Add warning level logging when:
- It's detected that update_engine is downloading a rollback
  image or switching channel.
- Notification about the rollback or channel switch to a more
  stable channel is shown.

Bug: 871759
Change-Id: I930b7a23def82ff239ec8da4feeff9daaf960b37
Reviewed-on: https://chromium-review.googlesource.com/1190882
Commit-Queue: Marton Hunyady <hunyadym@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586754}

Crashing the network service just after completing a network request
can corrupt the cache.

Bug: 878346
Change-Id: Ic5dbc1ce88c7bb2b7b9ef3849e3cee2d8a45bf38
Reviewed-on: https://chromium-review.googlesource.com/1193967Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586753}

The loading stack only notifies Blink with any increase in the
request priority. Add support to notify the scheduler with the
initial priority as well.

Bug: 870349
Change-Id: Ia578c4ec1297f56ecd5c853fdda4b9fbd93e0e9b
Reviewed-on: https://chromium-review.googlesource.com/1185593
Commit-Queue: Farah Charab <farahcharab@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586752}

This test is flaky but occasionally hits the retry limit, mark as always
failing.

TBR=zmo@chromium.org
NOTRY=true

BUG=814905

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Id0bcf0a33434008efebafeaed41cead9c21252c0
Reviewed-on: https://chromium-review.googlesource.com/1191025
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586751}

Using wpt-import in Chromium ec5e6e7a.
With Chromium commits locally applied on WPT:
fbb650b3 "Add WPT serialization tests for wasm modules"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23542

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Ib668d791a77d8f16cf51ae012d2b2eb3b0edf030
Reviewed-on: https://chromium-review.googlesource.com/1193751
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586750}

This CL workarounds a ui::Layer mask bug for UnifiedSystemTray.
ui::Layer mask does not update properly when a layer is resized.
I reached out to cc OWNERS but couldn't figure out the way to fix the
bug on cc:: or ui:: side. As the tray button highlight issue is easily
noticeable by users, we workaround the problem in ash for now.

Steps to repro:
1. Open UnifiedSystemTray
2. Click do-not-disturb button
3. System Tray button highlight does not resize
   (See the screenshot on the bug)

TEST=manual
BUG=854807,860367

Change-Id: Ic6dcefde8d0263e2e31953621b8c43f522696aba
Reviewed-on: https://chromium-review.googlesource.com/1193042
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586749}

This CL provides a templatized version of VaapiWrapper::SubmitBuffer()
in order to be able to omit the size argument in many of the calls.

The calls that can use the templatized version are fixed. Others are
left as they are because they involve arrays.

Bug: 878224
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ic15f95817c47c7fe0e0293c95c5db8bae616cd21
Reviewed-on: https://chromium-review.googlesource.com/1192742
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586748}

Bug: 864612
Change-Id: Ic7ee974224264eb15089c1915c660957592c4fc0
Reviewed-on: https://chromium-review.googlesource.com/1180418
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586747}

Bug: 867471
Change-Id: Id018134cab083690bfc4168f880cfbcd835a0cbb
Reviewed-on: https://chromium-review.googlesource.com/1191092
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586746}

Chrome-side companion to the Skia CL:

https://skia-review.googlesource.com/c/skia/+/150080 (Add a flag to disable mask-filtered mask caching for Chrome)

Bug: 878195
Change-Id: I8f2f7f2c5fb6dc5a9091750361722bd022e38a45
Reviewed-on: https://chromium-review.googlesource.com/1193968Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#586745}

overscroll-behavior should only take effect if the Element it's
specified on is actually a scrolling box. Otherwise, it must be ignored.
The overscroll-behavior test actually checks for this behavior but the
test wasn't working because we accidentally used "overflow: none" rather
than "overflow: hidden". "none" is not a valid value for the "overflow"
property.

Correcting this causes the test to fail when scrolling happens on the
main thread. It passes while compositor scrolling because the
overscroll-behavior is set on ScrollNodes. "overflow: none" is invalid
so it causes the box to be "overflow: visible" and so no ScrollNode is
created.

On the main thread, we check for overscroll-behavior by iterating  up
the DOM tree while computing the scroll chain. When the box is
"overflow: visible", we didn't have a ScrollableArea so we early-out in
CanPropagate. With "overflow: hidden" we do have a (non-user-scrollable)
ScrollableArea so we add a check here to only check the
overscroll-behavior on user scrollable Elements.

Change-Id: I9b4e3a340dcfe7eae701cbc87fb9ef6943330133
Reviewed-on: https://chromium-review.googlesource.com/1189706Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Sandra Sun <sunyunjia@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586744}

https://skia.googlesource.com/skia.git/+log/ffe1c1cad081..6b622963a065


git log ffe1c1cad081..6b622963a065 --date=short --no-merges --format='%ad %ae %s'
2018-08-28 brianosman@google.com Reland "Stop conflating F16 with linear gamma"


Created with:
  gclient setdep -r src/third_party/skia@6b622963a065

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stephana@chromium.org

Change-Id: I453e409e5656f7182b2579f92e2371bb0bbfa4a6
Reviewed-on: https://chromium-review.googlesource.com/1193588Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#586743}

Currently we call on the RFH's associated WebContents' focused
WebContents instead.

Bug: 819919,876890
Change-Id: Ia97f60cb524322fe3f2566ffa8f6ba86eeddcf90
Reviewed-on: https://chromium-review.googlesource.com/1192665
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586742}

https://chromium.googlesource.com/catapult.git/+log/44e5893116c6..18259e73a8b7


git log 44e5893116c6..18259e73a8b7 --date=short --no-merges --format='%ad %ae %s'
2018-08-28 ulan@chromium.org Update memory metric for the upcoming V8 memory dump provider changes.


Created with:
  gclient setdep -r src/third_party/catapult@18259e73a8b7

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:852415
TBR=sullivan@chromium.org

Change-Id: I4004ea4b2a408e6e67e8aea8596320cc814f2da2
Reviewed-on: https://chromium-review.googlesource.com/1193587Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#586741}

This change implements publishing of advertisments on WinRT. It uses the
UWP BluetoothLEAdvertisementPublisher interface to do so, which is
wrapped in a BluetoothAdvertisementWinrt class.

Bug: 821766
Change-Id: I894eaee7d916ca04b2a27de67cc66cf2f198164b
Reviewed-on: https://chromium-review.googlesource.com/1186732
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586740}

Last CL missed the string changes under Learn More as those were supposed to
already be fixed in M68.

The new strings used are available @
https://docs.google.com/document/d/1cVwZrMVUwOWUCdHFJ2bRe0nVzam4xFNSozmObaKs2Tg

Bug: 865947
Change-Id: Ibe836d32cb74087be66d4eeb4435525f94a3d170
Reviewed-on: https://chromium-review.googlesource.com/1193863Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586739}

Bug: 874653
Change-Id: I95b968427344a4c9821c0985ae1f89c153036bcd
Reviewed-on: https://chromium-review.googlesource.com/1185626
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586738}

NOTRY=true

TBR=pasko@chromium.org

Bug: 878175
Change-Id: I759a5d73e4ca9028e05dfba48771971416531680
Reviewed-on: https://chromium-review.googlesource.com/1194251Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#586737}

This reverts commit 38e765d6.

Reason for revert: May have broken
ios_chrome_ui_egtests  on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-uirefresh-simulator/2090

Original change's description:
> [ios] Add highlight animation state to fake omnibox.
> 
> Bug: 865834
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
> Change-Id: If4c9293870035e62828bfa44714a8dec2df673e2
> Reviewed-on: https://chromium-review.googlesource.com/1191285
> Reviewed-by: Gauthier Ambard <gambard@chromium.org>
> Commit-Queue: Justin Cohen <justincohen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#586693}

TBR=justincohen@chromium.org,pschaffner@chromium.org,gambard@chromium.org

Change-Id: I6427d0e3d31f9e7e1d4e217cd6c109ce70fc1695
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 865834
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/1193850Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Commit-Queue: Markus Heintz <markusheintz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586736}

Right now there are few places in TouchActionFilter where we set a
crash key and do DumpWithoutCrashing for debugging purpose. We don't
actually need the DumpWithoutCrashing because the crash will happen
just one line below the DumpWithoutCrashing, which means when it crashes,
we will have the crash key for debugging.

This CL removes the DumpWithoutCrashing.

TBR=dtapuska@chromium.org

Bug: None
Change-Id: I78f53cae28455e51e9ddb2ea6f20dc285967a954
Reviewed-on: https://chromium-review.googlesource.com/1193745Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586735}

This also removes the dependency on the Floating Action Button
and sets the accessibility text for the Select All, Undo and
Search buttons.

Bug: 876823, 860467
Change-Id: I1fc2758ddb72db133bf489ef7a0f71783b5d2ac9
Reviewed-on: https://chromium-review.googlesource.com/1190342Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586734}

When dragging a tab out of a snapped browser window to drop into
overview, it should be able to merge the tab window into the overview.
However, with the recent change to always update the dragged window's
bounds before adding it to overview, it's possible that the dragged
window is merged back into its source window due to its bounds change.
To avoid this, we temmrarily disable the dragged window's ability to
merge into another window when updating the dragged window's bounds and
restore its ability after adding it to overview.

Bug: 878191
Change-Id: I219517b19f42395ca8a0c095d7313734358e159e
Reviewed-on: https://chromium-review.googlesource.com/1192357Reviewed-by: Min Chen <minch@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586733}

This CL ensures that any access to the ManualFillingCoordinator checks
whether the latter exists in the first place. Because its initialization
happens after the native initialization, this is a possible source of
crashes.

Also, this CL handles that cases in which the bottom control space
changes even if there is no accessory to fill it.

Bug: 876215, 877687
Change-Id: I713ab1343742c858d6ab0277b94cf3190e88e5e2
Reviewed-on: https://chromium-review.googlesource.com/1189805
Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586732}

TBR=martiniss@chromium.org
NOTRY=true

Bug: 855319
Change-Id: Ia760d2ff0e5c7bfe6cf1508464d0c1e5bc1e2026
Reviewed-on: https://chromium-review.googlesource.com/1194325Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586731}

This CL makes the tests run for both the directory-based implementation
and the new USS based implementation.

Bug: 876301
Change-Id: Id613f23514b52bf01d1d0ed3bdc73b87e758a03b
Reviewed-on: https://chromium-review.googlesource.com/1189963Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Florian Uunk <feuunk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586730}

This change also simplifies the approach to getting the profiler callback
across CallStackProfileMetricsProvider and ChildCallStackProfileCollector
by directly calling ChildCallStackProfileCollector::Collect() or
CallStackProfileMetricsProvider::ReceiveCompletedProfile() from
CallStackProfileBuilder::OnProfileCompleted().

Bug: 851163
Change-Id: Ia9a39510342cf6f4f1e43464b4c54345ba5e4d63
Reviewed-on: https://chromium-review.googlesource.com/1185854Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586729}

This allows using //base/task/post_task.h for posting tasks to a
BrowserThread by specifying a BrowserThread::ID as a task trait.

Also adds a content::NonNestable task trait to support non-nestable
tasks in base::PostTaskWithTraits.

In the future, we will add further traits to facilitate scheduling
tasks onto different SequenceManager queues on the UI thread, see:
https://docs.google.com/document/d/1z1BDq9vzcEpkhN9LSPF5XMnZ0kLJ8mWWkNAi4OI7cos/edit?usp=sharing

Bug: 867421, 863341, 878356
Change-Id: Id8b7bc2e374917ceb421c7f6139790e6f1457511
Reviewed-on: https://chromium-review.googlesource.com/1181364
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586728}

Bug: 878309
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I961a8c962ca3b77b86a4cca37fdda81333ad8a88
Reviewed-on: https://chromium-review.googlesource.com/1194028Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586727}

Height of sliders were wrong. 40dip -> 32dip
It affected both slider bubble and main bubble.

TEST=manual
BUG=877558

Change-Id: I7b2822e263c4e335b845f0ea40a9b52866ced60e
Reviewed-on: https://chromium-review.googlesource.com/1192374Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586726}

SyncAuthManager has a supposed invariant that only one of an access token,
an access token request, or a pending retry can exist at any one time.
However, it didn't properly enforce this, so in some cases the invariant
could be violated. This CL fixes that, and adds a bunch of DCHECKs to make
sure.

Bug: 877440
Change-Id: I756e41d5045edb36fcfaa53104092a4f299a1e20
Reviewed-on: https://chromium-review.googlesource.com/1188472
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586725}

Send a histogram value from UpgradeDetector when the device did
install a rollback image and shows a notification before reboot.

The metric records whether the rollback is happening because of a
channel switch or because of an admin-initiated enterprise
rollback.

Bug: 871759
Change-Id: I38fad1792ba87b6bdbd788b3cd0f736dfa2d363c
Reviewed-on: https://chromium-review.googlesource.com/1190703
Commit-Queue: Marton Hunyady <hunyadym@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586724}

This fixes the issue that we're showing a misleading "Your
administrator rolled back this device" notification on non-enrolled
devices too if they switch the channel to a more stable version.

Bug: 871759
Change-Id: I75e9e3faacaed0499fedef1aafda290cf0b87e19
Reviewed-on: https://chromium-review.googlesource.com/1188665Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Marton Hunyady <hunyadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586723}

This test apparently:
- Tries to use something called "objCPlugin" for Obj-C bindings,
  which doesn't exist in Blink
- Then adds /etc/passwd as the canonical "local file" URL
- Then attempts to instantiate an NSPasteboard Objective-C object
- So that it can try to read the "NSFilenamesPboardType" obsolete
  data type off of it.

This is not a useful test in any way.

BUG=none

Change-Id: If7b17055536eda22d401bed1b48ab4f35b53c3f5
Reviewed-on: https://chromium-review.googlesource.com/1192262Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586722}

Allows passing in a precomputed border+padding struct to various
length util functions.

No-Try: True
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I330dfc77e7392928f2475a05ecfdb6c643c9a5f4
Reviewed-on: https://chromium-review.googlesource.com/1193403
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586721}

This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/shell_integration_linux.cc.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=thomasanderson@chromium.org

Bug: 874080
Change-Id: I64920670d2ccb62299815969d324003f462d8ecd
Reviewed-on: https://chromium-review.googlesource.com/1191801Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586720}

This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/web_applications/components/web_app_shortcut_mac.mm.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=rsesek@chromium.org

Bug: 874080
Change-Id: Iffe2955c934c9a81ffddefd2d42cfb277aec0ddb
Reviewed-on: https://chromium-review.googlesource.com/1191665Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586719}

It is always false and has been for over a year.

Change-Id: Ibd2b6b8c3f6dc5e9e6ba4a877bdec98e0482f9af
Reviewed-on: https://chromium-review.googlesource.com/1193750Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586718}