- 06 Nov, 2018 40 commits
-
-
David 'Digit' Turner authored
This was previously disabled because the GVR APK was loading its library with the system dlopen(), then passing the handle to code in libchrome.so, which happened to call the crazy linker dlsym() wrapper with it. This resulted in runtime crashes until a work-around was added in [1]. The Java check was never removed though, so this CL does it. [1] https://chromium-review.googlesource.com/885763 BUG=895194 R=agrieve@chromium.org, pasko@chromium.org Change-Id: If742399452336d349eb763a76357a38a72f6707e Reviewed-on: https://chromium-review.googlesource.com/c/1319589Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#605680}
-
Findit authored
Revert "Export the quic batch writer code to Chromium. Note it's not used anywhere in Chrome, we are just exporting the code so people outside of Google can take a look." This reverts commit cc75805c. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 605652 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2NjNzU4MDVjMWYzMmNhZDY2MDFmNzVjZjRjYWRmYmVlMjM0NDYzN2QM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/12757 Sample Failed Step: net_unittests Original change's description: > Export the quic batch writer code to Chromium. Note it's not used anywhere in Chrome, we are just exporting the code so people outside of Google can take a look. > > Change-Id: I9fd9486172a13cd8924dd622aa6984285e07ac6c > Reviewed-on: https://chromium-review.googlesource.com/c/1315961 > Reviewed-by: Ryan Hamilton <rch@chromium.org> > Commit-Queue: Bin Wu <wub@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605652} Change-Id: I4f8a4dea97f700bf98c8a244f9a505f083eb53b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1319850 Cr-Commit-Position: refs/heads/master@{#605679}
-
Henrik Boström authored
With the changes, the test should pass regardless of if the Chrome or Firefox behavior is used for what to do when no MSIDs are signaled. Follow-up work is needed to test both the case of "a=msid:-" and no "a=msid" line whatsoever, awaiting spec issue to be resolved: https://github.com/w3c/webrtc-pc/issues/2027 // Relying on fippo's approval to land. TBR=hta@chromium.org Bug: 901711 Change-Id: Icaf089d206413510aadad54a0c10b2674450385a Reviewed-on: https://chromium-review.googlesource.com/c/1319612Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#605678}
-
Luna Lu authored
After research, tentatively updating the unoptimized-images policy as: no using more than 0.5 byte per pixel of image data with approximate header size (1KB) removed. Bug: 901925 Change-Id: Ibc5b2e2e6ccaba7a273c63440d48d4e0d154cc2e Reviewed-on: https://chromium-review.googlesource.com/c/1318372Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#605677}
-
barkerd authored
Bug: 898840 Change-Id: Ib60cc54ed76911a42a637e6d859c7eb459f3e11d Reviewed-on: https://chromium-review.googlesource.com/c/1317850 Commit-Queue: David Barker <barkerd@google.com> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#605676}
-
Christopher Thompson authored
The lookup_affiliation_response_parser_fuzzer frequently crashes due to being unable to open the libicu test environment data tables. This adds IcuEnvironment setup code to the fuzz target to properly set up libicu before fuzzing. This follows the approach taken in https://crbug.com/754996#c15 Bug: 900811 Change-Id: Iebb7a7b7e8fac6ae6a089da1d51d2d85846b9967 Reviewed-on: https://chromium-review.googlesource.com/c/1318735Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#605675}
-
Sigurdur Asgeirsson authored
This shows a continuously updating graph of pages, frames and processes. Bug: 891310 Change-Id: I1b2f462740374dfb1d2529057d1831dc240e79f2 Reviewed-on: https://chromium-review.googlesource.com/c/1313449Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#605674}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e6c85755832b..e70c6b13dd55 git log e6c85755832b..e70c6b13dd55 --date=short --no-merges --format='%ad %ae %s' 2018-11-06 kjlubick@google.com Update emsdk-release image Created with: gclient setdep -r src/third_party/skia@e70c6b13dd55 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I1bbec78dccac50d0fee602fb4feaace049beb072 Reviewed-on: https://chromium-review.googlesource.com/c/1319381Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605673}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ce029014f300..01ed846cb1db Created with: gclient setdep -r src-internal@01ed846cb1db The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I62ed4e2d18da91a960943ebf8249feb846b4a45d Reviewed-on: https://chromium-review.googlesource.com/c/1319382Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605672}
-
Colin Blundell authored
//components/signin/core/browser contains three different types of code: 1. Code that forms the guts of IdentityManager and will form the guts of the Identity Service implementation (e.g., SigninManager). 2. Code that will be clients of IdentityManager (e.g., SigninTracker). 3. Code that will be used on both sides (e.g., AccountInfo). Currently, all of these are naturally grouped in the same GN target, since there was never any distinction between them. However, we need to separate them in GN now to enable converting the code in 2 to use IdentityManager. This split will also define the scope of the conversion of the codebase to IdentityManager: everything that is in 1 will need to have its clients converted to use IdentityManager. This CL performs an initial split, via the following process: - Moved signin_manager(_base).*, profile_oauth2_token_service.*, and account_tracker_service.* into a new "internals" target that the existing target now depends on. - Kept moving in code (and adding dependencies as needed) until "gn check" no longer complained about the "internals" target including code that wasn't in any dependencies. This CL also modifies //services/identity/public/cpp to depend only on //components/signin/core/browser:internals; this change is is the concrete benefit from doing the split, as it is what will allow us to convert client code in //components/signin/core/browser. Future CLs will refine the split, but this is a good initial checkpoint. Bug: 901859 Change-Id: Ied46c4cdf0153b78b53516fec9537a83c4c0a71d Reviewed-on: https://chromium-review.googlesource.com/c/1317915Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#605671}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b1495136fdfb..e4a55fc6dd08 git log b1495136fdfb..e4a55fc6dd08 --date=short --no-merges --format='%ad %ae %s' 2018-11-06 lalitm@google.com Merge "trace_processor: migrate slice table to StorageSchema usage" Created with: gclient setdep -r src/third_party/perfetto@e4a55fc6dd08 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iaac4b15a9c1462059d2ae26cb1aa4ceaeb310cc9 Reviewed-on: https://chromium-review.googlesource.com/c/1319379Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c1d2886c..9e6bab3a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5c71d04b624e3cd07d4c48608ae162f5ecdde3c3 Reviewed-on: https://chromium-review.googlesource.com/c/1319632Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605669}
-
Vasilii Sukhanov authored
field in PasswordGenerationAgent. Currently |generation_element_| has a double meaning. It's an element that should trigger the automatic generation. However, if a manual generation is triggered then it's overwritten by a password field. That's confusing. The CL decouples the field that should trigger the automatic generation from whatever is happening right now on a random password field. In the future that will allow us to have multiple generation elements simultaneously. For now it fixes 870220 where the manual generation on the ambiguous field was suppressing the automatic generation on it. Bug: 870220,852309 Change-Id: I6a3edd351e615289f6271fda5a45f6ff47e653af Reviewed-on: https://chromium-review.googlesource.com/c/1310713Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#605668}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/63ada787b5bc..254d3db59ad9 git log 63ada787b5bc..254d3db59ad9 --date=short --no-merges --format='%ad %ae %s' 2018-11-06 tzik@chromium.org Add missing #include to absl/memory/memory.h from audio_encoder_cng.cc 2018-11-06 kron@webrtc.org Add HdrMetadata to VideoFrame 2018-11-06 eladalon@webrtc.org Remove unused member variable - RTCPSender::using_nack_ Created with: gclient setdep -r src/third_party/webrtc@254d3db59ad9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:752720,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4dce8a21814d711bde82c662ead9f9614ac3269e Reviewed-on: https://chromium-review.googlesource.com/c/1319378Reviewed-by:
-
Rayan Kanso authored
This reverts commit cdc66684. Reason for revert: Broke the build https://logs.chromium.org/logs/chromium/bb/chromium.android/Android_Cronet_ARM64_Builder__dbg_/99962/+/recipes/steps/compile/0/stdout Sample build error log: ld.lld: error: undefined symbol: net::websockets::kWebSocketGuid >>> referenced by web_socket.cc:81 (../../services/network/public/cpp/server/web_socket.cc:81) Original change's description: > Network Service: Migrate NetworkMetricsProvider to NetworkConnectionTracker > > This CL migrates NetworkMetricsProvider from NetworkChangeNotifier to > NetworkConnectionTracker, which works with the network service enabled. > > The "Initial upload" patch of this CL is the same as: > https://chromium-review.googlesource.com/c/chromium/src/+/1222918 > > Bug: 883121 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo > Change-Id: Ic6879e48b9515d2281dc9da7c9437bad4c044a99 > Reviewed-on: https://chromium-review.googlesource.com/c/1274585 > Reviewed-by: Olivier Robin <olivierrobin@chromium.org> > Reviewed-by: Tao Bai <michaelbai@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Commit-Queue: Jun Cai <juncai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605566} TBR=michaelbai@chromium.org,jam@chromium.org,fdoray@chromium.org,asvitkine@chromium.org,olivierrobin@chromium.org,juncai@chromium.org,rmcelrath@chromium.org Change-Id: I49a7da919b912cf33bc0f0f06b9bf419080a968f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 883121 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/c/1319614Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#605666}
-
Henrik Boström authored
TBR=petewil@chromium.org, jianli@chromium.org, dtrainor@chromium.org, isherman@chromium.org NOTRY=True Bug: 901856 Change-Id: Icea45c9f384c1ad4a46e24a9fb4ee947a1b57a53 Reviewed-on: https://chromium-review.googlesource.com/c/1319593Reviewed-by:
-
Henrik Boström authored
This reverts commit b81908f9. Reason for revert: @DisabledTest: Cannot find symbol, oops. Original change's description: > Disable flaky ScreenshotTabObserverTest tests. > > TBR=petewil@chromium.org, jianli@chromium.org, dtrainor@chromium.org, isherman@chromium.org > NOTRY=True > > Bug: 901856 > Change-Id: I61b14dca18356bb71618150795cddc7cce016574 > Reviewed-on: https://chromium-review.googlesource.com/c/1318911 > Reviewed-by: Henrik Boström <hbos@chromium.org> > Commit-Queue: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605659} TBR=isherman@chromium.org,petewil@chromium.org,dtrainor@chromium.org,jianli@chromium.org,hbos@chromium.org Change-Id: I6ed97b424d0a649d7f02fd17a0569b6bd64f9069 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 901856 Reviewed-on: https://chromium-review.googlesource.com/c/1318913Reviewed-by:
-
Henrik Boström authored
This was supposed to have been disabled on ChromeOS in https://chromium-review.googlesource.com/c/chromium/src/+/1315207 but the CL disabled it on all platforms *except* for ChromeOS. Removing the "!" from "!defined(OS_CHROMEOS)" because this has kept flaking, e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/8738 TBR=mlamouri@chromium.org, vitaliii@chromium.org NOTRY=True Bug: 901235 Change-Id: I78ece1196efee61aa9c5fd66fd166290e3d8fbd6 Reviewed-on: https://chromium-review.googlesource.com/c/1319713 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
-
Henrik Boström authored
This was failing due to "unified garbage collection", https://chromium-review.googlesource.com/c/chromium/src/+/1290869. TBR=mlippautz@chromium.org, haraken@chromium.org, mkwst@chromium.org, vasilii@chromium.org NOTRY=True Bug: 902286 Change-Id: Ia5a8fd654f668d7b13d19fb44d39bd80809f9807 Reviewed-on: https://chromium-review.googlesource.com/c/1319672Reviewed-by:
-
Mathias Carlen authored
Before this patch we would add a settings entry on every resume of the activity. This patch only adds the entry once on creation and not on every onResume. Bug: 806868 Change-Id: I6d41d99f6f2d05ad98e306da2c6bdebed7c37722 Reviewed-on: https://chromium-review.googlesource.com/c/1318970Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#605661}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ef8feea70c2f..ce029014f300 Created with: gclient setdep -r src-internal@ce029014f300 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I798d96f769d764a0f633b484955608712628a5c6 Reviewed-on: https://chromium-review.googlesource.com/c/1319689Reviewed-by:
-
Henrik Boström authored
TBR=petewil@chromium.org, jianli@chromium.org, dtrainor@chromium.org, isherman@chromium.org NOTRY=True Bug: 901856 Change-Id: I61b14dca18356bb71618150795cddc7cce016574 Reviewed-on: https://chromium-review.googlesource.com/c/1318911Reviewed-by:
-
Mattias Nissler authored
BUG=chromium:775444 TEST=TPM firmware update offered in powerwash dialog even without finch config. Change-Id: I533afd2306c6e5f8af943f81f4f15542cf7ba116 Reviewed-on: https://chromium-review.googlesource.com/c/1317896Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#605658}
-
Rune Lillesveen authored
We called AttachLayoutTree on a new Document which just got its LayoutView created. The new Document should not have any child nodes, it's not marked initially dirty, but trying to land this change the first time we caused flakiness for a Window accessibility test. Instead of the AttachLayoutTree call, do the AXObjectCache update which would otherwise be called from Node::AttachLayoutTree. This is a new attempt after the previous got reverted: https://chromium-review.googlesource.com/c/chromium/src/+/1317889 Bug: 902050 Change-Id: I4e366013549627b54f016d76b3dcbf12ea115f70 Reviewed-on: https://chromium-review.googlesource.com/c/1319610Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#605657}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2b4710f3..c1d2886c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icaac22420c0bbfc93944c87dcae14d475042747c Reviewed-on: https://chromium-review.googlesource.com/c/1319629Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c8ac03930c6d..b1495136fdfb git log c8ac03930c6d..b1495136fdfb --date=short --no-merges --format='%ad %ae %s' 2018-11-06 rsavitski@google.com Merge "Add a "run ui unittests" shell script to be later used by Kokoro CI." Created with: gclient setdep -r src/third_party/perfetto@b1495136fdfb The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Id7ba136b9d48d12fe2ad1aab3cd6500c6a1079db Reviewed-on: https://chromium-review.googlesource.com/c/1319377Reviewed-by:
-
Alexander Timin authored
Move actual MessageLoop implementation to MessageLoopImpl and make MessageLoop a simple wrapper around MessageLoopImpl. This will allow us to switch MessageLoopImpl with SequenceManager in a future patch. R=gab@chromium.org BUG=891670 Change-Id: Iff089d5ccba91ba157db41a950a9d7b6640e7691 Reviewed-on: https://chromium-review.googlesource.com/c/1293613 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#605654}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/edfb883c85ef..63ada787b5bc git log edfb883c85ef..63ada787b5bc --date=short --no-merges --format='%ad %ae %s' 2018-11-06 saza@webrtc.org Remove outdated TODO 2018-11-06 ouj@fb.com Add severity into RTC logging callbacks Created with: gclient setdep -r src/third_party/webrtc@63ada787b5bc The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4f01ef84d03b6d72ee2dc796256be1aee9ccce8c Reviewed-on: https://chromium-review.googlesource.com/c/1319376Reviewed-by:
-
Bin Wu authored
Export the quic batch writer code to Chromium. Note it's not used anywhere in Chrome, we are just exporting the code so people outside of Google can take a look. Change-Id: I9fd9486172a13cd8924dd622aa6984285e07ac6c Reviewed-on: https://chromium-review.googlesource.com/c/1315961Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bin Wu <wub@chromium.org> Cr-Commit-Position: refs/heads/master@{#605652}
-
Kent Tamura authored
- core/event_names.json5 => core/event_interface_names.json5 - event_modules_names.json5 => modules/event_interface_modules_names.json5 This renaming changes generated *_names.{h,cc} too. This CL fixes #includes for them. Also, this CL removes unnecessary #includes for event_names.h, and add necessary #includes. This CL has no behavior changes. Change-Id: Id7b47788cde408bf81822c6e7d284683648f5854 Reviewed-on: https://chromium-review.googlesource.com/c/1317209Reviewed-by:Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#605651}
-
Keishi Hattori authored
Converts Touch* class allocations from new to MakeGarbageCollected. Bug: 757708 Change-Id: I4fe095a494f7bc1756890d03b97b62dd2ed51f8d Reviewed-on: https://chromium-review.googlesource.com/c/1317077Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#605650}
-
David Jean authored
Bug: 845472 Change-Id: Ifc6f448c0000d4886a15aab5b06a979bd8dc63d6 Reviewed-on: https://chromium-review.googlesource.com/c/1303730 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#605649}
-
Nikita Podguzov authored
This should help to understand perfomance of ResourceCache operations. Bug: 807068 Change-Id: I58b5c0da38b46c9497a3a878327a25dca58b5995 Reviewed-on: https://chromium-review.googlesource.com/c/1296489 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#605648}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/92fc277bf0f6..ef8feea70c2f Created with: gclient setdep -r src-internal@ef8feea70c2f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9d32b7a9ea85336fbfb94842122a0bae877244d1 Reviewed-on: https://chromium-review.googlesource.com/c/1319375Reviewed-by:
-
Nikita Podguzov authored
Bug: 807068 Change-Id: I1e55bdea38b02d5fdf1d7faa9a60390af5fac7d7 Reviewed-on: https://chromium-review.googlesource.com/c/1290983Reviewed-by:
-
Gauthier Ambard authored
This CL marks the WebState's view as dirty when the preferred content size is changed. It causes the view to be laid out again. It also changes the way the Overscroll controller is getting its initialHeaderInset, by asking it to the delegate every time instead of caching it, as the value become stale after changing the preferred content size. Bug: 892145 Change-Id: I2fe0b54a107e0cfed438ea5c57efdbb65fe4c5a3 Reviewed-on: https://chromium-review.googlesource.com/c/1307443 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#605645}
-
Arthur Sonzogni authored
devtools_instrumentation::OnResetNavigationRequest is probably called with an already deleted NavigationRequest. Add instrumentation to understand what happens. Crash reports: https://crash.corp.google.com/browse?q=expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27content%3A%3Adevtools_instrumentation%3A%3AOnResetNavigationRequest%27+AND+product_name%3D%27Chrome Experiment: NetworkService. OS: Windows StackTrace: * content::devtools_instrumentation::OnResetNavigationRequest * content::FrameTreeNode::TransferNavigationRequestOwnership * content::NavigationRequest::CommitNavigation * content::NavigationRequest::OnWillProcessResponseChecksComplete * content::NavigationHandleImpl::RunCompleteCallback * content::NavigationHandleImpl::WillProcessResponse * content::NavigationRequest::OnResponseStarted * content::NavigationURLLoaderImpl::OnReceiveResponse Bug: 880741 Change-Id: Ib428283192cc3de83292f2b62c71583e2596a19f Reviewed-on: https://chromium-review.googlesource.com/c/1316734 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#605644}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d7db17b992e4..edfb883c85ef git log d7db17b992e4..edfb883c85ef --date=short --no-merges --format='%ad %ae %s' 2018-11-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 11d7305a..7841106b (605505:605607) Created with: gclient setdep -r src/third_party/webrtc@edfb883c85ef The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I633278fa78bcc0a46cc6e69d4a57c7e329f9795a Reviewed-on: https://chromium-review.googlesource.com/c/1319374Reviewed-by:
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: Ida8672946dc60306d4269ddce06672f080953f8e Reviewed-on: https://chromium-review.googlesource.com/c/1319401Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#605642}
-
Hans Wennborg authored
implicit_weak_message.cc is part of protobuf_lite.dll, and it includes wire_format_lite.h, which includes the dllexport inline function WireFormatLite::WriteGroupToArray which will therefore be emitted. WriteGroupToArray in turn calls the inline function InternalWriteGroupToArray, however that definition is provided in the _inl file. To make sure the definition is available, the _inl file must be included. Before Clang r344987 the build worked anyway (due to luck), because InternalWriteGroupToArray was emitted into other object files (e.g. in wire_format_lite.obj). After that Clang revision, those definitions started getting inlined, and so are longer available and cause a link failure for the reference from implicit_weak_message.obj. Bug: 901776 Change-Id: I60ba265495eba6e868f0799f697c0d172e4c2fb1 Reviewed-on: https://chromium-review.googlesource.com/c/1317910 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#605641}
-
