- 12 Apr, 2018 40 commits
-
-
Joel Einbinder authored
The contentEncoded bit would sometimes be lost if a revision was added before the original content was recieved. The ImageView was not waiting long enough before calculating the image size. Missing content failures were not being detected. Change-Id: I6bf7069fe7ee185b24be60ebceb023613af76a99 Reviewed-on: https://chromium-review.googlesource.com/1008864Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#550358}
-
Filip Gorski authored
* Fetches favicons for contextual suggestions using the Image Id provided by the ExploreService Bug: 829103 Change-Id: Icb670b3df670039f78c7336ae7050b86f50ef07c Reviewed-on: https://chromium-review.googlesource.com/1010887Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#550357}
-
Yuwei Huang authored
We have got approval to turn on the fullscreen exit UI at 100% for Canary and Dev, but the Finch experiment has too much overhead for us, so it's easier to just turn it on with a CL. Bug: 829606 Change-Id: I3ad3880361e66aaef08a07646dc81f0dbda0670a Reviewed-on: https://chromium-review.googlesource.com/1010966Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#550356}
-
Yuwei Huang authored
We got some crash reports happened when the user tries to send a feedback during a session. Looks like their host os is OTHER, which is not mapped to a string and crashes the app. It's unsure when will the host OS be OTHER. Let's just add back the mapping for now. Bug: 831956 Change-Id: I2bf285955a266ab61aae4dfc525b5185546c9109 Reviewed-on: https://chromium-review.googlesource.com/1010969Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#550355}
-
Andrew Grieve authored
* Removes .equals() and .hashCode() (unused in non-test code) * Coalesce version checks in decode() * Move mTag field from generated to Union base class. diagnose_bloat.py --enable-chrome-android-internal shows: -262 entries methods -33,740 bytes main dex size bytes main dex size * Largest single symbol savings from equals(): -428 * Largest single symbol savings from hashCode(): -299 * Largest single symbol savings from decode(): -112 Bug: 828403 Change-Id: Iad41ec6baf0101fd5080375f3a0e65b561d90395 Reviewed-on: https://chromium-review.googlesource.com/1005031 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#550354}
-
Troy Hildebrandt authored
When tapping the microphone button on the search widget on the home screen, #isVoiceSearchEnabled would return false because we were trying to get WindowAndroid from the Tab, which doesn't exist in this case. We now rely on getting the WindowAndroid from the LocationBar so the two agree. What happened as a result is that recording metrics would fail almost every startup, if the call to RecordHistogram.record* was called before native was initialized, so CachedMetrics is used now. Bug: 831985 Change-Id: I34c4dbe46afd42c1d793e737a48c45dc3430701d Reviewed-on: https://chromium-review.googlesource.com/1010772 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#550353}
-
Jason Chase authored
This CL adds support for origin trials to follow the implied_by relationships defined for the runtime flags. The implied_by relationship only applies if both of the runtime flags are configured with an origin trial name. The implied by relationship is actually implemented in two ways: 1) The generated OriginTrials::<name>Enabled methods will now check the defined trial, and any implied by trials 2) When a token enables a trial, any implied trials are also enabled at the same time. Approach (1) doesn't handle the case of dynamically added tokens. In theory, approach (2) makes (1) unnecessary. Keeping (1) and (2) for now to ensure all cases are handled. Bug: 831346 Change-Id: Ibab588f11c69d31f1acd9e599ee917fb036dd32b Reviewed-on: https://chromium-review.googlesource.com/1008850Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#550352}
-
Zhongyi Shi authored
update flags https://chromium-review.googlesource.com/c/chromium/src/+/1006069 Refactor QuicConnection::Set(En|De)crypter and related methods These SetEncrypter/SetDecrypter methods took in a raw pointer to a QuicEncrypter/QuicDecrypter, and this changes them to take std::unique_ptrs instead. Merge internal change: 191952319 https://chromium-review.googlesource.com/c/chromium/src/+/1006074 [fix-write-blocked] Enable flag to fix QUIC write-blocked CHECK failures. n/a (Quartc change only) Merge internal change: 191932760 https://chromium-review.googlesource.com/c/chromium/src/+/1006016 Implement AES packet protection for initial encryption QUIC TLS crypto changes protected by FLAGS_quic_supports_tls_handshake Merge internal change: 191923711 https://chromium-review.googlesource.com/c/chromium/src/+/1005990 Call QuicConnection::WriteIfNotBlocked instead of OnCanWrite() from WriteAndBundleAcksIfNotBlocked to avoid writing another packet when the writer is already blocked. Protected by FLAGS_quic_reloadable_flag_quic_is_write_blocked. Merge internal change: 191910257 https://chromium-review.googlesource.com/c/chromium/src/+/1006014 Change the most common DLOG(INFO)'s in quic_stream.cc to DVLOG(1). n/a (Debug logging only) Merge internal change: 191904604 https://chromium-review.googlesource.com/c/chromium/src/+/1005891 Remove unused socket_receive_buffer from QuicConfig. n/a (Remove unused code) Merge internal change: 191904598 https://chromium-review.googlesource.com/c/chromium/src/+/1005879 [fix-iw10] Set the quic flag to enable IW10 to work with BBR. n/a (quartc code only) Merge internal change: 191834057 https://chromium-review.googlesource.com/c/chromium/src/+/1005845 [quic-expr] Quartc BBR options for number of RTTs in startup and initial cwnd. Adds QuartcBbrOptions for all the initial congestion window and RTT options. Quartc probably won't use most of these, but it's easier to add them all now. Sets QuartcConnection to use IW10 and 1RTT options. These options reduce the aggressiveness of the BBR startup phase. With IW10, the initial congestion window is reduced from its default size of 30 packets to 10 packets, meaning that BBR won't send as many packets in its initial burst. With 1RTT, BBR will only continue to send at startup rates for 1 RTT with no gains before it exits, rather than the default of 3 RTTs with no gains before exiting startup. n/a (Quartc change only) Merge internal change: 191659031 https://chromium-review.googlesource.com/c/chromium/src/+/1005809 Deflake NegotiatedInitialCongestionWindow by checking the value of the initial congestion window. n/a (Test only)` Merge internal change: 191635217 https://chromium-review.googlesource.com/c/chromium/src/+/1005836 Do not sending PROBING retransmissions when QUIC pipe-filling is enabled unless when there are unacked handshake packets. Merge internal change: 191615575 https://chromium-review.googlesource.com/c/chromium/src/+/1005449 Add GetPacketNumberLength, GetConnectionIdLength and IncludeVersionInHeader to QuicPacketCreator. n/a (refactor only) Merge internal change: 191583017 https://chromium-review.googlesource.com/c/chromium/src/+/1005448 Set the QUIC initial congestion window based on connection options in QuicSentPacketManager, rather than TcpCubicSenderBytes. Protected by FLAGS_quic_reloadable_flag_quic_unified_iw_options. Merge internal change: 191490391 https://chromium-review.googlesource.com/c/chromium/src/+/1005626 Add IsValidStatelessResetToken and OnIetfStatelessResetPacket to QuicFramerVisitorInterface. Add IsValidStatelessResetToken to QuicConnectionVisitorInterface. n/a (add unused code) Merge internal change: 191478833 https://chromium-review.googlesource.com/c/chromium/src/+/1005394 Change net/quic/quartc to use QuicMemSliceSpan. Merge internal change: 191341992 relnote: n/a (Quartc only) https: //chromium-review.googlesource.com/c/chromium/src/+/1005357 Change-Id: I444d6a8be23235abcab2a9d24fadc6d6e5e2e0f8 Reviewed-on: https://chromium-review.googlesource.com/1005563 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#550351}
-
Moe Ahmadi authored
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I723f6632b3708f86e25158f4065cb5d70590ffe6 Reviewed-on: https://chromium-review.googlesource.com/1010463Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550350}
-
Danyao Wang authored
Original review: https://chromium-review.googlesource.com/c/chromium/src/+/1006854 Using wpt-import in Chromium f7fd2525. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15475 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts TBR=danyao No-Export: true Change-Id: I6c70ccb059be8b9dbd6ca037176a39e79707eac2 Reviewed-on: https://chromium-review.googlesource.com/1010838Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#550349}
-
rbpotter authored
Bug: 821485, 822505 Change-Id: I33f117cd64726a475ef2df220f9a8089fd5e9312 Reviewed-on: https://chromium-review.googlesource.com/1000408Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#550348}
-
Christopher Cameron authored
Add functions to RWHNSViewClient to forward keyboard and Ime events. The messages that are forwarded during a keyboard event are forwarded to a RenderWidgetHost that is cached at the beginning of the event. This could potentially be different from the RenderWidgetHost to which other messages are forwarded. To ensure that behavior is preserved, bracket the lifetime of -[RenderWidgetHostViewCocoa keyEvent:] with calls that cause the RenderWidgetHostViewMac on the other side to save off the target RenderWidgetHost until the end of the function. Bug: 821651 Change-Id: I805aa282b05909604c62a12e4e82133c6aa0e554 Reviewed-on: https://chromium-review.googlesource.com/1005789Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#550347}
-
Kim Paulhamus authored
Since the current implementation doesn't support non-U2F authenticators, all non-U2F scenarios can be immediately denied with NotSupportedError. This CL also moves handling for empty allowCredentials (part of the aforementioned errors) out of u2f_sign, since u2f_sign should never be called with empty allowCredentials. Bug: 819256 Change-Id: I991949919fbe7a5e1e9c123ee750d80c3d25e9c3 Reviewed-on: https://chromium-review.googlesource.com/1006482 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550346}
-
Sammie Quon authored
1) Fix pin keyboard shifting when going from message to no message. 2) Fix loosing focus on input when clicking disabled backspace - it will also not loose focus anymore if anywhere on the PIN keyboard is clicked. 3) Fix no focus on input when directly going to lockscreen (chrome:settings/lockScreen). Test: manual Bug: 828450, 827948, 827126 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id64b80287c6667a419f186cf67d7b77c62cf02d1 Reviewed-on: https://chromium-review.googlesource.com/1006262 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#550345}
-
Eric Lawrence authored
The SameSite cookie specification calls for ignoring the SameSite attribute if the value is empty or unrecognized. Previously, Chrome would refuse to create a cookie with an empty or unrecognized SameSite attribute value. Bug: 635882 Test: net_unittests Change-Id: I429058d6f97db107307f9affb99bf96f4e175a2a Reviewed-on: https://chromium-review.googlesource.com/1007866 Commit-Queue: Eric Lawrence <elawrence@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#550344}
-
Roger McFarlane authored
Bug: 831755 Change-Id: I7b139dd05710afddb694bf962d93293f8ad6fc6e Reviewed-on: https://chromium-review.googlesource.com/1008304Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#550343}
-
Wei Li authored
Crash in pdf compositor service was hard to debug without knowing the content being printed. This CL added a new crash key "main-frame-url" to record the main frame url being printed, so we can try to reproduce the crashes with ease. Since the service is in a utility process, it doesn't have the printed url info, such info has to be passed in via IPC from browser process. BUG=822218 Change-Id: Ic18c3c70ebb04738f0802be6c2e3f37b1ed4293d Reviewed-on: https://chromium-review.googlesource.com/1005435 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
-
Fergus Simpson authored
Adds functions to get and set the brightness of a display. Optionally allows brightness to be changed smoothly. This will be an implementation-specific ramp. BUG=internal b/76421244 BUG=internal b/77479163 TEST=None Change-Id: I900b14321141ce1b3085e6bb986b180039f89244 Reviewed-on: https://chromium-review.googlesource.com/1000027 Commit-Queue: Fergus Simpson <afergs@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#550341}
-
Kevin Marshall authored
* external/wpt/html/syntax/parsing/html5lib_template.html?run_type=uri * virtual/gpu-rasterization/images/cross-fade-overflow-position.html TBR=shend@chromium.org,schenney@chromium.org Bug: 818324 Bug: 831993 Change-Id: I011bd7deb75b48c7572643a29d43f62a8a69ea6e Reviewed-on: https://chromium-review.googlesource.com/1010908Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#550340}
-
https://chromium.googlesource.com/catapult.git/+log/60096370137d..19b3dfed02a8 $ git log 600963701..19b3dfed0 --date=short --no-merges --format='%ad %ae %s' 2018-04-12 simonhatch Dashboard - Parse email list into a set. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I3571f1864c0e335d0fb6d15a708392cc6327359f Reviewed-on: https://chromium-review.googlesource.com/1010882 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550339}
-
sczs authored
- Navigates to a History entry when tapped by migrating the Legacy logic into the TableVC. - Cleans up the old implementation of HistoryTableViewControllerDelegate and moves it to its own file. - Some small cleanup and adds ContextMenu methods comments. Bug: 805190 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icf059e1ec9ec557ed8ea4e22eb46a813c1abe53a Reviewed-on: https://chromium-review.googlesource.com/999262 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#550338}
-
Victor Costan authored
The _version field of Port instances is "retina" on Mac machines with HiDPI displays. The MacPort implementation of path_to_apache_config_file currently uses that field to switch between Apache configurations that use PHP 7 (for 10.13) and PHP 5 (for lower versions). The current implementation worked because Retina detection was broken on Mac 10.12 and above. However, https://crrev.com/c/957306 fixed Retina detection, so run-blink-httpd is currently broken on Mac 10.13 with Retina. This CL gets the OS version information from host.platform.os_version, which is not overridden with "retina" on HiDPI displays. Change-Id: I377559466c8c4d0a3e99edcc7cf1ccce49cdc123 Reviewed-on: https://chromium-review.googlesource.com/1010035Reviewed-by:
-
Krishna Govind authored
R=cmasso@chromium.org Change-Id: I6b2835b58bae96363046c231fff6a014e49c75a6 Reviewed-on: https://chromium-review.googlesource.com/1011142Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#550336}
-
Jay Civelli authored
In preparation for the move of the zygote code from content/ to services/service_manager, moving the content specific presandbox initialization code to from zygote_main to ContentMainRunner. Bug: 831846 Change-Id: I4c2f160039f21bd1814d1bd9d3fd6664bbb0cf17 Reviewed-on: https://chromium-review.googlesource.com/1008865Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#550335}
-
Xianzhu Wang authored
This is a reland of 2d526f29 Was reverted because it caused crbug.com/832020 which is a crash in the following case: <div style="width: 0; height: 0; box-shadow: 0 5.5px"></div> The div has zero size and visual effect outset on one side only, so the overflow is still zero and doesn't create OverflowModel. Original change's description: > [PE] Let visual rect cover sub-pixel visual effect outsets > > If an overflowing visual effect has sub-pixel geometry and is painted > with anti-aliasing along pixel-snapped border box, the pixel-snapping > may cause the anti-aliased edge overflow the calculated visual rect. > > Let LayoutBox::VisualRectOutsetForRasterEffects() return 1 if there are > any sub-pixel visual effect outsets to ensure the visual rect covers > all pixels. > > Bug: 827516 > Change-Id: I48f8350fb2124d002333a4cc76486c63ca55f8c9 > Reviewed-on: https://chromium-review.googlesource.com/1003492 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Florin Malita <fmalita@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550014} Bug: 827516, 832020 Change-Id: I4e7831d7d91cc541127670ac102ec0292ae50387 Reviewed-on: https://chromium-review.googlesource.com/1010583Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#550334}
-
liberato@chromium.org authored
To facilitate adding new features, VideoDecodePerfHistory and related clases now take a mojom::PredictionFeatures struct which wraps the old values. Similarly, the resulting predictions are wrapped up as PredictionTargets for symmetry. Change-Id: Ic204aa8e66cc66090962acb65e7fcd250c123ce2 Reviewed-on: https://chromium-review.googlesource.com/975993Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#550333}
-
Kevin Marshall authored
This reverts commit 8c5544c2. Reason for revert: Breaks https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5174 Could be due to WideFrameView lacking an export directive? Original change's description: > Add WideFrameView class > > This will be used for ARC++ windows. This > a) is always placed at the topof the display and covered full width. > b) supports immersive mode > c) is resized when the display metrics changes. > > BUG=b/33693796 > TEST=covered by unittest > > Change-Id: I27c8e9d27b673b5f85ff6992380c8ea707d3ea55 > Reviewed-on: https://chromium-review.googlesource.com/990203 > Reviewed-by: Jun Mukai <mukai@chromium.org> > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550278} TBR=mukai@chromium.org,oshima@chromium.org Change-Id: I31847f2485f5e8b0f70cf2342991596863f097f6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/33693796 Bug: 832275 Reviewed-on: https://chromium-review.googlesource.com/1010843 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
-
Troy Hildebrandt authored
LBL#finishUrlFocusChange calls UrlBar#scrollToTld directly, which isn't behind the protective if check of scrollDisplayText. This patch makes all the scrolling methods in UrlBar private except for scrollDisplayText to ensure we perform this safety check, and instead we only call scrollDisplayText from #finishUrlFocusChange if the scrollType is SCROLL_TO_TLD to ensure the behavior is the same as before. Bug: 831472 Change-Id: Ib44e582a571bd5a45a2921581f4b2d2c1c388024 Reviewed-on: https://chromium-review.googlesource.com/1008279 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#550331}
-
sebsg authored
A classic example that will now support is filling a Canadian profile into a page where the default country was the US. When the country changes, some sites change the "state" field to a "province" field. Bug: 831661 Change-Id: Iec0deb5ab69f554756a75dd4e893f3535c6bfc06 Reviewed-on: https://chromium-review.googlesource.com/1010528Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#550330}
-
Ian Vollick authored
Short-circuiting tree walks can cause subtle issues. This CL introduces a variable to make it trivial to disable. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6af5f8c0c1b96c88c3c64f366b610e876e34d9c9 Reviewed-on: https://chromium-review.googlesource.com/1008522Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#550329}
-
Eric Lawrence authored
Devtools keybindings to Actions are not disabled when the associated command is disabled. The recently added Focus Debuggee command used F12 as a key binding but this had undesirable behavior when the DevTools were docked in the browser window. This CL removes the F12 key binding. Bug: 821285 Change-Id: I6acd66e01ba9a8ef3a8a082bd18e7da569ff347f Reviewed-on: https://chromium-review.googlesource.com/1010469 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
-
John Chen authored
Remove a workaround that is no longer needed in Chrome 67 and above. This workaround caused ChromeDriver to return too early, while iframes are still loading. Bug: chromedriver:2198 chromedriver:2350 Change-Id: I7e070cd02a4798b72315b6ba8f904567907eeba5 Reviewed-on: https://chromium-review.googlesource.com/1005618Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#550327}
-
Daniel Park authored
Bug: 832212 Change-Id: If9f76cf12ac58c8367c16275796acd2e38847051 Reviewed-on: https://chromium-review.googlesource.com/1010837Reviewed-by:
-
Xiaoqian Dai authored
See https://drive.google.com/file/d/1XFKAracGq63nmlE9yIambuS0WhzVt8YS/view for the spec. Bug: 827730 Change-Id: I61f7bb183c618567a3fc38bfefbffec358071284 Reviewed-on: https://chromium-review.googlesource.com/1008868 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#550325}
-
Pavel Feldman authored
Bug: 830526 Change-Id: I12665a63034f0a9ec5f628874b0af49194027668 Reviewed-on: https://chromium-review.googlesource.com/1006269Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#550324}
-
Hongchan Choi authored
As this discussed in the issue[1], use scoped_refptr<base::SingleThreadTaskRunner> instead of directly accessing the worklet thread. By fetching a per-global-scope task runner from the WorkerThread (that backs AudioWorkletThread), we can guarantee safe operation when the global scope is running. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=822725#c10 Bug: 822725 Test: The repro case in the bug does not crash anymore. Change-Id: I6fa00b342f3050b9b1197e257b0a9fb16c280117 Reviewed-on: https://chromium-review.googlesource.com/971445 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550323}
-
Pavel Feldman authored
Bug: 831087 Change-Id: Ife9e0fde092818be3c08c4e7fde2cd55bcfd4cef TBR: dgozman Reviewed-on: https://chromium-review.googlesource.com/1005360Reviewed-by:
-
Quinten Yearsley authored
This reverts commit 0d5e3630. Reason for revert: The tests that were failing after the first time landing this have now been removed (crbug.com/825837). R=eyaich@chromium.org Bug: 825837 Change-Id: Ibbd16ba0976863870ebb4cb00fc72a6bae3b9e0e Reviewed-on: https://chromium-review.googlesource.com/1005738Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#550321}
-
Dave Tapuska authored
Don't evict frames when the width doesn't change to avoid a few frame repaints that are completely blank. When the size is expanded only the area that doesn't exist in the old frame appears black. This is less jarring to the user and appears as less jank. BUG=831656 Change-Id: I787e10d277ffa08ddedd080efa76b984df92c1e1 Reviewed-on: https://chromium-review.googlesource.com/1008245 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#550320}
-
Andrey Lushnikov authored
This patch starts fetching mime type from the subrequest, if any. R=caseq Change-Id: Ic3ca487fa7ee80f5d8a1bcc270f7d7120fee8fc5 Reviewed-on: https://chromium-review.googlesource.com/1010415 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#550319}
-
