- 30 Oct, 2017 11 commits
-
-
Zhenyao Mo authored
Otherwise event observer like SystemInfoHandler could be stuck and time out. BUG=778680,744658 TEST=bots, perf tests TBR=piman@chromium.org,kbr@chromium.org,nednguyen@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I35dbc51f83ff1f1592e46152ec4a5c47f8b4376a Reviewed-on: https://chromium-review.googlesource.com/743041 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#512435}
-
Raymes Khoury authored
Currently we check the feature policy for midi in the PermissionService. This means that we can't easily return a specific error message for denial due to FP. Also, several permission features do not use the PermissionService codepath and need to be checked individually anyway, so it seems more appropriate to do this for all permissions. This CL adds these checks to NavigatorWebMIDI.cpp. It also logs a console warning when the feature is disabled to help inform developers. Furthermore, a UseCounter counts how many times the feature has been blocked due to Feature Policy. This CL was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/739882 because it broke layout tests on the site isolation bots. This issue has been worked around, see crbug.com/779433. Bug: 689802 Change-Id: I3ce66d6dc7dec644d8c11f23001ca73558970bf0 Tbr: timloh@chromium.org, toyoshim@chromium.org Reviewed-on: https://chromium-review.googlesource.com/743142Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#512434}
-
junweifu authored
Load com base functions dynamically at runtime with core_winrt_util. Request face detection failed if it's not supported. Add unittest and make sure work in win10 bots with using win10_chromium_x64_rel_ng in PRESUBMIT.py . Link Face Detection demo[2] here. Split original large CL[1] up in smaller subpatches including this CL. [1] https://chromium-review.googlesource.com/c/chromium/src/+/708336 [2] https://codepen.io/miguelao/pen/PmJWro BUG=767021 Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ice003ac398379b60e0668c14a7cec75195be0441 Reviewed-on: https://chromium-review.googlesource.com/724745 Commit-Queue: Junwei Fu <junwei.fu@intel.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#512433}
-
Bugs Nash authored
Since methods change between header files, blank lines between methods were adding excessive whitespace. Diff of generated files: https://gist.github.com/BugsNash/132e77773a10adc029123fa39b630e1a/revisions NB generated diff for ComputedStyleBase.cpp should be ignored, these are not due to this patch but are the result of a non deterministic bug Bug: 545324 Change-Id: Icc402d76690ea0c4ac5a424e2beb8f017df884f5 Reviewed-on: https://chromium-review.googlesource.com/743161Reviewed-by:
meade_UTC10 <meade@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#512432}
-
John Z Wu authored
Nothing will be compiled yet. Bug: 763797 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2fd69181b3bbb36bcb913dd540bcc9e8ef37454d Reviewed-on: https://chromium-review.googlesource.com/741091Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#512431}
-
Darren Shen authored
CSSParserObserverWrapper was used as an interface between CSSParserObserver and CSSParserTokenRanges for inspector parsing. Since we no longer use CSSParserTokenRanges for inspector parsing, we can delete this class and use CSSParserObserver directly. Bug: 661854 Change-Id: I099e2db34437ce666274508396f1e6eb9915382c Reviewed-on: https://chromium-review.googlesource.com/688974 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#512430}
-
Yuzhu Shen authored
BUG=777028 Change-Id: I7b77f86990dc65998927a264bd8165570b7d04fa Reviewed-on: https://chromium-review.googlesource.com/734209Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#512429}
-
Raymes Khoury authored
Currently we show deprecation warnings for mic/camera when they are disabled by feature policy in cross-origin iframes. However, once we enable Feature Policy for mic/camera an error will automatically be logged at the point where permission is requested. This is more accurate as currently it's possible to show the warning even when the feature policy has no impact on the function call (for example when the user is using getUserMedia for desktop capture). Although we remove the warning, we add some use counters to count the cases where mic/camera are requested while feature policy is disabled. Bug: 689802 Change-Id: I2a1ddc5b1a77357cde222352ad0d0268c32d447f Reviewed-on: https://chromium-review.googlesource.com/725004 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#512428}
-
Jon Napper authored
This patch adds missing well-known conflicting language codes. It also changes the lookup from a linear search to a binary search to improve performance (a previous version caused a performance regression). Bug: 765006 Change-Id: I0271eb620d0f412f168b4767de584e4896f86693 Reviewed-on: https://chromium-review.googlesource.com/727779 Commit-Queue: Jon Napper <napper@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#512427}
-
Joel Einbinder authored
Bug: 775261 Change-Id: I33e5131e8b922868881d44da864931ae80b4700f Reviewed-on: https://chromium-review.googlesource.com/727019Reviewed-by:
David Vallet <dvallet@chromium.org> Commit-Queue: David Vallet <dvallet@chromium.org> Cr-Commit-Position: refs/heads/master@{#512426}
-
marcin authored
Bug: Change-Id: If2a9409b0f1db115e67cb63d7adea4634ab574e9 Reviewed-on: https://chromium-review.googlesource.com/736729 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#512425}
-
- 29 Oct, 2017 12 commits
-
-
Trent Apted authored
Under MD, the close button takes up more vertical space than the dialog title, so it dominates the title insets. Make the test work for both by removing the close buttons from the layout. Bug: 713030 Change-Id: Ibead5d002dcbe36d6fda65a3a9a8e01695e4f1a8 Reviewed-on: https://chromium-review.googlesource.com/741381 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#512424}
-
dpapad authored
Bug: 775479 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I94f5f9d189edcf81f2087f60e5a118824874fad4 Reviewed-on: https://chromium-review.googlesource.com/742650Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#512423}
-
Matt Menke authored
In particular, switch them to using the EmbeddedTestServer from URLRequestFilter, which required them to be in the same process as the network stack. Bug: 776589 Change-Id: I4fd64fa427adedfd383dee8f86c21c4955d7f3eb Reviewed-on: https://chromium-review.googlesource.com/731523 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#512422}
-
Mark Mentovai authored
fbc365fa9ed5 GCC 7.2 support (-Wnoexcept-type) 2f481590112b Make crashpad_util_test build without warnings with clang- cl on Windows b96b9f627ee7 win: Use test::ErrorMessage() in test::ChildLauncher 52d766400da1 linux: ProcessReader can own ProcessMemoryLinux without unique_ptr 9bc5989125b8 crashpad_util_test warning fixes for clang-cl, 64-bit edition 34699d378b82 Create client data structures for typed Annotations 5e9ed4cb9f69 win: Dynamically disable WoW64 tests absent explicit 32-bit build output cb3aa9c4d8f3 DumpAndCrash in extended handler test in favor of debug break c49da9caef30 win: Expect uneven symbolic link support 1dae919b7e5a #include "base/logging.h" in client/annotation.h for DCHECK() ef262d1ee3c2 #include "build/build_config.h" where needed 672c87258912 Upstream crashpad_util_test-in-Chromium changes 692488a254c4 Un-disable WinMultiprocess-based tests in Chromium 3fae8ff07c09 win: Fix -Wsign-compare warnings produced by clang Change-Id: I4b1355afce8be5571af3582f7dd0057b5018d70f Bug: crashpad:204, crashpad:205 Reviewed-on: https://chromium-review.googlesource.com/742284 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#512421}
-
Weidong Guo authored
Changes: Move caps lock key handling from accelerator controller to event_rewriter_chromeos.cc. As an accelerator key, caps lock is always consumed before it is sent to web app (e.g. CRD) or browser tab (keyboard event viewer). So we handle it in event rewriter and do not stop propagating it. BUG=775743 Change-Id: Ib3eb29cb4be023142b0d402d7c56015a7197bc14 Reviewed-on: https://chromium-review.googlesource.com/740090Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#512420}
-
Philip Rogers authored
This patch rebaselines 11 passing tests. These baselines now match the non-RLS path. The updated expectations were generated by copying the non-RLS expectation and adjusting for the scrolling layer differences. Change-Id: Ib2893dc3a16562306cd95ab34ca761a314edab02 Reviewed-on: https://chromium-review.googlesource.com/742455 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#512419}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/ed6ae56e0ee8..2d8d196318a6 $ git log ed6ae56e0..2d8d19631 --date=short --no-merges --format='%ad %ae %s' 2017-10-29 update-skps Update SKP version Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: If9bb4e65bbc2dbfa81b416c4ff4365cc6ba66c09 Reviewed-on: https://chromium-review.googlesource.com/742367Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#512418}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/c7b18fef19ff..6bfac0383f34 $ git log c7b18fef1..6bfac0383 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7148eabccc784c9ae22a35a070870cfc0206c432 Reviewed-on: https://chromium-review.googlesource.com/742213Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#512417}
-
chrome-release-bot authored
TBR=amineer@chromium.org Change-Id: I054ccd393fa6bc7bbe9609f76b6b1d33ca42bd99 Reviewed-on: https://chromium-review.googlesource.com/742477Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#512416}
-
Kinuko Yasuda authored
ServiceWorker wants to pass several params for subresource-loader setup in the renderer that are not URLLoaderFactory, because it needs to create URLLoaderFactory in the renderer. Currently we pass them via a separate Mojo call but it causes racy situation and makes tests flaky. This change introduces SubresourceLoaderParams struct (that has URLLoaderFactoryInfo as a member) and pass it along from navigation request handlers instead of URLLoaderFactoryInfo. This CL also slightly changes how WebUI subresource loader factory is passed; to make it share more code with AppCache etc. Bug: 778898 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: Iafe0e2f7bd8f6c500c91bde3c46dff3d4d7dd8c8 Reviewed-on: https://chromium-review.googlesource.com/739621Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#512415}
-
Weidong Guo authored
BUG=777029 Change-Id: I691c4ea2e59f39645bb9725d6b59ee90809ae076 Reviewed-on: https://chromium-review.googlesource.com/742207Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#512414}
-
Lei Tian authored
Add return value for CustomTabBottomBarDelegate.showRemoteViews() so that client can know CCT bottom bar population fails. Bug: 729134 Change-Id: Ie0e8f3522d3ad96a2cf21f30c76579e5bb5a7979 Reviewed-on: https://chromium-review.googlesource.com/707737Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Lei Tian <ltian@google.com> Cr-Commit-Position: refs/heads/master@{#512413}
-
- 28 Oct, 2017 17 commits
-
-
Vaclav Brozek authored
This CL adds a reauthentication step before the user is asked to even select a file for exporting passwords to. Bug: 700003 Change-Id: Ie89529a27ce86ed74b0b3c98bf56abefb1a52899 Reviewed-on: https://chromium-review.googlesource.com/739661Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#512412}
-
Manish Jethani authored
Previously @keyframes rules in style sheets injected by extensions were managed in ScopedStyleResolver along with other author rules. With crrev.com/c/641294 we started treating these injected style sheets as user style sheets and moved the management of such rules to StyleEngine. This patch fixes a regression caused by this change whereby StyleResolver is no longer able to find @keyframes rules from these style sheets. StyleEngine now maintains a map of animation names to their corresponding @keyframes rules found in user style sheets. If StyleResolver is unable to find a given @keyframes rule among its author rules, it looks it up in StyleEngine next. BUG=632009,776661 Change-Id: I90462a0721cc75da14ee041c1a70736e4df99fb8 Reviewed-on: https://chromium-review.googlesource.com/735263Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#512411}
-
Vaclav Brozek authored
PasswordsPrivateDelegateImpl is the only client of PasswordManagerPresenter which uses the presenter's reauthentication methods. (PasswordUIViewAndroid bypasses the presenter.) To clarify the structure and exclude the Android usage more naturally than through NOTREACHED() calls, this CL moves the reauthentication methods into PasswordsPrivateDelegateImpl. To preserve testability, PasswordsPrivateDelegateImpl's unit test needs to be extended to be able to observe routed events. This caused a refactoring into a custom-fixture-using test for all the existing tests as well. Bug: 700003 Change-Id: I91b7276cc279473c6e3566c080cfec523965fb0a Reviewed-on: https://chromium-review.googlesource.com/741981Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#512410}
-
Finnur Thorarinsson authored
Bug: 734095 Change-Id: I48d891332bdd25ebc945d64b86c601600369d2d0 Reviewed-on: https://chromium-review.googlesource.com/735862 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#512409}
-
Xiaohan Wang authored
Based on the failure volume on Canary channel, choose to crash with a 1/10 probablity on this particular error. We also differentiate between the case where encrypted media init data has been reported or not. This is not equivalent to clear/encrypted playback, but should be close enough for bug investigation purposes. This CL also does minor cleanup (reordering) in SourceBufferState. The crash CHECK will be reverted in a few days after we collect enough crash reports. The CL to revert the crash CHECK is prepared at https://chromium-review.googlesource.com/c/chromium/src/+/742229 PSA: If this is causing too many crashes, feel free to CQ the above revert CL at any time! BUG=778363 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1b5f1343a0e7ec18261b6e0ad1dac6740339ff83 Reviewed-on: https://chromium-review.googlesource.com/739743 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#512408}
-
Vaclav Brozek authored
This CL moves the ownership of PasswordManagerPorter up from PasswordManagerPresenter to the owner of the presenter. It also makes PasswordManagerPresenter forget about the porter and lets PasswordsPrivateDelegateImpl call the PasswordManagerPorter methods directly, bypassing PasswordManagerPresenter. This removes the confusing dependency cycle between PasswordManagerPorter and PasswordManagerPresenter. Bug: 700003 Change-Id: I9ab4f45adc7dba3be083fa0a94ec3daceaa14eef Reviewed-on: https://chromium-review.googlesource.com/739384Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#512407}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/c543f3e03f6b..ed6ae56e0ee8 $ git log c543f3e03..ed6ae56e0 --date=short --no-merges --format='%ad %ae %s' 2017-10-28 fmalita Re-land: Stop using fixed point recs for gradient positioning info Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: I097133e99efa0c67df35c9220458c398e2474842 Reviewed-on: https://chromium-review.googlesource.com/742234Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#512406}
-
Chris Harrelson authored
It's important for a paint offset root to be set to a LayoutObject when it has any kind of transform. Paint offset roots are tied to the paint offset transform in the code structure, so it is simpler and easier to understand to always allocate it. The optimization this CL removes had an unclear performance benefit as well, which is another reason to be willing to remove it. Bug: 771300 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Idd6d32f8d58872f0e7f25040631990fe78277887 Reviewed-on: https://chromium-review.googlesource.com/741038 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#512405}
-
Miguel Casas-Sanchez authored
This CL creates a new va_surface.cc to accompany the existing va_surface.h, and moves into it the existing methods out of vaapi_wrapper.cc which is already large enough. ** No new code is intended except: added a DCHECK and a few consts. ... but just in case: TEST=compile a simplechrome with the patch, deploy to soraka, then navigate to crosvideo2.appspot.com, reproduce e.g. VP9 1080p, and verify in chrome://media-internals that GpuVideoDecoder is used (and, of course, that the reproduction is as good as w/o the patch). Bug: 778093 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If778645dba01600f63d1e857a5c9c76f761f0fda Reviewed-on: https://chromium-review.googlesource.com/740041Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#512404}
-
Hector Carmona authored
Bug: 764125 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib37d34dc82f7ee8bcdc0e050fbc6e7d5c2993abb Reviewed-on: https://chromium-review.googlesource.com/738635Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#512403}
-
Lei Zhang authored
The ASAN failure has been fixed. BUG=757243 Change-Id: I64867f85503aab620d51b6bd2b7a911c31c6bd22 Reviewed-on: https://chromium-review.googlesource.com/741543Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#512402}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/6a5c6f6f5b90..c7b18fef19ff $ git log 6a5c6f6f5..c7b18fef1 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None,None Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1fe66dedef42b412f8e0939965ba25dc493e4ee6 Reviewed-on: https://chromium-review.googlesource.com/742748Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#512401}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/5d7fd19c209f..6a5c6f6f5b90 $ git log 5d7fd19c2..6a5c6f6f5 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5f69213e24219bb632e68e42c31047dc313fc54a Reviewed-on: https://chromium-review.googlesource.com/742352Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#512400}
-
W. James MacLean authored
GuestViewMessageFilter::OnAttachToEmbedderFrame() up until now assumed the guest was created with the WebContents* that will be the final owner. This works for WebViews created in static HTML or from JS in the embedder, but can fail if window.open is used, and the embedder web contents may be created along with the new window. This function should instead look up the embedder WebContents* from the provided embedder local frame id, and use that to override in the call to GuestViewBase::WillAttach(). Bug: 777839 Change-Id: I4a33ecf3aaab6dbd645835191247670a3dccd1f3 Reviewed-on: https://chromium-review.googlesource.com/738278 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#512399}
-
Sebastien Marchand authored
This is a follow up on crrev.com/38f2e322 This CL does several things*: - It greatly simplify the logic in SwapThrashingMonitorDelegateWin: As suggested by wez@ the observation window now looks at how many samples are above a certain threshold rather than looking at the average page-fault rate over an interval of time. This average rate was really affected by the small burst in paging and this was causing a lot of unwanted switch to the suspected state. The delta on this CL isn't displayed properly, swap_thrashing_monitor_win.h has been renamed to swap_thrashing_monitor_delegate_win.h and the SampleWindow subclass now replace the PageFaultAverageRate one. - It introduce the monitor that owns this delegate. The monitor is responsible of calling the delegate at regular intervals to sample the state of the system. - It emits some new metrics to record how much time is spent in each state and how often the system transition from one step to another. * Sorry for sending this a one big CL... The timezone difference will really slow down the release of this if I split it into too many smaller CLs (and there's only a few days left for me to work on this). Bug: 771478 TBR: chrisha@chromium.org Change-Id: I8aa5c8fd2c768a3e1ad0c387a67c7205db5da37a Reviewed-on: https://chromium-review.googlesource.com/738072 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#512398}
-
Quinten Yearsley authored
Reason: Currently of the blink_rel try bots, the mac bots are the slowest. Bug: 772335 Change-Id: I087fbd652c6e11d2d884905859f13e1601d0dbe5 Reviewed-on: https://chromium-review.googlesource.com/737415Reviewed-by:
Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#512397}
-
Ramin Halavati authored
To correctly classify images to those suitable for color inversion and those not, we need to detect if some part of the image is static background and ignore it while sampling from the image. This is because frequently there are images with very large static background and some small foreground. Sampling uniformly from the whole image results in very few samples from foreground and most samples from the large background, and this skews the classifier towards inversion, while the decision must be taken based on the foreground area. Bug: 685242 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5b7bd9d2ed1b52913684e7ba2fdc6a2fd0e4a46a Reviewed-on: https://chromium-review.googlesource.com/720375Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#512396}
-