Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 15 Dec, 2017 28 commits
  3. 14 Dec, 2017 12 commits
    • Ahmed Fakhry's avatar
      Remove unused MD Feedback strings. · 04c34dcc
      Ahmed Fakhry authored 
      The MD Feedback app was killed and all related code was removed
except those strings.

BUG=none

Change-Id: I321085aa99a5d2e9a9c48174231019eb18f069f9
Reviewed-on: https://chromium-review.googlesource.com/826470Reviewed-by: default avatarapacible <apacible@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524235}
      04c34dcc
    • Jared Saul's avatar
      Update waterfall testing config for new Chrome Upstream launches · db75f306
      Jared Saul authored 
      Make the following changes:

* Remove AutofillUpstreamShowGoogleLogo and AutofillUpstreamShowNewUi.  The code has been updated to make those default.
* Add Mac to AutofillUpstreamRequestCvcIfMissing in preparation of the M64 launch.
* Add config for AutofillUpstreamSendDetectedValues and AutofillUpstreamSendPanFirstSix, part of the Upstream Partial Data Project targeting M65.

Bug: 736944, 789645, 793490
Change-Id: If6888d203dbceb3dcba8d38184244375c9cb110a
Reviewed-on: https://chromium-review.googlesource.com/827631Reviewed-by: default avatarMark Pearson <mpearson@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#524234}
      db75f306
    • Greg Kerr's avatar
      macOS V2 Sandbox: Sandbox utility processes. · c382e2ae
      Greg Kerr authored 
      This sandboxes utility processes with the V2 sandbox on macOS.

Bug: 689306
Change-Id: Ie7cca11834f060a4c0f59862f68de95c79893288
Reviewed-on: https://chromium-review.googlesource.com/817515Reviewed-by: default avatarRobert Sesek <rsesek@chromium.org>
Reviewed-by: default avatarNasko Oskov <nasko@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524233}
      c382e2ae
    • Jian Li's avatar
      Add the method to check if offline archive is in internal dir · 9f6510f2
      Jian Li authored 
      Bug: 758690
Change-Id: I8bb4283fc40a87fa7a87df2c7e513e2e16903290
Reviewed-on: https://chromium-review.googlesource.com/828049Reviewed-by: default avatarFilip Gorski <fgorski@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524232}
      9f6510f2
    • Doug Arnett's avatar
      Adds new observer method to DRPDataUseObserver for DidFinishLoad · 0959654c
      Doug Arnett authored 
      This is plumbing preparation for estimating data savings for the
NoScript preview (determined when page load finished event occurs).

Bug: 781885
Change-Id: I145b9d270327c757ea1fbfbc44aa5932822c592e
Reviewed-on: https://chromium-review.googlesource.com/820891
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: default avatarrajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524231}
      0959654c
    • Reilly Grant's avatar
      Switch //services/device/hid to use base::RefCountedBytes · 5911ee14
      Reilly Grant authored 
      This patch changes //services/device/hid to use base::RefCountedBytes
instead of net::IOBuffer and net::IOBufferWithSize. This has a couple
advantages:

1) base::RefCountedBytes always has a size which means in a follow-up
   patch we can stop passing separate length parameters.

2) base::RefCountedBytes is convertable to and from an
   std::vector<uint8_t> which reduces the mismatch between the C++ and
   Mojo interfaces.

3) base::RefCountedBytes holds unsigned data which is more correct for
   managing buffers (operations on signed values lead to bugs).

This patch makes as few changes as possible to effect this conversion.
Follow-up patches will take more advantage of the above to further
simplify the code.

Change-Id: I290b0415f74c0551f52bd59120a3c6012315681d
Reviewed-on: https://chromium-review.googlesource.com/798018
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: default avatarJun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524230}
      5911ee14
    • Shivani Sharma's avatar
      HttpCache - Writers and Readers should be mutually exclusive. · 7ed8d6eb
      Shivani Sharma authored 
      There is a combination of simultaneous transactions for an entry, namely
a READ transaction followed by a READ-WRITE transaction that was
violating the mutual exclusiveness of Readers and Writers. This violation
was happening even less frequently because the second transaction being
READ-WRITE can only happen for a range request. This CL fixes the
issue.
HttpCache.RangeGET_DoNotCreateWritersWhenReaderExists

TEST: net_unittests --gtest_filter=
Bug: 792818
Change-Id: I3a98fb8de2cd521210077e4baf9460fe91232eec
Reviewed-on: https://chromium-review.googlesource.com/825802Reviewed-by: default avatarRandy Smith <rdsmith@chromium.org>
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524229}
      7ed8d6eb
    • Peter Collingbourne's avatar
      Remove dependencies on ANGLE libraries from two targets. · 9e668e52
      Peter Collingbourne authored 
      These targets no longer directly depend on OpenGL symbols. These
days, the dependency on ANGLE (and SwiftShader) is achieved via a
data dependency from //ui/gl:gl.

This change is necessary in order to prevent the ANGLE libraries from
being loaded into a process as a result of a hard link-time dependency,
resulting in failures in the SwiftShader library. Normally, the lack of
a direct dependency on any of the symbols defined by ANGLE prevents a
link-time dependency from being created. But when ubsan is enabled,
it causes additional runtime library symbols to be exported from
each DLL. If one of those symbols is used in the main executable as a
result of ubsan instrumentation, it can create a link-time dependency
on an arbitrarily chosen (as a result of link order) DLL, which could
happen to be one of the ANGLE libraries. This will cause the following
to happen:

- The program loads SwiftShader libEGL.dll using the code in
  ui/gl/init/gl_initializer_win.cc.
- SwiftShader libEGL.dll tries to find SwiftShader libGLESv2.dll by
  calling GetModuleHandleEx [1], but it ends up finding ANGLE
  libGLESv2.dll because it was loaded first.
- SwiftShader tries to find the symbol libGLESv2_swiftshader in that
  DLL [2], but fails because the symbol is not exported from ANGLE
  libGLESv2.dll.
- All subsequent OpenGL calls fail.

[1] https://cs.chromium.org/chromium/src/third_party/swiftshader/src/Common/SharedLibrary.hpp?l=74
[2] https://cs.chromium.org/chromium/src/third_party/swiftshader/src/OpenGL/libGLESv2/libGLESv2.hpp?l=313

Bug: 507755
Change-Id: I67b75bb6eba062e82744268a551e2744afb6cbb8
Reviewed-on: https://chromium-review.googlesource.com/826544Reviewed-by: default avatarAntoine Labour <piman@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524228}
      9e668e52
    • Tim Brown's avatar
      Remove libdconf and libgconf from dependencies · 78a3d474
      Tim Brown authored 
      Use of gconf has been removed, and we depend on gsettings (in libgio)
instead of dconf directly.

Bug: 768027
Change-Id: Iec222f01577d3ffe10ee4a31345030d765eaefb4
Reviewed-on: https://chromium-review.googlesource.com/827921Reviewed-by: default avatarThomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524227}
      78a3d474
    • Yuly Novikov's avatar
      Conditionally link ANGLE statically into Android Chrome · 09d09f46
      Yuly Novikov authored 
      When use_static_angle is set

BUG=726002

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4d716a48002f03af29a0280cd9207460e470143d
Reviewed-on: https://chromium-review.googlesource.com/822952Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524226}
      09d09f46
    • Yuri Wiitala's avatar
      Refactor CursorRenderer for new VIZ tab/window capture impl. · a05fe420
      Yuri Wiitala authored 
      In preparation for the newer capture impl, content::CursorRenderer and
content::WindowActivityTracker have been merged into a single
CursorRenderer class that monitors platform views for mouse activity.
The client interface for CursorRenderer has been simplified, with added
support for: a) Changing the view being monitored without having to re-
instantiate a new CursorRenderer; b) Rendering the mouse cursor on the
VideoFrame from any thread (to avoid unnecessary hops to the UI thread);
and c) A callback to notify when the mouse cursor in the video needs to
be updated.

As a result of this refactoring, a few minor behavioral bugs were fixed.
Now, for tab capture, the mouse cursor should hide after 2 seconds of no
movement; as was intended.

TBR=nick@chromium.org

Bug: 754872
Change-Id: Iaab12fbd397d9034d9044e39c19a45f0cc88e9cf
Reviewed-on: https://chromium-review.googlesource.com/818730
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: default avatarXiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524225}
      a05fe420
    • Christopher Cameron's avatar
      viz/mac: Plumb CALayerParams to the browser process under viz · baa8c41c
      Christopher Cameron authored 
      The motivation for this change is a difference in behavior between
macOS and other platforms.

  On non-macOS platforms, once the output surface has been created,
  calling SwapBuffers on the output surface will cause content to appear
  in the window created in the browser process.

  On macOS, SwapBuffers generates parameters that then must be sent back
  to the browser process (more generally, wherever the NSWindow lives),
  in order for the content to be displayed on-screen.

  These parameters are stored in the CALayerParams structure. They are
  consumed by the ui::CALayerFrameSink interface (which, given a
  gfx::AcceleratedWidget and CALayerParams, will show the described
  content in the specified gfx::AcceleratedWidget).

Prior to this change, content::GpuOutputSurfaceMac would reach directly
over to ui::CALayerFrameSink. This doesn't work in viz, because the viz
equivalent (viz::GLOutputSurfaceMac) lives in the GPU process.

This change plumbs these CALayerParams back to the browser process, via
a new priviledged DisplayPrivateClient interface.

Note that creating a new DisplayPrivateClient interface is chosen over
repurposing the existing CompositorFrameSinkClient interface because
CompositorFrameSinkClient is not specific to an output display. The
feedback from the new DisplayPrivateClient will also be used in MacViews
in the future to ensure that NSWindows are not placed on-screen until
they have content available.

A stub DisplayPrivateClient is used by ui::ws::VisHostProxy, which will
need to be fleshed out for mus on macOS.

The DisplayPrivateClient for DirectLayerTreeFrameSink is left as nullptr
on Android (and other locations) for now. This interface should be made
non-optional in the future.

R=sadrul,tsepez,fsamuel
TBR=avi (content/)

Bug: 772576
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Id5e873cf18ef17e86dc26fd61e17705e94274015
Reviewed-on: https://chromium-review.googlesource.com/820630
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: default avatarFady Samuel <fsamuel@chromium.org>
Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: default avatarTom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524224}
      baa8c41c