- 15 Feb, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0613361e6c4f..abcac71093c8 Created with: gclient setdep -r src-internal@abcac71093c8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9cb694128e318e82d7c31001ac270c3716b28a89 Reviewed-on: https://chromium-review.googlesource.com/c/1474978Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632714}
-
Nick Burris authored
The resize corner was only getting properly scaled when a scrollbar was present, since Scrollbar::ScrollbarThickness() uses ChromeClient::WindowToViewportScalar() to scale its thickness[1], whereas ScrollbarTheme::ScrollbarThickness() does not[2]. This patch properly scales the resize corner in the case where there is no scrollbar present. [1] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/scroll/scrollbar.h?l=111&rcl=acee82f7b5654353a98f7b739c25d428642e8f82 [2] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/scroll/scrollbar_theme.h?l=61&rcl=b722ee8240e66004b021a1421d548bf10367b311 Bug: 884575 Change-Id: I3a7e0b4134928ea40be625fa1f64c05ed9490620 Reviewed-on: https://chromium-review.googlesource.com/c/1474293 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#632713}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5e577f20fc7c..4bb6437ff800 git log 5e577f20fc7c..4bb6437ff800 --date=short --no-merges --format='%ad %ae %s' 2019-02-15 lalitm@google.com Merge "Revert "Protect SharedRingbuffer against concurrent manipulation."" 2019-02-15 hjd@google.com Merge "trace_to_text: Uses names from sched_switch" Created with: gclient setdep -r src/third_party/perfetto@4bb6437ff800 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I673f19aa36abcf56cff9b445cfa60737ee490dae Reviewed-on: https://chromium-review.googlesource.com/c/1475696Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632712}
-
Changwan Ryu authored
I have not made any significant contribution to web apps in the last 3 years, and I do not plan to. Change-Id: Icb89277ef72c0b43be98bac953f216282017ef93 Reviewed-on: https://chromium-review.googlesource.com/c/1474599Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#632711}
-
Noel Gordon authored
Android aarch64 has different PMULL and CRC32 feature values compared to Android aarch32. Rename init_arm_features to _arm_check_features to be consistent with the _MSC_VER code. Add Android aarch64 feature value support. Use the correct return type for the platform feature detectors (getauxval and android_getCpuFeatures). Add comments and a TODO for OS_ZIRCON. Bug: 810125 Change-Id: Ie1526b1d6d3ebeba76d49a83911b335ffce1b288 Reviewed-on: https://chromium-review.googlesource.com/c/1472810Reviewed-by:
Mike Klein <mtklein@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#632710}
-
Sylvain Defresne authored
The preferences are already correctly registered as part of the creation of the TestingProfile so there is no need to call this method (it is deprecated). Bug: 932534 Change-Id: I1898d7a55e21f2a6524df3d84d849fa428f9c944 Reviewed-on: https://chromium-review.googlesource.com/c/1474760 Commit-Queue: Drew Wilson <atwilson@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#632709}
-
kylechar authored
TaskRunner::PostTask() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=eroman@chromium.org Bug: 714018 Change-Id: I752c22efc5f81b5a7fb6dba1769ca61ecd0f6bd9 Reviewed-on: https://chromium-review.googlesource.com/c/1475647 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#632708}
-
Rohit Rao authored
This will allow us to use the autoroller to update the pinned revision. It will also allow developers to use a "custom_vars" entry in their .gclient file to set this to refs/heads/master if they need to develop against ToT locally. BUG=None Change-Id: I5e506cb12de5e8ceb9b5883750169163ba09adf5 Reviewed-on: https://chromium-review.googlesource.com/c/1474818Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#632707}
-
Mehran Mahmoudi authored
This CL creates a new style selector (or rather refactors the old one) for interest rings in spat nav. It also removes the SpatialNavigationForcesOutline flag and always shows the interest ring when using spat nav. See crrev.com/c/1344252 A future CL will remove the FocuslessSpatialNavigation flag. Bug: 906640 Change-Id: I8bb0e367a0dfd08a7bd48a3f940e58ac60875b36 Reviewed-on: https://chromium-review.googlesource.com/c/1468590 Auto-Submit: Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#632706}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/33bba657449d..685ea8d6f03c git log 33bba657449d..685ea8d6f03c --date=short --no-merges --format='%ad %ae %s' 2019-02-15 pprabhu@chromium.org config: Migrate {auron_yuna,caroline,cave}-paladin to Skylab Created with: gclient setdep -r src/third_party/chromite@685ea8d6f03c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I168745190b8321bf95225433c2e1807748d88f6d Reviewed-on: https://chromium-review.googlesource.com/c/1475694Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632705}
-
Aleks Totic authored
This reverts commit c3f69282. Reason for revert: broke wpt Original change's description: > New wpt tests for absolute position > > Tests buggy code paths in NG and Legacy. > > Bug: 907911 > Change-Id: I38f22f3673576a776fbe7e89f1cc8452b99d3ded > Reviewed-on: https://chromium-review.googlesource.com/c/1471384 > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Commit-Queue: Aleks Totic <atotic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#632391} TBR=ikilpatrick@chromium.org,atotic@chromium.org,mstensho@chromium.org Change-Id: I39bd7b49cfd197eb9e194507d4e35b38f3987a97 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 907911 Reviewed-on: https://chromium-review.googlesource.com/c/1474994Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#632704}
-
Dana Fried authored
App menu now sets its label text context to toolbar button, like other toolbar buttons. Also prevent toolbar and app menu buttons from unnecessarily destroying and recreating empty borders if the inset size has not changed. Bug: 931575 Change-Id: Id2b7e146a97b1da56f08caa9b79b4c7072c9de04 Reviewed-on: https://chromium-review.googlesource.com/c/1474687Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#632703}
-
Shimi Zhang authored
Probably missed from https://codereview.chromium.org/1860703002, remove mnaganov@chromium.org and add michaelbai@chromium.org per that CL. Bug: None Change-Id: I9b53713260e5ab9cbc1a819659b31efbed283dd3 Reviewed-on: https://chromium-review.googlesource.com/c/1471517Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#632702}
-
Robert Sesek authored
This adds tests for a Watcher using WATCH_READ_WRITE and attempts to delete or stop watching after either a read or a write. Bug: 932175 Change-Id: I4e9fe95c200e8983811cb3b3a33855873bb2fbea Reviewed-on: https://chromium-review.googlesource.com/c/1471394 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#632701}
-
Yiming Zhou authored
This prevents git clean -dff from removing the captured site test files cpid downloads at the start of the 'bot update' job. Bug: 885350 Change-Id: I95b5a79fe6c5189f7d641ae936ca640761767f71 Reviewed-on: https://chromium-review.googlesource.com/c/1475152 Auto-Submit: Yiming Zhou <uwyiming@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#632700}
-
kylechar authored
TaskRunner::PostTask() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=sky@chromium.org Bug: 714018 Change-Id: I0006446b31cb38b814e71685ed488e49b476b7ac Reviewed-on: https://chromium-review.googlesource.com/c/1475640 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#632699}
-
Ian Vollick authored
This reverts commit 6b9ae2f7. Reason for revert: seems to be causing some build failures. Original change's description: > Android: Clean up unused Tab methods > > Now that https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/813849 > landed, the methods left unused in Tab can be cleaned up. > > Bug: 925242 > Change-Id: I64e0d8a6868644ce1843fbc965b6a3fa920d8e11 > Reviewed-on: https://chromium-review.googlesource.com/c/1470285 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#632406} TBR=tedchoc@chromium.org,jinsukkim@chromium.org Change-Id: I155dd33af54eb5defeac6a40c44e8c2e31cbe079 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 925242 Reviewed-on: https://chromium-review.googlesource.com/c/1474260Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#632698}
-
Tommy Martino authored
This reverts commit e07980a1. Reason for revert: This is breaking lots and lots of builds. See sample run: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-daisy-rel/48748 Original change's description: > Rename ClipboardURLProvider to ClipboardProvider > > ClipboardURLProvider now provides matches for text and images on the > clipboard as well as URLs. Therefore, we should rename it to just > ClipboardProvider. > > Bug: 923443 > Change-Id: I43ab8036cf2b0c564ebc3588b4c2324628ab2ee7 > Reviewed-on: https://chromium-review.googlesource.com/c/1445401 > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Commit-Queue: Robbie Gibson <rkgibson@google.com> > Cr-Commit-Position: refs/heads/master@{#632681} TBR=jdonnelly@chromium.org,bcwhite@chromium.org,rkgibson@google.com Change-Id: Ib879d771444dac13cdcbc49e0fc7e0e2cdb7618e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 923443 Reviewed-on: https://chromium-review.googlesource.com/c/1475796Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#632697}
-
Domenic Denicola authored
Follows https://github.com/WICG/kv-storage/pull/52. Bug: 931263 Change-Id: I4a943dd2d7dde28c98b88eff397cde769bb64e19 Reviewed-on: https://chromium-review.googlesource.com/c/1466865 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#632696}
-
Andrey Kosyakov authored
... to revision b9f19d327ece7e05c74898fbb6fdc551c6d3f344 Change-Id: I59aeafce75d665c56fd297418ed1f960e175a5ae Reviewed-on: https://chromium-review.googlesource.com/c/1474849Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#632695}
-
Daniel Bratell authored
blink::kAuto and blink::kFixed from the enum LengthType is often shadowed by other kAuto and other kFixed which triggers a ton of warnings when trying to enable -Wshadow. This makes enum LengthType into e class enum in Length, named Type. (So it will be be Length::kAuto instead of just kAuto) Bug: 925310 Change-Id: I6da0577c1a52954229297d9e0d81cb93fda60376 Reviewed-on: https://chromium-review.googlesource.com/c/1437282Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#632694}
-
Tommy Li authored
This reverts commit 6e200e4f. Reason for revert: Unfortunately, this CL landed within minutes of this other CL that renames TYPE_CLIPBOARD_URL to TYPE_CLIPBOARD. That causes a genuine merge conflict and makes all the buildbots fail the compile step. I recommend this CL be relanded with the enum name updated. I can review the reland in short order. Original change's description: > [omnibox]: Initialize HistoryURLProvider earlier. > > This CL moves the HistoryURlProvider's initialization after the SearchProvider's > but before the ZeroSuggestProvider's and ClipboardURLProvider's. > > For threading reasons, CL 1384637 moved the HistoryURlProvider's initialization > last in the AutocompleteController's constructor. However, the zero suggest and > clipboard URL providers take a reference of the history URL provider when > initialized. To avoid setting these references to NULL, this CL moves the > history URL provider's initialization before the other two's but keeps > it after the search provider's for the reasons described in the other CL. > > Bug: 932257 > Change-Id: I1085ad89e13f29ea29264ce3fa1a2d33197f3b17 > Reviewed-on: https://chromium-review.googlesource.com/c/1474383 > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Commit-Queue: manuk hovanesian <manukh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#632682} TBR=mpearson@chromium.org,jdonnelly@chromium.org,manukh@chromium.org Change-Id: Ie825b2782b3d7cc4f48619b71955d641756d2f00 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 932257 Reviewed-on: https://chromium-review.googlesource.com/c/1475795Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#632693}
-
Scott Violet authored
This reverts commit 03f4bd63. Reason for revert: landed fixes that was causing tab dragging to break (specifically https://chromium-review.googlesource.com/c/chromium/src/+/1474797 ) Original change's description: > Revert "chromeos: disables event throttling in window-service clients" > > This reverts commit 8e40f476. > > Reason for revert: crbug.com/931878, touch tab-dragging gets broken > > Original change's description: > > chromeos: disables event throttling in window-service clients > > > > Only the window-service should throttle. > > > > BUG=929914 > > TEST=none > > TBR=sadrul@chromium.org > > > > Change-Id: Iab7ea987c8fcb1f52b9c1e69576a0f950d790787 > > Reviewed-on: https://chromium-review.googlesource.com/c/1470941 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Scott Violet <sky@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#631868} > > TBR=sadrul@chromium.org,sky@chromium.org > > Change-Id: I4c356212aed1cf03b6c381ef05ce404a58517351 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 929914 > Reviewed-on: https://chromium-review.googlesource.com/c/1471458 > Reviewed-by: Jun Mukai <mukai@chromium.org> > Commit-Queue: Jun Mukai <mukai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#632025} TBR=sadrul@chromium.org,mukai@chromium.org,sky@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 929914 Change-Id: Ic0ee152a49bf03eb74fd5e1705cbab0f0e1248c1 Reviewed-on: https://chromium-review.googlesource.com/c/1475745Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#632692}
-
mrefaat authored
The problem is URLLoader doesn't know chrome://external-file So providing it with the actual file:// URL fixes the problem. Bug: 928252 Change-Id: I1cda9cc076bd804a660aa46fdea84569bf7a5829 Reviewed-on: https://chromium-review.googlesource.com/c/1474686Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#632691}
-
Changwan Ryu authored
I have not made any significant contribution in compositor/ in the last 3 years. Since I'm focusing more on android_webview/, I'd like to unown compositor/. Hopefully, this can open up more opportunity for others. Change-Id: I9eb227c78b777199e78a89d5893febb652626d77 Reviewed-on: https://chromium-review.googlesource.com/c/1474598Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#632690}
-
Brad Hall authored
Bug: 790139 Change-Id: I78592ed1ca48b1f7ba44f496f5a82927a907ddf7 Reviewed-on: https://chromium-review.googlesource.com/c/1474545Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Brad Hall <bradhall@google.com> Cr-Commit-Position: refs/heads/master@{#632689}
-
Ben Pastene authored
This reverts commit da307f24. Reason for revert: should no longer depend on chrome_login Original change's description: > chromeos: Disable Tast test security.Mtab to unblock LKGM rolls. > > It's failing with: > Error: [mtab.go:41] Root partition is mounted read/write; rootfs verification disabled? > > Let's disable it while we figure out a workaround since it's blocking > lkgm rolls. > > Bug: 931431 > Change-Id: Ibf953f77009ead69902da163b750e53cf43c6ffe > Reviewed-on: https://chromium-review.googlesource.com/c/1468599 > Reviewed-by: Dan Erat <derat@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#631479} TBR=derat@chromium.org,achuith@chromium.org,bpastene@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 931431 Change-Id: Ia496c1f04aaaabebc2737cca585a500a02c9928a Reviewed-on: https://chromium-review.googlesource.com/c/1475814Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#632688}
-
Elly Fong-Jones authored
This document describes: * Features (base::FeatureList) * Flags (chrome://flags) * Switches (command-line args) * Prefs * Settings (chrome://settings) and outlines when and how to use each of them. Bug: None Change-Id: Ic2fa2151eb1ef0c1144ec007cb7d5e4a8b7f6343 Reviewed-on: https://chromium-review.googlesource.com/c/1470930 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#632687}
-
Gang Wu authored
Add histograms for different behaviors when scheduler refresh to easy understand why scheduler returns kNoRequestWithWait so often. Bug: 931265 Change-Id: I59f5a08f262b1c11c152790d442bb6c900c3045b Reviewed-on: https://chromium-review.googlesource.com/c/1471391 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#632686}
-
Natalie Chouinard authored
Initialize all ProtoDatabases on construction of UsageStatsDatabase. Initialization is asynchronous, so in the event that a UsageStatsDatabase function is called when the underlying ProtoDatabases are not yet initialized, store a base::Closure in a queue for later execution. Bug: 931476 Change-Id: I76399c3ceb1ad92075af70d5976fa182cb8dfb45 Reviewed-on: https://chromium-review.googlesource.com/c/1474540 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#632685}
-
Elly Fong-Jones authored
This CL assigns: enable-ntp-asset-download-suggestions enable-ntp-bookmark-suggestions enable-ntp-offline-page-download-suggestions enable-ntp-remote-suggestions enable-ntp-snippets-increased-visibility enable-ntp-suggestions-notifications to fgorski@ for M76. These flags are currently in the process of being cleaned up. Bug: None Change-Id: Idef188192a6cb9bd4a8ebee6a3232421c5a84cf0 Reviewed-on: https://chromium-review.googlesource.com/c/1474465 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#632684}
-
Qingsi Wang authored
RTCPeerConnectionHandler. Currently RTCPeerConnectionHandler::OnIceCandidate only considers candidates with literal IPv4 or IPv6 addresses as legitimate. Hostname candidates are now supported by WebRTC, notably when the mDNS concealment of local IPs is enabled. Bug: 930339 Change-Id: Ia84328c39a5163f0816b7522421a56cc79aaf965 Reviewed-on: https://chromium-review.googlesource.com/c/1472253Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Qingsi Wang <qingsi@google.com> Auto-Submit: Qingsi Wang <qingsi@google.com> Cr-Commit-Position: refs/heads/master@{#632683}
-
manuk authored
This CL moves the HistoryURlProvider's initialization after the SearchProvider's but before the ZeroSuggestProvider's and ClipboardURLProvider's. For threading reasons, CL 1384637 moved the HistoryURlProvider's initialization last in the AutocompleteController's constructor. However, the zero suggest and clipboard URL providers take a reference of the history URL provider when initialized. To avoid setting these references to NULL, this CL moves the history URL provider's initialization before the other two's but keeps it after the search provider's for the reasons described in the other CL. Bug: 932257 Change-Id: I1085ad89e13f29ea29264ce3fa1a2d33197f3b17 Reviewed-on: https://chromium-review.googlesource.com/c/1474383Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#632682}
-
Robbie Gibson authored
ClipboardURLProvider now provides matches for text and images on the clipboard as well as URLs. Therefore, we should rename it to just ClipboardProvider. Bug: 923443 Change-Id: I43ab8036cf2b0c564ebc3588b4c2324628ab2ee7 Reviewed-on: https://chromium-review.googlesource.com/c/1445401Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#632681}
-
Etienne Pierre-doray authored
Migration is complete! Delete AssertBlockingAllowedDeprecated(). Bug: 903957 Change-Id: I683e879f8d1f07a1e38d2fa6bb1423101699fb68 Reviewed-on: https://chromium-review.googlesource.com/c/1474826 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#632680}
-
Gabriel Marin authored
The heap collector is enabled only on devices with the new version of tcmalloc on the canary and dev channels. The collector is enabled for all browser processes on the canary channel and with a 20% probability for browser processes on the dev channel. Added a new collection status value, UNABLE_TO_COLLECT, used when collection cannot be started due to technical reasons. BUG=b:121160411 TEST=Unit tests pass Change-Id: I3b71c2b10cc00cda66bf845fc5ac6f255dade3c6 Reviewed-on: https://chromium-review.googlesource.com/c/1435075 Commit-Queue: Gabriel Marin <gmx@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#632679}
-
Scott Violet authored
This reverts commit 860f3c63. Reason for revert: landed fixes that was causing tab dragging to break (specifically https://chromium-review.googlesource.com/c/chromium/src/+/1474797 ) Original change's description: > Revert "Reland "chromeos: makes resizes smoother with mash"" > > This reverts commit fca998b7. > > Reason for revert: crbug.com/931878, touch tab-dragging gets broken > > Original change's description: > > Reland "chromeos: makes resizes smoother with mash" > > > > This reverts commit 643813e1. > > > > Reason for revert: My test was wrong, we actually block mouse on device in certain modes. Sorry for the noise. > > > > Original change's description: > > > Revert "chromeos: makes resizes smoother with mash" > > > > > > This reverts commit b805090b. > > > > > > Reason for revert: This makes the mouse get stuck hidden on device. > > > > > > Original change's description: > > > > chromeos: makes resizes smoother with mash > > > > > > > > This contains two changes: > > > > 1. Adds call from ClientRoot to Compositor::OnChildResizing(). This ensures > > > > that WindowTreeHost doesn't dispatch move events until the frame has been > > > > activated. > > > > 2. Converts resetting of pointer moves lock from OnCompositingDidCommit() > > > > to OnCompositingEnded(). OnCompositingDidCommit() seems to be called much > > > > to earlier in the mash case, and results in jank when resizing. > > > > > > > > BUG=929914 > > > > TEST=none > > > > > > > > Change-Id: I68d87d6e7f237f246c2fad6218d9da5356c98641 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1467917 > > > > Commit-Queue: Scott Violet <sky@chromium.org> > > > > Reviewed-by: Saman Sami <samans@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#631743} > > > > > > TBR=sky@chromium.org,samans@chromium.org > > > > > > Change-Id: Iaf103ed66885da652c7013fcc412b0269e10b303 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 929914 > > > Reviewed-on: https://chromium-review.googlesource.com/c/1470935 > > > Reviewed-by: Scott Violet <sky@chromium.org> > > > Commit-Queue: Scott Violet <sky@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#631803} > > > > TBR=sky@chromium.org,samans@chromium.org > > > > Change-Id: I828256b878dfb8f5a8ec0bbd6c6c533e091ddb5f > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 929914 > > Reviewed-on: https://chromium-review.googlesource.com/c/1471010 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Scott Violet <sky@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#631820} > > TBR=sky@chromium.org,samans@chromium.org > > Change-Id: Id7eb67f636e13677122c6a8bd0c8e50bd4b51986 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 929914 > Reviewed-on: https://chromium-review.googlesource.com/c/1471493 > Reviewed-by: Jun Mukai <mukai@chromium.org> > Commit-Queue: Jun Mukai <mukai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#632024} TBR=mukai@chromium.org,sky@chromium.org,samans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 929914 Change-Id: I773ef9e31de890222104dc6cbf9e0f44466901d4 Reviewed-on: https://chromium-review.googlesource.com/c/1475743Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#632678}
-
Weidong Guo authored
This reverts commit 7fd1139c. Reason for revert: It will fix unnecessary Vox announcement for app list button when launcher is opened. Original change's description: > CrOS Shelf: Cleanup unnecessary override in ShelfButton > > The implementation of |GetAccessibleNodeData| in the base > Button class is more than sufficient, and does all the things > the ShelfButton does (and more). > > Change-Id: I3ee2d6f8ecff676fcad34e2216199128394cf731 > Reviewed-on: https://chromium-review.googlesource.com/c/1446256 > Auto-Submit: Manu Cornet <manucornet@chromium.org> > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#627956} Bug: 932200 TBR=xiyuan@chromium.org,manucornet@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Icd7ef295f026f4dc237d7920185eebb3a2aa51b2 Reviewed-on: https://chromium-review.googlesource.com/c/1474680Reviewed-by:
Weidong Guo <weidongg@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Auto-Submit: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#632677}
-
Brad Hall authored
This hasn't had any builds since 04/2018 Bug: 790146 Change-Id: I867b60e3dd9e4250fc739aa4ec13d97f32e65c23 Reviewed-on: https://chromium-review.googlesource.com/c/1475168 Commit-Queue: Brad Hall <bradhall@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#632676}
-
kylechar authored
TaskRunner::PostTask() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?Task)\((?:\n\s*)?FROM_HERE,(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=xiyuan@chromium.org Bug: 714018 Change-Id: I94b9f1129b8e818b2ecb4896f8974bf08cc66f2c Reviewed-on: https://chromium-review.googlesource.com/c/1474821 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#632675}
-