- 20 Jun, 2018 40 commits
-
-
Christopher Lam authored
This CL removes all compiled_resources2.gyp files from ui/webui and third_party/polymer, and removes the script that generates them for Polymer Elements. TBR=jochen@chromium.org Bug: 632206 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I1866d4e682e41c462958ac1185b6cb7e70cb7130 Reviewed-on: https://chromium-review.googlesource.com/1105677 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#568766}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/66cadcc6b924..f04148c810aa git log 66cadcc6b924..f04148c810aa --date=short --no-merges --format='%ad %ae %s' 2018-06-20 qingsi@google.com Enable any address ports by default. 2018-06-20 buildbot@webrtc.org Roll chromium_revision 6e14efc1..20579735 (568572:568689) 2018-06-20 steveanton@webrtc.org Mark unused/deprecated DTMF methods for removal 2018-06-19 shampson@webrtc.org Fixing flakiness in PeerConnectionIntegrationTest. Created with: gclient setdep -r src/third_party/webrtc@f04148c810aa The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I935d390e8be1182e0c65f64645b756a30c30dcd2 Reviewed-on: https://chromium-review.googlesource.com/1107140 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568765}
-
Marc Treib authored
- Move "enum SyncInitialState" into the .cc. - Get rid of many rarely or inconsistently used "using syncer::*"s. - Update some comments. - Remove a few unnecessary "virtual"s. - Merge ChangePreferredDataTypes into OnUserChoseDatatypes - all updates must go through that. - As a consequence, update SyncAwareCounterTests. In particular, don't use syncer::HISTORY_DELETE_DIRECTIVES which is not a user-selectable type. Instead use syncer::TYPED_URLS, which corresponds to the "History" checkbox, and which implies HISTORY_DELETE_DIRECTIVES. Bug: 839834 Change-Id: Ifea0178c1f1e1c1546a1f904c1e52d527df9ed7b Reviewed-on: https://chromium-review.googlesource.com/1106171Reviewed-by:Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#568764}
-
Raphael Kubo da Costa authored
The other pages were referring to android_emulators.md (plural), which does not exist. TBR=agrieve Change-Id: I6bd1c2ac95f851b8aae02550c650607ed2182a1f Reviewed-on: https://chromium-review.googlesource.com/1103569Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#568763}
-
Matt Falkenhagen authored
The linked bug is because Blink is surprised when we skip a non-fetch event controller. This CL is preparation to fix that. We have IsControlledByServiceWorker() but some callsites might be interested in the no-fetch vs fetch cases. Most likely, Blink only cares about the fetch case. However, in non-S13nServiceWorker, it's complicated because Blink doesn't know which controller will handle a request, since it's ultimately decided by the browser process and skipWaiting() may occur in the meantime. It's safest to just make things explicit and make IsControlledByServiceWorker() return an enum of state. If it turns out after S13nSW we can collapse "no controller" and "no fetch event controller" together, we can simplify then. This CL doesn't have an expected behavior change, just preparation. Bug: 850839 Change-Id: Ic7b2b527947c09be46c337ce90024aabccecbb1c Reviewed-on: https://chromium-review.googlesource.com/1104078 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#568762}
-
Ken Rockot authored
It's no longer used in these places, so wipe out any corresponding DEPS and gn deps entries. TBR=sky@chromium.org TBR=dschuff@chromium.org TBR=danakj@chromium.org TBR=xhwang@chromium.org TBR=nick@chromium.org Bug: 844763 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ia2237301555ceba399dc63373ab13fab5f0ab02b Reviewed-on: https://chromium-review.googlesource.com/1107105 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#568761}
-
Sasha Morrissey authored
Check for canCopy/canAddChildren capabilities when copying/moving in the Files App. This also affects drag-drop operations, although only on the RHS file listing (not the LHS directory tree). Also added integration tests for cut/copy/paste, including some that try copying a file and pasting it into a folder with and without the canAddChildren capability. Test: browser_test --gtest-filter="ContextMenu/FilesApp*" Bug: 719959 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I8621e873360dceffdb977b33a7261757841e929d Reviewed-on: https://chromium-review.googlesource.com/1096716 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#568760}
-
Nigel Tao authored
The EntryAction type is (now) fictional, and no longer corresponds to anything in chrome/common/extensions/api/file_manager_private.idl Test: "ninja ui/file_manager:closure_compile" runs without error Bug: 613096 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I3afc580cbcf259fac2a450f24cb7088164ee235c Reviewed-on: https://chromium-review.googlesource.com/1107027Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#568759}
-
Jan Wilken Doerrie authored
This change simplifies base/win/async_operation.h by deduplicating logic and flattening the class hierarchy. This is possible by introducing two compile time switches, that pick the correct storage and result type depending on the provided template instantiation. Bug: 821766 Change-Id: Ia04dc4cdbc42a4005204491cc47650d35f413cdb Reviewed-on: https://chromium-review.googlesource.com/1106382Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#568758}
-
Koji Ishii authored
Following bot results are included. 6947 6948 6951 6953 6957 6960 6968 6 lines were removed and 1 lines were deflaked by consecutive results since 6935. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: If3878b7f06bf1b38a56e08f35d872e318b90879d Reviewed-on: https://chromium-review.googlesource.com/1106177 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#568757}
-
Tatsuhisa Yamaguchi authored
Show date/time setting when the date view is clicked. Bug: 850439 Test: manual (--enable-features=SystemTrayUnified) Change-Id: I597776e79cf639cd2ce1a3890fc31064d21de8bd Reviewed-on: https://chromium-review.googlesource.com/1092555Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#568756}
-
Donna Wu authored
BUG=769630 Change-Id: I9566ec9c3efae1f8b7d30dec8622f35dc2ba3f7a Reviewed-on: https://chromium-review.googlesource.com/1096655 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#568755}
-
Nicholas Verne authored
Since installing crostini involved downloading around 300MB, we prevent the install flow from proceeding if we're offline. Added a browser test with ExtraParts support. Bug: 843065 Change-Id: Ia0049d4ec30ac79c585d129e05aa2240eeecba09 Reviewed-on: https://chromium-review.googlesource.com/1107419Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#568754}
-
Tetsui Ohkubo authored
This CL changes sub header separator color of detailed views in UnifiedSystemTray. Screenshot: http://screen/t36mz755DuP TEST=manual BUG=854146 Change-Id: I77b37bc6e352f427453c5da635c9d6d9dd649f0f Reviewed-on: https://chromium-review.googlesource.com/1107428Reviewed-by:
-
Tetsui Ohkubo authored
The button on the right of the brightness sldier is no-op, so we should call SetEnabled(false). In order to do this, this CL changed disabled color of the buton icon. TEST=manual BUG=854148 Change-Id: I1f0e98540a86696351135275be8946b7250cbc12 Reviewed-on: https://chromium-review.googlesource.com/1107423Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium b14d60b3. With Chromium commits locally applied on WPT: 03ef65db "Update existing WebUSB WPT to be multi-global" 89102421 "Reland "Multi-global WebUSB WPT for window and worker"" 08784a11 "[Mojo Blob URLs] Make clicking an <a target="blank_"> with a blob URL work correctly." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19930 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kozyatinskiy@chromium.org: external/wpt/console TBR=robertma No-Export: true Change-Id: Ifc3c52bfc29afe7fc3ad3e2e4e6cdf7ccb26d1e0 Reviewed-on: https://chromium-review.googlesource.com/1107395 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#568751}
-
Christopher Cameron authored
Also move render_widget_host_ns_view_bridge.mm to render_widget_host_ns_view_bridge_local.mm, in anticipation of adding a remote version. TBR=avi Bug: 821651 Change-Id: I90b5a1e85fdb52339a4b30cc65d14cb212741bb0 Reviewed-on: https://chromium-review.googlesource.com/1107389Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#568750}
-
Gauthier Ambard authored
This CL fixes the bubble tips for UI Refresh by adding a 1s delay before displaying the tip and increasing the duration to 5s. Bug: 830635 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic9ee7f9e01449965068832c67743354478799ce7 Reviewed-on: https://chromium-review.googlesource.com/1106344Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#568749}
-
Yuri Wiitala authored
1. Remove the unused viz.mojom.FrameSinkVideoConsumer.OnTargetLost() API. 2. Fix the viz.mojom.FrameSinkVideoCapturer.ChangeTarget() to accept an optional FrameSinkId (original intended behavior of the API before new struct traits restrictions on "null" FrameSinkIds). 3. C++ Style: Fixed argument ordering in a few methods of viz::FSVCImpl so that the output argument would come last. 4. Ran lint on all files changed, and made fixes (mostly include-what-you-use). Bug: 754872 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Idbceb49089811dd6f8494f8ee17d578239108866 Reviewed-on: https://chromium-review.googlesource.com/1090220 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#568748}
-
Joe Downing authored
A component in ASH was directly including one of the now-private inc files. We want to keep that data private so this CL introduces a header which exposes a DomCode[] to allow iterating over them w/o directly including the data files. CL which introduced this dependency: https://chromium-review.googlesource.com/c/chromium/src/+/1058080 Change-Id: I78b1fe1447e1f6354e690e5ec6fdd7132f61c74d Reviewed-on: https://chromium-review.googlesource.com/1091147Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#568747}
-
Raphael Kubo da Costa authored
IWYU. This fixes the build with libstdc++ after c1ab712a ("Stop using x-devtools-emulate-network-conditions-client-id header"): In file included from ../../services/network/throttling/scoped_throttling_token.cc:5:0: ../../services/network/throttling/scoped_throttling_token.h:29:15: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type static std::unique_ptr<ScopedThrottlingToken> MaybeCreate( ^~~~~~~~~~ Bug: 819294 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I66b2db483ac9e90d0a132a65f83f15aa673f12f9 Reviewed-on: https://chromium-review.googlesource.com/1105825Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
-
Yuichiro Hanada authored
OnImeInfoChanged() receives a list of installed IMEs in the ARC container and registers them as valid IMEs to InputMethodManager. Bug: 845079 Test: unit_tests Change-Id: Ic7252c5d9021252228697e351a1c251c1f167e52 Reviewed-on: https://chromium-review.googlesource.com/1105684 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#568745}
-
Adam Rice authored
This reverts commit 7e3874d4. Reason for revert: The flag has now been removed from the about:flags page on M68 where it doesn't work. Re-introduce it in M69 where it works. Original change's description: > Temporarily remove enable-websocket-auth-connection-reuse from about:flags > > The M68 branch has a non-working implementation of the > enable-websocket-auth-connection-reuse flag. In order to avoid the > confusion of having a flag that works in some versions and not in > others, temporarily remove the flag from about:flags. > > Once the flag has been disabled in the M68 branch it will be re-enabled > for M69 by reverting this CL. > > BUG=423609 > > Change-Id: Id17ac18e13effcfd5bd946dc1fe0f1c70df96539 > Reviewed-on: https://chromium-review.googlesource.com/1090700 > Commit-Queue: Adam Rice <ricea@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566730} TBR=ricea@chromium.org,yhirano@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 423609 Change-Id: Ifb83673ab8e6efaefbbc50e85b560b889fc160ad Reviewed-on: https://chromium-review.googlesource.com/1107437Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#568744}
-
Mitsuru Oshima authored
Looks like I misunderstood the comment when I refactored. BUG=843856 TEST=covered by unittest Change-Id: I6fb735472af25e833ef2a40f99bd0a26867da3fb Reviewed-on: https://chromium-review.googlesource.com/1107214Reviewed-by:
-
Patti authored
Add a three-dot / overflow menu to groups of origins in All Sites. This overflow menu allows the entire list of origins to have all their content settings reset in one go. This will be preceded with a confirmation dialog. Manual test - With #enable-site-settings turned on, change a content setting via Page Info > Site settings on both https://permission.site and http://permission.site. Navigate to chrome://settings/content/all and see that both sites are listed under 'permission.site'. Verify there is an overflow menu on this entry and that inside the overflow menu, there is a 'Reset permissions' option. Clicking this should bring up a reset permission dialog and confirming the dialog should remove this entry from All Sites. Bug: 835712, 717468 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I777f759c26bf0fe7f8da086fa887969897cf9833 Reviewed-on: https://chromium-review.googlesource.com/1098577 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#568742}
-
Yoichi Osato authored
This patch changes LayoutReplaced selection painting rect by expanding its top and height to the line height so that we paint selection filling line gap. This patch updates LayoutReplaced::LocalSelectionRect adapting NGPaintFragment. New image-writing-modes.html test confirms image selection painting on horizontal, vertical-lr/rt. Bug: 708452 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id7a74f0961109cc458b973664ff56e14655bf257 Reviewed-on: https://chromium-review.googlesource.com/1102287 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568741}
-
Tao Bai authored
This is the first patch to share the local prediction in Android autofill. Bug: 849913 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I20454214528244f1af7b42ccb2907987f4855913 Reviewed-on: https://chromium-review.googlesource.com/1081180 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#568740}
-
Kuo-Hsin Yang authored
The first version of cros_tab_switching can only run by specifying the argument --remote=DUT_IP. Enable running cros_tab_switching locally when --remote is not specified so it can be used on test_that. Bug: 852231 Change-Id: Ia92dc4913a039e7b4ae7488c1b8d0523451d4645 Reviewed-on: https://chromium-review.googlesource.com/1098872 Commit-Queue: Vovo Yang <vovoy@chromium.org> Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#568739}
-
yoshiki iguchi authored
Previously notification was activated when the notification is clicked. This patch changes this timing of focus change. With this CL, the notification is activated only when the notification's remote input is focused. Bug: 844310 Bug: b/78604162 Test: manual (notification is not focused just on click, and is focused when the remote input is activated) Change-Id: I30b91ca5d65b0e1089d63a062bdc9edc82de1f89 Reviewed-on: https://chromium-review.googlesource.com/1080502Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#568738}
-
Makoto Shimazu authored
The base url and history url have already been set appropriately. TBR=kinuko@chromium.org Bug: 846196 Change-Id: Ib0da047983f19c781dbf5e6d6bce3acda8006bda Reviewed-on: https://chromium-review.googlesource.com/1104079Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Tao Bai authored
Always check if log is enabled before ouput log, this avoid creating string object while log is disabled. Also only check Android log property when AwAutofillManager is created or new session starts. Bug: 843277 Change-Id: Id2ab708646d434677d11016132cc47b6fa4985be Reviewed-on: https://chromium-review.googlesource.com/1106959Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#568736}
-
Kent Tamura authored
v8_script_runner.h is used in 2,800+ compilation units, and this CL reduces its estimated expanded size from 4.06MB to 0.65MB. Bug: 242216 Change-Id: I87f5b5ada11794eaab07c1375741dce760201605 Reviewed-on: https://chromium-review.googlesource.com/1107034Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#568735}
-
Kent Tamura authored
Remove dependency to encoded_form_data.h and security_origin.h. resource_request.h is used in 4,400+ compilation units, and this CL reduces its estimated expanded size by 0.24MB. Bug: 242216 Change-Id: Ief70b318e39c508b75791db3d708ed7cee40c277 Reviewed-on: https://chromium-review.googlesource.com/1107030Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#568734}
-
Koji Ishii authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9300bd5c5565fc143bf315d892c003870b314187 Reviewed-on: https://chromium-review.googlesource.com/1098903 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
-
Wenzhao Zang authored
1) The new wallpaper picker relies on the Backdrop server to select surprise me images, instead of selecting random images by ourseleves (the back-end was implemented by a prior CL). 2) The surprise me images are per-category, ie. each wallpaper category has a "daily refresh slider". At most one slider may be active at a time. Toggling one slider to active should deactivate others. 3) Use "daily refresh" instead of "surprise me" in the code to distinguish from the old picker. Although it's possible to share code path with the old picker, generally avoid it for clarity. Test steps include: 1) Toggle daily refresh between enabled/disabled, during tablet/clamshell mode, and among different categories. 2) Enable surprise me on the old picker, then add switch --new-wallpaper-picker, and see the migration. 3) See the sync is working for two devices with the same account id. Bug: 834998, 810169, 834994, 837338 Change-Id: I369ce57ac4bd07e91da31bb2971b6970501f9c3a Reviewed-on: https://chromium-review.googlesource.com/1093742 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#568732}
-
Min Qin authored
This CL adds a flag into BrowserParts to allow Chrome to start with only the ServiceManager, without loading additional functionalities such as profile. This will allow features like download/sync to run without fully instantiating Chrome, thus saving memory footprints. Once ServiceManager is started, serviceManagerStartupComplete() will get called. And Browser startup will be paused if the request is to start ServiceManager only BUG=842245 Change-Id: I436c4bde16db55af012b5d9cf468c073c86a86cc Reviewed-on: https://chromium-review.googlesource.com/1093303Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568731}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/47c29fa64b3f..4359d529121f git log 47c29fa64b3f..4359d529121f --date=short --no-merges --format='%ad %ae %s' 2018-06-20 allanmac@google.com Skia Compute core files Created with: gclient setdep -r src/third_party/skia@4359d529121f The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I70bdb0c284710c99fd56217009581b7d605da1e1 Reviewed-on: https://chromium-review.googlesource.com/1107397Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568730}
-
Min Qin authored
This CL allows InProgressDownloadManager to take a URLLoaderFactoryGetter, and resume the download by itself. BUG=842245 Change-Id: Ie2e6dff715455ee8449be05d49c43144de8d25c8 Reviewed-on: https://chromium-review.googlesource.com/1102885Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568729}
-
Nico Weber authored
TBR=jbudorick Bug: 455679,843511 Change-Id: I716eaad2c98521978d25ee5b0bf00d57534eb19c Reviewed-on: https://chromium-review.googlesource.com/1104803Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#568728}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 90a2d3e7. With Chromium commits locally applied on WPT: 03ef65db "Update existing WebUSB WPT to be multi-global" 89102421 "Reland "Multi-global WebUSB WPT for window and worker"" 08784a11 "[Mojo Blob URLs] Make clicking an <a target="blank_"> with a blob URL work correctly." 3aaab5dd "webrtc wpt: trust getUserMedia to be compliant" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19929 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure guidou@chromium.org: external/wpt/mediacapture-streams igrigorik@chromium.org, panicker@chromium.org: external/wpt/performance-timeline kojii@chromium.org: external/wpt/css/css-scoping mcasas@chromium.org: external/wpt/mediacapture-record TBR=robertma No-Export: true Change-Id: Ia2fe07a0430a87cdaa2f6a7da2f9f5cc3c1a3c4d Reviewed-on: https://chromium-review.googlesource.com/1107249 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
