- 08 Jul, 2016 40 commits
-
-
sunnyps authored
Resources which do not belong to a particular ResourceProvider should not require a WaitSyncToken. This is a speculative fix for the increased idle wakeups seen on Mac non-overlay. R=piman@chromium.org BUG=621198 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2130213002 Cr-Commit-Position: refs/heads/master@{#404461}
-
msw authored
Flaked 7/16 of the last runs on Linux ChromiumOS Tests (1): http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=ash_unittests&tests=ShelfTooltipManagerTest.ShowTooltipWithDelay BUG=NONE TEST=No/fewer flakes in this test fixture. R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2130133003 Cr-Commit-Position: refs/heads/master@{#404460}
-
mariakhomenko authored
Upstream most of the implementation. Add unit tests. BUG=626159 Review-Url: https://codereview.chromium.org/2123393002 Cr-Commit-Position: refs/heads/master@{#404459}
-
jbroman authored
WebGL demos now work with --enable-slimming-paint-v2 --enable-layer-lists. BUG=587970 Review-Url: https://codereview.chromium.org/2121933003 Cr-Commit-Position: refs/heads/master@{#404458}
-
asvitkine authored
Keeps its default state as enabled, as before, but this lets us experiment with turning it off experimentally to see whether it may be causing a suspected startup regression. BUG=626676 Review-Url: https://codereview.chromium.org/2131233002 Cr-Commit-Position: refs/heads/master@{#404457}
-
rob authored
std::set's count() method is expected to return 0 or 1. But due to the fact that EventListener::operator< conditionally ignored |embedder_process_id|, the count method could return more than 1 (e.g. 2) in release builds on Windows (VC++), and fail an assertion. This assertion failure shows that the assumption about the uniqueness of EventListeners (while ignoring the |embedder_process_id| value) does not hold, i.e. there may be more than one non-webview EventListeners with the same |extension_id| and |sub_event_name|, but different |embedder_process_id|. To fix this, this patch removes the conditional exclusion of |embedder_process_id| from operator< and looks up |embedder_process_id| before searching through the set. BUG=589735 TEST=./unit_tests --gtest_filter=ExtensionWebRequestTest.AddAndRemoveListeners Review-Url: https://codereview.chromium.org/2121873002 Cr-Commit-Position: refs/heads/master@{#404456}
-
iclelland authored
Many origin trial features can be installed on interfaces and prototype objects without requiring an existing interface object. This creates an alternate method signature for installing such features, and simplifies the bindings installation code. BUG=626435 R=yukishiino@chromium.org Review-Url: https://codereview.chromium.org/2130883002 Cr-Commit-Position: refs/heads/master@{#404455}
-
konsto authored
Almost the same string is repeated in the title of the dialog. BUG=618140 Review-Url: https://codereview.chromium.org/2123653007 Cr-Commit-Position: refs/heads/master@{#404454}
-
pkotwicz authored
Non-WebAPK web apps rely on a property in site preferences to determine whether the web app has been installed. If a user clears Chrome's data via Settings->Apps->Chrome->Storage->"Clear Data" site preferences are cleared. This CL adds a way for determining whether a WebAPK is installed which works even after a user clears Chrome's data. BUG=622135 Review-Url: https://codereview.chromium.org/2124703003 Cr-Commit-Position: refs/heads/master@{#404453}
-
thestig authored
Also convert !container.size() to container.empty(). Review-Url: https://codereview.chromium.org/2119283002 Cr-Commit-Position: refs/heads/master@{#404452}
-
fdoray authored
The PrefService argument was optional because it wasn't available in components/html_viewer. Now that components/html_viewer is gone, a PrefService should always be provided when calling startup_metric_utils::RecordBrowserMainMessageLoopStart. BUG=580211 Review-Url: https://codereview.chromium.org/2131663002 Cr-Commit-Position: refs/heads/master@{#404451}
-
sky authored
Prior to this change if you registered an accelerator for a key event then only the accelerator got the event. After this change the tree that registered the accelerator (wm) need not consume the event. If the wm doesn't consume the event it'll be processed normally. BUG=612331 TEST=covered by tests R=sadrul@chromium.org, dcheng@chromium.org Review-Url: https://codereview.chromium.org/2125883003 Cr-Commit-Position: refs/heads/master@{#404450}
-
sanjoy.pal authored
The spec requires using the last selected shipping option. Instead of going through the whole list of shipping options from front to back, iterate from back to front and early return on the first selected shipping option. BUG=587995 TEST=None (No behavior change) Review-Url: https://codereview.chromium.org/2131963002 Cr-Commit-Position: refs/heads/master@{#404449}
-
jennyz authored
Do not notify Volume change event to CrasAudioHandler::Observer when CrasAudioHandler change volume during initialization. BUG=625222 Review-Url: https://codereview.chromium.org/2127033004 Cr-Commit-Position: refs/heads/master@{#404448}
-
lushnikov authored
DevTools "hosted mode" is broken in a multiple ways: - it uses sync XHR from inside the microtask (this was recentrly forbidden) - as the protocol was split and moved around, the InspectorBackendHostedMode.js is not able to generate proper inspector backend commands The patch fixes both problems. Here we: - manually copy browser_protocol.json and js_protocol.json to the front-end folder so that hosted mode can rely on it - preload protocol files into Runtime.cachedResources in hosted mode for future use of InspectorBackendHostedMode.js BUG=623602 R=dgozman, pfeldman Review-Url: https://codereview.chromium.org/2124203002 Cr-Commit-Position: refs/heads/master@{#404447}
-
dfalcantara authored
* The fields felt a little squished. Try to space them out a little better. * Update the underline colors to match the TextInputLayers. * Add support for half width controls in the display. Screenshots here: https://bugs.chromium.org/p/chromium/issues/detail?id=603635#c190 BUG=603635,626451 Committed: https://crrev.com/975b62f4fe7cfd7f3de7ab6fc49a3cc20e7f49ce Review-Url: https://codereview.chromium.org/2114493002 Cr-Original-Commit-Position: refs/heads/master@{#404241} Cr-Commit-Position: refs/heads/master@{#404446}
-
mariakhomenko authored
BUG=626450 Review-Url: https://codereview.chromium.org/2130873003 Cr-Commit-Position: refs/heads/master@{#404445}
-
mdjones authored
This change allows updates to a page's theme color to smoothly transition in the tab switcher. BUG=606612 Review-Url: https://codereview.chromium.org/2114513002 Cr-Commit-Position: refs/heads/master@{#404444}
-
bnc authored
* Remove SPDY field trial. * Add HTTP2 field trial to provide a kill switch for HTTP/2 just in case. * Remove enable_spdy31 flag. BUG=624095, 521597 Review-Url: https://codereview.chromium.org/2115213002 Cr-Commit-Position: refs/heads/master@{#404443}
-
gmanikpure authored
BUG=chromedriver:1418 Review-Url: https://codereview.chromium.org/2133163003 Cr-Commit-Position: refs/heads/master@{#404442}
-
penghuang authored
This change enables the HW supports in mus+ash by * Wire up ui service GPU channel. * Always create offscreen GL context for gfx::AcceleratedWidget (mus window) in browser process. * Provide a MusBrowserCompositorOutputSurface. In MusBrowserCompositorOutputSurface::SwapBuffers(), we use CommandBufferProxyImpl::TakeFrontBuffer() to take the offscreen GL context's front buffer into a mailbox, insert a sync token, and send mailbox+sync to the ui service process. Know issue: GPUInfo is not sent to renderer, so some webgl demos don't work. BUG=622708 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2096843002 Cr-Commit-Position: refs/heads/master@{#404441}
-
gsennton authored
The test PolicyUrlFilteringTest#testBlacklistedUrl is sometimes failing because it is expecting an onReceivedError callback. A potential reason for this failure could be that the test is not correctly waiting for the callback to be called. BUG=623586 Review-Url: https://codereview.chromium.org/2130393002 Cr-Commit-Position: refs/heads/master@{#404440}
-
msw authored
Move BrightnessControlDelegate ownership to WmShell. (it is not closely related to AcceleratorController) tools/git/move_source_file.py ash/system/brightness_control_delegate.h ash/common/system tools/git/move_source_file.py ash/system/keyboard_brightness/keyboard_brightness_control_delegate.h ash/common/system tools/git/move_source_file.py ash/system/chromeos/keyboard_brightness_controller* ash/common/system/chromeos tools/git/move_source_file.py ash/system/chromeos/brightness/* ash/common/system/chromeos/brightness BUG=619636 TEST=compiles; unit tests; no behavior changes. R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2131733002 Cr-Commit-Position: refs/heads/master@{#404439}
-
spqchan authored
Override hasDarkTheme: in TabWindowOverlayWindow so that we return the correct value. Make sure that the indicator icon updates its color when it moves to a new window. BUG=621348 Review-Url: https://codereview.chromium.org/2126953002 Cr-Commit-Position: refs/heads/master@{#404438}
-
pkotwicz authored
BUG=None Review-Url: https://codereview.chromium.org/2137573002 Cr-Commit-Position: refs/heads/master@{#404437}
-
miguelg authored
BUG=596161,595487 Review-Url: https://codereview.chromium.org/2093953002 Cr-Commit-Position: refs/heads/master@{#404436}
-
sunnyps authored
ResourceProvider::delegated_sync_points_required_ and ResourceProvider::Child::needs_sync_tokens only toggle the creation of sync tokens by ResourceProvider but ResourceProvider always tries to verify sync tokens already associated with resources e.g. from the worker thread. This CL ensures that we don't verify sync tokens if those flags are off. R=piman@chromium.org BUG=626193 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2128773002 Cr-Commit-Position: refs/heads/master@{#404435}
-
bruthig authored
Record user actions when: - SMS Detailed view is shown - SMS message is dismissed from the detailed view - SMS message is dismissed from the notification view BUG=620508 TEST=Manual Review-Url: https://codereview.chromium.org/2129913003 Cr-Commit-Position: refs/heads/master@{#404434}
-
etiennep authored
Old way: The detection of executables is achieve by allocating an instance of each Disassembler classes and trying to call ParseHeader() to see if it succeed. This operation is done many times during FindEmbeddedElements() step, which takes ~4% of patch generation time. New way: Using QuickDetect(), which executes only a quick preliminary check, we avoid useless allocation of Disassembler objects unless there's a high probability of successfully detecting a valid executable. This change reduces the execution time of FindEmbeddedElements() by 95%. BUG=619167 Review-Url: https://codereview.chromium.org/2055343002 Cr-Commit-Position: refs/heads/master@{#404433}
-
chrishtr authored
BUG=583470 TBR=mpearson Review-Url: https://codereview.chromium.org/2127213002 Cr-Commit-Position: refs/heads/master@{#404432}
-
rogerm authored
This CL adds a table of string rewrite rules, keyed by country code, to aid in address normalization when comparing autofill profiles. The rules for each country code are stored as static constant string tables and compiled to regular expression replacement params on first use, and subsequently cached. The address rewriting rules are applied when comparing and merging the state, city, and street address of a profile to correct for synonyms, abbreviations, and some common mispellings. R=mathp@chromium.org, sebsg@chromium.org BUG=618095 Review-Url: https://codereview.chromium.org/2137533002 Cr-Commit-Position: refs/heads/master@{#404431}
-
dominickn authored
These stats will help identify how often developers catch the event and call its methods. BUG=625716 Review-Url: https://codereview.chromium.org/2121083002 Cr-Commit-Position: refs/heads/master@{#404430}
-
thestig authored
Review-Url: https://codereview.chromium.org/2130253002 Cr-Commit-Position: refs/heads/master@{#404429}
-
metzman authored
https://chromium.googlesource.com/chromium/llvm-project/llvm/lib/Fuzzer.git/+log/7ee243229b1d..3ae6b1d11024 2016-07-07 delcypher [LibFuzzer] Unbreak the build on macOS which was broken by r272858. 2016-06-30 aizatsky [libFuzzer] Let user specify extra stats file. 2016-06-23 aizatsky [libfuzzer] moving is_ascii handler inside mutation dispatcher. BUG=611337 Review-Url: https://codereview.chromium.org/2131093002 Cr-Commit-Position: refs/heads/master@{#404428}
-
rohitrao authored
The ScopedTempDir is now an ivar of the test fixture, so that it survives past the end of SetUp(). BUG=None Review-Url: https://codereview.chromium.org/2130353002 Cr-Commit-Position: refs/heads/master@{#404427}
-
estade authored
Not entirely sure this is what Sebastien had in mind, but it seems like a reasonable starting point. Will ping him to test it out after landing. BUG=609922 Review-Url: https://codereview.chromium.org/2032683003 Cr-Commit-Position: refs/heads/master@{#404426}
-
maxbogue authored
BUG=620824 Review-Url: https://codereview.chromium.org/2122333002 Cr-Commit-Position: refs/heads/master@{#404425}
-
qiangchen authored
We've finished the development of 1. Capturing a single chromium tab for desktop share 2. A new picker UI, which is more user friendly During the developement, we hide the new feature behind a flag. This CL makes the new feature default on. BUG=557222, 624898 Review-Url: https://codereview.chromium.org/2125063002 Cr-Commit-Position: refs/heads/master@{#404424}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f3eb821e..a5d8806e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2130383002 Cr-Commit-Position: refs/heads/master@{#404423}
-
marshall authored
BUG=623085 Review-Url: https://codereview.chromium.org/2134433002 Cr-Commit-Position: refs/heads/master@{#404422}
-