GitLab

BUG=None

Review URL: https://codereview.chromium.org/184103012

git-svn-id: svn://svn.chromium.org/blink/trunk@168345 bbb929c8-8fbe-4397-9dbb-9b2b20218538

MeasureTextData::processRenderer is only used within
SVGTextMetricsBuilder::measureTextRenderer, and is always set before a
call to that method. This makes a good candidate for removal from the
traversal state struct (MeasureTextData) and being passed as an argument
to measureTextRenderer instead.

There's no need to track both the last character and whether there was
a previous character. It's sufficient to track if the the last character
was a whitespace or not. (The initial case which previously had
hasLastCharacter == false can be represented as having a been a whitespace
character.) This allows replacing the two fields hasLastCharacter and
lastCharacter with a single field lastCharacterWasWhiteSpace.

MeasureTextData::skippedCharacters is reset to zero (0) at the end of
SVGTextMetricsBuilder::measureTextRenderer, and is only read or written
if MeasureTextData::allCharactersMap is non-null.
This means it can be kept on the stack of measureTextRenderer instead.

Also change the type of surrogatePairCharacters from int to unsigned,
since it's a simple counter, that should never be negative (and is used
in arithmetic with unsigned typed variables.)

Review URL: https://codereview.chromium.org/183203003

git-svn-id: svn://svn.chromium.org/blink/trunk@168342 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This does some cleanup to GYP;
only change to build is consolidating two identical gyp-time files into one.

* Move temporary list file variables to the top, with other variables
  (keeps all these lists together, removes duplicate variables, and removes
   duplicate comments)
* Add comment lines between actions (GYP files are hard to read,
  and we're going to add more actions for caching lexer/parser)
* Fix indentation so consistent
(.gyp file formatting isn't terribly consistent or linted,
but this makes reading and edits easier)

BUG=341748
R=haraken

Review URL: https://codereview.chromium.org/181063013

git-svn-id: svn://svn.chromium.org/blink/trunk@168341 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Refactoring CL, inspired by and preliminary to Terry's "speed up r-b-t" CL.
This adds a thin wrapper class, IdlCompiler, which has two methods:
* Initialization (both IdlReader and CodeGeneratorV8)
* .compile()

The resulting main() is v. simple (clear initialization/compile);
this will also make Terry's CL considerably simpler and easier to review,
since he can just instantiate this class in r-b-t and call it repeatedly.

Terry's:
Faster PYTHON IDL dependency computation and parsing.
https://codereview.chromium.org/169743005/

R=haraken

Review URL: https://codereview.chromium.org/178003010

git-svn-id: svn://svn.chromium.org/blink/trunk@168340 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Set the initial directionality to Neutral in
RenderText::computePreferredLogicalWidths. This ensures that leading and
trailing SCRIPT_COMMON characters gets the correct directionality and
thus the correct width.

TEST=fast/text/international/rtl-space-in-ltr-element.html
BUG=333004
R=leviw@chromium.org

Review URL: https://codereview.chromium.org/185123002

git-svn-id: svn://svn.chromium.org/blink/trunk@168339 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently gin::IsolateHolder of the main thread is owned by V8PerIsolateData, and gin::IsolateHolder of a worker thread is owned by WorkerScriptController. This is inconsistent. gin::IsolateHolder of worker threads should be owned by V8PerIsolateData as well.

(c.f., gin::ContextHolder is owned by V8PerContextData.)

BUG=341032
NOTRY=true

Review URL: https://codereview.chromium.org/185653002

git-svn-id: svn://svn.chromium.org/blink/trunk@168338 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=tonyg@chromium.org
BUG=348655

Review URL: https://codereview.chromium.org/177983010

git-svn-id: svn://svn.chromium.org/blink/trunk@168337 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=346132
TBR=cbiesinger@chromium.org

Review URL: https://codereview.chromium.org/183893014

git-svn-id: svn://svn.chromium.org/blink/trunk@168336 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=
CC=apavlov@chromium.org,dongseong.hwang@intel.com
BUG=

Review URL: https://codereview.chromium.org/185293013

git-svn-id: svn://svn.chromium.org/blink/trunk@168335 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=168326

BUG=258420
TBR=a.suchit@samsung.com

Review URL: https://codereview.chromium.org/181573003

git-svn-id: svn://svn.chromium.org/blink/trunk@168334 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Prior to https://src.chromium.org/viewvc/blink?revision=166428&view=revision
scroll, scale and form state was lazily serialized at the moment of
sending up the NavigationEntry message to the browser.  However, this
read-time mutation sometimes inappropriately clobbered the scroll offset
so it was deleted in the above patch.  But it's important to frequently
reserialize this state to defend against unexpected process deaths.

This patch brings a more principled approach to history save/restore:
- scroll save now happens immediately whenever one of the inputs changes.
- for scroll restore, we now attempt to do it every contents size
  change, which is similar to the policy that's proven optimal for page
  scale initialization.  This should improve usability by converging to
  the scroll position more quickly (instead of waiting until the
  progress spinner completes).
- for form fields specifically, I brought back the previous behavior of
  serializing on currentHistoryItem() calls (but added a "dirty" flag to
  do it only when needed).  This was a batching optimization dating from
  2009 (https://bugs.webkit.org/show_bug.cgi?id=31276), I'm guessing to
  avoid O(n) cost per letter when typing into huge textboxes.

NOTRY=true
BUG=344072

Review URL: https://codereview.chromium.org/172893007

git-svn-id: svn://svn.chromium.org/blink/trunk@168333 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change is to match Blink's HTML Imports implementation
match the spec change [1] which says that all imported document
should follow CSP of the master document, instead of its own.

The implementation is straightforward. It:

- Makes ContentSecurityPolicy object ref-counted and passes
  one of the master to its imported document.
- Disables <meta> directive for CSP when the document is an import.

Tests have to be changed much. As one CSP constraints all the scripts in each test,
things like shouldBe() is no longer usable in many test. Also, many imports
are now need to be servced via CORS so the change turns some of them from HTML to CGI.

Removed tests are ones that is no longer relevant: if script-src is unsafe-inline,
we cannot load any imports thus cannot test scripts in such imports.

[1] https://www.w3.org/Bugs/Public/show_bug.cgi?id=24268

BUG=334210
TEST=http/tests/htmlimports/
R=abarth@chromium.org, dglazkov@chromium.org

Review URL: https://codereview.chromium.org/183883004

git-svn-id: svn://svn.chromium.org/blink/trunk@168331 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The reported crash can't be reproduced anymore.

BUG=232903

Review URL: https://codereview.chromium.org/180213005

git-svn-id: svn://svn.chromium.org/blink/trunk@168330 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=pfeldman

Review URL: https://codereview.chromium.org/178463005

git-svn-id: svn://svn.chromium.org/blink/trunk@168328 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=168320

BUG=114658
TBR=cbiesinger@chromium.org

Review URL: https://codereview.chromium.org/176843013

git-svn-id: svn://svn.chromium.org/blink/trunk@168327 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When all rows in spanning cell are having only row spanning cells with empty
cell than None of the rows in spanning cell was not getting any height.

Total height of the rows in spanning cell should have at least spanning cell
height so apply spanning cell height in the last row of the spanning cells
if all rows in spanning cell are have zero height.
The total height of the rows in a spanning cell should be at least the height of
the spanning cell's itself because content should fit in the cell. This change
adds the remaining height to the last row because every row is belong to this cell only.

R=jchaffraix@chromium.org
BUG=258420,330564,341366,346150

Review URL: https://codereview.chromium.org/47923009

git-svn-id: svn://svn.chromium.org/blink/trunk@168326 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Change to use same logic for verifying keySystem and contentType values when creating MediaKeys and MediaKeySessions as is used for isTypeSupported(). Removes unfinished stub code in ContentDecryptionModule.

BUG=342107
TEST=manual

Review URL: https://codereview.chromium.org/183943003

git-svn-id: svn://svn.chromium.org/blink/trunk@168321 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit e0f8e760cad9f8a63e86bdf451620b5460e4b59c.

Fix tests. Followup to https://codereview.chromium.org/183763024

BUG=
TBR=dongseong.hwang@intel.com

Review URL: https://codereview.chromium.org/185773008

git-svn-id: svn://svn.chromium.org/blink/trunk@168320 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For linux only.

TBR=vollick@chromium.org
BUG=

Review URL: https://codereview.chromium.org/185693005

git-svn-id: svn://svn.chromium.org/blink/trunk@168319 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Avoid double attribute lookup in HTMLElement::matchesReadWritePseudoClass().
Instead of calling fastHasAttribute() then fastGetAttribute(), call
fastGetAttribute() directly and check if the returned value is nullAtom.

fastHasAttribute() and fastGetAttribute() do exactly the same thing internally
and the only difference is the return type. The attribute lookup is a linear
search and thus it is a good idea to avoid doing it twice.

R=adamk, eseidel

Review URL: https://codereview.chromium.org/184613003

git-svn-id: svn://svn.chromium.org/blink/trunk@168318 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Suspected of causing lots of browser_test failures on Mac:
http://build.chromium.org/p/chromium.webkit/builders/Mac10.6%20Tests/builds/23338

> Drop background color optimization for composited layers
> 
> Rationale
> 1. GraphicsLayer deals with background-color layer as a contents layer, so a
> background-color layer is in trouble in terms of the correct order with negative
> z-order children.
> 2. CompositedLayerMapping has the big hack to decide the given layer can be
> background-color layer. Unfortunately, the big hack is incomplete and invasive.
> 3. Hybrid Accelerated Rasterization will cover this optimization in more generic way.
> 4. background-color layer covers very limited cases. A layer-promoted box
> object must not have children, not have decoration, only have a background-color
> property.
> 
> BUG=114658, 340691
> TEST=compositing/background-color/background-color-drawn-over-child.html,
> compositing/*
> 
> Review URL: https://codereview.chromium.org/178013003

TBR=dongseong.hwang@intel.com

Review URL: https://codereview.chromium.org/183763024

git-svn-id: svn://svn.chromium.org/blink/trunk@168317 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This target will replace the current blink_web_test_support target. But
we need to add it first, then change Chromium to use, just after that we
will be able to remove blink_web_test_support from blink.gyp.

In fact webkit_test_support after this three side change lands,
webkit_test_support will actually be renamed to blink_web_test_support.

BUG=None
TEST=content_unittests, blink_tests
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/180743011

git-svn-id: svn://svn.chromium.org/blink/trunk@168315 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=caseq@chromium.org

Review URL: https://codereview.chromium.org/185403008

git-svn-id: svn://svn.chromium.org/blink/trunk@168314 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=168303

BUG=114658
TBR=apavlov@chromium.org

Review URL: https://codereview.chromium.org/181063017

git-svn-id: svn://svn.chromium.org/blink/trunk@168312 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=pfeldman@chromium.org, pfeldman
BUG=347496

Review URL: https://codereview.chromium.org/176843007

git-svn-id: svn://svn.chromium.org/blink/trunk@168311 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/185543006

git-svn-id: svn://svn.chromium.org/blink/trunk@168310 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=erik.corry@gmail.com, eseidel@chromium.org, jochen@chromium.org
BUG=

Review URL: https://codereview.chromium.org/183833009

git-svn-id: svn://svn.chromium.org/blink/trunk@168309 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Oilpan: Remove Persistent handles from heap allocated CSSRule objects and fix finalization of CSSKeyFramesRule which iterates its children in the destructor. There is no need to do that with oilpan.

R=erik.corry@gmail.com, wibling@chromium.org
BUG=

Review URL: https://codereview.chromium.org/177423010

git-svn-id: svn://svn.chromium.org/blink/trunk@168308 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=346642

Review URL: https://codereview.chromium.org/183923004

git-svn-id: svn://svn.chromium.org/blink/trunk@168307 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some operations such as createClosure and v8::ObjectTemplate::NewInstance
returns an empty handle when the stack is exhausted.
Promise should throw a StackOverFlow exception in such a case.

BUG=345088
R=haraken

Review URL: https://codereview.chromium.org/174073009

git-svn-id: svn://svn.chromium.org/blink/trunk@168306 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL caused a lot of failures in oilpan bots:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan/builds/1657

NOTRY=true

Review URL: https://codereview.chromium.org/185393006

git-svn-id: svn://svn.chromium.org/blink/trunk@168305 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The new implemention logs a different console message for this
case. Updated the expectation accordingly.

This CL requires Chromium CL https://codereview.chromium.org/177403002/ to be landed first.

BUG=346211
TEST=compressed-control-frame.html layout test

Review URL: https://codereview.chromium.org/177433002

git-svn-id: svn://svn.chromium.org/blink/trunk@168304 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reason for revert:
Stale expectations

Original issue's description:
> Auto-rebaseline for r168245
> 
> http://src.chromium.org/viewvc/blink?view=revision&revision=168245
> 
> BUG=114658
> TBR=dongseong.hwang@intel.com
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168273

TBR=dongseong.hwang@intel.com
NOTREECHECKS=true
NOTRY=true
BUG=114658

Review URL: https://codereview.chromium.org/180273011

git-svn-id: svn://svn.chromium.org/blink/trunk@168303 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=apavlov@chromium.org

Review URL: https://codereview.chromium.org/185553006

git-svn-id: svn://svn.chromium.org/blink/trunk@168302 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=331572
TBR=vsevik

Review URL: https://codereview.chromium.org/185383005

git-svn-id: svn://svn.chromium.org/blink/trunk@168301 bbb929c8-8fbe-4397-9dbb-9b2b20218538

r168267 contained obsolete expectations

TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/181493003

git-svn-id: svn://svn.chromium.org/blink/trunk@168300 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=168168

BUG=345609
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/183683011

git-svn-id: svn://svn.chromium.org/blink/trunk@168299 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=167970

BUG=261177
TBR=fs@opera.com

Review URL: https://codereview.chromium.org/185303009

git-svn-id: svn://svn.chromium.org/blink/trunk@168298 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=167954

BUG=342077
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/185533005

git-svn-id: svn://svn.chromium.org/blink/trunk@168297 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=167933

BUG=335212
TBR=ziran.sun@samsung.com

Review URL: https://codereview.chromium.org/185783002

git-svn-id: svn://svn.chromium.org/blink/trunk@168296 bbb929c8-8fbe-4397-9dbb-9b2b20218538