GitLab

BUG=419191
TEST=manual + new test

Review URL: https://codereview.chromium.org/738593002

Cr-Commit-Position: refs/heads/master@{#307058}

Add a synced property, elastic_overscroll, similar to page_scale_factor.

Use this property to translate the overscroll elasticity layer.

With this in place, the overscroll effect works most of the time,
when using impl-thread events.

Originally committed at r306991, reverted at r306995 due to ASAN break
due to LTI::overscroll_elasticity_layer_ not being initialized.

BUG=133097
TBR=aelias

Review URL: https://codereview.chromium.org/749393005

Cr-Commit-Position: refs/heads/master@{#307057}

When running VC++'s /analyze it says:
src\chrome\installer\mini_installer\mini_installer.cc(217) : warning
C6001: Using uninitialized memory 'ret'.

This may be a false positive but if reg is guaranteed to be initialized
before it is read then this guarantee is very subtle. The safe thing to
do is to initialize it.

This potential bug was introduce in December 2010 in:
http://codereview.chromium.org/5875003

BUG=427616

Review URL: https://codereview.chromium.org/780983002

Cr-Commit-Position: refs/heads/master@{#307056}

BUG=439346

Review URL: https://codereview.chromium.org/761863007

Cr-Commit-Position: refs/heads/master@{#307055}

VC++'s /analyze complained about peculiar use of sizeof, and the code is
peculiar.

The original code was:

memset(ref, 'X', sizeof(char) * arraysize(buf));

Validating the correctness of this requires knowing that buf and ref
have the same number of elements, and requires knowing that ref is an
array of 'char'. It is simpler and safer to do this:

memset(ref, 'X', sizeof(ref));

The warning was:

src\base\strings\safe_sprintf_unittest.cc(64) : warning C6260:
sizeof * sizeof is usually wrong.  Did you intend to use a character count
or a byte count?

This change will not change the behavior of the code, just its
readability.

This code was introduced in:
https://chromiumcodereview.appspot.com/18656004

BUG=427616

Review URL: https://codereview.chromium.org/774933011

Cr-Commit-Position: refs/heads/master@{#307054}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/95f9b5f..22c9ae1

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=halcanary@google.com

Review URL: https://codereview.chromium.org/777423002

Cr-Commit-Position: refs/heads/master@{#307053}

BUG=none
TEST=none
R=jam@chromium.org

Review URL: https://codereview.chromium.org/758463003

Cr-Commit-Position: refs/heads/master@{#307052}

This is done by turning scoped_ptr<PrefixSet> into scoped_ptr<const PrefixSet>.

While this doesn't fully address the issue of making sure there are no
updates on other threads it does help any readers trying to prove this
for themselves.

BUG=None

Review URL: https://codereview.chromium.org/781613002

Cr-Commit-Position: refs/heads/master@{#307051}

BUG=chromedriver:416
TBR=stgao@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/776233004

Cr-Commit-Position: refs/heads/master@{#307050}

device/bluetooth will soon be accessed by content/browser. This
change converts it from a static library to a shared component.

BUG=438305

Review URL: https://codereview.chromium.org/778443002

Cr-Commit-Position: refs/heads/master@{#307049}

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/781623002

Cr-Commit-Position: refs/heads/master@{#307048}

BUG=chromedriver:992
TBR=stgao@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/764373003

Cr-Commit-Position: refs/heads/master@{#307047}

BUG=437085

Review URL: https://codereview.chromium.org/778923003

Cr-Commit-Position: refs/heads/master@{#307046}

- Expand the PromiseErrorFilter to allow multiple types of errors to be filtered out.

- Add a new type of allowed error, namely errors from the compiler failing to
  unwrap the result of a returned Promise chain.  Example:

  /** @return {!Promise<string>} */
  var getStringAsync = function() {
    /** @return {!Promise<string>} */
    var generateString = function() {return Promise.resolve('foo');};
    return Promise.resolve().then(generateString);
  };

  The compiler will emit an error that looks like

  ERROR - inconsistent return type
  found   : Promise<Promise<string>>
  required: Promise<string>

BUG=406995

Review URL: https://codereview.chromium.org/776273003

Cr-Commit-Position: refs/heads/master@{#307045}

This removes some uses of Bit('target_ARCH'), the definitions of which
have been removed from the NaCl side.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=2703
TEST=nacl_integration

Review URL: https://codereview.chromium.org/778173002

Cr-Commit-Position: refs/heads/master@{#307044}

This was checked with the following command line:

$ out/Debug/gn check out_gn/Debug //ui/*

And cleaned until it reported "Header dependency check OK".

BUG=367595,376000
TEST=see above
R=sky@chromium.org

Review URL: https://codereview.chromium.org/769943003

Cr-Commit-Position: refs/heads/master@{#307043}

Replace direct access to kGoogleServicesUsername with calls to SigninManager.  There is no functional change in this CL.

Some places outside SigninManager still use the pref, like one_click_signinin and ProfileIOData, but that is deprecated code that will go away.  I will remove that code in separate CLs.

BUG=107160

Review URL: https://codereview.chromium.org/763673002

Cr-Commit-Position: refs/heads/master@{#307042}

Google to other.

This also resets the pref to off if they go away from Google.

BUG=437889

Review URL: https://codereview.chromium.org/780703004

Cr-Commit-Position: refs/heads/master@{#307041}

app_shell is pure-aura, so cannot rely on the usual views::WebView and
views::Widget initial-focus behavior. It must manually set focus on the
WebContents during creation.

BUG=438751
TEST=added to app_shell_browsertests ShellApiTest

Review URL: https://codereview.chromium.org/754313003

Cr-Commit-Position: refs/heads/master@{#307040}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a9bf1aa..95f9b5f

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=halcanary@google.com

Review URL: https://codereview.chromium.org/756423007

Cr-Commit-Position: refs/heads/master@{#307039}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/fde5bea..e542608

TBR=schenney@chromium.org,dominicc@chromium.org

Review URL: https://codereview.chromium.org/757943003

Cr-Commit-Position: refs/heads/master@{#307038}

TBR=avi@chromium.org for comment-only change in content/public

Review URL: https://codereview.chromium.org/780783004

Cr-Commit-Position: refs/heads/master@{#307037}

With this patch work on "Allow to collect URL?" bubble starts. View of bubble is implemented. But
bubble itself never will be shown to a user

BUG=435080
R=vabr@chromium.org

Review URL: https://codereview.chromium.org/765073004

Cr-Commit-Position: refs/heads/master@{#307036}

This rolls the AOSP manifest to match build 1622219 and the glue
layer to the most recent version.

BUG=None
TESTS=build

Review URL: https://codereview.chromium.org/781833003

Cr-Commit-Position: refs/heads/master@{#307035}

The changes trickle through the DLL loader as well.

BUG=24672
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/775383002

Cr-Commit-Position: refs/heads/master@{#307034}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/96e3f0f..fde5bea

TBR=schenney@chromium.org,dominicc@chromium.org

Review URL: https://codereview.chromium.org/778153002

Cr-Commit-Position: refs/heads/master@{#307033}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/0be41a0..a9bf1aa

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=halcanary@google.com

Review URL: https://codereview.chromium.org/751383003

Cr-Commit-Position: refs/heads/master@{#307032}

BUG=None

Review URL: https://codereview.chromium.org/781443004

Cr-Commit-Position: refs/heads/master@{#307031}

Fixing issues introduced by https://codereview.chromium.org/719463003/.

- Fixing the constant suffix in case of boolean action
- comment fix for mocks.

BUG=439328

TBR=phajdan.jr@chromium.org, brettw@chromium.org

Review URL: https://codereview.chromium.org/757233004

Cr-Commit-Position: refs/heads/master@{#307030}

BUG=none

Review URL: https://codereview.chromium.org/771253003

Cr-Commit-Position: refs/heads/master@{#307029}

ProxyPolicyProvider and ForwardingPolicyProvider seemed to be
similar-purpose judging by the name, but that's far from accurate.
This change adds more documentation and renames
ForwardingPolicyProvider to SchemaRegistryTrackingPolicyProvider in an
attempt to clarify the situation for readers coming after me.

BUG=None
TEST=No functional changes.

Review URL: https://codereview.chromium.org/775613004

Cr-Commit-Position: refs/heads/master@{#307028}

Remove ios::SupportsUserData shim in favor of directly using
base::SupportsUserData since the shim didn't bring anything
except friction.

BUG=429756

Review URL: https://codereview.chromium.org/781643004

Cr-Commit-Position: refs/heads/master@{#307027}

Unfortunately these are not the droids we're looking for.

BUG=388741

Review URL: https://codereview.chromium.org/783533002

Cr-Commit-Position: refs/heads/master@{#307026}

BUG=439149
TEST=Happy thread sanitizer.

Review URL: https://codereview.chromium.org/773393004

Cr-Commit-Position: refs/heads/master@{#307025}

Revert of [Telemetry] Fix video_unittest so that it actually runs on bots. (patchset #6 id:100001 of https://codereview.chromium.org/756553003/)

Reason for revert:
Looks like this broke telemetry_unittests
Build link:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/17356

Output:
[284/694] telemetry.core.video_unittest.VideoTest.testFramesFromMp4 failed unexpectedly:
  Traceback (most recent call last):
    File "/mnt/data/b/build/slave/Linux_Tests/build/src/tools/telemetry/telemetry/decorators.py", line 84, in wrapper
      func(*args, **kwargs)
    File "/mnt/data/b/build/slave/Linux_Tests/build/src/tools/telemetry/telemetry/core/video_unittest.py", line 35, in testFramesFromMp4
      for i, timestamp_bitmap in enumerate(video_obj._FramesFromMp4()):
    File "/mnt/data/b/build/slave/Linux_Tests/build/src/tools/telemetry/telemetry/core/video.py", line 158, in _FramesFromMp4
      dimensions = GetDimensions(self._video_file_obj.name)
    File "/mnt/data/b/build/slave/Linux_Tests/build/src/tools/telemetry/telemetry/core/video.py", line 137, in GetDimensions
      output)
  AssertionError: Failed to determine video dimensions. output=avconv: error while loading shared libraries: libavdevice.so.53: cannot open shared object file: No such file or directory

Original issue's description:
> [Telemetry] Fix video_unittest so that it actually runs on bots.
>
> This also makes it explicitly clear that the avconv dependency is currently linux only.
>
> I had another CL out a while ago that fixes this, but that CL's blocked, so I'm separating this out.
>
> BUG=433943
>
> Committed: https://crrev.com/eae4959498c328f8e3fa710b1d507c0d68225b18
> Cr-Commit-Position: refs/heads/master@{#306858}

TBR=tonyg@chromium.org,slamm@chromium.org,mthiesse@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=433943

Review URL: https://codereview.chromium.org/748873003

Cr-Commit-Position: refs/heads/master@{#307024}

Looks like a typo from https://codereview.chromium.org/740633006

BUG=439353

Review URL: https://codereview.chromium.org/778143002

Cr-Commit-Position: refs/heads/master@{#307023}

function normally.

Other classes that depend on DeviceCloudPolicyStore to work normally include
CloudPolicyManager, CloudPolicyService, and CloudPolicyInvalidator.

PolicyUI, VersionInfoUpdater, SystemTrayDelegateChromeOS, and
PolicyHeaderService also observe on DeviceCloudPolicyStore, but they don't
really use the policy from the store and can work either way.

BUG=chromium:353050
TEST=unit_tests

Review URL: https://codereview.chromium.org/782483002

Cr-Commit-Position: refs/heads/master@{#307022}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6c3c386..96e3f0f

TBR=schenney@chromium.org,dominicc@chromium.org

Review URL: https://codereview.chromium.org/755653007

Cr-Commit-Position: refs/heads/master@{#307021}

Revert of Revert of Cleanup: Update the path to vector2d_f.h header. (patchset #1 id:1 of https://codereview.chromium.org/771283003/)

Reason for revert:
This didn't cause the issue. As noted in https://codereview.chromium.org/781863004/#msg8

Original issue's description:
> Revert of Cleanup: Update the path to vector2d_f.h header. (patchset #1 id:1 of https://codereview.chromium.org/781863004/)
>
> Reason for revert:
> Breaks Win8 GN and Win8 GN(dbg) builders
>
> Original issue's description:
> > Cleanup: Update the path to vector2d_f.h header.
> >
> > The geometry headers were moved from /ui/gfx/ to ui/gfx/geometry, so
> > we are updating the include paths to fix this.
> >
> > BUG=395370
> > TEST=gfx_unittests
> > TBR=sky@chromium.org,danakj@chromium.org
> >
> > Committed: https://crrev.com/b486216287a3e1f30e81f70444f889d321b7819a
> > Cr-Commit-Position: refs/heads/master@{#306960}
>
> TBR=danakj@chromium.org,sky@chromium.org,tfarina@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=395370
>
> Committed: https://crrev.com/0dffffd306e8e21bd027b26e947ec8b5ffcdfa51
> Cr-Commit-Position: refs/heads/master@{#306962}

TBR=danakj@chromium.org,sky@chromium.org,samli@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=395370

Review URL: https://codereview.chromium.org/762063006

Cr-Commit-Position: refs/heads/master@{#307020}

Cr-Commit-Position: refs/heads/master@{#307019}