- 03 Mar, 2020 40 commits
-
-
Mark Cogan authored
This CL refactors the tab restoration classes for multi-window, scoping some functions to a Browser, and removing use of TabModelList. Non-functional changes: * TabRestoreDelegateImplIOS (which is the iOS implementation of the sessions::LiveTabContext API, not "TabRestoreDelegate") was a keyed service. It's renamed to LiveTabContextBrowserAgent and (accordingly) scoped to a Browser (on desktop, Browser directly implements this API. * The associated factory class is removed. * TabRestoreServiceClient is updated to use Browser and BrowserList instead of TabModel and TabModelList. * The RestoreTab() helper function is updated to take a Browser param instead of a BrowserState. FUNCTIONAL CHANGE: Previous to this CL, IOSChromeTabRestoreServiceClient's implementation of CreateLiveTabContext() simply returned the (single) BrowserState- scoped sessions::LiveTabContext implementation. Looking at the desktop implementation of this function, it appears to create a new window: https://cs.chromium.org/chromium/src/chrome/browser/sessions/chrome_tab_restore_service_client.cc?type=cs&g=0&l=35 While that might be a desirable behavior when multi-window is supported, we don't yet have a set of hooks available to do that cleanly; nor do we want to instead return some arbitrary, already-opened window. It looks like the call sites for this (in TabRestoreServiceHelper) are: - When restoring a session by ID with the WINDOW type, and - When restoring a tab without a provided context or with the NEW_WINDOW disposition. ios/ doesn't currently have code paths that do either of these, and this CL adds a check in the RestoreTab helper to guard against them. Then, the implementation of CreateLiveTabContext() now is a NOTREACHED() no-op. crbug.com/1056596 tracks adding support for window restoration with multi-window. Bug: 1056208 Change-Id: Ib51ea7ea6efd3a51e6ec07d031e1a3ae1203579b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078915 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746384}
-
Xi Han authored
CachedFeatureFlag values are set by @Features.EnableFeatures and @Features.DisableFeatures after this CL. Bug: 1056327 Change-Id: Ie4bbc9f21908ef3f7e9336c7d558165a54837381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075972 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#746383}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/56364b6b6026..bbbd9a2a1f41 git log 56364b6b6026..bbbd9a2a1f41 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 cepheus@frii.com Fix #1843: Handle built-in function output parameters to a swizzled arg Created with: gclient setdep -r src/third_party/glslang/src@bbbd9a2a1f41 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: I79a75d05ef8e8faf7bae1a2584130517ddf9e3a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083967Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746382}
-
Anna Malova authored
Bug: 1007815 Change-Id: I1cf38ed3882ae5c01690cd18e706deffef7e91c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083485Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#746381}
-
Ian Clelland authored
This affects the parsing and serialization of tokens in structured headers draft 15 and above. When operating in Draft 9 mode for backwards compatibility, a character sequence beginning with an asterisk will be parsed as a byte sequence instead. Bug: 1048756 Change-Id: I5b1e2a57501a2e2dedb1183f495f71d75146c46b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084711Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#746380}
-
Anna Malova authored
Bug: 1007815 Change-Id: I72241731610b566ca062ff95f8fd94289999b3a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083327Reviewed-by:
-
Harald Alvestrand authored
This is a read-only attribute revealing a detail from the SDP offer/answer exchange. Spec: https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-cantrickleicecandidates Bug: chromium:708484 Change-Id: I8fab2050bac0237cb513d70c8c257a54bdc0a4b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082512Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#746378}
-
Anna Malova authored
Bug: 1007815 Change-Id: I55de9222c2fe53148a3e73524db8cc668a34b4a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083324Reviewed-by:
-
Anna Malova authored
Bug: 1007815 Change-Id: I225112c7fcd440a7f67980ccca934593d6110e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083182Reviewed-by:
-
Anna Malova authored
Bug: 1007815 Change-Id: I7dae325790cbd7f9cca45659ee0f7ec9ec27f63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083544Reviewed-by:
-
Anna Malova authored
Bug: 1007815 Change-Id: I09fad24dfee175d0456e12333b063ac57b2c0193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083543Reviewed-by:
-
Jonathan Backer authored
This reverts commit d32b3d49. Bug: 1037939 Change-Id: I150adeacc788d6e06e7c41b7ce00b4edd8cddc94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989034Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#746373}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e36af5c1ab9b..db533a37a8ca Created with: gclient setdep -r src-internal@db533a37a8ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Idecc3a5456dff651e768734dae29f4669929462b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083964Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746372}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/06b6db68ff7e..6e9087162a1c git log 06b6db68ff7e..6e9087162a1c --date=short --first-parent --format='%ad %ae %s' 2020-03-03 dneto@google.com Get spirv.hpp from SPIRV-Headers, not Glslang (#992) Created with: gclient setdep -r src/third_party/shaderc/src@6e9087162a1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I3d264570307be0a48f0f533a645d85cb9f1c4816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083966Reviewed-by:
-
Yoichi Osato authored
That's because we won't send body with the request. This CL also refactors CopyHeadFrom function to take reference than pointer because all arguments must not be null. Bug: 787704 Change-Id: I426c0251772cede8d130a24c298f99d005ac345c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082853Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#746370}
-
Tim van der Lippe authored
This test was replaced by an e2etest in https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2083316 TBR=aerotwist@chromium.org Bug: 1044632 Change-Id: Ie1fd5772d3139aa4b61a725cd271bd4bf6feec60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084853Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#746369}
-
shivanigithub authored
Change-Id: I0225bfb6a17f9a914eb317ee814d729778fc4e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079095Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#746368}
-
Ehimare Okoyomon authored
Changed edit_exception_dialog.js from site settings to follow the same exception pattern setting as add_site_dialog.js Bug: 1057091 Change-Id: I7d1337197df0fc7bc294df077eb433b90820c661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082379 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#746367}
-
Bret Sepulveda authored
To ensure permission bubbles are consistent with other bubbles in width, this patch tweaks CalculatePreferredSize so that it is always DISTANCE_BUBBLE_PREFERRED_WIDTH dips wide instead of sometimes snapping to a larger size. Change-Id: Ifed85665168ffccf2d8fda1e34f489a51c11f085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082570Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#746366}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/853789cdfe3c..96c2eb6258ae git log 853789cdfe3c..96c2eb6258ae --date=short --first-parent --format='%ad %ae %s' 2020-03-03 borenet@google.com [recipes] Move nanobench flags logic into gen_tasks_logic/nanobench_flags.go 2020-03-03 borenet@google.com [recipes] Compute nanobench flags in gen_tasks 2020-03-03 borenet@google.com [recipes] Move nanobench flags to a separate file Created with: gclient setdep -r src/third_party/skia@96c2eb6258ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: I888c5a94b2babf88cdcce4b0cdd27c9e3c2d6078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083963Reviewed-by:
-
Stepan Khapugin authored
Groups all per-window shutdown code together and moves it before the other shutdown code to match expected behaviour of shutdown in multiwindow world. Bug: none Change-Id: I7abf63beecd3d2d6c0479da9c9a6f31477f3ae53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084595Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746364}
-
Stepan Khapugin authored
Moves AppURLLoadingService to SceneController. Change-Id: Ifc8053cf455918fed6839646be65f22fd7d35a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081427Reviewed-by:
-
Maksim Moskvitin authored
All usages already replaced with TopicInvalidationMap. Additionally, this CL adds tests for TopicInvalidationMap (based on the tests we had for ObjectIDInvalidationMap) and cleans up its interface from redundant ToString() and ResetFromValue(). There should be no behavioral changes. Bug: 1029698 Change-Id: I81c9e9aa5e00fd196fe8911b92f5c11b5d1f280a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078473 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#746362}
-
Andrew Solovey authored
Force log out unauthenticated enterprise users if |ForceLogoutUnauthenticatedUserEnabled| policy is set to true. |ChromeOSLimitedAccessAccountReconcilorDelegate| is being refactored to support two different types of accounts: child and enterprise with |ForceLogoutUnauthenticatedUserEnabled|. The ReconcilorDelegate logic connected with child accounts remains unchanged. Bug: b/146461662 Change-Id: Ic340ea3d59537f8c1092362ae0c8e32756bbb26f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058820 Commit-Queue: Andrei Salavei <solovey@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#746361}
-
Eugene Girard authored
Bug: 1057351 Change-Id: Id33f6092a76ea69ad92607fe0ebf7e397aca0654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083386 Commit-Queue: Eugene Girard <girard@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#746360}
-
Daniel Vogelheim authored
Remove unused functions and associated unit tests. This prepares for changes to rename & change the trusted_types_util.h interfaces. Bug: 739170 Change-Id: I45ddf92d5946cb72a33ae4fba2bfb8d04f8c4d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078611 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Yifan Luo <lyf@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#746359}
-
Ramin Halavati authored
Update AmbientAuthenticationInPrivateModesEnabled description and example value. Bug: 458508 Change-Id: Icc6e91ec5cfe15cc37886ebd52d4401b77b24e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081422 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#746358}
-
Bret Sepulveda authored
On Linux, the extensions menu bounds can appear off the screen in tests on the bots, which is causing the tests to be flaky. Since the menu doesn't have any control over where it appears, this patch just disables those checks to stop the failures. Bug: 1050012 Change-Id: I10bbf42cee6985eca82c60cf5c6e769cf7e81ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080352 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#746357}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/29f04c8cdb9b..8ff2fc8fcdb1 git log 29f04c8cdb9b..8ff2fc8fcdb1 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 rsavitski@google.com Merge "traced_perf: pid/cmdline target white/black-listing" Created with: gclient setdep -r src/third_party/perfetto@8ff2fc8fcdb1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ied3d638fa7e898df6144853d5959651ff03a2567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083961Reviewed-by:
-
Mohamed Amir Yosef authored
Whether saving in the account store should be guarded by the current settings not the current state. This is relevant for when the user just opted in butter, it may take couple of seconds till the passwords get synced. We shouldn't however block storing in the account store in the meanwhile. Bug: 1012203 Change-Id: Ieac2799b88ab8d8d64dee84bbd51450af82790ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083453Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Adds the screen to be shown when there are no passwords to show. The current image is a placeholder while the final version is ready. Bug: 1045448 Change-Id: I7f5a6cdcd6f564d78d0ea25bc82312b23d8ddd14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082922 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746354}
-
Side Yilmaz authored
PassphraseDialogFragment. |Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates PassphraseDialogFragment class. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: I3153d152820781be684fc0fd0a7ff00d45c6981b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082912Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#746353}
-
Jonathan Backer authored
Bug: 1019787 Change-Id: I3f3121b7da6e46a9558ac0a2058b9ba8239fea84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078772 Auto-Submit: Jonathan Backer <backer@chromium.org> Reviewed-by:
-
Kenneth Russell authored
Due to flakiness seen, add RetryOnFailure expectation on GeForce GTX 1660 for deqp/functional/gles3/framebufferblit/depth_stencil.html . Bug: 1057635 Change-Id: I7140dc317fc229ddaf62c85ccfdc70049894ae6b Tbr: jmadill@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081619Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#746351}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7e2188de..189353b3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6e68b952753daefd30bbbfbecb4d6dcdac98a52c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084511Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746350}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: Ie729809d9a64635b28828461aaf84d01105b0719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083448Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746349}
-
Javier Ernesto Flores Robles authored
Adds the screen to be shown when the passwords are erased due a sign out. The current image is a placeholder while the final version is ready. Bug: 1045452 Change-Id: Ifccdbd64618e28d8c670aa80adf6b02b76e90b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084593 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9ee726959e1f..e36af5c1ab9b Created with: gclient setdep -r src-internal@e36af5c1ab9b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic33623039df13345f92a406a8927d3b3dc21a65a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083960Reviewed-by:
-
Paul Lewis authored
Bug: 1032561, 1046784 Change-Id: I8de085643cd605e3f12b7640b703157f9bfbb176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082386Reviewed-by:
-
Nico Weber authored
MSVC_PUSH_DISABLE_WARNING (and MSVC_POP_WARNING) had a few (no-op) uses that needed cleaning up. MSVC_DISABLE_OPTIMIZE (and MSVC_ENABLE_OPTIMIZE) have no uses and can just be removed. Bug: 1053958 Change-Id: Ic4e3a4c7443988d4621d79e02b348f1a3628730f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082353 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#746345}
-
