- 19 Oct, 2017 40 commits
-
-
Michael Giuffrida authored
Associate words relating to association with properly associated spelling by associating letters associated with association-related words with each other in a specific order associated with the correct spelling of the word "associate." Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:closure_compilation Change-Id: Ie5647f5e3fdbba7fc3e6aaf6d85cb0d86cc7f999 Reviewed-on: https://chromium-review.googlesource.com/727559Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#510200}
-
Tom Sepez authored
Move mac-specific InitializeSandboxInternal routine from content/ into this file. More platforms to follow. Rename existing class Sandbox to SandboxMac to avoid collisions. Also remove some redundancy in SandboxMac method naming, and normalize content's InitializeSandbox overloads. Change-Id: Ib0388539c16b87b0a766492d3717bcb3ea1349cf Reviewed-on: https://chromium-review.googlesource.com/726528 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#510199}
-
Theresa Wellington authored
BUG=746712 Change-Id: I8fc4116433defb3ec7fe973d071c65f2885aeaee Reviewed-on: https://chromium-review.googlesource.com/728341 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#510198}
-
Xiyuan Xia authored
- Replace eula iframes with webview; - Load chrome://terms via XHR and set to webviews via data url to re-use existing online/local/oem terms loading code; - Get rid of padding for .eula-frame css class as webview looks good without it; - Move online terms loading from ChromeOSTermsHandler to Oobe Eula webui; - Re-write EulaTest since old tests are testing chrome://terms in a tab; - Move EulaTest from interactive_ui_tests to browser_tests since it no longer uses ui_test_utils::FindInPage; Bug: 770313 Test: Manual. Verify Eula screen works with MD/non-MD/language change. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2d90492958d0adae06a3e873942f2d3f534f7991 Reviewed-on: https://chromium-review.googlesource.com/710738Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#510197}
-
Steven Bennetts authored
Most UI code uses |guid| (aka |network_id|) now and not service_path. NetworkStateNotifier was missed in the conversion causing subtle error notification failures. Recent changes to the low level DBus code turned that into a crash. Bug: 775779 Change-Id: I3442d02c956ba6948f1c2d03ff500b58af9e58c8 Reviewed-on: https://chromium-review.googlesource.com/727521 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kevin Cernekee <cernekee@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#510196}
-
Sandeep Vijayasekar authored
In cases where the system is out of disk space, the system occasionally runs free_cache which will remove any minidump files currently on disk. BUG=internal b/62552143 TEST=cleared cache no longer crashes process Change-Id: I7af1d0d776536c205e79a59d9748d73e5aab4ce1 Reviewed-on: https://chromium-review.googlesource.com/727721Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Sandeep Vijayasekar <sandv@chromium.org> Cr-Commit-Position: refs/heads/master@{#510195}
-
Patrick Monette authored
Changed SetUpDefaultCommandLine to SetUpCommandLine in order to not override the base implementation. Hopefully resolves the timeouts seen in this test on some builders. Bug: 764079 Change-Id: Ibe596ddabad3f58e9f66c5879db048d353f1a2e2 Reviewed-on: https://chromium-review.googlesource.com/723668Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#510194}
-
Ria Jiang authored
1. For invisible windows that are not on screen. 2. For children of a child surface. If a window has local_surface_id set then that window is a child surface and should be responsible for submitting hit-test data for its children. Considered setting the event targeting policy for that window to be TARGET_ONLY but we do check that flag in non-viz hit-test so prob shouldn't change that. Bug: 732395 Test: aura_unittests Change-Id: Ie70c75e3d0145b56cf42110b4eab2f169741bdf6 Reviewed-on: https://chromium-review.googlesource.com/726544Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#510193}
-
Sylvain Defresne authored
Bug: 754050 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I455f44efdbc02214a51d182460baeb1ab224383d Reviewed-on: https://chromium-review.googlesource.com/728334Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#510192}
-
Carlos Knippschild authored
Fixes the OfflinePages.ClearStoragePreRunUsage.* series of metrics -- renaming them to ClearStoragePreRunUsage2 -- so that they report their values in KiB. They were previously expected to be reported in MiB but were incorrectly reported in bytes. Bug: 775321 Change-Id: Ia12f0c039172292770ee066efc128b0fd9c8204e Reviewed-on: https://chromium-review.googlesource.com/722033 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#510191}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ae262c24..c032d789 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I9516cd259eca224771f2e76aefb69c47e1d3648f Reviewed-on: https://chromium-review.googlesource.com/728539Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#510190}
-
Andrew Grieve authored
This reverts commit 0462fc40. Reason for reland: Leaving keystore and empty/ until recipes updated and bots build. TBR=thakis Bug: 375324,776328,776351 Change-Id: I8c8cfc0b94ce681772c3792799011e77d72d81d9 Reviewed-on: https://chromium-review.googlesource.com/728460 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#510189}
-
Tao Bai authored
Android autofill won't work with application context, disable Autofill if WebView is created with application context. Also add a warning log. Bug: 776152 Change-Id: I3b9b05b43c6359b4f5f4339699b4143b1d0b84ad Reviewed-on: https://chromium-review.googlesource.com/726968Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#510188}
-
John Abd-El-Malek authored
Since the network service doesn't know about blobs, the renderer sends a data pipe of the blob. BUG= 761117 Change-Id: I362a6afff33002c8f3758a19c9f0f0268c1c7f89 Reviewed-on: https://chromium-review.googlesource.com/721241 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#510187}
-
Geoff Lang authored
These failures went away with the bot driver upgrade. BUG=773823 TBR=zmo@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I01153c2213d10c70037217fb63549630b343ab61 Reviewed-on: https://chromium-review.googlesource.com/728324 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#510186}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/68708e4344b9..943360187bb8 $ git log 68708e434..943360187 --date=short --no-merges --format='%ad %ae %s' 2017-10-19 hnakashima Fix integer overflows in cfx_font.cpp. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I27ec02c5815a138e7217d15bbdff095d2c5e0f0a Reviewed-on: https://chromium-review.googlesource.com/728330 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#510185}
-
Yixin Wang authored
This CL lands internal change 166256846 by wangyix. BUG=488484 Change-Id: Idb25c187d402edc5e6c180c529fc3eede2c416bf Reviewed-on: https://chromium-review.googlesource.com/620201 Commit-Queue: Yixin Wang <wangyix@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#510184}
-
rnephew authored
TBR=charliea@chromium.org,nednguyen@google.com Change-Id: Iae8eef1ccdbf192ffac79cfd3f4ef80ba249f7d0 Reviewed-on: https://chromium-review.googlesource.com/728351Reviewed-by:
rnephew <rnephew@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#510183}
-
Biao She authored
This CL adds an invisible button which should trigger voice search. Note that the UI will change significantly. The main purpose of this CL is to add speech recognition API wrapper. Bug: 773767 Change-Id: If760a88cc950b231d3b2c14b94403afd8f23c56b Reviewed-on: https://chromium-review.googlesource.com/701174 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#510182}
-
danakj authored
When a fatal error happens on ChromeOS, we will crash the browser, so these logs will be present in the crash report which will be important in case any are wrong or we need to debug a device failure. For other platforms they will help explain why the compositor drops into software compositing (or why android aborts and crashes as well). R=piman@chromium.org Bug: 772574 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I10fa8230a210df96b29d9d3767c0cd1e8d57a775 Reviewed-on: https://chromium-review.googlesource.com/727190 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#510181}
-
Julia Tuttle authored
Bug: 763433 Change-Id: Id314290c18ff7d6c7d2f2c4c995002a3434d734e Reviewed-on: https://chromium-review.googlesource.com/648028 Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Chris Bentzel <cbentzel@chromium.org> Cr-Commit-Position: refs/heads/master@{#510180}
-
bsheedy authored
Include a few Python scripts in the build target that are necessary for running the test on swarming. Bug: Change-Id: I9301db91c6e8024d9bc3beae49b74c89b4827d2c Reviewed-on: https://chromium-review.googlesource.com/728384Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#510179}
-
tzik authored
scoped_refptr is allowed in Blink now, and WTF::RefPtr is an alias of scoped_refptr for migration. This CL inlines the alias to the RefPtr users in core/css to remove RefPtr. Bug: 763844 Change-Id: I45575d76738769f0ff0747278d03274c37268f80 Reviewed-on: https://chromium-review.googlesource.com/727646Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#510178}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/22e74ebb13a5..76a8dd7e8a11 $ git log 22e74ebb1..76a8dd7e8 --date=short --no-merges --format='%ad %ae %s' 2017-10-19 benjhayden Add a_tracing_uri to add_histograms_queue. 2017-10-18 bsheedy Add VrCore permission to blacklist 2017-10-18 benjhayden Replace RelatedHistogramBreakdown in memoryMetric with RelatedNameMap. 2017-10-18 tiborg [vr] Calculate frameCycleDurationMetric based on VR AnimationExpectation Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ib0a50262c44deb5ad21df752a86e479eb8e5ae7c Reviewed-on: https://chromium-review.googlesource.com/728356 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#510177}
-
Philippe Hamel authored
This CL depends on https://chromium-review.googlesource.com/c/chromium/src/+/723589 Bug: 759161 Change-Id: I8f4334b53a185fa4354d1e78e243c69a7e41a488 Reviewed-on: https://chromium-review.googlesource.com/724122Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Philippe Hamel <hamelphi@chromium.org> Cr-Commit-Position: refs/heads/master@{#510176}
-
Katie Dektar authored
This allows automation API users to determine if something should be ignored because it isn't visible to the user. It generally applies to elements with 0 height and overflow:hidden whose contents also have no size. Bug: 773851 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia656a5907191aaad71dd2315e3f60a21fbecb6d8 Reviewed-on: https://chromium-review.googlesource.com/726242 Commit-Queue: Katie Dektar <katydek@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#510175}
-
Olli Etuaho authored
This field will be removed once support for arrays of arrays is added in ANGLE. Access array size through helper functions that will be kept instead of using the arraySize field directly. BUG=angleproject:2125 TEST=gpu_unittests Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id8b2c6deec0760beed47780a4b7bd5c9b17834f8 Reviewed-on: https://chromium-review.googlesource.com/728262Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#510174}
-
Xing Liu authored
This CL exposes the content layer's fetch_error_body flag in download service. Bug: 765778 Change-Id: I2f9ea5b437387e6e1864fb1867436869b6348472 Reviewed-on: https://chromium-review.googlesource.com/707780Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#510173}
-
bsheedy authored
Makes pages in the WebVR benchmark exit VR and navigate to a blank page after everything else is done. This is to prevent unnecessary heat generation caused by staying in VR while the traces are being processed. This only has a minimal affect on devices that process the trace data quickly, but on very slow devices (e.g. Raspberry Pis), this has a significant effect on generated heat. Bug: Change-Id: I21b7efdf141b4241f91f29908827c9f430a11c9c Reviewed-on: https://chromium-review.googlesource.com/728337 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#510172}
-
Aaron Leventhal authored
The ax_dump_tree output puts out a lot of information, which can be too noisy to efficiently read. This supports property filtering as follows: ax_dump_tree --filters=[FILTERS_TEXT_FILE] The filters file can have @ALLOW, @ALLOW-EMPTY and @DENY rules, similar to the dump accessibility tree browsertests. It is not necessary to have a platform prefix (e.g. @WIN- or @MAC-). The role of the object cannot be filtered, but any other properties can. If no filters are provided then all properties are shown. Example, to filter out everything except role, name and value, use: @ALLOW:name=* @ALLOW:value=* Put each filter on a separate line. For more info on writing rules, see https://cs.chromium.org/chromium/src/content/test/data/accessibility/readme.md Bug: 771747 Change-Id: If15a5c6f6baf6a1827749dae16825242a0913913 Reviewed-on: https://chromium-review.googlesource.com/725879 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#510171}
-
Bill Budge authored
This reverts commit 0ad0d051. Reason for revert: This doesn't actually help V8, so I'm removing it for now. Original change's description: > [page_allocator] Support predictable ASLR calculation for fuzzers. > > - Adds a 'initial_seed' parameter to GetRandomPageBase, which defaults > to 0. If non-zero, generates a predictable sequence, using the value > as the initial seed. > - Adds a unit test for the predictable sequence. > > Bug: chromium:756050 > Change-Id: Iaf718baa2b7d49dc8eda7b0f97aa12b576ddca28 > Reviewed-on: https://chromium-review.googlesource.com/703509 > Commit-Queue: Bill Budge <bbudge@chromium.org> > Reviewed-by: Chris Palmer <palmer@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509575} TBR=palmer@chromium.org,bbudge@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:756050 Change-Id: I0f6a3618465470e93b7981580cb547474456dda9 Reviewed-on: https://chromium-review.googlesource.com/728459 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#510170}
-
David Tseng authored
Bug: None Test: braille routing over rich contextual output routes selection within rich text. For example, routing over'tbl' moves the selection to the beginning of the table (i.e. a selection on the table node). Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I02bfbcf8e48dbb502f1e031c67bc778a219e4a92 Reviewed-on: https://chromium-review.googlesource.com/726383Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#510169}
-
David Reveman authored
Capture was failing because data URLs are sometimes too long. This avoids the use of GURLs with this limitation and creates object URLs for PNG images to ensure that they are displayed correctly. Bug: 773981 Test: manual Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9dd19aa346874a690f1fab2965baec69c9f6f3c2 Reviewed-on: https://chromium-review.googlesource.com/724526 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#510168}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/0341f160befa..00c6432dea51 $ git log 0341f160b..00c6432de --date=short --no-merges --format='%ad %ae %s' 2017-10-19 angle-deps-roller Roll skia/third_party/externals/angle2/ 6dee4d8c1..cbcb96fcd (1 commit) 2017-10-19 egdaniel Revert "Support creation/use of mipped proxy in GrBackendTextureImageGenerator" 2017-10-18 egdaniel Support creation/use of mipped proxy in GrBackendTextureImageGenerator 2017-10-19 mtklein speculative fix for Android roll Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I100b7bdd70b8b6224c31a19301309bfb8dfbb49f Reviewed-on: https://chromium-review.googlesource.com/728359Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#510167}
-
Hidehiko Abe authored
Taking two callbacks API (CallMethodWithErrorCallback()) is not familiar with OnceCallback unfortunately. So, instead, this CL introduces a ResponseOrErrorCallback, which takes either Response* or ErrorResponse*, and it is called on completion of CallMethod task regardless of whether it is success or fail. CallMethodWithErrorCallback() is deprecated now, and the callers will be migarted into CallMethodWithErrorResponse() in following CLs. BUG=739622 TEST=Build. Change-Id: Ib12e27de0d1dc09f2878679c53e0ad741c916fe9 Reviewed-on: https://chromium-review.googlesource.com/704794Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#510166}
-
Eric Roman authored
Bug: 649017,649000,762380 Change-Id: Ic80908a4b883fbae23ba60f67c422d95478836db Reviewed-on: https://chromium-review.googlesource.com/721850 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#510165}
-
Karan Bhatia authored
This CL removes some un-used info map instances from test fixtures in web_request_api_unittest.cc BUG=None Change-Id: I6bf743e06ae6297676e8c9cbd1cfb596f63225cb Reviewed-on: https://chromium-review.googlesource.com/722119Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#510164}
-
Misha Efimov authored
- Unused after https://codereview.chromium.org/2911513002 - Causing compilation error with use_asan=true on iOS. Bug: 593874 Change-Id: I448cdcc472faaa44fa914efe56219b2448ed0b71 Reviewed-on: https://chromium-review.googlesource.com/728395Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#510163}
-
Eugene Ostroukhov authored
Bug: 738065 Change-Id: I1ca301942f151bea6a1665a02bc58a89b0eb2ad7 Reviewed-on: https://chromium-review.googlesource.com/726840Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Cr-Commit-Position: refs/heads/master@{#510162}
-
David Trainor authored
Trim the query parameters to make the URL easier to visualize. BUG=776146 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id5b13c27a20e868b67bb121d9339e1be0ca893ad Reviewed-on: https://chromium-review.googlesource.com/727359 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#510161}
-