GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236944 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236939 0039d316-1c4b-4281-b951-d872f2087c98

Let me know if you prefer to keep some of these as INFO or just delete
them.

R=jam@chromium.org
BUG=322805

Review URL: https://codereview.chromium.org/84293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236936 0039d316-1c4b-4281-b951-d872f2087c98

Failing compile on win and win x64

FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\media\video\capture\win\media.capability_list_win.obj.rsp /c ..\..\media\video\capture\win\capability_list_win.cc /Foobj\media\video\capture\win\media.capability_list_win.obj /Fdobj\media\media.pdb 
c:\b\build\slave\cr-win-rel-x64\build\src\media\video\capture\win\capability_list_win.h(54) :error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
c:\b\build\slave\cr-win-rel-x64\build\src\media\video\capture\win\capability_list_win.h(54) : warning C4183: 'DISALLOW_COPY_AND_ASSIGN': missing return type; assumed to be a member function returning 'int'
ninja: build stopped: subcommand failed.

> Reorganize media::VideoCapture* types
> 
> The purpose of this CL is to clean up the distinction between
> VideoCaptureFormat (which identifies the captured type of a frame),
> VideoCaptureParams (which identifies the requested format of a capture),
> and VideoCaptureCapability (which identifies the capture capabilities of a
> device).
> 
> Notably:
> * VideoCaptureFormat::frame_size_type ->
>   VideoCaptureParams::allow_resolution_change, as variable resolution
>   capability is a per-session, not a per-frame property.
> * VideoCaptureCapability::color -> VideoCaptureFormat::pixel_format, as frame
>   color format is a per-frame property.
>   * As VideoCaptureParams holds a VideoCaptureFormat member, capture requests
>     are able now to request a particular capture color format.
> 
> BUG=269312
> TEST=local build, run unittests, chrome on CrOS snow, desktop Linux
> 
> Review URL: https://codereview.chromium.org/68503005

TBR=sheu@chromium.org

Review URL: https://codereview.chromium.org/84393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236935 0039d316-1c4b-4281-b951-d872f2087c98

The rest of NaClBrowserTest.* were turned on for linux asan a
while back. This one shouldn't be any different, just missed
it in r217769.

BUG=161709

Review URL: https://codereview.chromium.org/82653007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236933 0039d316-1c4b-4281-b951-d872f2087c98

* Make the various translate OptionsMenuModels scoped_ptr<>s like the other menu
  models.  This is mostly for convenience for the refactor change, where
  accessing the delegate (to initialize this) in the constructor is kind of
  annoying.  Added bonus, we can pull a few #includes out of some .h files.
* Add a blank line between blocks of forward declarations... this seems to be
  how most other code does it and feels a little less cramped

BUG=none
TEST=none
TBR=sky

Review URL: https://codereview.chromium.org/84363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236932 0039d316-1c4b-4281-b951-d872f2087c98

Use first unlock user (which is the primary user at the
moment) pref for locking screen;

BUG=322662

Review URL: https://codereview.chromium.org/83543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236931 0039d316-1c4b-4281-b951-d872f2087c98

BUG=318908
TEST=manual testing on Link

Review URL: https://codereview.chromium.org/84233004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236930 0039d316-1c4b-4281-b951-d872f2087c98

Instead, use the list of plugins that have already been
set on the system profile. This makes the API simpler and
paves way for my upcoming change to log initial stability
metrics in their own log. The new code is also slightly
more efficient, since there's fewer string conversions.

Also adds tests coverage for the functionality, which was
previously untested.

BUG=312733
TEST=New unit test.

Review URL: https://codereview.chromium.org/83023006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236929 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/83483013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236928 0039d316-1c4b-4281-b951-d872f2087c98

The purpose of this CL is to clean up the distinction between
VideoCaptureFormat (which identifies the captured type of a frame),
VideoCaptureParams (which identifies the requested format of a capture),
and VideoCaptureCapability (which identifies the capture capabilities of a
device).

Notably:
* VideoCaptureFormat::frame_size_type ->
  VideoCaptureParams::allow_resolution_change, as variable resolution
  capability is a per-session, not a per-frame property.
* VideoCaptureCapability::color -> VideoCaptureFormat::pixel_format, as frame
  color format is a per-frame property.
  * As VideoCaptureParams holds a VideoCaptureFormat member, capture requests
    are able now to request a particular capture color format.

BUG=269312
TEST=local build, run unittests, chrome on CrOS snow, desktop Linux

Review URL: https://codereview.chromium.org/68503005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236927 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236926 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/84083004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236925 0039d316-1c4b-4281-b951-d872f2087c98

This patch bumps the libaddressinput version that Chrome uses from r163 to
r166. The new revision enables building libaddressinput in Windows with
MSVS.

TBR=estade@chromium.org
BUG=317837

Review URL: https://codereview.chromium.org/83633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236924 0039d316-1c4b-4281-b951-d872f2087c98

BUG=320723
R=jyasskin@chromium.org

Review URL: https://codereview.chromium.org/83023014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236923 0039d316-1c4b-4281-b951-d872f2087c98

It was increased in https://codereview.chromium.org/46043006
but 70s is too long and only few tests are affected.

BUG=236893
R=jam@chromium.org

Review URL: https://codereview.chromium.org/83443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236922 0039d316-1c4b-4281-b951-d872f2087c98

In HWNDMessageHandler::OnMouseRange() function, mouse events synthesized
in response to touch should be ignored if they are in the client area of
the window. The hit testing to decide if a point is in the client area
needs the point in screen coordinates, but, for most of the mouse events
the point is in window coordinates. So, the point should be converted to
screen coordinates if it is not.

BUG=312708

Review URL: https://codereview.chromium.org/83973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236921 0039d316-1c4b-4281-b951-d872f2087c98

This cl contains the parsing of the RTCP packets containing the log
messages. The callbacks sending the parsed data into our log system is
not wired up; that will be done in a seperate cl.
Additionally the sender does not generate these type of messages yet.

Review URL: https://codereview.chromium.org/83903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236920 0039d316-1c4b-4281-b951-d872f2087c98

While introducing the new AudioLog class, I encountered some WebRTC
and AudioRendererHost unittests abusing MediaInternals for internal
state observation.  https://codereview.chromium.org/68173025/

In the AudioRendererHost case, everything tested is already enforced
by various DCHECKs and the AudioManager (all streams closed, etc).

Similarly, in the WebRTC case, most checks are enforced implicitly or
tested via other means.

To remove the usage in AudioRendererHost I needed to switch over to
a TestBrowserThreadBundle which should have been done anyways.

BUG=260005
TEST=unittests still pass.

Review URL: https://codereview.chromium.org/81953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236919 0039d316-1c4b-4281-b951-d872f2087c98

When they are removed on unloading, they are in particular removed on disabling an extension. Re-enabling the extension then does not restore these rules.

BUG=313241

Review URL: https://codereview.chromium.org/52743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236918 0039d316-1c4b-4281-b951-d872f2087c98

Support URL fragment resolution against non-hierarchical schemes
As a result, data: about: etc now have 'query' and 'ref' components
parsed; as a result a new GURL::GetContent() convenience is added to
retrieve the spec with the scheme stripped off.

A complication in supporting this is that we now need to allow whitespace
to trailing whitespace to be preserved when transferring url_parse::Parsed
structs between KURL and GURL. Without this, the URL prior to the
#fragment can change (i.e. whitespace stripped) when following an anchor
link which breaks the page (causes reload from source). See
http://crbug.com/291747 for more details on this.

R=brettw@chromium.org
TBR=cbentzel@chromium.org
BUG=291747

Review URL: https://codereview.chromium.org/23835019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236917 0039d316-1c4b-4281-b951-d872f2087c98

* Remove code handling the case where the overlay doesn't include any text.
* Remove remnants of code handling opacity transitions.

BUG=none
TEST=none
R=groby@chromium.org

Review URL: https://codereview.chromium.org/82933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236916 0039d316-1c4b-4281-b951-d872f2087c98

* Add padding around the text.
* Use the same font as what's used in the notifications.
* Set the font color.

BUG=315975
TEST=Legal documents display to match notifications and mocks.
R=groby@chromium.org

Review URL: https://codereview.chromium.org/82913004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236915 0039d316-1c4b-4281-b951-d872f2087c98

BUG=318439

Review URL: https://codereview.chromium.org/82303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236914 0039d316-1c4b-4281-b951-d872f2087c98

default is off.

BUG=315317

Review URL: https://codereview.chromium.org/77083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236913 0039d316-1c4b-4281-b951-d872f2087c98

large as its border requires.

BUG=311269
TEST=none
R=msw@chromium.org

Review URL: https://codereview.chromium.org/82483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236912 0039d316-1c4b-4281-b951-d872f2087c98

Skip conformance/ogles/GL/control_flow/control_flow_001_to_008.html instead of marking it as fail.

BUG=322795
TEST=
TBR=kbr@chromium.org,bajones@chromium.org

Review URL: https://codereview.chromium.org/82763009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236910 0039d316-1c4b-4281-b951-d872f2087c98

This modifies install-build-deps.sh to require language packs needed for
running browser_tests. This also corrects a typo in
locale_tests_browsertest.cc where we wanted a '_' instead of a '-'.

BUG=316716

Review URL: https://codereview.chromium.org/84013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236908 0039d316-1c4b-4281-b951-d872f2087c98

This patch introduces telemetry.value, which factors out the different kinds of
data collected by telemetry benchmarks, currently scalar values, lists of
scalar values, and histograms. This factoring provides mechanisms for combining
together values --- value summarization, which was previously the job of the
results objects, is now part of the value system.

The actual interface between the page_measurement_results object and the
rest of telemetry is unchanged. A values_backcompat module exists to convert
the old interface to the new interface. A followup patch can remove this
backcompat path.

Most discussion of this is on https://codereview.chromium.org/27486002/

BUG=306944

Review URL: https://codereview.chromium.org/83813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236907 0039d316-1c4b-4281-b951-d872f2087c98

which should've been removed in https://codereview.chromium.org/23536051

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/83423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236906 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236905 0039d316-1c4b-4281-b951-d872f2087c98

This brings in recent changes that allow Syzygy to process VS2013 binaries.

BUG=318016

Review URL: https://codereview.chromium.org/83383006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236904 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23581

Review URL: https://codereview.chromium.org/83203004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236902 0039d316-1c4b-4281-b951-d872f2087c98

We don't need them anymore after the video decode acceleration warmup cleanup.

BUG=321209
TEST=compiles.

Review URL: https://codereview.chromium.org/82993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236901 0039d316-1c4b-4281-b951-d872f2087c98

This brings the message into line with the new LOG policy, and
more closely reflects the reality of the warning.

Review URL: https://codereview.chromium.org/82973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236900 0039d316-1c4b-4281-b951-d872f2087c98

With the last input event, gestures often overshoot the specified distance,
e.g. scrolling distance. This patch makes sure that the final move event is
adjusted so that we cover exactly the specified distance.

BUG=322084

Review URL: https://codereview.chromium.org/81153004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236899 0039d316-1c4b-4281-b951-d872f2087c98

Windows failures
  conformance_ogles_GL_atan_atan_001_to_008
  conformance_ogles_GL_atan_atan_009_to_012
  conformance_ogles_GL_control_flow_control_flow_001_to_008

BUG=322794,322795
TEST=
TBR=bajones@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/83953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236898 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236897 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=162560:162565&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/82963006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236896 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=peria@chromium.org

Review URL: https://codereview.chromium.org/82703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236895 0039d316-1c4b-4281-b951-d872f2087c98