GitLab

Omnibox suggestions can have image data, then later can post image data
to do image search.

Bug: 1055925
Change-Id: Ic7c83b10b404eee56217003f4d9c6cd1bcce1bc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103081Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Ender <ender@google.com>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756867}

This reverts commit 033f06d6.

Reason for reland: there are new changes:

1. Fix how the loading behavior is observed. Now it's observed whenever
a font is preloaded.

2. The loading behavior flag is renamed.

Original change's description:
> Revert "Reland "Record split UMA histograms when rendering has been delayed for font preloading""
>
> This reverts commit 0e19fa7c.
>
> Reason for revert: should go through the normal review process
>
> Original change's description:
> > Reland "Record split UMA histograms when rendering has been delayed for font preloading"
> >
> > This reverts commit 950810de.
> >
> > Reason for revert: Loading behavior fixed
> >
> > Original change's description:
> > > Revert "Record split UMA histograms when rendering has been delayed for font preloading"
> > >
> > > This reverts commit 4a7fe529.
> > >
> > > Reason for revert: The loading behavior is designed wrong.
> > >
> > > The objective of these split histograms is to study, when there's font preloading, how effective delaying rendering is.
> > >
> > > Currently: the behavior is observed when rendering is delayed by font preloading.
> > >
> > > What's actually needed: the behavior is observed when font preloading occurs
> > >
> > > Original change's description:
> > > > Record split UMA histograms when rendering has been delayed for font preloading
> > > >
> > > > This patch adds split histograms of the following metrics when
> > > > rendering delay for web font preloading has been triggered:
> > > > - PaintTiming.NavigationToFirstPaint
> > > > - PaintTiming.NavigationToFirstContentfulPaint
> > > > - PaintTiming.NavigationToLargestContentfulPaint
> > > > - LayoutInstability.CumulativeShiftScore
> > > >
> > > > This will help us understand the effectiveness of this optimization, and
> > > > adjust the length of the delay to the best value.
> > > >
> > > > Bug: 1040632
> > > > Change-Id: I6f8aa151c576c9d8d583647a3a7ef6fcb8fb833d
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109251
> > > > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> > > > Reviewed-by: Charlie Harrison <csharrison@chromium.org>
> > > > Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> > > > Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
> > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#754771}
> > >
> > > TBR=chrishtr@chromium.org,ksakamoto@chromium.org,skobes@chromium.org,bmcquade@chromium.org,csharrison@chromium.org,xiaochengh@chromium.org
> > >
> > > Change-Id: I7829822fea47183df9d4ed27c0eec2a1f888aa0b
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 1040632
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131010
> > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
> > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#755081}
> >
> > TBR=chrishtr@chromium.org,ksakamoto@chromium.org,skobes@chromium.org,bmcquade@chromium.org,csharrison@chromium.org,xiaochengh@chromium.org
> >
> > Change-Id: Ibae7230089fe9e56e91cf1480d19c7bc70778567
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1040632
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131011
> > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#755108}
>
> TBR=chrishtr@chromium.org,ksakamoto@chromium.org,skobes@chromium.org,bmcquade@chromium.org,csharrison@chromium.org,xiaochengh@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1040632
> Change-Id: I80ae98e1f0ec97a11f35bb2c55ad9d591f1b07b1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135047
> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#756098}

Bug: 1040632
Change-Id: I44b9ff37bf7cf75b0d4c9967cc183aa0609e4532
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134887
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756866}

The hang is because fence helper is used for destroying vulkan
surface asynchronously. However the platform window (X11, android
or Win32 window) could be destroyed before destroying the vulkan
surface which is created for the native window. It causes hang or
crash. Fix the problem by calling vkWaitQueueIdle() and destroying
the vulkan surface synchronously.

Bug: 1062727,1062703
Change-Id: I73715fe0548221dc33cd5ffb2c266d53795dbb13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138253
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756865}

BUG=none
TEST=doc only change

Change-Id: Id3ab4abe817ea56da4a60238285a23557b6e2a11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135830
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756864}

This CL uses a rudimentary views::Label to display header text for
AutocompleteResults that contain matches with headers.

Screenshot: https://i.imgur.com/f61GxWR.png

Bug: 1052522
Change-Id: I042c21a60a8416e243498793cee5c3dabeaac4f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137673
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756863}

The render path was transferring the GpuFence for the produced shared
image, but was missing the crucial step of converting it to a local GL
fence and doing a server wait, apparently this was missed in a refactor.
Add that, and re-enable shared image transport which was disabled in
https://crrev.com/c/2135957.

See example code for details:
https://chromium.googlesource.com/chromium/src/+/HEAD/docs/design/gpu_synchronization.md

Bug: 1068347
Change-Id: I6fdf3e963de49dc522cb8b0323eeb86ab1a1104e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138159Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756862}

Remove unused constants and methods from extension_urls.h/cc.

Bug: None
Change-Id: Ifddcbcaff4fa9a8b6753bd3efe539dc10acbc7fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131363Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756861}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/c2fb0f637ece..4e3bbd9c5f1a

git log c2fb0f637ece..4e3bbd9c5f1a --date=short --first-parent --format='%ad %ae %s'
2020-04-06 rharrison@google.com Start shaderc v2020.1
2020-04-06 rharrison@google.com Finalize shaderc v2020.0
2020-04-06 rharrison@google.com Update CHANGES

Created with:
  gclient setdep -r src/third_party/shaderc/src@4e3bbd9c5f1a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: radial-bots+chrome-roll@google.com
Change-Id: I4fd7b21c7aae6a71ed5928a041c62f8d3e0afcaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138059Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#756860}

Change-Id: I2844e801f9dc28fb2673b0b7b2df0f180fd14ffc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138118
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756859}

Fixed a performance regression of ~1.3-1.8% in frame times by
deferring updating the BubbleDialogDelegateView's |anchor_widget_|
until the bubble needs to be created rather than every time the view
is added to a new Widget.

Bug: 1064717
Change-Id: I349b4dc6750db107d1d73c561c5cab64d837c403
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128976
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756858}

The histogram will help us evaluate upcoming work. The counter was
originally added in https://crrev.com/c/1871601.

Bug: v8:9892
Change-Id: I96e11d1ea8bedf8146ba77daaa4d46730af3bb12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128108
Auto-Submit: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756857}

There is a chance that the HeapMojoReceiver::Wrapper may outlive the Owner in case of a ConservativeGC.
The stack scanning may create a root to HeapMojoReceiver::Wrapper, prolonging its life.
To make sure they die together in the same GC cycle, we will make the Wrapper retain the Owner.
So in case HeapMojoReceiver::Wrapper is kept alive, the Owner is guaranteed to be alive too.

Bug: 1067476
Change-Id: I6456c368dc2ad446a627d1b75102bd42a5770c0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134093
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756856}

The ServiceWorkerBasedBackgroundTest.TabsOnUpdatedSpanning was
flaky due to unexpected sync issues between the browser and the
renderer. This CL changes the implementation so the renderer
pushes the results to the browser, rather than the browser pulling
the results from the renderer.

This passed 3000 iterations on the try bots with no flakes.

Bug: 1003244
Change-Id: I8a1c3c0ed7427535210d9d8cabac5d8b9ddb17cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131362Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756855}

Test: CQ
Bug: chromium:1064512
Change-Id: I2cd99ab4db524adb32d5d591ba9174597e089755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137187Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Nic Hollingum <hollingum@google.com>
Commit-Queue: Nic Hollingum <hollingum@google.com>
Auto-Submit: David Munro <davidmunro@google.com>
Cr-Commit-Position: refs/heads/master@{#756854}

Bug: 1044139
Change-Id: I6c394dbc3f3c70715134b83a33ecea9388b63c2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137488
Commit-Queue: Ian Wells <iwells@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756853}

https://swiftshader.googlesource.com/SwiftShader.git/+log/3942f5cbdde7..bdb6807825ac

git log 3942f5cbdde7..bdb6807825ac --date=short --first-parent --format='%ad %ae %s'
2020-04-06 sugoi@google.com Don't blend integer formats

Created with:
  gclient setdep -r src/third_party/swiftshader@bdb6807825ac

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: Ia61d9b1795fb8140da8fef5a0cd95c47a4d029e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138057Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#756852}

Limit Media Feed discovery to HTTPS.

BUG=1066252

Change-Id: I34130ca7c9d4c5643c4d9fc3315db06132c969a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130669Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756851}

TabsInfo can be null. It is best to transform
a null TabsInfo list to an empty list in the
constructor to avoid the consumer needing
to do null checks.

Bug: 1061991
Change-Id: If6345ed3bed720b783415b62a86bb8361ec5c2b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128566
Commit-Queue: David Maunder <davidjm@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756850}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6be23fae..8ab0d8cc

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ia6ed09ad4f607e2cf6ab6fe00ed07255c14d95dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137873Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#756849}

This reverts commit c4fb74d3.

Reason for revert: vm tool is broken, needs CL:2138196

Original change's description:
> Roll src/third_party/chromite ca6b5b7a1781..6f4de37e7b32 (23 commits)
> 
> https://chromium.googlesource.com/chromiumos/chromite.git/+log/ca6b5b7a1781..6f4de37e7b32
> 
> git log ca6b5b7a1781..6f4de37e7b32 --date=short --first-parent --format='%ad %ae %s'
> 2020-04-06 chrome-bot@chromium.org Update config settings by config-updater.
> 2020-04-06 mmortensen@google.com In cros_build_lib.CreateTarball, log context on failures.
> 2020-04-05 vapier@chromium.org Revert "cbuildbot: switch to python3 only via virtualenv wrapper [reland]"
> 2020-04-04 vapier@chromium.org cros_build_lib: run: only return output when requested
> 2020-04-04 vapier@chromium.org cbuildbot: switch to python3 only via virtualenv wrapper [reland]
> 2020-04-04 sanikak@chromium.org auto_updater: reboot device before au kicks off if device is not idle
> 2020-04-04 saklein@chromium.org run: Fix output capturing calls.
> 2020-04-04 kimjae@chromium.org build_dlc.py: Non sudo copying from build directory
> 2020-04-04 engeg@google.com release_stages: add an output tag for channels
> 2020-04-03 seanabraham@chromium.org chromeos_config: add R83 schedule
> 2020-04-03 gredelston@google.com Stop using self._current_board as a buildstore
> 2020-04-03 saklein@chromium.org metrics_unittest: Fix flake.
> 2020-04-03 tcwang@google.com afdo: Reduce the frequency of AFDO updates to 2x/week
> 2020-04-03 morg@google.com Add -arc-r boards to unified lab board names hack
> 2020-04-03 vapier@chromium.org table/upgrade_table: require python 3
> 2020-04-03 bpastene@chromium.org vm: Add retries to vm.Start() if WaitForBoot fails.
> 2020-04-03 cjmcdonald@chromium.org pytest: Don't skip 'redirected_stdin_error' marker
> 2020-04-03 cjmcdonald@chromium.org pytest: Don't skip 'requires_portage' marker
> 2020-04-02 engeg@google.com chroot_util: preserve env for emerge call for unit tests
> 2020-04-02 cjmcdonald@chromium.org run_pytest: Add namespacing & chroot initialization
> 2020-04-02 cjmcdonald@chromium.org pytest: Skip flaky CIDB mock tests
> 2020-04-02 rkolchmeyer@google.com Revert "lakitu: Turn off GCETest stage"
> 2020-04-02 chrome-bot@chromium.org Update config settings by config-updater.
> 
> Created with:
>   gclient setdep -r src/third_party/chromite@6f4de37e7b32
> 
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/chromite-chromium-autoroll
> Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
> is aware of the problem.
> 
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
> Bug: None
> Tbr: chrome-os-gardeners@google.com
> Change-Id: I9ab77961f8ff6f4b52e39e451ba731edf5150059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136461
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#756696}

TBR=oshima@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com

Change-Id: I1a11f9cfedd126f85c7bf69433faa4fb37dbe899
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138168Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756848}

The aborted test list is generated by comparing all tests list detected
by otool with tests that's actually ran.

Parsing otool result isn't working correctly for device binaries. The
list of all test names parsed contains non-test components.

For multitasking and flaky test suite, the real tests to run is
determined in chrome_test_case.mm and it's less than all tests detected
in otool.

Thus, in these situations, the aborted test list is not correct. As
we're moving to Chromium recipe, aborted(timed out) tests will make the
builders fail. And devices will run eg2 tests in upstream main after
EG1 deprecation. This change prevents these false failures.

Bug: 1046369, 1067753
Change-Id: I514523a3f6ebdae5ea8a14860a0fc2ce88b95685
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135056Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756847}

During shutdown, BrowserImpl is cleared before FullscreenCallbackProxy
is destroyed. FullscreenCallbackProxy destroyed invalidates
WebPreferences, thus causing the crash.

Just add a null check.

Make testActivityShouldNotLeak a regression test by setting
FullscreenCallbackProxy. Factor out TestFullscreenCallback from
FullscreenCallbackTest to be reusable.

Bug: 1067754
Change-Id: I3fe130f4ed6f1ad563ee27179db9932c3c2e88a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136844Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756846}

https://android.googlesource.com/platform/external/perfetto.git/+log/b726d1c21aa6..430f07b53422

git log b726d1c21aa6..430f07b53422 --date=short --first-parent --format='%ad %ae %s'
2020-04-06 lalitm@google.com Merge "tp: fix compile on builds with zlib disabled"
2020-04-06 lalitm@google.com Merge "tp: ensure that sde_tracing_mark_write tgid is always set to be kthreadd"

Created with:
  gclient setdep -r src/third_party/perfetto@430f07b53422

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I5c02ba01e02b1b10f1d34182294f8f9dd5a95ecf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138056Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#756845}

Bug: 1060448
Change-Id: I04de559f42ed31d159e93f55b59940fd15d1721e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132635Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756844}

With committed interstitials, when Chrome shows an auth prompt, the
entered credentials are populated into the cache and then the page is
reloaded to pick up the user-provided credentials. This CL disables
the repost confirmation dialog on the reload. Before this CL, if a
POST navigation request encountered an auth challenge, the user would
be prompted to resubmit the form after entering credentials, which is
not necessary because the POST data was presumably not processed by
the server on the navigation request that resulted in an auth
challenge.

Bug: 1062317
Change-Id: I32d9833478f72c6bd25c57567374506c675a2b67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138114Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756843}

Moving README.txt to README.md and updated format, to be consistent
with other Chromium documentation. Made some minor fixes.

NOTRY=true

Change-Id: I5431d77a839b8010b347e9a59def49d15697b88a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137541Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756842}

- This adds a new polymer element that contains a print job in the print
  management app.
- Print jobs will now appear upon app's startup.
- CSS styling + sorting will be implemented in separate CLs.
- Implemented i18n for strings. Current strings are not final.

Screenshot of current status: https://screenshot.googleplex.com/PbiY16Y7d8M

Bug: 1053704
Tests: browsertests
Change-Id: I5c96ec72bd3f528917d5b5c9876ec642a2e87fdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125246Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756841}

Update ImagePaintTimingDetector's last_registered_frame_index_ acordingly when empty records are removed from the records_manager_'s queue.

Bug: 1062974
Change-Id: I2e5923eb070249d6c561a4bac4defbf9345e5f72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108732Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756840}

This CL adds enforcement that |resource_request.request_initiator| matches
|current_context.render_frame_host->GetLastCommittedOrigin()| and
rejects the prefetch request otherwise.

To gain visibility into violations occurring in the wild, the CL also
adds calls to mojo::ReportBadMessage, so that IsValidCrossOriginPrefetch
failures will generate a DumpWithoutCrashing (and potentially terminate
the renderer process that sends the invalid IPC).

Bug: 1065076
Change-Id: I8150b253b881d74d4453a243be295e1ab8b1287e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122621
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756839}

This CL corrects spelling of IsDisplayIdentificationEnabled() from
IsDisplayIdentificationlEnabled().

Bug: 1068252
Change-Id: Iae14138946a773cf6b615fc4f92322f937f651f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138153Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756838}

This disables two tast tests which are consistently failing:
https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-rel/41488
https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-rel/41489
https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-rel/41490
https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-rel/41491
https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-rel/41492

TBR=iby@chromium.org,bpastene@chromium.org
Bug: 1059426

Change-Id: I32ce8ec695dff6397f2e5eb14eeb01b29130b779
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138001Reviewed-by: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756837}

fuchsia/third_party/aemu/linux-amd64/+log/7YlCg.....lSCFQ...


Created with:
  gclient setdep -r src/third_party/aemu-linux-x64@lSCFQ...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chonggu@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: chonggu@google.com
Change-Id: I84b67bb554e5bbb9c8033fb1e79108535f3d4eca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137663Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#756836}

PrintPreview.InitialDisplayTime, PrintPreview.RendererError, and
PrintPreview.RegeneratePreviewRequest.BeforePrint are all useful stats.
Extend and synchronize their expiration dates. Also add a secondary
owner and fix some typos.

Bug: 1055430,1066105
Change-Id: I670662cbaee89b67801454d0aecacf6b45c7d595
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135535Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756835}

The current vr_headset icon seems to be partially transparent. This
change updates the png to be fully opaque, as intended.

Bug: 1067798
Change-Id: If485da0a1d36eb45b2d692ce154c340c188a817e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137992
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756834}

A touch event can be blocking or non-blocking. They can be sent to the
main thread if the compositor determines that the main thread must know
about the event. If the event is sent as blocking, the browser will
avoid dispatching further events until the main thread responds by
ACK'ing the event. This allows author script to call preventDefault to
change how gestures are dispatched. A non-blocking event is sent to the
main thread but as purely informational; the main thread won't ACK the
event and the browser won't block before dispatching successive gesture
events

The compositor can turn a blocking touch event into a non-blocking one.
This is done while a fling is in progress to prevent janking fling
boosting (see https://crbug.com/595327). In this case, if a user touches
down during a fling we want the browser to dispatch scroll events
immediately without waiting on an ACK so that the scroll can continue or
boost the fling without interruption. The compositor does this by
setting the touch as DID_NOT_HANDLE_NON_BLOCKING_DUE_TO_FLING which will
cause it to be forwarded as non-blocking to the main thread.

Compositor touch action[1] lets the browser receive an ACK from the
compositor to let it know a set of "safe" whitelisted touch actions that
can be dispatched before the ACK from the main thread arrives. This
allows scrolls to be dispatched with less latency in some cases if the
compositor can determine that the main thread won't block certain touch
actions. The whitelisted touch action is sent back to the browser at the
same time as the event is forwarded to the main thread.

The bug here is caused by the whitelisted touch action not accounting
for the "non-blocking fling" behavior. When the touchstart hits a
blocking region (e.g. non-passive event listener) the whitelisted touch
action set to kNone (the compositor can't guarantee the main thread wont
block any gestures)[2,3]. However, if we're in a fling the event will be
made non-blocking so that the main thread *cannot* block scrolls. Worse,
because it's non-blocking the main thread won't ACK the event at all so
the browser will block dispatching any gestures until a new one is
started.

This CL fixes the issue by setting the whitelisted touch action to kAuto
(allow all) when we enter a "non-blocking due to fling" state.


[1] https://docs.google.com/document/d/1bSv_qNsLLnpXImuH7sHa6D3R_0GdDYkTiNjxso8Rgxo/edit#heading=h.jvxrm66og6z0
[2] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/layout/layout_object.h?l=2229&rcl=b9275f87a13183e295a7a55bc6cef6eaea4ed86c
[3] https://cs.chromium.org/chromium/src/ui/events/blink/input_handler_proxy.cc?l=1016&rcl=25ed318ba5c24057ea2a402c62f25649fda5093f

Bug: 1048098
Change-Id: Ifa2fdd2fb7124f6f350f05e08f905229731297bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132843Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756833}

This CL introduces the concept of a compositor IO seqeuence for the
Paint Previews compositor. Functionally this sequence is used to
interact with the compositor and serializes/deserializes mojo responses.
This is critical to ensuring bitmaps are not deserialized on the UI
thread as they can take up to 1 second to deserialize.

I'd like to avoid exposing the sequence to callers if acceptable as:
- This avoids confusion about what sequence the mojo::Remote is bound to
- This helps ensure weak ptrs and callbacks are handled on the expected
  sequence (caller's sequence) rather than the sequence on which the
  remote is bound.

The low test coverage is somewhat incorrect as this code is covered via
a javatest.

Bug: 1068180
Change-Id: I01fe9ef5f8918656a8821f95f1f850d65b8995e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136090
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756832}

This change removes a DCHECK from the result of updating Progressive
Web App (PWA) launchers, to prevent debug builds of Chrome from
crashing when an update fails.

PWA launcher update could fail for any of the following reasons:
* Latest launcher version path does not exist
* Failed to create a temporary directory
* Failed to rename any launcher path to "_old"
* Failed to create a hardlink/copy of the latest launcher

Because some of the above failures are file operations that could
reasonably fail, a DCHECK on their success is misleading as it implies
"this should never happen".

A more appropriate way to handle update failure is to stop the update
(without crashing) and emit a UMA metric indicating the failure
reason. This change adds TODOs for that as a next step.

Bug: 1067241
Change-Id: If2f2145fc62619618917c80f26234930d3a26d0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134584Reviewed-by: Olivier Yiptong <oyiptong@chromium.org>
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Cr-Commit-Position: refs/heads/master@{#756831}

Bug: 1055540
Change-Id: I03621fa68a0606b210e31e0d45a8b0e78228c355
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134573Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756830}

This CL allows for HDR to be queried with MediaCapabilities.decodingInfo
with hdrMetadataType, colorGamut, and transferFunction. Both Blink- and
Media-side changes are included. The feature is flagged by
MediaCapabilitiesDynamicRange.

Bug: 1048045
Change-Id: I9f144726bbc7aaead4dcc1c9f69cf536da1bf2a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035053
Commit-Queue: Vi Nguyen <ving@microsoft.com>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756829}

It's present during the initial model load.
We'll need to add the load-more spinner logic
later when we have load-more loading logic.

I went ahead and removed UiEvent since we are moving away
from using protos for events.

Bug: 1044139
Change-Id: I1a180b601cf34d16ef8e58e119577195c39f0cee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136033Reviewed-by: Ian Wells <iwells@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756828}