- 05 Jan, 2021 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6356cb1904b8..4f509345ab9f 2021-01-05 reed@google.com Pass sampling to drawImageSet 2021-01-05 brianosman@google.com SkSL-to-SkVM: Misc fixes around arguments 2021-01-05 rmistry@google.com [recreateskps-bot] New locations for hosted pages If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I6b4405627c67a8b3fb1e4c0099ad9317755768ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611816Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840374}
-
Jeremy Roman authored
It's usual to use integral_constant for this, especially since the underlying computation already is one. It still allows function-like syntax. Change-Id: Ie04bc5e3b46b63fbc7c0da2d1ae6198f7ecbac29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606127 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#840373}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. The errors are: * "'transfer' used after it was moved" (4 times); * "'callback' used after it was moved" (2 times). Bug: 1122844 Change-Id: I212a2fef9d33aed17e322e599a1c21a86e3eeae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601483Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#840372}
-
Toby Huang authored
This CL cleans up a feature flag that has already been on stable for over three milestones. Bug: 1158494 Change-Id: I6a529e3b31e34fb5af19e6b5e5e471c475ff80e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602251Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#840371}
-
Scott Violet authored
Prior to this the header was always added. After this, the header is only added if an extra is supplied. This only changes whether setClientDataHeaderForNewTab() is called and does not alter the implementation of that function. BUG=1163158 TEST=covered by tests Change-Id: Ic5d222d719a81c6da3d4e0c7866e18cbcee6e817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611340 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#840370}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/472239462122..f9a1b53d2809 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I47990ba03242fffef5708db3af9f3ec1c5058153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611868Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840369}
-
Allen Bauer authored
This reverts commit 5f44611e. Reason for revert: Potential cause of recent crashes in toolbar layouts. Original change's description: > Use class properties for Ignored and can-be-visible state in a layout for a given view. > > This will remove the need for the child_infos_ field in LayoutManagerBase. > > Somewhat related to the work of integrating fill layout behavior into views::View. > > Bug: 1159116 > Change-Id: I968aa58fb3b29f78d96cd520e61ccb731c2e9ac9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605567 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#839620} TBR=pkasting@chromium.org,kylixrd@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1159116 Change-Id: I9672a447b3b30530c049a9f6a89a8a1d42621bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611911Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#840368}
-
Yue Zhang authored
This CL adds a three-dot menu to single cart item. The menu button is shown when users hovering on the cart item, and the menu pops up when the button is clicked. Right now the menu is a empty menu with no action items. Screenshot: https://drive.google.com/file/d/15L6okmPeKyN2BfnOEDlKuaLDCTg9vX-h/view?usp=sharing&resourcekey=0-wdcJxKoUVofqIh396Awepg Bug: 1160968 Change-Id: Id773fc280dd1c40aa8af7b0a8cac8f24660f5793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601278 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#840367}
-
Adrienne Walker authored
This will help move cache storage to the storage service. The next step here is to add a CacheStorageControl to replace the direct use of CacheStorageContextImpl here (and in background fetch). Bug: 1147642 Change-Id: If97503f214e11c87394043c833029485a71a0aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551662 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#840366}
-
Luciano Pacheco authored
Generate JS module for //ui/file_manager/file_manager/background/js/ * file_operation_handler.js * file_operation_handler_unittest.m.js * file_operation_manager.js * file_operation_manager_unittest.m.js * trash.js * trash_unittest.m.js Bug: 1133186 Change-Id: I01334c52540202c1b7c22d0fd14527a1ca42cf28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610412 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#840365}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/de6e3a9d85af..6c876045de14 2021-01-05 jbudorick@chromium.org devil: make devil_env_test pass under py3. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC matthewdeluca@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1007101 Tbr: matthewdeluca@google.com Change-Id: I2e0359bddda1f8287cfd881439299926ad0fc2e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611890Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840364}
-
ccameron authored
This reverts commit dd424da8. Reason for revert: The original revert was because this was landed before its dependencies (a rebase does not trigger a new try job). This reverts the revert now that the dependencies have been landed. Change-Id: I7e548abdc127d06ed9c23afc72f7ad3dee50d001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608767Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#840363}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ia2fad32d0b2d7a52ad1c3580d59b31c2728ef24f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611127Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840362}
-
Zach Kirschenbaum authored
This reverts commit 394a78b4. Reason for revert: this breaks something Original change's description: > [fuchsia] handle RetrySystemUpdate reboot reason > > In this change, we add support for RetrySystemUpdate. Also, we stop > mapping `RebootSource::OTA` to `StateControlRebootReason::SystemUpdate` > because reboots for system updates should only be called from > fuchsia.git -- the code we remove isn't being run anyway. > > BUG=fuchsia:64591 > TEST=cast_reboot_unittests > > Change-Id: Ic15f86d31d3985d2fa5a2a3957c5ca61066cd476 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600053 > Reviewed-by: Sergey Volk <servolk@chromium.org> > Commit-Queue: Zach Kirschenbaum <zkbaum@google.com> > Cr-Commit-Position: refs/heads/master@{#838871} TBR=spang@chromium.org,servolk@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,zkbaum@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: fuchsia:64591 Change-Id: I9a2dd0fe105b1750c733925a8320a2f4e71cded2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611448Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Zach Kirschenbaum <zkbaum@google.com> Cr-Commit-Position: refs/heads/master@{#840361}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ie42b3cb4f779547ee0f1b79f3c75992cd31784f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611814Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840360}
-
Yuly Novikov authored
Bug: 1133921 Change-Id: I2a9ca38e25c89420fd37ecb094e57018bb06ba5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580279 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#840359}
-
Mattias Nissler authored
Chrome OS will stop passing feature flags as raw switches, but rather a list of feature flag names encoded in a new command line switch value. The conversion to switches and features thus happens at Chrome startup as is already the case for other platforms. BUG=chromium:1073940 TEST=Manual Change-Id: I84caee876792e19dc5603808e82b866f6e01de61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287291 Commit-Queue: Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#840358}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e8f563f111db..7ed37cbced6f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kmoon@google.com,sahel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1139098,chromium:1150925,chromium:1150928,chromium:1161396 Tbr: kmoon@google.com,sahel@google.com Change-Id: I02e7114a79d8928d92d8feac3095a63bbd051d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611835Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840357}
-
David Bokan authored
This base::Callback typedef isn't actually used anywhere so remove it. Bug: 1152268 Change-Id: I07a9664c22622d77de5b746a102e1dceeedf9016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605351Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#840356}
-
Reilly Grant authored
Updates runtime_enabled_features.json5 and the stable webexposed tests to mark the Web Serial API stable on desktop platforms. Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/RCtZPCQLLOQ Bug: 884928 Change-Id: Ifefaa045a239d3b482287016c98e72c0d8c1da15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579840 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#840355}
-
Yi Gu authored
This patch changes the owner of some viz hit tesing related metrics because yigu@ is no longer working on this project. Bug: 1160809 Change-Id: Ic5ea3c2905adb3219e668eab327b66c687d8929c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597653Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840354}
-
Mustafa Emre Acer authored
When upgrading a typed omnibox navigation to HTTPS, we observe the HTTPS load and fallback to HTTP if it fails. For slow HTTPS sites, this will introduce a very user visible delay. Instead of indefinitely waiting for the HTTPS navigation to succeed or finish, this CL implements a timeout so that we can cancel the HTTPS navigation (i.e. the "upgrade") and fall back to HTTP. Bug: 1141691 Change-Id: I8ec6d4bdd42abd2a9b8f90a802b9280cc0ded6bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577633 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#840353}
-
Daniel Nicoara authored
Insets represent a "border" like area around each side of the Webview. By setting insets the Webview's visible area will shrink. This will be used to represent occluded area in a Webview where the virtual keyboard will be shown. Bug: internal b/175873498 Test: cast_shell_browsertests and on device by calling the new API Change-Id: Ide948ab2cd955f7f7a687de7cb91ef418dd0aa70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596073Reviewed-by:
Ryan Daum <rdaum@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#840352}
-
Zhaoyang Li authored
git grep -l '12b5044c' | xargs sed -i '' -e 's/12b5044c/12c33/g' Bug: 1158906 Change-Id: I51f5e5031b66d4a5606f77b7bff87a3d5088e261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594272 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#840351}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/472239462122..f9a1b53d2809 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iabef9134fa34e209277ca3facd2bf03d8ce44115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611864Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840350}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ifbac49491ff181550f23b4bd611eb0f28e470688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602289 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#840349}
-
Cattalyya Nuengsigkapian authored
Regardless of where the highlight position is, after switching alt-tab mode, the highlight will be reset to the first or second window. This is consistent with highlighting when users first enter alt-tab mode: - In general case, highlight the second (next) most recently used window after the current one. - In the special case that the most recently used is minimized, highlight itself (the MRU window), so tabbing into it causes it to unminimize rather than opening up the next window in the list. - Track mode switching state in the controller to differentiate between normal tab pressing and mode switching. - Add Ash unit tests for both cases. `ash_unittests --gtest_filter=ModeSelectionWindowCycleControllerTest.SwitchingModeUpdates*WindowHighlight` Bug: 1157100 Test: Manual test (a video uploaded to crbug) and ash unit tests Change-Id: Id85b389ba9d59eb1815b8250d640e5aa9128240b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604907Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Cr-Commit-Position: refs/heads/master@{#840348}
-
cfredric authored
This aims for a simpler method signature for CanonicalCookie::IsSetPermittedInContext, and aims to have all exclusion reasons (except those set by MaybeDeleteEquivalentCookieAndUpdateStatus) set by CanonicalCookie itself. Change-Id: Id0673d11795241f10728d90424612b1bc0ab9883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611764Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#840347}
-
Trent Begin authored
The network ONC strings are used both in //chrome and //chromeos. Strings that are required in both locations need to be moved to //chromeos to prevent a layering violation. Screenshots are added in this change as they were not required when these strings were originally added. Bug: chromium:1159069 Change-Id: Id2615e0b42b11c88ac3170fc7734cb8f817d0831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606632Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Trent Begin <tbegin@chromium.org> Cr-Commit-Position: refs/heads/master@{#840346}
-
Tarun Bansal authored
Add experiment config parameter to disable preconnects to Default Search Engine (DSE) when the browser app is likely to be in the background. Bug: 1163183 Change-Id: I4bea073aeac20b6ae717305bdfac2bb0df052751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605226 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#840345}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609858728-6f035387130eda965f3c879c319423c426ffdda8.profdata to chrome-win64-master-1609869437-3a75c705c558e60abdee705e3f24c9125b018e03.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id3601eb822428c821d63549871e703b14eae5603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611806Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840344}
-
Alan Ding authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/d6f3734b69e2..e5fc0c7ccb3c $ git log d6f3734b6..e5fc0c7cc --date=short --no-merges --format='%ad %ae %s' 2020-12-16 alanding system_api: Add field to disable MediaStore maintenance tasks in ARC. 2020-12-23 allenwebb Renamed chromeos_dbus_bindings to chromeos-dbus-bindings. 2020-12-15 matthewmwang shill: wifi: move RekeyInProgress property from Device to Service 2020-12-16 sonnysasaka system_api: bluetooth: Update battery-related constants Created with: roll-dep src/third_party/cros_system_api Bug: b:173906243 Change-Id: I532d6027a8fd6320d17a740b344d1b7b44f97125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606628Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Alan Ding <alanding@chromium.org> Cr-Commit-Position: refs/heads/master@{#840343}
-
Patrick Noland authored
Accessing the UrlCoordinator post-destroy is no longer safe as of https://crrev.com/c/2553145. finishUrlFocusChange and setUrlFocusChangeInProgress can both be invoked post-destroy by tablet animation code, so these are guarded with early returns. I've left other call sites alone for the moment, since I'd like to understand and address other null accesses independently. Bug: 1160975 Change-Id: I4b5acd24b180cc8389cc45c8c99e01d5b30ea077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610949Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#840342}
-
Joel Hockey authored
Crosh (chrome-untrusted://crosh) will be hosted in lacros, and this field used by process_proxy must be included in lacros. Bug: 1161413 Change-Id: I504dadb1d34f68298ebd3bc044f9203ed3ca50dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608101 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#840341}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I6796f9607a75c620f5bc7a8a0fd9d8828752b93e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611812Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840340}
-
Andrew Grieve authored
Shaves off ~500ms off of blink_public_mojom_mojom_platform With python3 & change applied, logs on my machine: I 18 Started (mojom_parser.py) I 30 Parsing 177 .mojom into ASTs I 2117 Processing dependencies I 2342 Loaded 92 modules from dependencies I 2342 Ensuring inputs are loaded I 2488 Serializeing 177 modules I 2958 Finished Bug: 1143399 Change-Id: I926e9ea71b44b1b754ab00b0c42dd718922fdd1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605873Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#840339}
-
David Bokan authored
Text fragments have been enabled in stable since M80 so we can now remove the flag. The runtime feature remains since the feature can still be disabled via enterprise policy so this just removes the about:flag. Bug: 919204 Change-Id: Ifccc631362795c35dc0ac2fd78c519916cb28066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606129Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#840338}
-
Scott Violet authored
Prior to this patch what was the non-snapshotting backend did not use timestamps. This is racy, as it means the file is potentially in a bad state if WebLayer were to crash before the initial state was written. This changes the kOther backend to use time stamps. This required some changes in the WebLayer to deal with the additional files. BUG=648266 TEST=covered by tests Change-Id: I232cdfbf44ddc90b8942048d92028a646d746a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605525 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840337}
-
Jeremy Roman authored
flat_map construction prefers taking a vector so that it need only be sorted once (and it happens that here, it will always be correctly sorted) rather than having to do a binary search for each insertion. host_model_features is also now searched only once, rather than once in contains() and another in find(). Technically it could be searched slightly more efficiently (given its sorted order is guaranteed to match the other two flat trees here), but this is slightly awkward to do and so I'll stop this premature optimization short of doing that. Change-Id: I9ce61d68c16e63cefbcd2d758bee522696f6528d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605649Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#840336}
-
Xianzhu Wang authored
The maximum animation scale may be unknown in the following cases: 1. ui:TransformAnimationCurveAdapter's AnimationStartScale() and MaximumTargetScale() always return false for any animation curve, making cc not able to optimize raster scale for ui transform animations. 2. When the maximum animation to screen scale can't be computed, e.g. when there are nested scale animations. This CL partly reverts crrev.com/c/2566053 for the case that the scale is unknown by using the native scale. For 1, in the future we need to 1. distinguish translation-only transform animation (scale==1, but for now kNotScaled) and transform animations with non-computable scale (scale==kNotScaled). 2. implement ui::TransformAnimationCurveAdapter scale methods (crbug.com/1161586). Bug: 1157407, 1163100 Change-Id: I104261aa4c9400eded02e850bd2cc0e61394e2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602699 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#840335}
-