GitLab

Also slightly modify a comment, as linebreak only changes make
Rietveld sad.

BUG=NONE
TBR=mmenke@chromium.org

Review URL: https://codereview.chromium.org/311623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274270 0039d316-1c4b-4281-b951-d872f2087c98

This is needed for the delegated software renderer. For the GL delegated
render, the texture state is maintained by the driver.

BUG=314190

Review URL: https://codereview.chromium.org/303063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274269 0039d316-1c4b-4281-b951-d872f2087c98

This is a spinoff of https://codereview.chromium.org/266373006/, Patchset 11.

BUG=304290

Review URL: https://codereview.chromium.org/280393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274268 0039d316-1c4b-4281-b951-d872f2087c98

It somehow causes unresolved symbol errors when building other packages.
Let's see if we can skip instrumenting it without breaking MSan builds.

BUG=313751
R=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/308683010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274265 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/311563007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274264 0039d316-1c4b-4281-b951-d872f2087c98

Also ShellDesktopController has its own logic to initialize the
window manager, and its subclass (like Athena) can initialize
its own window management logic.

R=jamescook@chromium.org, oshima@chromium.org
TEST=no logic changes, confirmed athena_main running
BUG=

Review URL: https://codereview.chromium.org/308783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274263 0039d316-1c4b-4281-b951-d872f2087c98

Reason: the tests still fail.

> Tentatively enable StartupBrowserCreatorFirstRunTest.* on official Mac builder.
> 
> I recently fixed some places which passed empty URLs around (r272182), and these
> tests might have been failing because of the empty URL behavior (empty URLs were
> treated as the home page, and maybe the home page is something different on the
> official Mac builder than other builders).
> 
> Feel free to revert this commit if the tests fail.
> 
> R=bartfab@chromium.org
> TBR=sky@chromium.org
> BUG=314819
> 
> Review URL: https://codereview.chromium.org/308083004

TBR=marja@chromium.org

Review URL: https://codereview.chromium.org/305963012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274262 0039d316-1c4b-4281-b951-d872f2087c98

Remove 2 outdated entries. Add an entry for an issue caused by an MSan bug.

BUG=363487,378909
TBR=eugenis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/310653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274261 0039d316-1c4b-4281-b951-d872f2087c98

And run the new Python-driven test_mini_installer on win_rel trybot.

BUG=277655

Review URL: https://codereview.chromium.org/301223007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274260 0039d316-1c4b-4281-b951-d872f2087c98

This patch disables a flaky test on mac.

TBR=dharcourt@chromium.org

Review URL: https://codereview.chromium.org/305963011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274259 0039d316-1c4b-4281-b951-d872f2087c98

> Remove passwords from the keychain if profile is destroyed.
> 
> BUG=343891
> 
> Review URL: https://codereview.chromium.org/307673002

TBR=vasilii@chromium.org

Review URL: https://codereview.chromium.org/306343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274257 0039d316-1c4b-4281-b951-d872f2087c98

Fixes the memory leak in the unit tests

BUG=116119

TBR=koz,jochen

Review URL: https://codereview.chromium.org/310483008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274256 0039d316-1c4b-4281-b951-d872f2087c98

The purpose of this change is to move ProfileOAuth2TokenServiceRequest
into google_apis/gaia and drop any browser dependencies.

ProfileOAuth2TokenServiceRequest becomes OAuth2TokenServiceRequest.

Add support for invalidating tokens.

Review URL: https://codereview.chromium.org/299943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274255 0039d316-1c4b-4281-b951-d872f2087c98

The eventual goal is to allow it to simulate flaky network connections.

Docs:
https://docs.google.com/a/google.com/document/d/1SkuWqLYIUpMDI05n7vgx8zdkunyUsxGs9tvUPDOqEJY/edit
https://docs.google.com/a/google.com/document/d/19O_UeUfCFZg5cEnH5jkkZ6_tqsfaLQLYUEIGyXw3oTo/edit

BUG=245436

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273584

Review URL: https://codereview.chromium.org/182993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274253 0039d316-1c4b-4281-b951-d872f2087c98

To solve the dependency on chrome_command_ids, this CL removes the
IDC_OPTIONS_TRANSLATE_* constants and instead defines the command IDs
locally in the file, which is an approach already used at several other places in
the code.

To solve the dependency on themes, the icon ID for the translate infobar is no
longer hardcoded, but fetched from the translate client instead.

BUG=371845
TBR=estade, joaodasilva

Review URL: https://codereview.chromium.org/284313008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274252 0039d316-1c4b-4281-b951-d872f2087c98

The (future) relocation packing tool requires a host build of gtest for
its unit tests.

BUG=

Review URL: https://codereview.chromium.org/308913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274251 0039d316-1c4b-4281-b951-d872f2087c98

Blink in Chromium now has this define, so it can be removed from Chromium.


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274250 0039d316-1c4b-4281-b951-d872f2087c98

Support dumping coverage data generated by AsanCoverage from sandboxed processes. For the GPU process, we simply pre-open a file before engaging the sandbox. For the renderers, we use a helper process which we fork from the zygote. The helper process collects coverage data from renderers over a socket and writes it to a file. This allows an arbitrary number of renderers to share one output file.

With this change, GPU and renderers will write coverage data to .sancov.packed files which may contain data from multiple modules/processes. Previously, we created one .sancov file per process per module (and still do so for other processes).

Note that the new behavior takes effect regardless of whether the sandbox is actually enabled.

BUG=336212
R=jln@chromium.org
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/280303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274248 0039d316-1c4b-4281-b951-d872f2087c98

BUG=178409
R=phajdan.jr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/304353006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274247 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274240 0039d316-1c4b-4281-b951-d872f2087c98

BUG=60973
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/303393005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274238 0039d316-1c4b-4281-b951-d872f2087c98

Disabling ExtensionToolbarModelTest.SizeAfterPrefChange due to the following
flake
../../chrome/browser/extensions/extension_toolbar_model_browsertest.cc:601: Failure
Value of: model_->GetVisibleIconCount()
  Actual: 1
  Expected: -1

BUG=379170
TBR=finnur@chromium.org,kihong.kwon@samsung.com

Review URL: https://codereview.chromium.org/308003017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274237 0039d316-1c4b-4281-b951-d872f2087c98

OutOfProcessPPAPITest.TrueTypeFont

TBR=jam@chromium.org
BUG=379774

Review URL: https://codereview.chromium.org/308003016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274236 0039d316-1c4b-4281-b951-d872f2087c98

This change moves some more OpenManifestEntry logic out of the trusted plugin.
This code specifically looks up file descriptors for support files for helper
processes (llc, ld) for the PNaCl translator.

BUG=239656

Review URL: https://codereview.chromium.org/307933005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274233 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 274198 "Depend on v8:v8 instead of v8:mksnapshot"
> 
> > Depend on v8:v8 instead of v8:mksnapshot
> > 
> > BUG=none
> > R=brettw@chromium.org
> > 
> > Review URL: https://codereview.chromium.org/302783009
> 
> TBR=jochen@chromium.org
> 
> Review URL: https://codereview.chromium.org/308303003

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/306293004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274232 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379769
TBR=jennyz@chromium.org,stevenjb@chromium.org

Review URL: https://codereview.chromium.org/302063012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274231 0039d316-1c4b-4281-b951-d872f2087c98

Updates the whitelisted XKB input method IDs to sync up with the component XKB extension. Obsolete input methods are deleted.
And makes sure there won't be duplicated input methods for certain languages.

BUG=379434
TEST=None

Review URL: https://codereview.chromium.org/312443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274226 0039d316-1c4b-4281-b951-d872f2087c98

Allow the session_manager process name to use a relative
path or to not have any arguments, rather than requiring it
to have the prefix "/sbin/session_manager " (note trailing
space).

BUG=377301

Review URL: https://codereview.chromium.org/302163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274225 0039d316-1c4b-4281-b951-d872f2087c98

It fails with timeout because cleaning the profile directory is too heavy operation.

BUG=343891
TBR=erg@chromium.org,gcasto@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/306343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274224 0039d316-1c4b-4281-b951-d872f2087c98

This CL modifies ProtocolHandlerRegistry to enable addition of policy for registering and ignoring protocol handlers. The current implementation does not allow it since it saves the registered handlers, which would result in policy leak when directly mapped, i.e., protocol handler registered via policy would be saved to disk and mixed with user preference.

BUG=116119

TBR=koz,jochen

Review URL: https://codereview.chromium.org/293983004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274223 0039d316-1c4b-4281-b951-d872f2087c98

The previous implementation worked only for Google Drive filesystem.
The new implementation in the current CL generally supports all
volumes accessible from Chrome OS file manager, in particular
including MTP devices and file systems provided by fileSystemProvider extensions.

BUG=367028

Review URL: https://codereview.chromium.org/303133008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274222 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379738
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/306333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274221 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369796

Review URL: https://codereview.chromium.org/306923008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274220 0039d316-1c4b-4281-b951-d872f2087c98

Reverting - still flaky. See http://crbug.com/303491#c104 for details.

> Re-enable PDFExtensionTest.BasicPlugin
> 
> This test was disabled because it was failing. A few changes have been made:
> -The page zoom cannot be assumed to be 100% on load as it will depend on the screen size being tested on. So testPageSize now doesn't make that assumption.
> -testAccessibilityWithPage was flaking because accessibility information was not always returned for the two text boxes. I spent a bit of time investigating, but couldn't work it out so I've left it partially disabled for now and filed crbug.com/378091.
> -The files have all been moved to a more appropriate location (in particular the test was moved out of the data directory).
> 
> BUG=303491
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273819
> 
> Review URL: https://codereview.chromium.org/290803007

TBR=raymes@chromium.org

Review URL: https://codereview.chromium.org/302163007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274219 0039d316-1c4b-4281-b951-d872f2087c98

BUG=304341

Review URL: https://codereview.chromium.org/307623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274218 0039d316-1c4b-4281-b951-d872f2087c98

For consistency, has_next is changed to has_more. Also, has_more is easier to
understand in providing extensions context.

TEST=browser_tests, unit_test: *FileSystemProvider*
BUG=373165

Review URL: https://codereview.chromium.org/304533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274217 0039d316-1c4b-4281-b951-d872f2087c98

The problem why it did not work is that the FIFO used in MSAP has a size smaller than 10ms buffer before, so it crashed before webrtc::AudioProcessing consumes it.

FYI, previously the APM in Chrome was only enabled for finch experiment on Canary, so the problem does not occur in stable and beta. And I recently enabled it as default.


BUG=378895
TEST= use 96000KHz as sample rate, go to apprtc.appspot.com/?&debug=loopback to make a call.

Review URL: https://codereview.chromium.org/308643004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274216 0039d316-1c4b-4281-b951-d872f2087c98

The changes are:
- Show a supervised user icon. Note that this has a different look than on CrOS, to fit in with the "lock" icon on desktop. (The final icon resource is still missing, but since this must land in time for M37 I'm already sending the code for review now, and will switch out the icon later.)
- Use the supervised user deletion warning text from CrOS also for supervised users on desktop.

Mocks at https://folio.googleplex.com/chrome-ux/mocks/064-chrome-away-from-chrome/supervised/mirror

BUG=372812, 310640

Review URL: https://codereview.chromium.org/307483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274215 0039d316-1c4b-4281-b951-d872f2087c98

Providing extensions will very often mount provided file systems on startup.
When an extension is installed, the background is executed, and hence the file
system registered.

Since providing extensions should be event pages, they will also register
all of the request events, so the extension is woken up once there is a request
sent to it.

However, the background page is not run after a reboot. All of the registered
events are remembered in preferences, but mounted file systems not. As a result
after a reboot, the file systems are lost.

To overcome this issue, this CL introduces storing mounted file systems to
preferences, so they are remounted automatically after a reboot, once the
extensions are loaded. This is consistent with remembering registered
event handlers in preferences.

Note, that if the extension is gone after a reboot, then remounting will not
be performed, since it is done after the extension is loaded.

All of the mounted file systems are written to preferences during shutdown.

TEST=TBD
BUG=248427

Review URL: https://codereview.chromium.org/295413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274214 0039d316-1c4b-4281-b951-d872f2087c98

Some methods not used in product code keep to call GetMetadataDatabase directly.


BUG=347425
TEST=./unit_tests --gtest_filter="DriveBackendSyncTest.*:SyncEngine*:Conflict*:RegisterApp*:RemoteTo*:LocalTo*:ListChange*:MetadataDatabase*:TaskDep*"

Review URL: https://codereview.chromium.org/306813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274213 0039d316-1c4b-4281-b951-d872f2087c98