GitLab

when used together with rtcp-mux

Change-Id: I87e07d8dc74d58e69463a3a24a95c7b291b21804
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546684
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831108}

Due to some subtle C++ rules, BluetoothProfileManagerClient::Options'
role field was not being initialized to the default value. This ended up
working correctly most of the time by chance, but we have see the role
of CLIENT go over d-bus when there is no reference to ever setting in
the code. See this article for the subtle details:

https://abseil.io/tips/146

Specifically section "A Digression Discerning Defaulted Default
Constructor Declarations". Because the ctor was defined in the .cc
file it is considered a "user-defined" ctor (even though it is
defaulted) and thus scalar members are not explicitly initialized.


Bug: b:173832484
Change-Id: Iaf518d903f219128e5832b2a793ce092b02733ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561261
Commit-Queue: James Vecore <vecore@google.com>
Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org>
Auto-Submit: James Vecore <vecore@google.com>
Reviewed-by: Sonny Sasaka <sonnysasaka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831107}

Bug: 1128264
Change-Id: I841de5c4aa05b1010b276c937f39f8337d6856db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560994
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831106}

Using wpt-import in Chromium 74900845.
With Chromium commits locally applied on WPT:
19c42992 "Add a WPT test to verify the mouse click count in infrastructure/"
bcff0ea8 "[CLS] Don't count layout shifts due to content-visibility:auto unskipping"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
cbiesinger@chromium.org:
  external/wpt/css/css-flexbox
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
jsbell@chromium.org, mek@chromium.org:
  external/wpt/FileAPI
ksakamoto@chromium.org, npm@chromium.org, yoavweiss@chromium.org:
  external/wpt/resource-timing
npm@chromium.org:
  external/wpt/element-timing

NOAUTOREVERT=true
TBR=robertma@google.com

No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel
Change-Id: Ifb268ca923c2bde606f2d7fa217dbb9b7cccf60a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561218Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#831105}

Hiding the placeholder via CSS does not play nicely with "find in page"

Fixed: 1130457
Change-Id: Ia46f0fe9d62cf9f714abe6c340e334a1c768ae7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555882
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831104}

Use testdriver Action API to simulate key actions in
css/selectors/focus-visible-001.html.

Bug: 1145677
Change-Id: I5f39a03b41624e2a12c523dc9b1a0a509925621a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546602Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831103}

Bug: 1128264
Change-Id: Ibce9e5bc6cb86a88a6b5b1ce8365494e4d6d4f80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561258
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831102}

Fix enable/disable YUV decoding flags and rebaseline necessary tests.
JPEG YUV decoding was enabled by default in M87, so these tests should be cleaned
up in the near future. Primarily, this change is a fix-up for crrev.com/c/2415373.

Bug: 919627
Change-Id: I04d8c9822a8343fc4ba9730560cac72b7b178fab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417067
Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831101}

Goma RBE is now the default backend for Goma, and it only supports
relative paths. The gn variable ios_use_goma_rbe is used to create
symbolic links below root_build_dir that can be use for -isysroot
flags passed to the compiler. Automatically set the variable if it
is left unspecified, the build uses goma and targets ios.

It is not possible to always set this variable to true as it would
break macOS build when use_system_xcode is true (i.e. non-Googlers)
due to some action trying to use files below sysroot as inputs.

Change the definition of the variable so that it defaults to true
when needed, false otherwise, but can still be overridden as a fix
to allow building Chrome on iOS while using Goma.

Bug: 1152689, 1015730, 635745
Change-Id: Ia850e2d8ef9657dd342e624a72f72847e0570696
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560510
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831100}

Currently, inter-partition dangling pointers are not covered by PCScan.
This fixes it by making PCScan a singleton. The CL also ensures that
access to the global object is kept fast, i.e. no double-checked locking
(e.g. __cxa_guard_acquire/release) is introduced by the compiler.

Bug: 11297512
Change-Id: I07500a974607a30f2ad79c96f8a1e0d2c52bbbd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552397
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Reviewed-by: Bartek Nowierski <bartekn@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831099}

Adds a histogram that is recorded when a dialog is
closed in Kaleidoscope with whether the user selected
a watch action from that dialog.

Change-Id: I4f589ad843da8024150e8f99565ce20a692352f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555457
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831098}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3558df528adf..c9d4c07d6d0f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC etiennep@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1149908
Tbr: etiennep@google.com
Change-Id: If8df4cb62abbf7dd2967140256a9641c2978871c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560877Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#831097}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/740b9c2b4984..9ed30bc3ed29

2020-11-25 ahassani@chromium.org cros_flash: Allow stateful payload not to be copied to device
2020-11-25 bpastene@chromium.org cros_test: Don't raise a RunCommandError when tast tests fail.
2020-11-25 yyanagisawa@chromium.org Automatically enable ATS for ChromeOS (simple chrome).
2020-11-24 jorgelo@chromium.org usergroups_baseline.py: Use respectful words.
2020-11-24 mmortensen@google.com GatherSymbolFiles: Handle full-file paths, ignoring non .sym files.
2020-11-24 henrysun@google.com octopus: remove 11297.106.B firmware builder

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Tbr: chrome-os-gardeners@google.com
Change-Id: I06c64163a4dc518b5481f5ddd698f7af655ddd43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560998Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#831096}

The right component for Chrome OS specific accessibility is now
OS>Accessibility (or one of its subcomponents).

Bug: none
Change-Id: Icee0132859735f067b9943f152c0b88dff5ec117
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558766Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831095}

base::TimeDelta has a constexpr constructor and can be used for
constants, preventing bugs and avoiding the need for clarifying
comments.

Bug: 1152797
Change-Id: I9cd5168af01d8e9b17e83524ef37e10b50ceda44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556641Reviewed-by: Victor Vianna <victorvianna@google.com>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831094}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d4403bdefc66..3642900e6d46

2020-11-25 jacktfranklin@chromium.org Load new theme colours in the component docs.
2020-11-25 bmeurer@chromium.org [cleanup] Remove Gimli based DWARF prototype.
2020-11-25 alexrudenko@chromium.org Extract OverlayColorGenerator to a separate file
2020-11-25 alcastano@google.com Fix Icon not showing on Source Tab RowInfo
2020-11-25 alexrudenko@chromium.org Change _previouslyRecordedGridCountNodeIds to be a Set
2020-11-25 szuend@chromium.org Update TypeScript to latest stable version 4.1.2
2020-11-25 aerotwist@chromium.org [TS] Update comments for remaining files

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1083146,chromium:1151316
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I68e93bec3b1698f51857b49f91d09f36a48b045d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561278Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#831093}

Drop std::move() call that has no effect and only triggers the
"bugprone-use-after-move" clang-tidy warning.

Bug: 1122844
Change-Id: Icf792dbe102e61976e7f86454d2bdc8fcf369979
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560269
Commit-Queue: Yusuf Sengul <yusufsn@google.com>
Auto-Submit: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Yusuf Sengul <yusufsn@google.com>
Cr-Commit-Position: refs/heads/master@{#831092}

Bug: 1128264
Change-Id: I87382bc3acfcde44a0695994088d7b550dc837cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559258Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831091}

https://chromium-review.googlesource.com/c/chromium/src/+/2359370
The above CL made a custom property animation always composited if
it is used by paint worklet, even if the element does not have
"will-change: transform". The approach is that we give a special
ElementId which is uint64_t::max() to the paint worklet element,
and then on the CC side, once we see that element id, we know that
it is an animation associated with paint worklet and we will always
tick that animation.

The problem comes when there are two paint worklet elements.

The short version of the problem is:
CC's animation system doesn't allow two layers with the same
ElementId.

Longer version:
Then these two layers would have the same ElementId when
we try to attach a composited layer with that animation. As a
result, in the AnimationHost::RegisterAnimationForElement(), we
will have two Animation with the same ElementId. Then, the actual
crash happens at ElementAnimations::GetPropertyToElementIdMap(),
at the first DCHECK.

So the solution in this CL is to not DCHECK in certain cases.
The DCHECK actually doesn't make sense in this case where
there is no composited layer. In fact, the callers of the
ElementAnimations::GetPropertyToElementIdMap gives the result
to MutatorHostClient::ElementIsAnimatingChanged, and in there
it only cares about 4 properties. So for the other properties
that it doesn't care, we should not put it in the map.

Bug: 1151755
Change-Id: I5479ccae80f3c89db98d27518ef013dded527ece
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553691
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831090}

Bug: 1144538
Change-Id: Ib2671b51c6cfef72efa1fd5edc235b2dab30717b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560993Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831089}

There's no reason for this class to take a fixed string with a debug
message upon construction. It can instead produce the string dynamically
upon condition verification, such that the failure messages provide a
better insight into the actual state.

Bug: 1150829

Change-Id: I693339cc1bfe79ce69c28d7ce84faf8e48ec3562
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557986Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831088}

The tests have been migrated here:
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2560943

Bug: chromium:1137281
Change-Id: I817755683437726126139b3464bb807e2a43629f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560511
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831087}

Not sure how it made it through CQ, but the line that broke CI build,
causing a revert, has been taken care of.

Original CL: crrev.com/c/2551793
By consolidating the error histogram logging (and import the shared
component), we'll be able to make use of the new UKM logging functions
in a follow-up CL and provide it with the error causes.

Added histogram validation steps in unit tests before moving the
logging logic.

Bug: 1148807
Change-Id: I8f82ba094aca84ee659fab851b070014af1e29eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560898Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831086}

Introduces a singleton SSLKeyLoggerManager that owns the SSLKeyLogger so
that it can be used with multiple SSL_CTX instances.

Bug: 1101691
Change-Id: I3436c9158ddb28f59d1511924c7f6940f9877dc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558727
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831085}

Flag is intended to be temporary, just long enough to change the
overrides in Chrome over to the new API.

See https://skia-review.googlesource.com/c/skia/+/338596

Change-Id: I0f7cc353ab0eec649b03ffa39e9ca1dba6d7b08f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560217Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>
Cr-Commit-Position: refs/heads/master@{#831084}

This is a refactoring effort to have in-memory and in-file capture support for PaintPreviewBaseService.

Change-Id: I57c796d689239dfe133a0927979555b3e8b72ea0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548541Reviewed-by: Tanya Gupta <tgupta@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Yashar Dabiran <yashard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831083}

This change replace back button with cancel during editing.

Bug: 1146127
Change-Id: I7feed5cdc201d2239d0dd957119a31330f5b23ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526085
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831082}

Bug: 1142855
Change-Id: I0201f15c5c595a945e9e5bafcf51f789f5ade39a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559648Reviewed-by: Etienne Bergeron <etienneb@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831081}

Hooks up next/previous paragraph buttons in the STS panel. Will implement navigate by single-click in follow up CL.

AX-Relnotes: N/A

Bug: 1143819
Change-Id: Ie6ea6e8446e6aeb17a322af61df9c2a6054cd903
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549568Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Joel Riley <joelriley@google.com>
Cr-Commit-Position: refs/heads/master@{#831080}

Using float instead of int for calculating the center point of the
notification badge allows for better positioning when the icon is
scaled up and down on long press.

Bug: 1131076
Change-Id: Ic5d41c1c94c941a984f34b3a41344160b10fceff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559312Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831079}

This CL moves SigninManager to signin.services target.

Bug: 1152717
Change-Id: Ibdf3a5ea99bd059dbf7a971e21e486e39b88f54d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560302
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831078}

4 flake occurrences of this test have been detected within the
past 24 hours. List of all flake occurrences can be found at:
https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVQsSBUZsYWtlIkpjaHJvbWl1bUBpb3NfY2hyb21lX3VpX2VnMnRlc3RzX21vZHVsZUBPcGVuSW5NYW5hZ2VyVGVzdENhc2UvdGVzdE9wZW5JblBERgw.

Bug: 1152782
Change-Id: I9ed1a6ea0ea50ce447d1fa523ba880483a057625
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560268
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Auto-Submit: Ewann Pellé <ewannpv@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831077}

https://skia.googlesource.com/skia.git/+log/3e2e7b28b699..6e5079a280ed

2020-11-25 mtklein@google.com minor hash_fn() followups
2020-11-25 johnstiles@google.com Detect invalid boolean binary expressions.
2020-11-25 brianosman@google.com Reland "Move GL's SkSL::Compiler to the GPU (like all other backends)"
2020-11-25 jlavrova@google.com Heuristic for filtering out too big editing text cases
2020-11-25 johnstiles@google.com Code cleanup: Add isScalar/isVector/isMatrix helpers to Type.
2020-11-25 johnstiles@google.com Replace SPIR-V assertion with mixed-types error message.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: michaelludwig@google.com
Change-Id: Ic6d23656885a8974813cc5458f8d1d81376b7b78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560540Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#831076}

This is part of an effort to make CanonicalCookie's constructor private.

Since make_unique<T> will not compile if T's constructor is private, we
need to replace uses of make_unique in CanonicalCookie's implementation
with base::WrapUnique() and the "new" keyword.

Bug: 1102874
Change-Id: Ie5de0b4814cd8c39c5ff7484f2a8f880f2ec810d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559287Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/master@{#831075}

This adds CSS rules to the contact visibility page that will truncate
and elide the name or email of any contact if it is long enough to
overflow the given width.

Screenshot:
  https://screenshot.googleplex.com/siHhtdWNFVeEphM.png

Bug: b:168841167
Change-Id: Idaef4ea803b95b8ade014d30271474cc6806d9d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559235Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Michael Hansen <hansenmichael@google.com>
Cr-Commit-Position: refs/heads/master@{#831074}

VpnServiceFactory::GetInstance() and
VpnServiceFactory::GetForBrowserContext() are declared at the extensions
layer but only defined by its embedders (chrome and shell). This is
incorrect since it means any targets depending on extensions without
defining these methods will fail to link. Prevent this by providing an
implementation at the extensions/ layer and removing the embedder
implementations.

BUG=981112

Change-Id: Ic6af1b8e95b7bf569fd5791031facd8e30f52ba1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557222
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831073}

This will make it easier to use this factory when testing code that uses
SetCanonicalCookie() and other methods that take unique_ptrs to
CanonicalCookies.

The factory method uses base::WrapUnique to create the unique_ptr so
that the constructor can be made private. I plan on updating the other
factory methods to use base::WrapUnique instead of make_unique in a
follow-up CL.

Bug: 1102874
Change-Id: I3e84fbc68ce95438a5adfdac46573df9efe4e38d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559311Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/master@{#831072}

Generate DIR_METADATA files and remove metadata from OWNERS files for
//components/polic

Change-Id: I997f3ab15d694f1e8a18e415ea70b2b75ce84b65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554297Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Norman Rosas <normando@google.com>
Cr-Commit-Position: refs/heads/master@{#831071}

Fixed: 1121509
Change-Id: I9b6919dfa12a31909d4cee9cbcc02638bbfe2813
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559645Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831070}

This CL is the result of running the proto_export script.

Change-Id: Ib08c5a7475c4f02c6a37eb18c9ef49e1548ee533
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559225Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Auto-Submit: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831069}