GitLab

BUG=NONE

Review URL: https://codereview.chromium.org/1003953007

Cr-Commit-Position: refs/heads/master@{#320743}

R=lcwu@chromium.org,maclellant@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/1012793003

Cr-Commit-Position: refs/heads/master@{#320742}

BUG=418375

Review URL: https://codereview.chromium.org/1012483002

Cr-Commit-Position: refs/heads/master@{#320741}

TBR=bbudge@chromium.org
BUG=738729

Review URL: https://codereview.chromium.org/1011783003

Cr-Commit-Position: refs/heads/master@{#320740}

Can't post a task with a ref-counted instance of the watcher from the
destructor.

BUG=467170

Review URL: https://codereview.chromium.org/1006403002

Cr-Commit-Position: refs/heads/master@{#320739}

Move FaviconService and FaviconHandler into //components/favicon/core/browser
as they have no problematic dependencies anymore.

Update DEPS and dependencies of favicon component.

BUG=359514,359513

Review URL: https://codereview.chromium.org/983043003

Cr-Commit-Position: refs/heads/master@{#320738}

This implements support for in-process discardable
memory. Each in-process discardable memory instance is
associated with a discardable shared memory segment. This
is hopefully efficient enough with the limited use of
discardable memory in the browser process.
DiscardableSharedMemoryHeap can be used if this is not
enough.

This also moves the test implementation of the discardable
memory allocator into a TestDiscardableMemoryShmemAllocator
class and requires tests that use discardable memory to
explicitly use this test allocator. Browser tests uses the
real discardable memory allocator.

BUG=422953,463250

Review URL: https://codereview.chromium.org/1004043002

Cr-Commit-Position: refs/heads/master@{#320737}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/1e23738..3675874

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1012773002

Cr-Commit-Position: refs/heads/master@{#320736}

Root-case of the issue is that GTMCopyLaunchdExports does
not work on 10.10, so we can't resolve socket name
generated for SecureSocketWithKey.

Socket provided by SecureSocketWithKey was used for:
1. Communicate with service from browser.
This solved by using predefined socket name known to browser
and service. Socket just needs to be unique for user_data_dir.
Similar approach is used on Linux.

2. Start temporarily .plist file during service registration.
No we can start just using RunAtLoad.

BUG=428369, 466644

Review URL: https://codereview.chromium.org/982883003

Cr-Commit-Position: refs/heads/master@{#320735}

This flag is not used.
Instead, SetChildrenNeedBeginFrames() will be used to control child compositor's
frame scheduling.

R=brianderson@chromium.org
BUG=467416
TEST=cc_unittests

Review URL: https://codereview.chromium.org/1010623002

Cr-Commit-Position: refs/heads/master@{#320734}

BUG=462294

Review URL: https://codereview.chromium.org/1011753003

Cr-Commit-Position: refs/heads/master@{#320733}

BUG=

Review URL: https://codereview.chromium.org/1012683003

Cr-Commit-Position: refs/heads/master@{#320732}

BUG=466884

TBR=sky@chromium.org for renderer_resources.grd

Review URL: https://codereview.chromium.org/1004233002

Cr-Commit-Position: refs/heads/master@{#320731}

We still only track the main frame and do not share FNEs across
NavigationEntries, but this new TreeNode class will make it possible
to track them for subtrees and share them across entries of a tab.

BUG=236848
TEST=Existing Navigation{Controller,Entry} tests pass.

Review URL: https://codereview.chromium.org/1006693002

Cr-Commit-Position: refs/heads/master@{#320730}

BUG=467528
TBR=hcarmona@chromium.org

Review URL: https://codereview.chromium.org/1013673002

Cr-Commit-Position: refs/heads/master@{#320729}

The old WebSocket implementation did not correctly ignore trailing
whitespace on response headers.

This test ensures that the issue does not regress in the new
implementation.

BUG=180504
TEST=net_unittests

Review URL: https://codereview.chromium.org/1001353002

Cr-Commit-Position: refs/heads/master@{#320728}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/19c25f1..1e23738

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1012673003

Cr-Commit-Position: refs/heads/master@{#320727}

BUG=none
TEST=none
R=jamesr@chromium.org, qsr@chromium.org

Review URL: https://codereview.chromium.org/1002033004

Cr-Commit-Position: refs/heads/master@{#320726}

BUG=467529

Review URL: https://codereview.chromium.org/1006333002

Cr-Commit-Position: refs/heads/master@{#320725}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1ab2b16..cb8017b

TBR=mkwst@chromium.org

Review URL: https://codereview.chromium.org/1009893002

Cr-Commit-Position: refs/heads/master@{#320724}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b04b0ead..1462eb64

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/1007303002

Cr-Commit-Position: refs/heads/master@{#320723}

BUG=466598

Review URL: https://codereview.chromium.org/1003113003

Cr-Commit-Position: refs/heads/master@{#320722}

Many methods in PasswordStore and its backends have a ScopedVector of password forms as an out-argument, into which they put retrieved credentials.
Ideally, those methods would return that vector instead, but that is often not possible, because they already return a bool flag of success.
Keeping the out-argument has one bad consequence: it is not clear, if the retrieved credentials are appended to the vector, or if they replace the contents of the vector.

It looks like those methods are fed empty vectors anyway, so it is natural to make that explicit. This CL adds comments stating that the vectors are erased before anything new is added to them, and also modifies the code to make sure that they are indeed erased, even in failure cases.

The CL also contains some related clean-ups, like moving static methods to anonymous namespace etc.

BUG=324291

Review URL: https://codereview.chromium.org/906973007

Cr-Commit-Position: refs/heads/master@{#320721}

This CL adds handling of the PageActionNotSupported exception for the
test to pass on systems with older browser versions, which does not
support drag gesture yet.

BUG=467090

Review URL: https://codereview.chromium.org/1007953002

Cr-Commit-Position: refs/heads/master@{#320720}

Cr-Commit-Position: refs/heads/master@{#320719}

BUG=467514
TBR=hcarmona@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1011753002

Cr-Commit-Position: refs/heads/master@{#320718}

Revert of Revert of Add WebSocketDispatcherHostTest.InvalidScheme (patchset #1 id:1 of https://codereview.chromium.org/1007263002/)

Reason for revert:
The breakage still persists https://crbug.com/467471 after the original CL was reverted.

Original issue's description:
> Revert of Add WebSocketDispatcherHostTest.InvalidScheme (patchset #3 id:40001 of https://codereview.chromium.org/1000883004/)
>
> Reason for revert:
> Speculatively revert for https://crbug.com/467471
>
> Original issue's description:
> > Add WebSocketDispatcherHostTest.InvalidScheme
> >
> > This is a regression test for
> > https://codereview.chromium.org/998173003/.
> >
> > BUG=466335
> >
> > Committed: https://crrev.com/6a8de59ae3ecd7b04bee2ddec89eb7075fbd1871
> > Cr-Commit-Position: refs/heads/master@{#320262}
>
> TBR=ricea@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=466335
>
> Committed: https://crrev.com/725e3aed98c2b8a22c17bfef078b9c7a20709e49
> Cr-Commit-Position: refs/heads/master@{#320704}

TBR=ricea@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=466335

Review URL: https://codereview.chromium.org/1013663002

Cr-Commit-Position: refs/heads/master@{#320717}

Revert of Revert of Fix use-after-free in WebSocketHost::AddChannel() (patchset #1 id:1 of https://codereview.chromium.org/1006293002/)

Reason for revert:
The breakage still persists https://crbug.com/467471 after the original CL was reverted.

Original issue's description:
> Revert of Fix use-after-free in WebSocketHost::AddChannel() (patchset #3 id:40001 of https://codereview.chromium.org/998173003/)
>
> Reason for revert:
> Speculatively revert for https://crbug.com/467471
>
> Original issue's description:
> > Fix heap-use-after-free in WebSocketHost::AddChannel()
> >
> > WebSocketHost can be deleted in channel_->SendAddChannelRequest() and this
> > caused heap-use-after-free when |pending_flow_control_quota_| is accessed in
> > WebSocketHost::AddChannel().
> > This CL fixes it by posting OnFlowControl() with WeakPtr instead of calling
> > SendFlowControl() directly in WebSocketHost::AddChannel().
> >
> > BUG=466335
> >
> > Committed: https://crrev.com/d3a1d188162e45f75c87a218a70681c5d92139a8
> > Cr-Commit-Position: refs/heads/master@{#320260}
>
> TBR=ricea@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=466335
>
> Committed: https://crrev.com/4f078b9b59cbf2c1ea7098835c6488fa32d46474
> Cr-Commit-Position: refs/heads/master@{#320703}

TBR=ricea@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=466335

Review URL: https://codereview.chromium.org/1014543002

Cr-Commit-Position: refs/heads/master@{#320716}

Revert of Revert of Per-renderer WebSocket throttling (patchset #1 id:1 of https://codereview.chromium.org/1009303002/)

Reason for revert:
The breakage still persists https://crbug.com/467471 after the original CL was reverted.

Original issue's description:
> Revert of Per-renderer WebSocket throttling (patchset #13 id:300001 of https://codereview.chromium.org/972963002/)
>
> Reason for revert:
> Suspected to have caused WebSocket breakage.
> Failure seen on apprtc.appspot.com and in browser_tests.  Run the manual MANUAL_WorksWithAppRTC test for repro.
>
> See https://code.google.com/p/chromium/issues/detail?id=467471&thanks=467471&ts=1426498439 for details.
>
> Original issue's description:
> > Per-renderer WebSocket throttling
> >
> > Design Doc:
> > https://docs.google.com/document/d/1aw2oN5PKfk-1gLnBrlv1OwLA8K3-ykM2ckwX2lubTg4/edit?usp=sharing
> >
> > BUG=459377
> >
> > Committed: https://crrev.com/58d344316cf2b2cc110619c0fea4979ef143b3a9
> > Cr-Commit-Position: refs/heads/master@{#320074}
>
> TBR=ricea@chromium.org,hiroshige@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=459377
>
> Committed: https://crrev.com/3464a08a0c157c57ea02881687f10058303de8ea
> Cr-Commit-Position: refs/heads/master@{#320705}

TBR=ricea@chromium.org,henrika@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=459377

Review URL: https://codereview.chromium.org/1011743002

Cr-Commit-Position: refs/heads/master@{#320715}

Adobe test fails, Github test passes.

BUG=369521

Review URL: https://codereview.chromium.org/1007883002

Cr-Commit-Position: refs/heads/master@{#320714}

It can be flaky in other configurations as well

BUG=467483
TBR=nasko

Review URL: https://codereview.chromium.org/1007293002

Cr-Commit-Position: refs/heads/master@{#320713}

BUG=430400
TBR=enne@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1014533002

Cr-Commit-Position: refs/heads/master@{#320712}

When calling an sync method in a test, you need to wrap the passed
callback in continueTest that will call testDone if the callback stops
aunexpectedly. This makes developing easier since the tests report
immediately instead of having to wait for a timeout.

R=dtseng@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/938623003

Cr-Commit-Position: refs/heads/master@{#320711}

BUG=465863
TBR=noms@chromium.org, cpu@chromium.org

Review URL: https://codereview.chromium.org/1013613002

Cr-Commit-Position: refs/heads/master@{#320710}

TEST=run vaapi_h264_decoder_unittest on ozone/freon
BUG=none

Review URL: https://codereview.chromium.org/978263002

Cr-Commit-Position: refs/heads/master@{#320709}

When the tests determine, whether Chrome displayed a "save password" prompt appropriately (or saved automatically in the setting skipping the UI), it scrapes the password internals page for the corresponding ASK/SAVE message.

There is a delay between a new page loads and this message appears. Currently the tests wait max. 3 seconds until giving up. That breaks often.

This CL changes that to 15 seconds, curing some of the tests. Note that if the message is received earlier, the tests don't wait for the rest of the timeout, so this should not make the test duration unnecessarily longer.

BUG=369521
R=battre@chromium.org

Review URL: https://codereview.chromium.org/1009573003

Cr-Commit-Position: refs/heads/master@{#320708}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/59c7666..1ab2b16

TBR=

Review URL: https://codereview.chromium.org/1009863002

Cr-Commit-Position: refs/heads/master@{#320707}

Adding test for Vkontakte. Test passes.
Credential description string: test account for vk.com.

BUG=369521
R=vabr@chromium.org

Review URL: https://codereview.chromium.org/1005043002

Cr-Commit-Position: refs/heads/master@{#320706}

Revert of Per-renderer WebSocket throttling (patchset #13 id:300001 of https://codereview.chromium.org/972963002/)

Reason for revert:
Suspected to have caused WebSocket breakage.
Failure seen on apprtc.appspot.com and in browser_tests.  Run the manual MANUAL_WorksWithAppRTC test for repro.

See https://code.google.com/p/chromium/issues/detail?id=467471&thanks=467471&ts=1426498439 for details.

Original issue's description:
> Per-renderer WebSocket throttling
>
> Design Doc:
> https://docs.google.com/document/d/1aw2oN5PKfk-1gLnBrlv1OwLA8K3-ykM2ckwX2lubTg4/edit?usp=sharing
>
> BUG=459377
>
> Committed: https://crrev.com/58d344316cf2b2cc110619c0fea4979ef143b3a9
> Cr-Commit-Position: refs/heads/master@{#320074}

TBR=ricea@chromium.org,hiroshige@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=459377

Review URL: https://codereview.chromium.org/1009303002

Cr-Commit-Position: refs/heads/master@{#320705}

Revert of Add WebSocketDispatcherHostTest.InvalidScheme (patchset #3 id:40001 of https://codereview.chromium.org/1000883004/)

Reason for revert:
Speculatively revert for https://crbug.com/467471

Original issue's description:
> Add WebSocketDispatcherHostTest.InvalidScheme
>
> This is a regression test for
> https://codereview.chromium.org/998173003/.
>
> BUG=466335
>
> Committed: https://crrev.com/6a8de59ae3ecd7b04bee2ddec89eb7075fbd1871
> Cr-Commit-Position: refs/heads/master@{#320262}

TBR=ricea@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=466335

Review URL: https://codereview.chromium.org/1007263002

Cr-Commit-Position: refs/heads/master@{#320704}