GitLab

SurfaceDependencyProvider is badly named (since it is application level
dependencies). However, a rename is not possible without breaking the
internal tree for some period of time. So, we will do a 3 sided change.

First step is to move all methods into a properly-named interface
superclass.

Change-Id: I7da10b5bfffb53c2e3b685bdc5b4145f1e83d7c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261633
Auto-Submit: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782044}

https://boringssl.googlesource.com/boringssl/+log/c17985424391fcbaaa57f733b7197c5dd3e510aa..430a7423039682e4bbc7b522e3b57b2c8dca5e3b

The following commits have update notes:
  33f8d33af Convert X.509 accessor macros to proper functions.
  d206a11d4 Remove X509_CINF_get_issuer and X509_CINF_get_extensions.
  beaf594f8 Remove X509_get_signature_type.
  dd86e75b2 Check the X.509 version when parsing.
  fd86eaa86 Fix x509v3_cache_extensions error-handling.

Bug: none
Change-Id: Ic03b5430a3651594df2f8504abb6b154b0e38d3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264495
Commit-Queue: David Benjamin <davidben@chromium.org>
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782043}

TBR=govind@chromium.org

Change-Id: Iac292ff2e010028eb5f66819b90feea69dc6ade4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264336Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782042}

This reverts commit d64b01c3.

Reason for revert: crbug.com/1098916
vulkan_pixel_skia_gold_test and vulkan_content_browsertests failures on on Android device Pixel 2

Original change's description:
> Utility function to create VkImage from ScopedHardwareBufferHandle.
> 
> Add a utility function to create VkImage from
> ScopedHardwareBufferHandle. This helps to unify
> common code.
> 
> Bug: 1091945
> Change-Id: I87448b6a577bba95420ed0dd4f8d6925501cdec5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263478
> Reviewed-by: Peng Huang <penghuang@chromium.org>
> Commit-Queue: vikas soni <vikassoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#781848}

TBR=penghuang@chromium.org,vikassoni@chromium.org

Change-Id: I8016e4e108e4baad6b9d1e533fe616cc0f009f45
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1091945
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264587Reviewed-by: Behdad Bakhshinategh <behdadb@chromium.org>
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782041}

Serialization support of metafiles will soon be expanded to handle
font typefaces.  Clarify the naming of the existing support for pictures
ahead of the addition of contextual support for typefaces.

Bug: 1044996
Change-Id: I4e8f52026276a6a5e5b81f77818b1022d3f24033
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264619Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Alan Screen <awscreen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782040}

Currently, before the first launch of web kiosk app, the icon is not
loaded and remains default until user installs the app for the first
time. This can be somewhat inconvenient.

In this cl we will use url provided by policy to download the icon.

Bug: 1066496
Change-Id: I2b7a105723b4ff62748e95e211f1c9e67a11c077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257896Reviewed-by: Anqing Zhao <anqing@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782039}

This test was originally failing on iOS 12 device, but disabled for all
configurations. The test passes locally on available devices (iOS 13.5.1
and iOS 14).

Bug: 1060758
Change-Id: I14cab0b8aaff25c9da4728459ba0819c0b5a4e35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264852Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782038}

https://chromium.googlesource.com/catapult.git/+log/f9898ac95a9b..ba416f33b636

2020-06-24 jbudorick@chromium.org devil: add --blacklist-file back to device_recovery temporarily.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC oysteine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1097306,chromium:1098775
Tbr: oysteine@google.com
Change-Id: I159571126491456342e82e581731350ee2c92154
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264848Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#782037}

Warning messages for cookies with unspecified SameSite that are accessed
in a cross-site context, and for cookies with SameSite=None but not
Secure, are removed from the JS console in DevTools.

Analogous warnings have been added to the DevTools Issues Panel, so
these are no longer needed.

Bug: 977040
Change-Id: I7089e11679d603db8e9bb6e1380dca949dd2aa89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264262Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782036}

This reverts commit c0913ca9 and most
of commit b11af76b, including support
for release channel suffix on packages, archive_name_override, and C++
build flags for channel name.

context_provider_test_connector.* are kept in their new locations.

The TODO for https://crbug.com/1046615 is removed as that is obsolete.

Bug: 1029184,1046615,1049378
Change-Id: Ia0b7191d15a889bc497ce77a4250b9db168e58f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262594Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782035}

Several console methods were intended for old Chrome versions that are
not longer supported. Console.messageAdded event was eliminated and
Chrome 54 TODOS where resolved. Unit test was updated to test newer
Chrome versions.

Bug: chromedriver:3518
Change-Id: Iebf08a32a3c90d3ffd200fb81686c54a636d49f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259132Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Lucía Cantú-Miller <cantumiller@google.com>
Cr-Commit-Position: refs/heads/master@{#782034}

m.foo.com can set cookies on foo.com, so when checking for cookies in
the eligibility code path, any cookie applicable to the same or higher
domain up until TLD should cause the prefetch to be non-eligible.

Also adds some browsertesting in the same vein.

Bug: 1096765
Change-Id: I23801d45bbdd789b52977613bf1086deda166460
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264933Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782033}

By default the absence of the flag means that the feature is disabled.
This is to protect code while in development.

Bug: chromium:1098854
Test: Manual
Change-Id: I20063bf28ea74d9aeaa1bb541809fc6ab7162c74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264577
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Auto-Submit: Yves Arrouye <drcrash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782032}

Changes the expected schema format that indicates promise support to no
longer specify a callback in the parameters, but instead supply a
"returns_async" key. This key species the format of the return value to
the promise, or to the callback if one is supplied. Also adjusts
associated tests to check for such.

Bug: 978538
Change-Id: Ifcb0b8e8152fd6b6c9049e2d856b10d577c955fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253205Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Tim Judkins <tjudkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782031}

These tests were disabled due to MSan failures, but have been fixed by
https://chromium-review.googlesource.com/c/chromium/src/+/2253759

Fixed: 1096972

Change-Id: I49d5da2660c78a55b7b5590e7b6f775c4bf65a0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264018Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782030}

The CL which caused the flakiness was reverted in
(https://chromium-review.googlesource.com/c/chromium/src/+/2218833).

The cause was attaching request params to image requests causing
multiple requests being sent(previously only one request with one url).
Upon first layout, different number of requests complete causes
flaky behaviour.

Unmark the test as flaky.

Bug: 1087208
Change-Id: I5124c9107b50500962e82e63c6f846f557d6f282
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261255Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782029}

Allow action.setIcon() to be called from ServiceWorker contexts. Also
expand the existing MV3 browsertest to cover calling setIcon() from a
ServiceWorker context.

Bug: 893373, 1093832
Change-Id: Iedf20774dd7653245777ff8046e667d024dd3979
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257274Reviewed-by: David Bertoni <dbertoni@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782028}

The test sometimes timeouts currently. It is suspected some slow bots
cannot handle 6 test_no_interpolation within assigned time limit.

Increase the time limit for the test. Further inspection is required
if the test is still flaky afterwards.

Bug: 1087208
Change-Id: I29ce6f0ec8f3b1a92642a586be8f3633f9c7a5b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259253
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782027}

In that case we can't wait for results, and we just end the test instead
of crashing.

R=avi@chromium.org

Bug: 866140, 1098835
Change-Id: I954be9e0ec795d5e17dbfb054b2c4479e3d772ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264938Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782026}

Send ARC++ applications that should be hidden from
the family link app through ChildStatusReport.
Example of these apps are the new ARC++ TWAs
installed through playstore. The user is not able
to launch these applications from the launcher and
hence they shouldn't be added to AppActivityRegistry.

Bug: 1093072
Change-Id: I0b6bd2016cf5c00bf5096d90d88c0ebbf500cecb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252919Reviewed-by: Jeevan Shikaram <jshikaram@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782025}

- enable lens shopping experiments variants for google.com
- add unit tests to LensUtilsTest for shopping intent

Bug: 158099013
Change-Id: Ib605afcfe069320a0b2a52d4ea045759a39e3592
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261093
Commit-Queue: Yu Su <yusuyoutube@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782024}

This brings extensions APIs that access accessibility features up to date.

Bug: None
Change-Id: Iab3b588738b148ee0249488ce47c0bbd86f31cf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261179
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782023}

Currently a wl_surface is in a 1:1 relationship with WaylandWindow. To
get wayland subsurface forwarding, fields that are 1:1 to wl_surface
should be grouped and moved out of WaylandWindow. In the future,
WaylandWindow can have 1 to many relationship with wl_surfaces, some of
which are assigned wl_subsurface role.

A new WaylandSurface class is created. Original WaylandSurface is now
renamed to WaylandToplevelWindow.

Bug: 1063865
Change-Id: I23feed2a98329e3c0cc5067065af6e7dd1b2e4b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261252Reviewed-by: Maksim Sisov <msisov@igalia.com>
Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782022}

R=adunaev,sky
CC=​msisov,nickdiego

Change-Id: I88402f8562b37ee7eee4013331c593ad093e47ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258350
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782021}

Using |DefaultHash<mojom::blink::DocumentPolicyFeature>| to substitute
|IntHash<mojom::blink::DocumentPolicyFeature>| fixes the timeout
issue in release build.

Note: Although |DefaultHash<mojom::blink::DocumentPolicyFeature>| is
defined in document_policy_feature.mojom-blink-forward.h, its
hash impl |blink_mojom_internal_DocumentPolicyFeature_DataHashFn| is
defined in document_policy_feature.mojom-blink.h. Include forward.h
is not enough for DefaultHash to be used as HashTrait.

Bug: 1069021
Change-Id: Ia267c2de06f8fbc787e471103fcccc8ce861b1dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264854Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#782020}

- Status text was missing a set width, resulting in its column
  overlapping the "Date" column.

Screenshot: https://screenshot.googleplex.com/kct7u0vDHPw

Bug: 1055841
Change-Id: I9d251867a48dbacddaf7e2a0d036390c0edae751
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264498
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Auto-Submit: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782019}

Bug: 1098431
Change-Id: I59d6d61731c4eb515ee1bc648adf7c8607133f65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261258
Auto-Submit: Juan Mojica <juanmojica@google.com>
Commit-Queue: Theresa  <twellington@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#782018}

crrev.com/c/2206222 broke this behavior by making the outer <div>
focusable and preventing the inner <button> to which the click handler
is attached to from gaining focus.

This CL restores the original behavior by attaching the handlers to the
outer focusable container. It also simplifies the a11y setup by making
the outer container a real button and the inner container an unfocusable
div.

Bug: 1095549
Change-Id: Iacc1d5f673545cd25cc93965463d57d7447a7ff3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264801
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782017}

This is a follow up to crrev.com/c/2254319

By using the layout constants instead of the hard coded values.

For the combobox, this however affects only Mac
The reason for that is on Mac both
config.icons_in_label and type_ == Type::kCheckbox evaluated to true.
while on Linux both were false.

Screenshots:
Before: https://screenshot.googleplex.com/YC96zjVu2Cx
After: https://screenshot.googleplex.com/Uusea7yG6wd

Bug: 1044038
Change-Id: I20ee4e2aa416e0405df7a660e419b2b3a01e16e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264335Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782016}

The underlying data channel always returns true on sending,
asynchronously invoking a callback to notify that the message was sent,
so there's no reason not to call it asynchronously at the blink level.
This will make the main thread more responsive.

Bug: webrtc:11547
Change-Id: I8a8fd518bf25d14242561501a3b05c614be0a3db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255317
Commit-Queue: Tommi <tommi@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782015}

It previously had no logic to evict unexpired entries, but we'll be
keying it on NIK soon, which will potentially blow up the number of
entries. To avoid this causing issues, either with memory usage,
disk usage, or load time, we need to add such logic.

Bug: 1091496
Change-Id: Ifa875726dfa36e1796a78c5e7ceac41cef7953af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240031
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782014}

Now that this function exists, there is no need to reinvent it.

Bug: 1009837
Change-Id: I2980378d90d7c2f7440caec519d532d3656ee569
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261696Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782013}

Bug: 1098111, 997376
Change-Id: Ie7a98821799cb45e0db94cd4e1aa61fb064066b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261693Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#782012}

Roll Chrome Mac PGO profile from chrome-mac-master-1592999982-db22937bc7e305fa743bdb260ed4ee93f882ca20.profdata to chrome-mac-master-1593021431-7b0ea0cd42ff146f154f99cb6b34c129710780a4.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC liaoyuke@google.com,jeffyoon@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome
Tbr: liaoyuke@google.com,jeffyoon@google.com
Change-Id: Ia94664cb2170f6f73d63338f6df5b7bbe1cd1a7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264850Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#782011}

Instead of doing nothing if the focus ring manager hasn't yet been
initialized, initialize it.

Fixes a bug where there's no focus ring when the feature is enabled.

TBR=dtseng@chromium.org

AX-Relnotes: n/a.
Bug: None
Change-Id: I5cb3c4f7e837b5d0c6ffbdd969fc4594b9359b1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264880Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#782010}

Switch from headless ozone to scenic for viz_unittests.

Bug: 865172
Change-Id: I1103b27b5e9285ad90612e6597b35b5c2bab0d37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258360
Commit-Queue: Chong Gu <chonggu@google.com>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782009}

Will be disabled when either SDK is <= M, or when run on an emulator.
These are the configurations we're currently seeing flakes on.

Bug: 1095535
Change-Id: I16aca30f1535cfafc706fe10932b42dcbebc50d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255125Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782008}

Previously, failing to invoke an external protocol handler ('foo://bar')
would fail silently if the protocol was not registered or if the user
gesture requirement was not met. This limitation made it difficult for
web developers to troubleshoot such situations. This CL emits errors to
the Developer Tools console when the protocol handler is not registered,
is forbidden, or is temporarily blocked pending a user-gesture.
Similarly, if an external handler is launched, an informational log
entry is added.

Bug: 1096610
Change-Id: Ie562d0c030f138f7e5ac0a09576ba73a79de3971
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252848Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#782007}

These settings are directly controlled via feature flags and field
trials.

On the browser, they are used to filter out surfaces that should be
excluded from the study. Such exclusions are meant as a privacy measure.

On the renderer, they are used to prevent specific surfaces from being
sampled in the first place. Such an exclusion is meant as a granular
kill switch to account for unforeseen adverse effects of the act of
sampling a surface. Browser-side filtering of reported data cannot
address such issues.

Directory layout including per-directory division of responsibilities is
now described in //docs/privacy_budget_code_locations.md.

Bug: 973801
Change-Id: Id0ba366a4f5625a59d5b40031d80764d3584a892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232892Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Caleb Raitto <caraitto@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782006}

Logging for dark image doodles works identical to light image doodles
but with different logging URLs.

+ Remove DoodleLogging feature flag. Doodle logging is enabled since a
  long time and there is other code that assumes doodle logging is
  enabled.

Bug: 688960
Change-Id: If825a29abb8e23c11fa837cac4fd7288e0107fa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262057
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782005}