- 02 Sep, 2020 40 commits
-
-
Stephen Nusko authored
This test is flaky on the nexus 5x webview. This is due to a timeout Exception. This was recently added in http://crrev/c/2367753. No-Try: True TBR: johnchen@chromium.org CC: behdadb@chromium.org,jonross@chromium.org,sadrul@chromium.org,yiyix@chromium.org Bug: 1124237 Change-Id: I9086c4f1a7b443fe35924cad15ea287bc6259c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390063Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#803825}
-
Joanmarie Diggs authored
When AXSelection::Select is called to set the caret in an unfocused input, FrameSelection::DidSetSelectionDeprecated focuses the node by default. If this focus event happens to trigger a DOM mutation, the DOM tree version associated with the selection will not match the version associated with the document. As a result, when AXSelection::Select goes to cache the selection range, the DCHECK for this condition in SelectionTemplate<Strategy>::AssertValid fails. We can stop this condition from happening by using the same logic in FrameSelection::SetSelection, namely call SetSelectionDeprecated and if true, then call DidSetSelectionDeprecated -- but only after we have cached the selection range. If instead the DOM mutation is a consequence of the selection itself, there will be a similar check failures, both for the DOM tree version and the fact that layout is needed. Therefore, if a layout is pending immediately after we dispatch the selection start, update the layout, the AXPositions, and our stored DOM tree and Style versions. AX-Relnotes: N/A Change-Id: Ifbd63744d77db10b8895905a130b0b901cad3e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346329 Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#803824}
-
Nektarios Paisios authored
When an accessibility text or value changed event is raise, assistive software, such as VoiceOver and ChromeVox, doesn't really know how the previous text was modified. The event doesn't specify for example if: a character has been typed, a new line inserted, a piece of text has been cut, something was pasted, or the current selection replaced with a new piece of text. Assistive software, such as screen readers, need to either monitor key presses, or rely on heuristics to determine what to announce. This patch adds such information to text and value changed events through a list of event intents which describe the command that was carried out. R=dmazzoni@chromium.org, yosin@chromium.org AX-Relnotes: n/a Bug: 989156 Change-Id: Ie33cfd73d195086c80883315ee8fef13bdff251e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214951 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile and HasOffTheRecordProfile without argument is getting deprecated. Use cases of this call that ONLY refer to incognito or guest mode can use [Get/Has]PrimaryOTRProfile() instead. Four tests are updated to use the new API. This CL does NOT change any behavior. Bug: 1060940 Change-Id: I84280adbef886e727a008c2e9502a42c8ec08e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389203Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#803822}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8c1ced4e. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I470f2a24acb43e131ed223394c21d46e78f6badf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389900Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803821}
-
Andrei-Laurențiu Olteanu authored
Add implementation to chrome://. Add implementation to chrome-untrusted://. Add tests. Bug: b:162051831 Change-Id: I0b245f28d1acc6a28251c0c4b19fc49b27047562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372564 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#803820}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6eeb3d8bf667..bc53046b29f8 2020-09-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from a2e6c1a149f4 to e1051cbaad46 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I3e68fc301f0956cdd1bd9839de27ab7fcc11bf17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389782Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803819}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8a0ebd40f86d..c278dada96d9 2020-09-02 stefanomil@google.com spirv-fuzz: Fix GetIdEquivalenceClasses (#3767) 2020-09-02 stefanomil@google.com spirv-fuzz: Replace id in OpPhi coming from a dead predecessor (#3744) 2020-09-01 stefanomil@google.com spirv-fuzz: Transformation to replace the use of an irrelevant id (#3697) 2020-09-01 vasniktel@gmail.com spirv-fuzz: TransformationMutatePointer (#3737) 2020-09-01 stefanomil@google.com spirv-fuzz: Compute interprocedural loop nesting depth of blocks (#3753) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC cwallez@google.com,radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: cwallez@google.com,radial-bots+chrome-roll@google.com Change-Id: I07b4464acb921342ad66d0730956a61253e90ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389780Reviewed-by:
-
Yuki Shiino authored
Cronet bots are specifying use_partition_alloc=false to disable partition alloc. Respect it over use_allocator="partition" (i.e. disable PartitionAlloc-EveryWhere on cronet bots). Bug: 998048 Change-Id: I9db31569533e388d540bd8bcb04ae9e4c0801438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383372 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#803817}
-
Nohemi Fernandez authored
Fixed: 1056634 Change-Id: I18e13be1bbee5449b865745719a9f38ea1432096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387765Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#803816}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/52fe4c46..5e37cae6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iab4e3a2e77fc6490ae6fc45e60b9aac013a52491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389821Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803815}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2c19a23d6219..26be5f68f929 2020-09-02 jleconte@google.com More forward fix for crrev.com/c/2383650. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101773 Tbr: nuskos@google.com Change-Id: Ia6455decbcfb402d01ef172f29974a6864988a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389341Reviewed-by:
-
Kent Tamura authored
Change them to 'auto'. This CL has no web-exposed changes because web authors can't call getComputedStyle() for UA shadow elements. Bug: 965432 Change-Id: Ie397179b5fb78474e545dbed4b1898c00ee5c32f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389741Reviewed-by:
-
Rushan Suleymanov authored
In case when there are several entities having the same GUID and they have different types (one is a folder and another one is a URL), the folder will be preferred because it may contain more bookmarks. This patch fixes CHECK violation in SyncedBookmarkTracker::Add method during the initial merge due to duplicate entities (with the same GUID). Bug: 1081061 Change-Id: I45dd90d345c323a52b33d2fb5282a9b806a34f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379728 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#803812}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2886c86eeb44..56048e67ae15 2020-09-02 ukai@google.com Roll out new goma client binary VERSION=205 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I23de99ced31f0b8d3bf668313e8e8cc6710f399b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389560Reviewed-by:
-
Matt Falkenhagen authored
It looks like this was accidentally added in https://chromium-review.googlesource.com/c/chromium/src/+/1417431. There is another blink::BytesConsumerTee() to use instead. Change-Id: I45db617f249405c7886f0edd111e7092ea779961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389804Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#803810}
-
Mathias Bynens authored
This patch updates the FPS meter colors per the UX team’s suggestions: | description | old color | new color | | --------------------------- | --------- | ------------------------ | | dropped frame | red | #CA5B1DFF (orange/brown) | | partial/missed frame | yellow | #FFF500FF (light yellow) | | successfully rendered frame | green | #AEDDFFBF (light blue) | Bug: chromium:1104087 Change-Id: I0654562172b5f8219502f9d121a8294c138ce0f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384033Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#803809}
-
Oleh Lamzin authored
Bug: b:158658869 Change-Id: I03743e22ec8af9cea22aac92a86ed2cbe3906f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388441Reviewed-by:
-
Kuo Jen Wei authored
Bug: 1122444 Test: tast run <DUT> "camera.CCAUI*" Change-Id: Ia6c99c524569a027cc52b38ce7bf24e2c8469f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379425 Auto-Submit: Inker Kuo <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#803807}
-
Jan Wilken Dörrie authored
Bug: 927473 Change-Id: I4a40c28d76da0726bf4c8d92b01a599ccf22be4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388383 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#803806}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6f5aa3945a7f..1338a37a1add 2020-09-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 09ccc6e0 to 33b01ad5 (397 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: I93e1137425069f6bce3638fba825b0392fbd2e8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389608Reviewed-by:
-
Kuo Jen Wei authored
Bug: 1123783, b:162281119 Test: Manually Change-Id: Ie79e847b761a429c94b19898b1dbb78d2f308dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389290Reviewed-by:
-
Morten Stenshorne authored
Test got removed in CL:2388605 TBR=rmhasan@google.com Bug: 1110003 Change-Id: Iff10ef9eaa18a65b1b0097b5d58ac61a955d22c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389182Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#803803}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e2e69a28bf78..4855aad4994b 2020-09-02 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib51cd8905609fca7351b7247a553d3a374043aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389023Reviewed-by:
-
Takashi Sakamoto authored
user_activation_state_unittest.cc inludes user_activation_notification_type.mojom-blink.h, but the deps doesn't have the dependency. c.f. ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. FAILED: obj/third_party/blink/common/common_unittests_sources/user_activation_state_unittest.o Change-Id: If140383d722fb2b35aef22d4eacbc5dbc9295e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387910Reviewed-by:Kentaro Hara <haraken@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#803801}
-
Erik Anderson authored
This updates from revision 7922d7c20e246552be418e8f72e577899fd30d99 (2020-02-18) to revision bd6f96933d74ad35820533cc991b4110e6e40199 (2020-08-28) Bug: 1123982 Change-Id: Iabf283b8a6eb02468124e5640447dd8f63388c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387485 Auto-Submit: Erik Anderson <Erik.Anderson@microsoft.com> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#803800}
-
Antonio Sartori authored
As explained in https://github.com/w3c/webappsec-cspee/pull/18, Content-Security-Policy: Embedded Enforcement source list intersection algorithm sometimes computes a wrong intersection of two lists of source expressions. Additionally, blink CSPEE source intersection algorithm was computing a wrong intersection for http://*.com and http://*.example.com. We fix those problems and add a unit test and WP tests. Change-Id: Ie7b85d8c7e978af6b5e87141d257c66e5556be95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385458Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#803799}
-
Alan Cutter authored
This CL updates the background web app install process to use the install_url instead of the start_url for registering the site's service worker. This is to avoid loading the start_url during start up (potentially very resource intensive). Note that this may cause policy installed web apps to fail to preinstall the service worker if they happen to be using an install URL that doesn't register a service worker (unlikely). This regression is very mild though as the SW will just register when the user visits the site. Default installed web apps (Canvas) already serve the service worker from their install URL. Bug: 1123435 Change-Id: I96349dddb43001ff54082b3f830d11b066378c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389483 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#803798}
-
Rob Buis authored
Implement compact operator dictionary as specified [1]. Clients of the operator dictionary can query operator values using the HasBooleanProperty method. When attribute values (stretchy, form, symmetric, largeop or movablelimits) are set or changed, dirty flags are used to efficiently recompute the operator dictionary. [1] https://mathml-refresh.github.io/mathml-core/#operator-dictionary Bug: 6606 Change-Id: I1c24cc1e91599abe985efbc1102125261d3beba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368362 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#803797}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4e51400c4f05..2c19a23d6219 2020-09-02 jleconte@google.com Add missing ids for the getElementById to work. 2020-09-02 fancl@chromium.org auto-triage: Disable email notification for adding comment to issue 2020-09-02 jleconte@google.com Add Monorail project when triaging an alert with an existing bug. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101773,chromium:1113800 Tbr: nuskos@google.com Change-Id: Ieb31041460ec0935472c6f294c5c342645b9d915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389605Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599004657-692466066135c7d7137e03ca7609fab6b8e724c2.profdata to chrome-mac-master-1599025789-640f7b1f8708a3cc11acd7ca6b1de767d17f4a26.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I6103bbedcaadeadbbb5d60d82e5b75db1a7691a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389606Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ie1a0515f544e0832181e85023cfae922df2ee430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382593 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#803794}
-
Joel Hockey authored
Rather than having CrostiniManager explicitly attach USB devices when termina starts, CrosUsbDetector can be a Concierge::VmObserver and do this for all VMs whether they are started by chrome, or by vmc. It also observes VmPluginDispatcherClient::OnVmStateChanged RUNNING to reconnect devices for Plugin VM. Moved USB functions from CrostiniManager to CrosUsbDetector since it is the only client and USB is not specific to crostini, but applies to all VMs. Bug: b/150341671 Change-Id: Ic14765d3b4d2911ae297b59ab5fbba7212c9957d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386441 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#803793}
-
Abhijeet Kandalkar authored
This CL defines frame widget specific methods that will be invoked from the browser process to activate/deactivate the corresponding RenderWidget. Bug: 1071565 Change-Id: I2866536547d9b58fb6bd9559329e3d35b577748d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188013 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#803792}
-
Oleh Lamzin authored
Rename enumToCpuArch_ to cpuArchToString_ in trusted.js. Bug: b:158658869 Change-Id: I349e2c77c8943caa0f5f0fa37ffd86b0165c81be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389180Reviewed-by:
-
Oleh Lamzin authored
Rename some browsertest classes to start with TelemetryExtensionUI and end with BrowserTest. The benefit is that we can run all tests by using gtest filter "TelemetryExtension*". Bug: b:158566609 Change-Id: Id178ae867c145a7335da91fc54b011e5f3e3f551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388461Reviewed-by:
-
Oleh Lamzin authored
Remove telemetryInfo.cpuResult.cpuInfo.architecture from if statement, because architecture is a number and can be 0. Bug: b:158658869 Change-Id: Id0c064434b016175bc81849c6460fa352cb45dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387112Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/feb4151c5a11..e2e69a28bf78 2020-09-02 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie27226e58fe5d759c67f7621299dbe3cd6236816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389470Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fbcc21f83e83..6f5aa3945a7f 2020-09-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from c0dda02196e8 to 6eeb3d8bf667 (8 revisions) 2020-09-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from a2e6c1a149f4 to e1051cbaad46 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: I5ddaac937ba25f3ef9851f1e54fd96ce5bb41fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389469Reviewed-by:
-
Ryan Harrison authored
https://dawn.googlesource.com/tint.git/+log/11eda3cc3e50..464928ed913b $ git log 11eda3cc3..464928ed9 --date=short --no-merges --format='%ad %ae %s' 2020-09-01 rharrison Add missing include patch 2020-09-01 tommek [spirv-writer] Generate sampler type Created with: roll-dep src/third_party/tint/src Bug=dawn:521 Change-Id: I16357b13d9a674ac97ac2399d8b3d926a9f69615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389262 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Auto-Submit: Ryan Harrison <rharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#803786}
-
