- 22 Nov, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/258f61029f40..102af505dafe git log 258f61029f40..102af505dafe --date=short --no-merges --format='%ad %ae %s' 2019-11-22 mmenke@chromium.org netlog_viewer: Trim down cr.js and ui_webui_resources_js_util.js. Created with: gclient setdep -r src/third_party/catapult@102af505dafe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1026294 Tbr: oysteine@google.com Change-Id: I0ff17be8f6e2c4c58f6905d81871574ca4d375e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931099Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718234}
-
Max Moroz authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/88ea42af73f4..dbd3825b3104 $ git log 88ea42af7..dbd3825b3 --date=short --no-merges --format='%ad %ae %s' 2019-11-22 mmoroz Fix include path for FuzzedDataProvider. Created with: roll-dep src/third_party/icu TBR=inferno@chromium.org,metzman@chromium.org Change-Id: I96042cd235986682ee59dd82ac15bf203f2d4c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930466Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#718233}
-
kdillon authored
[scheduler] Add feature to compositor priority experiments to prioritize compositing until a BeginMainFrame is run. By default, these experiments will prioritize compositing until a compositor task has been run and then set the priority back to normal until a condition is met. This addition will allow us to experiment with prioritizing the compositor until we actually see a BeginMainFrame, a specific compositing task, with the goal of prioritizing rendering more specifically. This feature can be used with three of the five existing approaches. For alternating, compositing will be prioritized until a BeginMainFrame is run instead of any compositor task. For the delay approach, a BeginMainFrame will reset the delay, and for the budget approach the budget will only be exhausted when a BeginMainFrame is run. Bug: 966177 Change-Id: I1b9e2487cfaf33b1aefe4f949256c064921451b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906330 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#718232}
-
Ryan Sleevi authored
Device Setup > Emulators is largely a pointer to //docs/android_emulator.md, which has more setup instructions. However, it also references the instructions for how to run, but those don't appear until later in the document, and thus is unclear when read in order. Add a link to the later section, to make it clearer that it's discussed later in the document. Bug: none Change-Id: I2b3fee4d973ab500bba942a016bcb52a299aab19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930140Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#718231}
-
David Maunder authored
Bug: 1026068 Change-Id: Iddb82387326f988f5530eb08380d37dfb3f6d716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927378 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#718230}
-
Reilly Grant authored
Bug: 1007656 Change-Id: Ie2e494bcbbb0892ba35d7fd176924e7040f9d1ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929640 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#718229}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0fffc5ea..ccb488f8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4fd7d86bae3c3d7c086c79434fff12a78972490d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930341Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718228}
-
haozhe authored
Change-Id: I10c84de98370c27530d77d37a5f6b8f62404df22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930456Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Hao Sheng <haozhes@chromium.org> Cr-Commit-Position: refs/heads/master@{#718227}
-
Michael Spang authored
This reverts commit 0e7d45d4. Reason for revert: reland bypassed cq unintentionaly, more missing #includes Original change's description: > Reland "display: Deduplicate display transform code with overlay transform code" > > This reverts commit cf6bd850. > > Reason for revert: added missing #include > > Original change's description: > > Revert "display: Deduplicate display transform code with overlay transform code" > > > > This reverts commit 4430b4c3. > > > > Reason for revert: Possible cause of this failure: https://ci.chromium.org/p/chromium/builders/ci/GPU%20Mac%20Builder/173997 > > > > Original change's description: > > > display: Deduplicate display transform code with overlay transform code > > > > > > Display rotation transforms are a subset of overlay transforms, so we can > > > reuse OverlayTransformToTransform to compute display rotation matrices. > > > > > > Bug: 1019015 > > > > > > Change-Id: I95d099323cb866ccc4b9cea404e1e6f8f2dfff65 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913604 > > > Commit-Queue: Michael Spang <spang@chromium.org> > > > Reviewed-by: Khushal <khushalsagar@chromium.org> > > > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > > > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > > > Reviewed-by: Mitsuru Oshima (OOO - back on Dec 2nd) <oshima@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#717832} > > > > TBR=oshima@chromium.org,kenrb@chromium.org,spang@chromium.org,khushalsagar@chromium.org > > > > Change-Id: I2757890a784f97adf30776c2b418fba2574f1759 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1019015 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928380 > > Reviewed-by: Darren Shen <shend@chromium.org> > > Commit-Queue: Darren Shen <shend@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#717846} > > TBR=oshima@chromium.org,kenrb@chromium.org,spang@chromium.org,khushalsagar@chromium.org,shend@chromium.org > > Change-Id: I8988120b1dd114fdc0f5e0d515b9fb90ffe3cbb5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1019015 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931159 > Reviewed-by: Michael Spang <spang@chromium.org> > Commit-Queue: Michael Spang <spang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718220} TBR=oshima@chromium.org,kenrb@chromium.org,spang@chromium.org,khushalsagar@chromium.org,shend@chromium.org Change-Id: I7fb92732ed342f1e6b7922e96faa77d69835335d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1019015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931129Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#718226}
-
haozhe authored
Chrome does not support cross-fade. Bug filed: https://bugs.chromium.org/p/chromium/issues/detail?id=1026706 Firefox does not support cross-fade and have some unexpected behavior. Bug filed: https://bugzilla.mozilla.org/show_bug.cgi?id=1598130 Bug: 900581 Change-Id: Ibb79453ecc78a19dfe7e80958521d0ee224e1f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921344Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Hao Sheng <haozhes@chromium.org> Cr-Commit-Position: refs/heads/master@{#718225}
-
Jonathan Backer authored
TestGpuServiceHolder has several threads which pick up a mock clock created by TaskEnvironment. This mock clock is used by TestGpuServiceHolder when posting delayed tasks. This CL adds hooks so that when a TaskEnvironment is non-trivially destroyed (e.g. not as a result of a move), TestGpuServiceHolder will be notified and tear down first to avoid data races and potential use after free. Bug: 1014790 Change-Id: Ibeabf93d66d3f7bb73f2aee085130b599029e3c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929531 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#718224}
-
Toni Barzic authored
Also, do not maximize the app window unless it was full-screen when preview exit is requested. This prevents wallpaper from being shown again if the preview exits because the app window is minimized (e.g. by going home from overview UI). BUG=1027313 Change-Id: I513e74c2b07bcef1c8dfcf9e197722cb8142ebba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930254Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#718223}
-
Avery Musbach authored
In SplitViewController, when OnWindowBoundsChanged and OnResizeLoopEnded end split view and overview, they shall just end overview and rely on OnOverviewModeEnding to end split view. The purpose is consistency as I have already made a similar change to OnResizeLoopStarted in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1874716 Bug: None Change-Id: I20959977400247915de45e7187974ba42f21c44b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929622 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#718222}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/bcdac2a1318b..26b030de1b76 git log bcdac2a1318b..26b030de1b76 --date=short --no-merges --format='%ad %ae %s' 2019-11-22 thestig@chromium.org Load the first-page xref stream in linearized PDFs. 2019-11-22 thestig@chromium.org Fix LoadLinearizedAllCrossRefV4() to work properly. 2019-11-22 thestig@chromium.org Clean up some xref code in CPDF_Parser. 2019-11-22 tsepez@chromium.org Allocate CFX_Font::m_FontDataAllocation from the partition. 2019-11-21 tsepez@chromium.org Add another malloc(0) test. 2019-11-21 nigi@chromium.org Add a test for a non-embedded font with illegal CIDToGIDMap string. Created with: gclient setdep -r src/third_party/pdfium@26b030de1b76 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1021762 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I94e8e3ac447914908e85a91a614e1658b141b959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930467Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718221}
-
Michael Spang authored
This reverts commit cf6bd850. Reason for revert: added missing #include Original change's description: > Revert "display: Deduplicate display transform code with overlay transform code" > > This reverts commit 4430b4c3. > > Reason for revert: Possible cause of this failure: https://ci.chromium.org/p/chromium/builders/ci/GPU%20Mac%20Builder/173997 > > Original change's description: > > display: Deduplicate display transform code with overlay transform code > > > > Display rotation transforms are a subset of overlay transforms, so we can > > reuse OverlayTransformToTransform to compute display rotation matrices. > > > > Bug: 1019015 > > > > Change-Id: I95d099323cb866ccc4b9cea404e1e6f8f2dfff65 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913604 > > Commit-Queue: Michael Spang <spang@chromium.org> > > Reviewed-by: Khushal <khushalsagar@chromium.org> > > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > > Reviewed-by: Mitsuru Oshima (OOO - back on Dec 2nd) <oshima@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#717832} > > TBR=oshima@chromium.org,kenrb@chromium.org,spang@chromium.org,khushalsagar@chromium.org > > Change-Id: I2757890a784f97adf30776c2b418fba2574f1759 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1019015 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928380 > Reviewed-by: Darren Shen <shend@chromium.org> > Commit-Queue: Darren Shen <shend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717846} TBR=oshima@chromium.org,kenrb@chromium.org,spang@chromium.org,khushalsagar@chromium.org,shend@chromium.org Change-Id: I8988120b1dd114fdc0f5e0d515b9fb90ffe3cbb5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1019015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931159Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#718220}
-
Clemens Arbesser authored
This CL adds support for right-aligned checkboxes to the ShowFormAction. Prior to this CL, checkboxes would be left-aligned rather than right-aligned. This CL also adds support for an additional description line for counters and two additional description lines for checkboxes and radiobuttons. This change is intended to be short-term for an upcoming experiment, and will be removed or refactored in the near future. Bug: b/144402029 Change-Id: I679bf1273f13bd836b9cce69662fa60bd724a3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917176 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#718219}
-
Aya ElAttar authored
Moved the browsertests of Arc policies and all related stuff from policy_browsertests to a separate file. Bug: 1002483 Change-Id: I7cd14a0b622d50db59bfe06da768cfdc34bd1ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925062 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#718218}
-
Sven Zheng authored
These tests were disabled because they were flaky on Win7 with TIME_OUT. However, these tests should get skipped. I can't repro this on Win 7 anymore, even sync to the same revision. (https://chromium-swarm.appspot.com/task?id=48a8456871114310) This is an attempt to fix the issue similar to https://cs.chromium.org/chromium/src/chrome/browser/vr/test/xr_browser_test.cc?l=166&rcl=5e8d5843886822da7d70bd23db473ab5ea47e3a2 Call GTEST_SKIP has been an issue for googletest, see https://github.com/google/googletest/issues/2189 And I verified skip can work on Win7 with unittest. TEST: https://chromium-swarm.appspot.com/task?id=48a3f0a5e08c7610 Bug: 1025335 Change-Id: I906a799810d61952198ca1a57cf73e2414ca2611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925135Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Auto-Submit: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#718217}
-
Tim Volodine authored
Set the WebLayerSafeBrowsing feature to be enabled by default in weblayer. Also adds components/safebrowsing java dependency to the following targets: - weblayer_instrumentation_test_apk - weblayer_browsertests_java in order to make test bots work (e.g. otherwise missing SafeBrowsingApiBridge java class on the android-marshmallow-arm64-rel bot). Note: depends on https://crrev.com/c/1926321 (for M80+) BUG=1015418 Change-Id: Ibcf44d6f4ad249001813c29a082292d3d46fd73e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926471 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#718216}
-
Ionel Popescu authored
Prior to this change the time columns were misaligned by 1px in HC. This CL updates the style so that the same layout is going to be provided for both HC and non-HC. Note that the background and border colors for time cell are going to be updated in a future CL. Bug: 1024483 Change-Id: Ic490f82ee03885ad6f3574d74ed235793fb8f8fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929984Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#718215}
-
Sophie Chang authored
Since Previews has stopped using it, I don't really see a point of this method. Change-Id: I0ab18dc3be15991954b3e40e4627af1df03aec70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930465Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#718214}
-
Andrew Grieve authored
Change-Id: I057bf56030afcd59de307a6fac24c98572d0fc46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929516 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#718213}
-
Elly Fong-Jones authored
The change adding this code snuck in right as https://chromium-review.googlesource.com/c/chromium/src/+/1929981 was landing to make this class private, forcing a revert. Break the dep so I can re-land the privatization CL :) Tbr: shend@chromium.org Bug: 1011446 Change-Id: I4819acec98525afb411287aa946e6e27551f3064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929856Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#718212}
-
Daniel Cheng authored
Bug: 1020714 Change-Id: I785f911539f37a94df12e626eb622bae700f2afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930110 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#718211}
-
Robbie Gibson authored
The feature itself was added in a different CL and added to the general Chrome flags then. This just adds it to the iOS chrome://flags. Bug: 398135 Change-Id: I89be8cda2aaf2d3d3596e91189ad7642409052d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930899Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#718210}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1b6b54b82d86..d03f9786558e Created with: gclient setdep -r src-internal@d03f9786558e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:None,chromium:None Tbr: jbudorick@google.com Change-Id: I7361d1a3ac75f511cd40b7d77620639dacceab33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930461Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718209}
-
Kevin Ellis authored
Previously, a finished promise could be resolved if created while the finish notification task was pending. This fails in the cases where the play state is only momentarily in the finished state. For example: anim.currentTime = ANIMATION_DURATION; anim.finished.then(doSomething); anim.reverse(); anim.finished.then(doSomethingElse); In this case, doSomething should not be called. Bug: 1005861 Change-Id: I4a04c7fc75c2ae9ee719a0444a0d22ba49fb6ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928049 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#718208}
-
Nate Chapin authored
Design doc: https://docs.google.com/document/d/1Apz-SD-pOagGeyWxIpgOi0ARNkrCrELhPdm18eeu9tw This updates the WebScheduling API prototype to organize groups of tasks with the controller/signal pattern rather than with queues. The new TaskController and TaskSignal types are subclasses of AbortController and AbortSignal, respectively. They can therefore be used to abort a group of tasks, but they can also be used to modify the priority of that group of tasks dynamically. This requires a few small changes to AbortController and AbortSignal to enable subclassing. The changes to platform/scheduler/ allow a WebSchedulingTaskQueue to have a dynamic priority, and gives FrameSchedulerImpl a way to update the WebSchedulingTaskQueue's associated MainThreadTaskQueue's priority without needing to update the priority of all queues. Bug: 979017 Change-Id: I0618a54634d52b3ecfe82b06304b28a9c6d64624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814390Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#718207}
-
Chris Dalton authored
Bug: 259915 Change-Id: I57c3c65cf5b685364bc027ee7f278794b3532e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927376Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Chris Dalton <csmartdalton@chromium.org> Cr-Commit-Position: refs/heads/master@{#718206}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b1edfde279fe..fe13ca3e67d3 git log b1edfde279fe..fe13ca3e67d3 --date=short --no-merges --format='%ad %ae %s' 2019-11-22 michaelludwig@google.com Move textureop fallback code out of GrRTC and into AddTextureSetOps 2019-11-22 rmistry@google.com [G3 compile bot] Add comment to CL when there is an interesting failure 2019-11-22 mtklein@google.com rough unit test support for FM Created with: gclient setdep -r src/third_party/skia@fe13ca3e67d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: Iad41e1673c28045ee59da761955db2c36534422f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930462Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718205}
-
Tarun Bansal authored
The implementation now is very similar to getWifiSSID() method in that same java file. Change-Id: I7ae47c3fd4bb7c610829957ccedc3e63c9f7558d Bug: 1026686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922740Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#718204}
-
Wenbin Zhang authored
In load_tests, we decided to skip some stories based on tag check, per crbug.com/1019383. Though, we will still download the WPR archive for those skipped stories. This CL remove those stories when generating the story_set, and, as a result, in version check and WPR archive download workflows Bug: chromium:1025416 Change-Id: I2c8397bd4568efd6b6efbe085ec103608aff6174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927297Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#718203}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1874a9fbecdd..498ba7042fc1 git log 1874a9fbecdd..498ba7042fc1 --date=short --no-merges --format='%ad %ae %s' 2019-11-22 fmayer@google.com Merge "Allow to produce DeobfuscationMapping from proguard map." 2019-11-22 lalitm@google.com trace_processor: remove ref and ref_type from test outputs Created with: gclient setdep -r src/third_party/perfetto@498ba7042fc1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:135177627 Tbr: perfetto-bugs@google.com Change-Id: Idbc02d31dd2b71f12a07bad25fd1ebf0bf9b6fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930460Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718202}
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /chrome/browser/android/explore_sites This CL was uploaded by git cl split. R=freedjm@chromium.org Bug: 1018667 Change-Id: I901dc75034f90bb545e26716b8dbed5e802e7390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917762 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#718201}
-
Daniel Nicoara authored
The gRPC channel may close early, but the WebContents is closed async. Make sure any accesses from WebContents to transmit state via gRPC check that gRPC related state is still valid. Bug: b/144986364 Change-Id: I5c33a050f1d458b6744f913a6a72f6d574f3fc54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930455Reviewed-by:
Albert Chaulk <achaulk@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#718200}
-
Xida Chen authored
This CL changes the ukm.xml to include frame throughput. The client side code is also changed to include sampling logic. The UKM collection request has been approved here: https://docs.google.com/document/d/1SDxdua997Gm7ihJFVjinHz9qTdBzTJrEzC7GEeQHs-8/edit# Bug: 852482 Change-Id: I056353b78e08f73a593036c133c92ec125081688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821817Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#718199}
-
Ted Choc authored
This adds logic to ensure the menu button is present before checking its enabled state. This hopes to avoid timing issues with the top controls becoming visible. BUG=1026908 Change-Id: Ied47a0d1661b6d45c808d127e60ff0997d85c246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928792 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#718198}
-
Ben Pastene authored
This reverts commit 9c48331f. Reason for revert: crbug.com/1027382 Original change's description: > Don't clobber Simple Chrome cache on every gclient-runhooks call. > > This hook is mostly used by the bots, and since all of our bots are now > recycled continuously, there should be no need to clobber the cache at > every build. This will save a couple min per build, as well as a couple > GB of bandwidth per build. > > R=dpranke, jbudorick > > Bug: None > Change-Id: I9c46184566de3defb2456b6261ff9505b6a4872c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920476 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#716382} TBR=dpranke@chromium.org,bpastene@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1027382 Change-Id: Ib7c1198727e307fb4c141b62e9f3a041ce400c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929917Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#718197}
-
Jenny Zhang authored
Bug: 1009479 Change-Id: I5c13921770a21a336f03a9215a6ae430ef42cba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928636Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#718196}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 266edaa7. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." dbb86fd8 "[WebNFC] Add permission prompt for NDEFWriter.push" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I5b8caed5b2abd79cd9c2d6b81e1504232a00ccf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930855Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718195}
-