GitLab

The special-case handling for displaying the host desktop at 1:1
in high-DPI added in r174845 incorrectly handles mapping of the
clip rect from DIPs to client plugin output coordinates.

This CL re-names the various size and scale members to make a
clearer distinction between DIP, device and (client plugin) view
coordinates, and corrects the clip rect logic.

BUG=163228,168440
TEST=Connect high-DPI client to Chromoting host, switch to Original Size, and configure host to be larger than the client. Scroll around the host desktop and verify that all contents update correctly, e.g. while a video is played in a maximized window.

Review URL: https://chromiumcodereview.appspot.com/11782016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175988 0039d316-1c4b-4281-b951-d872f2087c98

By using uint32, we have bugs on 64-bit platforms: callers passing in a size_t, will have their size truncated, potentially allocating a smaller
chunk than requested. There are a few places this happens, including on the
receiving ends of IPCs(!)

However, coversely, other callers of the API might directly assign the
memory chunk's length to uint32, leading to a different possible truncation
problem. This is guaraded against by limiting operations internally to
std::numeric_limits<uint32_t> in size for now.

There's some minor cascade effects that make the CL look larger than it is.

BUG=164678
Review URL: https://codereview.chromium.org/11446048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175987 0039d316-1c4b-4281-b951-d872f2087c98

Currently if we try to activate on a carrier like Sprint, which does not use any activation process, we'll not be able to via the UI. In fact, we'll end up using the Verizon activation process which will completely fail. This CL fixes that.
Additionally, this CL also fixes the issue that once the details page is up, the connection state data (and the corresponding state of the various buttons on the page) is not updated as the network updates itself. This affects celluar but also WiFi.

R=gspencer@chromium.org
BUG=chrome-os-partner:14111


Review URL: https://chromiumcodereview.appspot.com/11829015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175984 0039d316-1c4b-4281-b951-d872f2087c98

Also makes the presence of the checkboxes in WebUI be based on
ProfileShortcutManager::IsFeatureEnabled().

BUG=162026,168196
TEST=Edit a profile that has a desktop shortcut. The WebUI should should a delete checkbox that should work as expected. Edit a profile without a shortcut and the checkbox should still be the create one.

Review URL: https://chromiumcodereview.appspot.com/11633041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175983 0039d316-1c4b-4281-b951-d872f2087c98

We use TestResult.GetAllBroken to identify and retry tests.
However, this list is empty if a test times out (and the device is
responsive). In this case we should propagate the timed_out info to the
final result, which will report a STEP_FAILURE based on this
information.

Ex. bad run:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/6093/steps/sandbox_linux_unittests/logs/stdio

BUG=169064
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11833017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175982 0039d316-1c4b-4281-b951-d872f2087c98

Just a little cleanup and some extra checks.

R=danakj@chromium.org
BUG=155209


Review URL: https://chromiumcodereview.appspot.com/11827036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175981 0039d316-1c4b-4281-b951-d872f2087c98

be null.

This is causing these crashes
https://code.google.com/p/chromium/issues/detail?id=169129

BUG=169129,168890
TEST=crashes be gone
Review URL: https://codereview.chromium.org/11834003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175980 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11830035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175979 0039d316-1c4b-4281-b951-d872f2087c98

Mostly disable c4267, but a couple that seem safe to me.

R=jschuh@chromium.org
BUG=167187

Review URL: https://chromiumcodereview.appspot.com/11819038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175978 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11823036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175977 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/xp-release-dual-core/moz/report.html?history=102&rev=175797
http://build.chromium.org/f/chromium/perf/chromium-rel-win7-dual/moz/report.html?history=70&rev=175789


BUG=169043


Review URL: https://chromiumcodereview.appspot.com/11783068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175976 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100845


Review URL: https://chromiumcodereview.appspot.com/11783045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175975 0039d316-1c4b-4281-b951-d872f2087c98

Switch to using a load method that allows us to distinguish
between frames to ensure we only update the loading progress bar
on main frame loads.  Also, clears the progress when starting a load
to nofity the user earlier of a change.

BUG=168368


Review URL: https://chromiumcodereview.appspot.com/11825007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175974 0039d316-1c4b-4281-b951-d872f2087c98

This is causing asserts in single-thread-proxy. We will want
to enable this independant of the renderer and command-line flag.

BUG=


Review URL: https://chromiumcodereview.appspot.com/11829033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175973 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11827035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175972 0039d316-1c4b-4281-b951-d872f2087c98

Revert 175890: actually, looks like we want this to also help move chromeos webui pages out of src/chrome.
> Revert 175822
> 
> After more investigation of what it would take to share the webui code framework from chrome with content, it didn't seam feasible to do this. The code in chrome (i.e. ChromeURLDataManager) is heavily tied to chrome, and is used by chrome for non-webui stuff. The JS code is also specific to Chrome. It seems better to not bring in all this stuff to content.
> 
> > Allow multiple WebUIControllerFactory objects to be registered. This makes is possible to implement webui inside content.
> > Review URL: https://codereview.chromium.org/11783038
> 
> TBR=jam@chromium.org
> Review URL: https://codereview.chromium.org/11818036

TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/11819050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175971 0039d316-1c4b-4281-b951-d872f2087c98

They are running as part of content_browsertests on gpu bots now.

BUG=111506
TEST=gpu bots
Review URL: https://codereview.chromium.org/11783078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175970 0039d316-1c4b-4281-b951-d872f2087c98

R=groby@chromium.org
BUG=None


Review URL: https://chromiumcodereview.appspot.com/11828026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175969 0039d316-1c4b-4281-b951-d872f2087c98

Move the Chrome Variations HTTP header helper file into c/b/metrics/variations, and fix up lock behavior a bit.

Specifically:
  (1) Reduces the duration for which the lock is held when appending HTTP headers.
  (2) Adds a debug assertion that the lock is correctly held when calling UpdateVariationIDsHeaderValue().

BUG=none

Review URL: https://chromiumcodereview.appspot.com/11821019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175967 0039d316-1c4b-4281-b951-d872f2087c98

The callback function of chrome.tabs.create is called once the tab is created, not when it is loaded.

If runTests() is called, it would open a tab for URL about:blank and once that is created, run the tests. The tests may call navigateAndWait which performs a navigation and waits for the completion. The chrome.tabs.onUpdated listener could be triggered by the completion of loading about:blank, however. Not by the completion of loading the URL which navigateAndWait tried to load. With this change, we wait until about:blank is fully loaded until we start executing any tests.

BUG=112155


Review URL: https://chromiumcodereview.appspot.com/11645021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175966 0039d316-1c4b-4281-b951-d872f2087c98

(which can be reused when WebDataService is broken up).

TBR=ben@chromium.org (for gyp changes)
TEST=No visible change
BUG=166488



Review URL: https://chromiumcodereview.appspot.com/11761016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175965 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11828029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175963 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/11789004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175962 0039d316-1c4b-4281-b951-d872f2087c98

- One for AppListControllerDelegate class.
- Other for the AppList - Init/Show functions.

R=xiyuan@chromium.org
TBR=sky@chromium.org # for trivial include updates

Review URL: https://codereview.chromium.org/11834002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175961 0039d316-1c4b-4281-b951-d872f2087c98

It used to be manually listed in the new engineer setup guide. Removing
it from there and adding here.

NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11777031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175960 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11830028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175959 0039d316-1c4b-4281-b951-d872f2087c98

Previously the directory name contained spaces which is problematic
when applying patches on trybots. In the future this directory
will go away with the new native host installation mechanism, so the name
doesn't really matter.

BUG=142915

Review URL: https://codereview.chromium.org/11833021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175958 0039d316-1c4b-4281-b951-d872f2087c98

> Windows: Remove content's dependency on d3dx9_43.dll.
> 
> ANGLE doesn't need this loaded anymore.
> 
> Review URL: https://chromiumcodereview.appspot.com/11737027

See also: https://codereview.chromium.org/11747017/

TBR=apatrick@chromium.org
Review URL: https://codereview.chromium.org/11820033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175957 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175956 0039d316-1c4b-4281-b951-d872f2087c98

BUG=166496
BUG=167187
TBR=rsleevi

Review URL: https://chromiumcodereview.appspot.com/11833014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175954 0039d316-1c4b-4281-b951-d872f2087c98

TBR=noel
TEST=
BUG=


Review URL: https://chromiumcodereview.appspot.com/11833012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175953 0039d316-1c4b-4281-b951-d872f2087c98

Clamps the incoming invalidation regions of PictureLayer to the actual layer bounds to avoid bloating the update region data structure. It also adds an early out when the invalidation rect is empty. 

Review URL: https://chromiumcodereview.appspot.com/11824013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175952 0039d316-1c4b-4281-b951-d872f2087c98

> Solution: the popup keeps mouse capture, so that any mouse click closes it (via WebKit's WebPopupMenuImpl.cpp) not just clicks in it or in its browser window.
> 
> BUG=161129
> TEST=navigate to
> http://www.w3schools.com/tags/tryit.asp?filename=tryhtml_select
> Click on the "car name" to bring up the pop-up.
> Click outside the browser window to see it close (just as for clicking inside the browser window)
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/11675002

TBR=sschmitz@chromium.org
BUG=169115, 161129
Review URL: https://codereview.chromium.org/11829044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175951 0039d316-1c4b-4281-b951-d872f2087c98

The IPC proxy is now the default. The SRPC proxy can still be run locally and
in tests with the --enable-nacl-srpc-proxy command line flag.
BUG=154443
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/11801039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175950 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=binji@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/11817037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175949 0039d316-1c4b-4281-b951-d872f2087c98

Doing so prevents the silliness of passing the same pointer into WebMediaPlayerParams twice. Furthermore, the switch-checking logic and render view ID code is better contained as part of RenderViewImpl as opposed to being stuffed inside RenderAudioSourceProvider's constructor.

BUG=136442

Review URL: https://codereview.chromium.org/11830004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175948 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11833008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175946 0039d316-1c4b-4281-b951-d872f2087c98

The SyncManager will stop the scheduler as part of StopSyncingForShutdown, which
happens well before things like the invalidator are torn down / told to stop
interacting with the scheduler.  As such, we can wind up scheduling nudges on a lame
duck scheduler.  Some of the stacks associated with 165561 clearly show browser
shutdown happening on the UI thread and OnIncomingInvalidation happening on the
sync thread, which will crash on a second invocation as pending_nudge will be
set to a job that is dropped by ScheduleSyncSessionJob.

BUG=165561


Review URL: https://chromiumcodereview.appspot.com/11827013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175945 0039d316-1c4b-4281-b951-d872f2087c98

This will save some trouble to those who want to interpret
the field trial results.

BUG=chromium-os:37583
TEST=manually tested


Review URL: https://chromiumcodereview.appspot.com/11823028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175944 0039d316-1c4b-4281-b951-d872f2087c98

> [Media Galleries] Add an ImageCaptureCore listener for Mac. (part 2)
> 
> This listener uses the ImageCapture API to watch for attach and detach
> events of PTP devices and other devices which can be read through the
> library. It forwards such notifications through the SystemMonitor.
> 
> Also provides an API for clients to access such devices directly and
> retrieve the media contents from them.
> 
> R=thestig@chromium.org,sail@chromium.org
> BUG=151681
> 
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175471
> 
> Review URL: https://chromiumcodereview.appspot.com/11442057

TBR=gbillock@chromium.org
Review URL: https://codereview.chromium.org/11817036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175943 0039d316-1c4b-4281-b951-d872f2087c98