GitLab

Currently, browser contexts created with `Target.createBrowserContext()`
method will die once the protocol session is closed. This is inconvenient
and inconsistent with headless behavior.

This patch introduces a new DevToolsBrowserContextManager class to take
care of browser context management. The instance of this class is shared
between all protocol sessions.

R=dgozman
BUG=836272

Change-Id: If8b4b542d1a861298ef417a40b44c218d04d2f22
Reviewed-on: https://chromium-review.googlesource.com/1049110
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556923}

The params class sets default parameters for specific platforms, particularly desktop (which should not need to specify min size and desired size, and should store icons as IconType::kFavicon). Also added a separate Google Favicon Service client to be used on desktop. These will be used in the upcoming NTP redesign.

Bug: 837798
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib1a78c49a2518acffdc8f1f7c746a751377cfb45
Reviewed-on: https://chromium-review.googlesource.com/1031562Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556922}

https://skia.googlesource.com/skia.git/+log/75ce242a4662..60c67490a1f2

$ git log 75ce242a4..60c67490a --date=short --no-merges --format='%ad %ae %s'
2018-05-08 angle-skia-autoroll Roll third_party/externals/angle2/ 3b9b027c5..c009255c7 (1 commit)
2018-05-08 fmalita Add a single-file viewer option
2018-05-07 csmartdalton Add a drawPaths method to GrCCPathProcessor

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=egdaniel@chromium.org

Change-Id: I4cbcb2c8d88e52e4372ac98aafe80721af61e53a
Reviewed-on: https://chromium-review.googlesource.com/1050565Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556921}

This CL updates the comment to be in line with acutal behavior as of:
https://codereview.chromium.org/2942013002

Bug: 729415
Change-Id: Iab429d507a3ff6e700d0230d9fd03c6054326df2
Reviewed-on: https://chromium-review.googlesource.com/1048176Reviewed-by: Kevin Bailey <krb@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556920}

If we are a containing block for an abspos descendent, we can't
reuse the fragment because we don't know if the list of abspos
items has changed -- we need to let them bubble up during layout.

This is an unsatisfying solution in the long-term but should work
for now, and does fix some crashes/bugs when fragment caching is on.

Bug: 635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I5ea5a742ed87a8f6546a1405c5935d4d8a7686b0
Reviewed-on: https://chromium-review.googlesource.com/1015327
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556919}

This cleans up multi-platform code paths selection and prepares for
the removal of OS_POSIX for the Fuchsia build.

Bug: 836416
Change-Id: Ia326c5b5f0f05d347ee52abc89ad69386761792f
Reviewed-on: https://chromium-review.googlesource.com/1033994
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556918}

Add utility methods to ExtensionBuilder to allow for setting a manifest
key or path without needing to go through MergeManifest(). This saves
the hassle of needing to construct a dictionary with a key in order to
set a manifest value.

Use it in a smattering of places.

Bug: 832958

Change-Id: If885273205572ba72787e21acc1a75da4f861751
Reviewed-on: https://chromium-review.googlesource.com/1048848Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556917}

https://chromium.googlesource.com/catapult.git/+log/08f785343ab3..a6dce8334230

$ git log 08f785343..a6dce8334 --date=short --no-merges --format='%ad %ae %s'
2018-05-08 achuith Disable cache_temperature tests on chromeos.

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:840033


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I8f31b645893821634c756a7f65e29415e7a39048
Reviewed-on: https://chromium-review.googlesource.com/1050430Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556916}

This CL adds ErrorPageTest ios_web_inttest for error pages. These tests
are faster than EG tests and can test is_post and is_off_the_record
arguments passed to TestWebClient. ErrorPageTestCase exists, because
it's not possible to test old implementation with ios_web_inttest
infrastructure. ErrorPageTestCase will be removed when old error pages
code is no longer supported. Tests for is_post and is_off_the_record
arguments will be added in a separate CL.

Bug: 725241
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic06e9613c6e69a488ac734922ffc691f124bd24b
Reviewed-on: https://chromium-review.googlesource.com/1047951
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556915}

This change implements most of the font, color, and spacing changes
requested in the mocks.

Specifically:
* Introduces a new subclass hierarchy, where AutofillPopupRowView is
  abstract and its children are divided based on whether they display
  an option (AutofillPopupItemView) or a separator
  (AutofillPopupSeparatorView).
* Introduces style divergence between suggestion rows and footer rows
  through further subclassing.
* Updates colors and most padding values to be in line with the new
  spec.

Bug: 768881
Change-Id: I45825ffd7ad8d832cf08114116ef9b0efb834e12
Reviewed-on: https://chromium-review.googlesource.com/1026204
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556914}

Using wpt-import in Chromium 89b341c5.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17160

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=danyao

No-Export: true
Change-Id: Ib59c3d472c2da8d88f1b7f37edc81e3c109e6c10
Reviewed-on: https://chromium-review.googlesource.com/1050467
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556913}

Change-Id: I06cde9dc0e217751680ed7827dd246dcfcbf70e3
Reviewed-on: https://chromium-review.googlesource.com/1050432Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556912}

A few methods and members of CanvasResourceProvider deal with
CanvasResource recycling; these only apply to a derived class
(CanvasResourceProviderTextureGpuMemoryBuffer); this CL moves
them there, deeper in the class hierarchy.

Asides from that, this CL addresses a few more nits:

- Changes the protected methods of a final class to private.
- |msaa_sample_count_| can be const.
- CanvasResourceProviderBitmap doesn't need a |surface_| member
because it inherits it from CanvasResource.
- Removes a few {} from one-line if()s.

Bug: 839970
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I7d2e2e82fa500b1b1c9c667a4f36c48d5a57bada
Reviewed-on: https://chromium-review.googlesource.com/1047807Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556911}

Fix a simple error that I made in the context menu positioning logic.

Bug: 838389
Change-Id: I2ee54d111a47bfa101af7db2fa8593ca26275a73
Reviewed-on: https://chromium-review.googlesource.com/1050509
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556910}

Bug: 814528
Change-Id: Ib98362502ec42cfa19de522ee40493d949295bc5
Reviewed-on: https://chromium-review.googlesource.com/1045486
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556909}

In the legacy UI, fullscren was disabled when the WKWebView was loading
so that the URL of the page is always visible.  After the UI refresh,
the URL is always visible, so fullscreen does not need to be disabled.
However, the toolbar should still be shown (but not disabled) upon load
events to ensure that navigation to AMP pages allows access to the
navigation controls on these pages.

Bug: 837254
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Icc9e54cd6972b481c9041fb547f4ab5e8ba40b81
Reviewed-on: https://chromium-review.googlesource.com/1048635
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556908}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5ae86d202127..276da0b4d90a

$ git log 5ae86d202..276da0b4d --date=short --no-merges --format='%ad %ae %s'
2018-04-27 jmadill git cl: Do not set WIP when using no_squash.

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:767439


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Ifd085ed96d5ee4b37679c9d16faf171da45f2d1a
Reviewed-on: https://chromium-review.googlesource.com/1049955Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556907}

https://pdfium.googlesource.com/pdfium.git/+log/967aa0793c0b..9ec0bca735b5

$ git log 967aa0793..9ec0bca73 --date=short --no-merges --format='%ad %ae %s'
2018-05-08 thestig Simplify more code in CPDF_TextObject.
2018-05-08 dsinclair [fm2js] Create fewer CFX_WideTextBuf classes
2018-05-08 dsinclair [fm2js] Fail transpiling if lexer has left over data
2018-05-08 thestig Move CalculatePitch8() to core/fxcodec.

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:834575,chromium:834575


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I17f2467f429b3a99b040bda60f9515488cbe26d7
Reviewed-on: https://chromium-review.googlesource.com/1050511
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556906}

Screen capturer based on IOSurface for OSX has been landed in WebRTC
and set as Disabled by default.
This cl is to add a base::Feature command line flag to enable it.

Bug: 840597
Change-Id: I7dd17ccd50e352f72a1dac809709db119275c8b6
Reviewed-on: https://chromium-review.googlesource.com/1048977Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556905}

https://chromium.googlesource.com/angle/angle.git/+log/3b9b027c59f3..de1c1db091aa

$ git log 3b9b027c5..de1c1db09 --date=short --no-merges --format='%ad %ae %s'
2018-05-08 jmadill Revert "Update cq.cfg with new builders."
2018-05-08 jmadill Update cq.cfg with new builders.

Created with:
  roll-dep src/third_party/angle
BUG=chromium:833999,chromium:833999


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: I43662d7c300123f31ed164c0d7acd9f822adb5f9
Reviewed-on: https://chromium-review.googlesource.com/1050382Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556904}

Bug: 837333
Change-Id: I7d8899093a74d1d6c0d3656ca1ddef8fbe547ea4
Reviewed-on: https://chromium-review.googlesource.com/1050469Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556903}

We move FaviconCache to the Omnibox component for two reasons:

 1) Since there's no need for this to live in chrome/, it shouldn't.
    We generally favor code living in components/ for modularity.

 2) Favicon component OWNERs have indicated that this cache may one day
    be included into the Favicon component if there is another user
    other than Omnibox.

Bug: 823535
Change-Id: I5f4464f868f069ab6d5fa2ab9cb6e94b84eec7e6
Reviewed-on: https://chromium-review.googlesource.com/1048409Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556902}

Change-Id: I148c521426976adc5e15e1a0d5c70a573da8bc84
Reviewed-on: https://chromium-review.googlesource.com/1045104
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556901}

This CL adds feature flags that causes Chrome to suppress suggestions,
votes and quality metrics based on profile data which has been flagged
as likely invalid.

This will allow Chrome Team to evaluate the utility of attempting to
filter out this data.

Bug: 835984
Change-Id: I63f51ac893d2bf657af9eb136d920cb0b7f2bddd
Reviewed-on: https://chromium-review.googlesource.com/998132
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556900}

Change-Id: I481ee17e83c2eef8433fa774285cf68e0b7c4ac8
Reviewed-on: https://chromium-review.googlesource.com/1041139Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556899}

Change-Id: Id9829fbc88f7df9171625886c0d94ef7ae97b60a
Reviewed-on: https://chromium-review.googlesource.com/1042291Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556898}

This Cl adjusts the size of rich suggestion images (and placeholders).
The placeholders are also now rounded rectangles. The images
(non-placeholder) are not rounded rectangles because I'd like to look
into doing that processing on the server.


Bug: 798631
Change-Id: I656c6f850db251f8f5ee81d2e95dd5f6b95aa32f
Reviewed-on: https://chromium-review.googlesource.com/1048609Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556897}

This CL adds OWNERS files for components/*_grdp/ directories where the
components/OWNERS file had a clear owner for the corresponding
components/*.grdp file.

Bug: None
Change-Id: I99e80c3fe39809d4b64570cbc359a4c835ad3952
Reviewed-on: https://chromium-review.googlesource.com/1045171
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556896}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e72214bb..21cb8d2c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I9ee9866061151cc7de24b9089ce22bed6fb21b56
Reviewed-on: https://chromium-review.googlesource.com/1050070Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556895}

R=jchinlee@chromium.org

Bug: 790168
Change-Id: I6429db2b040ae8490cec5d792a9b2c22556a852e
Reviewed-on: https://chromium-review.googlesource.com/1049054Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556894}

This CL updates the size of the separator text when laying out a split
row using ComputeMaxWidths.

Bug: 839714
Change-Id: I4350f864115bd891a00f3fb8a34a2a2eafe67e17
Reviewed-on: https://chromium-review.googlesource.com/1049106
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556893}

Show printer changes on the setting page when they're received
from sync.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I86b82f06ae6bc255e5494a78f2fdcfaad28da8de
Reviewed-on: https://chromium-review.googlesource.com/1029266Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556892}

This patch increases the aura shel version to 6 that was missed in the
previous change(I19eb520818281161abd53230b8cabcd0d40e1ebd).

Bug: 840107
Change-Id: I749a72dcfbf74e805164ff3adfe210c5fc6b9155
Component: aura shell
Reviewed-on: https://chromium-review.googlesource.com/1050514Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556891}

This patch includes 2 changes, These changes only effect Windows
touchpad because only fling events on Windows touchpad can reach
overscroll controller.

1. Prevent fling event start overscroll.
2. Only fling events in first 0.3 second will processed for
   overscroll. On Windows, we don't generate the inertial
   events (fling) but receive them from Win API. In some cases,
   we get a long tail of inertial events for a couple of seconds.
   The overscroll animation feels like stuck in these cases. So
   we only process 0.3 second inertial events then cancel the
   overscroll if it is not completed yet.

Bug: 647140
Change-Id: Iea7941bff77a84f95acf8f342c12273cb909a5d3
Reviewed-on: https://chromium-review.googlesource.com/1025391
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556890}

We added second set of |NGInlineItem|s when ::first-line rule
is used, because ::first-line may change styles and thus
|ShapeResult|s.

The 'text-transform' property in ::first-line rules may change
the text content as well. This patch adds the text content for
::first-line to support the 'text-transform' property.

A new struct |NGInlineItemsData| stores text content and a
vector of |NGInlineItem| to represents a set, one for
::first-line and another for other cases. It also includes
|NGOffsetMapping| because it depends on text content.

This patch does NOT include:
1. Applying the 'text-transform' property. In this patch, the
   ::first-line set has the same string, and that no visible
   behavior changes are in effect in this patch.
   Most normal cases are easy, but it's not easy when it
   changes the length of the text. I'm exploring a few options.
2. |NGOffsetMapping| for ::first-line. This patch adds a
   storage for ::first-line, but its callers need to be
   updated to pass |is_first_line|.

I will work on item 1 next.

Bug: 636993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I29a841dee935c3dbaf2577c0dc76209a8462a221
Reviewed-on: https://chromium-review.googlesource.com/1046865
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556889}

Rename SurfaceTextureGLOwner interface to a more generic name TextureOwner.
This is because in future this interface will have multiple different
implementations. Also rename current implementation of this interface
SurfaceTextureGLOwnerImpl to SurfaceTextureGLOwner.
Rename all the usage of this surface texture interface to texture owner.
Please see crbug for more details.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I17ae56c12ac86cb09e57ad9c8e7a91d9927d4b1b
Bug: 838725
Reviewed-on: https://chromium-review.googlesource.com/1038125Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556888}

Currently, they only run when the network service is disabled.  This CL
will both make it easier to enable them for SafeBrowsing once
SafeBrowsing correctly sets up its tests with the network service
enabled, and protects against regressions in the legacy in-process path
in the meantime.

Bug: 789640
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I5d33acbe7c3ee918a2fe5335c60c7c2b7bb0721a
Reviewed-on: https://chromium-review.googlesource.com/1042888Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556887}

Bug: 840480
Change-Id: Ia92ed5a05d23ce25d577f5ab822527b7a25fa915
Reviewed-on: https://chromium-review.googlesource.com/1048063Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556886}

This CL introduces HeapTracer which a single concept to track interesting
garbage collection numbers across garbage collections.

This allows for unit testing measurements and unifying the histogram
logic into a single place.

Bug: chromium:840789
Change-Id: Ie36d6f9cc973f0dec28a3305b2d0def59bafe135
Reviewed-on: https://chromium-review.googlesource.com/1046647
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556885}

We gather the library dependencies of the executable, to include them
in the manifest, by running 'readelf' on it, then iterating over each
library in turn to add its dependencies, and so-on.

'readelf' can accept multiple filenames on the command-line, so rather
then invoking it once per-file, run it on a batch of all the not-yet-
processed dependencies, at each iteration.

Bug: 798851, 796779
Change-Id: If1ff5be592bfea120b93d16b09eb53c651d6c50f
Reviewed-on: https://chromium-review.googlesource.com/1049174
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556884}