- 01 Mar, 2018 40 commits
-
-
Peter Wen authored
Overhead should be tracked but these symbols are not actionable. Making them padding-only removes them from size diffs. Bug: 814078 Change-Id: I68991f54d4ee990c7bd675c4dd0f22e5337eb9f4 Reviewed-on: https://chromium-review.googlesource.com/941587 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#540164}
-
Kevin Bailey authored
Feature change which adds a button to tab switch suggestions (under a flag). Currently the flag does nothing but let the user evaluate it. In a subsequent change, the button will invert the selection logic such that <enter> will navigate, <shift-enter> will switch and the button will switch. Bug: 780835 Change-Id: I4453598f95db22fed8cc0bde50ef6d9788a205b2 Reviewed-on: https://chromium-review.googlesource.com/919247 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#540163}
-
Gabriel Charette authored
And use it instead of flaky sleep timings in tests that exercise the reclaim timeout. Bonus: this speeds up these tests from ~1500ms to ~500ms in the normal case. R=fdoray@chromium.org, robliao@chromium.org Bug: 735701, 803900 Change-Id: I3b271fda6c7b42033ac7b3c128e8663e80acebb3 Reviewed-on: https://chromium-review.googlesource.com/937505 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#540162}
-
Peter Wen authored
Original CL: https://crrev.com/c/938122 Fix: - Division by zero when there is no uncompressed pak files. TBR=agrieve@chromium.org Bug: 814078,817534 Change-Id: Id3198a84dce95074d13ca20afe4caec45631b0cc Reviewed-on: https://chromium-review.googlesource.com/943221Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#540161}
-
Eric Seckler authored
The new test verifies that animated GIFs don't produce CompositorFrames for animate_only BeginFrames and that their animation is aligned with virtual time progression. Also replaces use of --enable-surface-synchronization flag with Feature and adds a trace event for impl-side invalidations to cc::Scheduler. Bug: 646774 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I24f5a3ab14588f787b3dd571223b4737574929d8 Reviewed-on: https://chromium-review.googlesource.com/941562Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#540160}
-
Emily Hanley authored
Change-Id: Ie32821761795bdaaffe3d6a2c0bf6054bd436230 Reviewed-on: https://chromium-review.googlesource.com/931926 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#540159}
-
Ioana Pandele authored
Bug:817785 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id735d1bd561de497e351d0482fa0e21b3c874359 Reviewed-on: https://chromium-review.googlesource.com/943106Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#540158}
-
jonross authored
More tests have been fixed, re-enabling on FYI to start to verify no flakes. TBR=kylechar@chromium.org TEST=viz_content_browsertests, viz_browser_tests Bug: 760181 Change-Id: I3d27ff8372fbe10b46efeb074f2bf07d60e14f43 Reviewed-on: https://chromium-review.googlesource.com/943243Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#540157}
-
Michael Hablich authored
This is a roll-back to v8 6.6.346. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. TBR=machenbach@chromium.org NOTRY=true Change-Id: I9ca1490f7d5f647abd7788acd3ff385f64d1acc5 Reviewed-on: https://chromium-review.googlesource.com/942902 Commit-Queue: Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#540156}
-
Harald Alvestrand authored
These counters measure non-standard features, except for the "dtmf" attribute which measures the standard feature that is replacing a non-standard feature (createDTMFSender). Bug: 812587 Change-Id: Iffd97a87fbc81a3c9b6f9a8afbd3c775220da1d1 Reviewed-on: https://chromium-review.googlesource.com/941802 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#540155}
-
Gabriel Charette authored
While auditing the code I noticed that this was a problem: if a worker cleans up while waiting for n workers to be idle, the idle stack will shrink and this condition may never be reached. This prevents this completely for WaitForAllWorkersIdleForTesting() and greatly reduces the likelihood for WaitForWorkersIdleForTesting(n). WaitForAllWorkersIdleForTesting() is safe because "n" is obtained under the lock. Whereas an external call to WaitForWorkersIdleForTesting(n) could wait on a worker which was already detached. But in practice if the reclaim timeout is long enough and the main thread invokes this immediately after unblocking a test task and waiting for it to resolve, the race would require the main thread to be preempted for the full reclaim timeout for no reason which seems highly unlikely. Audited current usage and added a comment as such. R=fdoray@chromium.org, robliao@chromium.org Bug: 816170, 735701 Change-Id: Ie7b4fd81c04f53cc9597ebc02a25b39d4f1d658f Reviewed-on: https://chromium-review.googlesource.com/937361 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#540154}
-
Keishi Hattori authored
Limit trace depth for VisitPersistents so we don't trace most of the object graph in one go. Bug: 757440 Change-Id: Ib43956d4b6f128169ada158e849f6e9668591378 Reviewed-on: https://chromium-review.googlesource.com/937421 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#540153}
-
Rakina Zata Amni authored
This change is the continuation of crrev.com/c/925763. With this change, CSSOM changes to constructed stylesheets are reflected on all TreeScopes where the style is applied to. Spec draft: https://wicg.github.io/construct-stylesheets/#dom-cssstylesheet-cssstylesheet Bug: 807560 Change-Id: I1cddeea9dc346aa238fa4d0aabe233397166e2a5 Reviewed-on: https://chromium-review.googlesource.com/938872Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#540152}
-
clamy authored
This CL replaces the usage of a ResourceDispatcherHostDelegate in CrossSite* content_browsertests by TestNavigationManagers. It also moves the remaining CrossSiteResourceHandlerTest into the CrossSiteTransferTests. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ie10a45ce406471d4286fbc893e870cb044c4c4ac Reviewed-on: https://chromium-review.googlesource.com/922182 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#540151}
-
Mounir Lamouri authored
This is done by keeping track of whether a playback was autoplay initiated when starting and always returning this value to the WatchTimeReporter. Bug: 814268 Change-Id: Id34b73047df7a68ee8bb19d6f25285930a85d60e Reviewed-on: https://chromium-review.googlesource.com/923984Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#540150}
-
Francois Doray authored
With this CL, when a WebContents is occluded on aura: - WebContents::GetVisibility returns OCCLUDED - RenderWidgetHostImpl::WasHidden is called on all RenderWidgetHostImpls that belong to the WebContents. That allows: - Changing the priority of renderer processes to background. - Not rendering frames unnecessarily. Bug: 668690 Change-Id: Ie1c86d271276576a6b5c7adfb11bd0e42d5d491e Reviewed-on: https://chromium-review.googlesource.com/937820Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#540149}
-
Ramin Halavati authored
Network traffic annotation is added to content/renderer/media/webrtc/peer_connection_dependency_factory.cc Bug: 656607 Change-Id: Ie88c13b8ab6f28e7604f48d134c231b16ab18a61 Reviewed-on: https://chromium-review.googlesource.com/934127 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Taylor Brandstetter <deadbeef@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#540148}
-
Christopher Cameron authored
The device_scale_factor_ and painted_device_scale_factor_ members of LayerTreeHost are mutually exclusive -- a tree will either use one or the other (and leave the unused member as 1). Prior to this cleanup we would call SetDeviceScaleFactor or SetPaintedDeviceScaleFactor to update these variables. Add a LayerTreeSettings member to select the device scale factor mode, and make LayerTreeHost::SetViewportSizeAndScale update the specified variable. Remove the remaining calls to SetPaintedDeviceScaleFactor (from Android's compositor) and remove the function. Remove RenderWidgetCompositor::SetDeviceScaleFactor, and several related WebKit functions that called this. The call was only necessary to work around a bug where we did not specify the "original" (aka "non-emulated") device scale factor in RenderWidget::UpdateCompositorSurface non-IsUseZoomForDSFEnabled mode. R=dgozman,piman,fsamuel TBR=pdr (for public/) Bug: 805774 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I233727da320b14b041bb48515da3cfb0d2be1ea4 Reviewed-on: https://chromium-review.googlesource.com/938958 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#540147}
-
kylechar authored
The VizDisplayCompositor feature moves the display compositor off the browser main thread and into the GPU process on a dedicated thread. Make sure that the display compositor thread is recorded separately in the thread_times benchmark and counted as part of the fast path total. Bug: 778749 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ic18c3564ecf5e192f2dcf1e2e272dac3c99d8873 Reviewed-on: https://chromium-review.googlesource.com/937398 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Brian Anderson <brianderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#540146}
-
Bryce Thomas authored
This event notifies the dev tools client when a web font has successfully loaded. Event information includes the font-family, src, and other font properties, as well as the resolved platform font family name. R=dgozman@chromium.org Bug: 803226 Change-Id: I2bb399ce1c08b0a397f8eb94d95aa85556ebb2c1 Reviewed-on: https://chromium-review.googlesource.com/905829 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#540145}
-
Sylvain Defresne authored
Partial manual revert of https://crrev.com/c/903245 to accomodate the refactoring done in ios/chrome/browser/browsing_data. Notable changes: - removed class IOSBrowsingDataCounterFactory that was used purely for namespacing a static function and instead used a free function in an anonymous namespace - use BrowsingDataRemoverObserver to watch for removal of browsing data instead of using subscription with the old global CallbackList - introduced chrome://flags#new-clear-browsing-data-ui flags (backed by a feature) to enable or disable the new UI - fix presubmit checks by converting uses of base::Bind to base::Bind{Repeating,Once} - re-enabled disabled tests Bug: 760084 Change-Id: I18a59144f2ba461e096d1e009261a2e717e463b7 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/939624 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#540144}
-
Vasilii Sukhanov authored
Previously navigator.credentials.get() would return a blacklisted credential like a normal password. It's a problem if due to another bug the username isn't empty. Bug: 817754 Change-Id: I51f79e8399f0566438ce203cb9338bd5e4dc5f0d Reviewed-on: https://chromium-review.googlesource.com/942921 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#540143}
-
Martin Sramek authored
The SyncConfirmationUI class passes a set of strings to the chrome://sync-confirmation WebUI. The strings relevant to consent recording are then extracted from HTML and passed back to the C++ side, to SyncConfirmationHandler. At the same time, SyncConfirmationUI passes a copy of these strings directly to SyncConfirmationHandler to verify that they weren't altered. This assertion failed for string translations that contain the Unicode NBSP symbol. This symbol was serialized into HTML as " ", and so the set of strings passed to SyncConfirmationHandler from chrome://sync-confirmation no longer matched those passed directly. Bug: 816862,781765 Change-Id: Icb3e2cb35326ba72e8aa340dc1d73a77d0ea2c59 Reviewed-on: https://chromium-review.googlesource.com/942321Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#540142}
-
chrome://dinoEdward Jung authored
Change the way touch is detected, so we listen to touch events regardless of device. The touch controller is added at the point the game is started with touch. This caters for hybrid devices, where the game could be started by keyboard or touch. Bug: 784279 Change-Id: Ie173825dbc4353a38444f864b39108d8e38e92c0 Reviewed-on: https://chromium-review.googlesource.com/939478Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Commit-Queue: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#540141}
-
Juan Antonio Navarro Pérez authored
This reverts commit a1d023d3. Reason for revert: Causes large battery usage regression on Go devices. Original change's description: > Record visible load time metric for images > > This metric tracks how long the user has to wait for a visible image to > load completely. This metric will help understand how much delay does > lazyload of images incurs users. > > Bug: 812684 > Change-Id: Ic97c9a192254a2b64d9f2427d8694d6e36759db9 > Reviewed-on: https://chromium-review.googlesource.com/831530 > Commit-Queue: rajendrant <rajendrant@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Scott Little <sclittle@chromium.org> > Reviewed-by: Fredrik Söderquist <fs@opera.com> > Cr-Commit-Position: refs/heads/master@{#539221} TBR=rkaplow@chromium.org,fs@opera.com,hiroshige@chromium.org,sclittle@chromium.org,rajendrant@chromium.org,schenney@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 812684 Bug: 816944 Change-Id: I000e532a22150dc600b3e49337a8507cdeace504 Reviewed-on: https://chromium-review.googlesource.com/942861Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#540140}
-
Scott Chen authored
Bug: 814995, 814996 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0537d1b713e5b781995bb6dc1ee958b53e4e3bc9 Reviewed-on: https://chromium-review.googlesource.com/935746Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#540139}
-
Greg Kraynov authored
Backgrounding, audio playing, keep-active mode, and process type are fairly important states of the renderer. Change-Id: Idde31df06b4f046ce1cd5692390b1dccbf56da85 Reviewed-on: https://chromium-review.googlesource.com/939963 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540138}
-
Colin Blundell authored
TBR=msw@chromium.org Bug: 817327 Change-Id: I5ffb15a717f732db5543cd682ac54b443b663a80 Reviewed-on: https://chromium-review.googlesource.com/942906Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#540137}
-
Colin Blundell authored
TBR=ekaramad@chromium.org Bug: 817066 Change-Id: I940c9a93ac05e3e2245fa7bafc42cd812d03a514 Reviewed-on: https://chromium-review.googlesource.com/942903Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#540136}
-
Gabriel Charette authored
This extracts task_scheduler.flow from toplevel.flow. toplevel.flow has way too many events at the moment and is essentially unusable (results in massive traces which are slow to visualize). Unfortunately the tracing macros result in a static variable that assumes the category never changes (INTERNAL_TRACE_EVENT_GET_CATEGORY_INFO). As such the code in task_annotator.cc cannot be reused to log events to a provided category. Instead TaskAnnotator now supports nullptr to disable trace events and TaskScheduler adds its own trace flow events. Bonus: restricted the scope of the TRACE_EVENT_FLAG_FLOW_IN events such that the event "receiving the task" precedes TaskAnnotator::RunTask instead of overlapping with it. This will make flow arrows line up nicer. R=fdoray@chromium.org, primiano@chromium.org Bug: 811035 Change-Id: I1b4042c225486df0caf6c242f1f111291b2a1101 Reviewed-on: https://chromium-review.googlesource.com/939177Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#540135}
-
Brian White authored
Extensions are covered by a different setting under sync. If that setting is enabled then extension:// urls can be included in UKM information. This only works if the broader system has consent. Bug: 810766 Change-Id: Id0ba274ee4bceafe4521ce1f2f1060533cccc2ac Reviewed-on: https://chromium-review.googlesource.com/911591 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#540134}
-
Hans Wennborg authored
num_ack_blocks is a uint8_t, so "num_ack_blocks - 1" would have type int, causing MSVC to warn. TBR=rch Bug: 817722 Change-Id: I4d9cbc0cf266dc00174ab73f66d80e56fc007ad2 Reviewed-on: https://chromium-review.googlesource.com/941945 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#540133}
-
https://chromium.googlesource.com/catapult.git/+log/b019720d08b2..279fcf542e09 $ git log b019720d0..279fcf542 --date=short --no-merges --format='%ad %ae %s' 2018-03-01 perezju Revert "[Telemetry] Remove PageTestResults.failures getter" 2018-02-28 perezju Reland "[Telemetry] Simplify code for --browser=exact on Android" 2018-02-28 eakuefner [TBMv2] Allow nulls to be stably stringified 2018-02-28 eakuefner [Telemetry] Don't populate benchmark_descriptions if not set 2018-02-28 eakuefner [TBMv2] Factor mergeHistograms out in merge_histograms_cmdline 2018-02-27 eakuefner [Telemetry] Remove PageTestResults.failures getter 2018-02-28 eakuefner [Dashboard] Remove spurious print in add_histograms_queue Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I6dd7aaf71029d8ff15086e2d59eb8588c19d7710 Reviewed-on: https://chromium-review.googlesource.com/942801 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540132}
-
Yoshifumi Inoue authored
This patch makes |SelectionAdjuster| not to call |SetAsBackwardSelection()| of |SelectionTemplate::Builder| with logically collapsed range because |SetAsBackwardSelection()| expects |range.end > range.start|. Note: |EphemeralRange| constructor checks |start <= end| Note: logically collapsed range means |Position::CompareTo(other)| for start and end positions returns 0, e.g. "abc"@0 and before "abc". This patch is a preparation of the patch[1]. [1] http://crrev.com/c/939142 Utilize selection_test() to editing/selection/select-across-readonly-input-[1-5].html Change-Id: I6e39b69aa9b0975255d262f9346506d22f800dad Reviewed-on: https://chromium-review.googlesource.com/938871 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#540131}
-
Oskar Sundbom authored
This CL adds platform support for the native echo canceller available in macOS 10.12+, as well as a way to enable it through a runtime flag or Origin Trial. A native echo canceller has the opportunity to perform better than a general one in that it can be tuned for the hardware platform in question. In this case, it's also closer to the hardware, so it's less likely to be affected by IPC glitches. Intent to Implement discussion: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/kEld5OudUOM Bug: chromium:776327 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia828ae2b9e6503ca814de4154dee96c63b838e1d Reviewed-on: https://chromium-review.googlesource.com/941321 Commit-Queue: Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#540130}
-
tzik authored
This CL moves RepeatingTimer and OneShotTimer to Timer by removing BaseTimerMethodPointer, which is a middle level class. Bug: 817344 Change-Id: I33ff580694a7359332ca4fcdc39b9d58c1d091b6 Reviewed-on: https://chromium-review.googlesource.com/940903Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#540129}
-
Eric Seckler authored
Viz doesn't really support WebContentsObserver::DidReceiveCompositorFrame. As our use of this for headless isn't really necessary in full-pipe + surface-sync mode (now our supported configuration), this patch removes this use along with related DevTools parameters / events. Also refactors CompositorController / VirtualTimeController's StartDeferrer: CompositorController is now able to defer both start and resume of virtual time. This way, it knows for certain that all other tasks have completed the current virtual time pause and that virtual time is about to resume. Tests still fail with --enable-features=VizDisplayCompositor, probably because viz's support for software compositing isn't fully ready yet. Bug: 786067 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Iba775e4ef7ed77d7d7bf9837d6971be70a53cedb Reviewed-on: https://chromium-review.googlesource.com/934723Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#540128}
-
Scott Chen authored
Same fix as CL https://chromium-review.googlesource.com/934244 but for Mac. Bug: 814555 Change-Id: Ie4e04b8f1b586daee5a8b4a876d023ab1d09896a Reviewed-on: https://chromium-review.googlesource.com/939393 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#540127}
-
Aleksandar Stojiljkovic authored
BUG=674440 Change-Id: Ie33ae36877d56987bb3b1ea366558a6afb677a8f Reviewed-on: https://chromium-review.googlesource.com/940301Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Aleksandar Stojiljkovic <aleksandar.stojiljkovic@intel.com> Cr-Commit-Position: refs/heads/master@{#540126}
-
Marc Treib authored
This adds UMA histograms to record the number of Wallet credit cards and addresses that were added and removed during each Sync cycle (i.e. during startup, and whenever we receive an update from the server). Bug: 816831 Change-Id: I6673e1737f79dea9669b3a96f0ae9164645ea8da Reviewed-on: https://chromium-review.googlesource.com/937710 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#540125}
-