- 23 May, 2019 40 commits
-
-
vasilii authored
The element is already stored in the votes uploader. Bug: 936011 Change-Id: I655ea64547ced1deaad9c510494e0f444e9e7fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627371Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#662633}
-
Kevin Ellis authored
Bug: 958359 Change-Id: I7ab0dea91227a45fcbaf9f27ac668f1d1ce8bc2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604490 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#662632}
-
Marc Treib authored
That's what it means, so now the name matches reality. Bug: 953641 Change-Id: Ib376da99f3da59ec44fc9edca8f6ffc13c6691b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627372 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#662631}
-
rnasri authored
Pass the rects detected by the jank tracker into the heads up display layer. Use the method push_properties_to to hand the rects off to the heads up diplay layer impl. Finally, add the layout shift rects to the list of debug rects. Bug: 961846 Change-Id: Ifab3c19a7769bbe32645f6bfee98e22b32cab843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625020Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Rasha Nasri <rnasri@google.com> Cr-Commit-Position: refs/heads/master@{#662630}
-
Becky Zhou authored
Add a wrapper for AlertDialog.Builder to work around an issue with AppCompatDelegate not taking account of the night mode of the owner Activity when creating an AppCompatDialog. Bug: 966101 Change-Id: Ie175897f6e0058ce0ba060e47997408a620af715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626009Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#662629}
-
Clemens Arbesser authored
This CL refactors clicks in web_controller such that the caller can specify one of a number of click-types (click, tap, JS-click). Also, this CL adds three stress-tests which fail for tap, but succeed in JS-click. The intent is to let scripters override the type of click to perform in order to increase reliability. Bug: b/133129236 Change-Id: Ied8a1145186e1277c5b0cd70bb433b723a9a7395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621919 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#662628}
-
Mikel Astiz authored
One DCHECK is simply wrong (the Nigori sync entity is a folder) and the bridge was lacking a call to ModelReadyToSync(). Bug: 922900 Change-Id: I529592e90aaae2ef12ca2fdde08984c0ddf835e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620627 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#662627}
-
Harald Alvestrand authored
This doesn't diagnose the bug referenced, but verifies that the error doesn't occur on these codepaths. Bug: 959128 Change-Id: I6f7543d7010b097d93a2614ecf8b94ada78762dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626410 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#662626}
-
Henrique Ferreiro authored
As advised in [1], this CL ports calls to Foo::Create() factory functions to use MakeGarbageCollected<Foo> from //third_party/blink/renderer/core/dom. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBg> Bug: 939691 Change-Id: I9ed956ee209084aab6dd88167d82093d85059745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624807Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#662625}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/550868a2b2b4..acd66b4946f1 git log 550868a2b2b4..acd66b4946f1 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 egdaniel@google.com Remove viewport from GrGLRenderTarget. Created with: gclient setdep -r src/third_party/skia@acd66b4946f1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Change-Id: Ida5f4e305f01529b35def614ce7b34c20f458fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625804Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662624}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a021ed986342..93571e89c9f4 git log a021ed986342..93571e89c9f4 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 perezju@chromium.org Reland "Telemetry changes to remove fallback code for old Chrome versions" Created with: gclient setdep -r src/third_party/catapult@93571e89c9f4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:962883 TBR=eyaich@google.com Change-Id: I4e899d0facf03f5c6d7ac4355bc3da4c9f1728e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625802Reviewed-by:
-
Albert Chaulk authored
We need to implement a couple WebContentsDelegate functions in order to enable fullscreen behaviours Bug: b/128926264 Test: desktop cast_shell build w/ embedded video page Change-Id: I7c5e95fb4f59b3369b35f770dcccff647bf7f899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585104Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#662622}
-
Peter K. Lee authored
This is simpler than -viewWillTransitionToSize:withTransitionCoordinator: because all the logic is in one place, ContentSuggestionsHeaderView. Bug: 965964 Change-Id: Id990d4b91e07282f7ff985f529c5ad27856f0199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626302Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#662621}
-
Olivier Yiptong authored
This change adds a writable stream output to the `FileSystemFileHandle`. This follows some [discussion](https://github.com/WICG/native-file-system/issues/19#issuecomment-490579093) on github. While this writable stream does not yet feature stream-like behavior, it carries over some of the interface from `NativeFileSystemWriter`, namely `truncate` and `write`. Bug: 955189 Change-Id: I8b8c9ff1ef36adfb30501251563699c6c7973889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623534Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
-
Mason Freed authored
This test, which currently fails, tests that rounded-corner clips do not create a Backdrop Root. Bug: 964417 Change-Id: I1849962b408ecc451cc2934668488046bc4f89ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626456 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#662619}
-
Eric Stevenson authored
This is a reland of a531e3b1, but has changed enough that the original commit message is not longer accurate. This CL is now more of a general refactor, and does not fix the issues seen when moving source files of generate_jni() targets. Changes from the original CL: * Removed Python 3 incompatibility * Removed added dependencies on //build/android/gyp/util/build_utils.py * Change jni_generator.py to use argparse * Do not rename jni output dirs (causes places that use qualified includes to break) Bug: 951701 Change-Id: I94f63eaf55b16f6c18f7f9eb2c37735c31ed2f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617544 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#662618}
-
Tommy Steimel authored
This CL adds a new MediaNotificationContainer abstraction to the media notification so that the MediaNotificationView no longer depends on Ash or MessageView. This will allow media notifications to be created that don't need to be sent to the MessageCenter. Instead of MediaNotificationView being a MessageView, it will be contained in a MessageView in Ash when it needs to be sent to the MessageCenter. This is part of a refactoring of the media notification to make it reusable outside of ash/media. Bug: 959478 Change-Id: Iac96211b3feb6e640b5e79a61832927c72a4fa88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616953Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#662617}
-
Owen Min authored
Sync ChromeDesktopReportRequest proto update from server side to into Chromium. The original CL is cl/249333459. Bug: 956237 Change-Id: I74acad9e8a047fffd3b1aed3b5af15eca8535e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625689Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#662616}
-
Mihai Sardarescu authored
This CL adds a temporary solution to present the advanced sign-in settings when the user taps on settings from the FRE sign-in screen: * is adds a command that open the advanced sign-in settings * it calls this command from the FRE screen. * it updates the failing earl grey test. This is a temporary solution as the plan is to move the ownership of the FirstRunChromeSigninViewController to the SigninInteractionCoordinator (see crbug.com/965992). However it is preferred to only make this change after the unified consent feature is launched as it is fairly complex to do if we want to also support pre-unified consent flows. Bug: 963406 Change-Id: Ie291dc7f935e5b5e0b100888b3f55c81fb64558e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621176Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#662615}
-
Lei Zhang authored
- Remove PolicyUIHandler::AddLocalizedPolicyStrings() and use AddLocalizedStringsBulk(). - Remove policy::PolicyStringMap and use LocalizedString. - Remove uses of "policy::" inside namespace policy. - Use auto in more places for iterators. - Fix lint errors. Change-Id: I68a9939431769fe50197ff1b160756be3348c79b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626740Reviewed-by:
-
Gauthier Ambard authored
This CL changes the BUILDgn target in ios/web/web_view from web_view to util, to reflect its current content. Bug: none Change-Id: I74eb4bb167b32bfc4dc4875abd6920e1d620ef9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625998Reviewed-by:
Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
Vladimir Levin authored
This patch ensures that we don't process any update() lifecycle phases when layout is forced outside of the lifecycle phase. This can happen if the budget yields, and then script runs which forces something to be forced. We don't want to process update phases in that case, since we want to wait until proper lifecycle runs to do that. R=chrishtr@chromium.org, rakina@chromium.org Bug: 964827 Change-Id: I05848c9dd3dcd4fcedc209a2f66e324d2ba6f0b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626172Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#662612}
-
Stephen McGruer authored
A few cleanups for CSSPaintValue and its unittest: * Remove unused Create functions * Add test for delaying paint until the generator is ready * Inline the HTML for the existing tests and make them more unittesty Bug: None Change-Id: I9d3e5a7c6abd5fbc5443c9408480567ef0ff3b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622911Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#662611}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b0504239ab66..07a101971791 git log b0504239ab66..07a101971791 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 kevin.petit@arm.com Validate OpenCL environment rules for OpImageWrite (#2619) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@07a101971791 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: Ie1d943ea04698acfb232accf3194c7f934e1a656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627145Reviewed-by:
-
David Tseng authored
Accessibility in BLink recently made it so most events fire after layout. As a result, RenderAccessibilityImpl::during_action_ is no longer working properly. Previously, |during_action_| gets set to true within the same call stack where RenderAccessibilityImpl::OnPerformAction gets called. Events generated during this time get marked as coming from an action. However, events now are deferred to a different call stack than the above. This change moves the computation of event from into AXObjectCacheImpl. When a client calls into RenderAccessibilityImpl::OnPerformAction, the WebAXObject layer scopes the block where the action is being performed by setting AXObjectCacheImpl::is_handling_action_ to true/false. This results in a queue of events, which are processed after layout completes. When layout completes, this queue of events (which includes the event from field computed during the processing of the actual event some time ago), calls back out to the web layer (via WebLocalFrameClient), which eventually ends up in RenderAccessibilityImpl::HandleAXEvent. Test: end to end tests exercising ChromeVox. Two tests are added. One performs an accessibility focus action (which should result in a focus event from action); another tabs (which results in an event from user). Change-Id: I196f3621caa75643fe705929e5144bee85725be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618649Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#662609}
-
Liquan (Max) Gu authored
FCP++ has already been 50% enabled in stable for a while. As we don't see performance regression, we should push FCP++ to 100%. According to the best practice, we should set FCP++ to stable on ToT before enabling the finch trial for 100%. Bug: 966216 Change-Id: I419296a7fd21c4f697e42e3fadba8b00b5776f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626223 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#662608}
-
Philipp Hancke authored
Removes the explicit width from the stats table which may cause issues unfold the last details element due to a scrollbar that happens because of very long DTLS fingerprints. May cause the stats table container to be positioned differently depending on the window width Test Plan: manually tick the box left of width on the .stats-table-container to get a visual preview, check this removes the bottom scrollbar BUG=966330 Change-Id: I792b99d9cba80baa1c5dc90dd039dd9be831f76c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626854Reviewed-by:
-
Clemens Arbesser authored
This CL fixes two possible crashes in AA PR: 1) When updating the contact details section, even though the contact details were not requested (and are not visible). 2) When updating the contact details section before a contact editor was set. Converting autofill profiles to autofill contacts is currently done via ContactDetailsSection, which in turn relies on a non-null ContactEditor for the conversion. 1) is easy to fix (wrap in if statement). As a workaround for 2), this CL creates a temporary contact editor in those cases. A proper fix would decouple the UI aspects (editor) from the backend aspects (converting autofill profiles to contacts), but this requires some more refactoring and is out-of-scope for now. Bug: 806868 Change-Id: I26e511d405930166ebac858f8f878d924f6c1843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627352 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
Alex Clarke authored
Promises |p2|, |p3| and |p4| could be resolved by another thread by the time the EXPECT_FALSE is executed on the main thread leading to failures. This patch removes these to make the test non-flaky. Bug: 906125 Change-Id: Iab8afc16a9c4532678fe70f4237f1a894a8d5ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627350 Auto-Submit: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#662605}
-
Aran Gilman authored
Change-Id: Iee9c633bc0b0407cfff511f43735ea5b99e25d41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626394 Auto-Submit: Aran Gilman <gilmanmh@google.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
Robbie Gibson authored
The layout guides were not set up in showcase, so the popup was broken. This also fixes a autolayout warning when the second text view was larger than one line. The stack view didn't know which text view to shrink if necessary. This also turns on adjusting content insets due to safe area for the popup view controller, so the bottom of the popup does respect the safe area. Bug: 962957 Change-Id: I626fcb40420f8728094760cb1261766899e82df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611823Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#662603}
-
Per Åhgren authored
Bug: webrtc:5298 Change-Id: Ie51de26cfe002d087ebc919586e9b3f75aa35ced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594530Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Per Åhgren <peah@chromium.org> Cr-Commit-Position: refs/heads/master@{#662602}
-
Olya Kalitova authored
Adds PluginVm.LaunchResult UMA histogram, that records PluginVm launch result as success or error. Launch result is recorded each attempt to launch PluginVm. Bug: 962952 Change-Id: I6ebf8cbbddc2949dff7cf8c469b2480b9e3b6952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611983 Commit-Queue: Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Alex Oldemeier <aoldemeier@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#662601}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bd0a8835..b78e7c13 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2743d48b2e9b4316988fb1c376fb18d477c9e46c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625799Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662600}
-
Rune Lillesveen authored
As part of trying to remove the forced UpdateStyleAndLayoutTree on parsing finished, this test started failing. Parsing the document would finish and force a style update after display is set to none, but before the promise is resolved through rAF. Add another rAF to allow for a lifecycle update of the computed style instead. Bug: 742413 Change-Id: I91d21b5cd871d82d81dd8fb156465762ad594318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627355Reviewed-by:
-
Eric Willigers authored
Force a style calclation before setting webkitAnimationName in animation-iteration-event-destroy-renderer.html Otherwise the animation may be considered to have already completed before event listeners were added. BUG=936462 Change-Id: I5db698db48fe8d029079b144c31673abcef2550a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623725 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#662598}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/22003298ae1b..836ac4b41082 Created with: gclient setdep -r src-internal@836ac4b41082 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=lowell@google.com,kmilka@google.com,yutak@google.com Change-Id: Iccba71b5b1ac2faa8ec993cb28f35cf560cd182a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625797Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662597}
-
Olya Kalitova authored
Based on: https://chromium-review.googlesource.com/c/chromium/src/+/1607641 This extends plugin_vm::IsPluginVmAllowedForProfile with an alternative condition for testing and adds the whole check to ChromeFeaturesServiceProvider so that Chrome OS does the proper checks for PluginVm. Adapts all relevant PluginVm tests accordingly. Currently only PluginVm unit tests rely on PluginVmTestHelper - plan to change it in the future CLs and file a P3 bug for now. --gtest_filter="PluginVm*" Bug: 920999 Test: unit_tests --gtest_filter="PluginVm*" && browser_tests Change-Id: I0e24186fbf4411de423141dfbf33bf2886b2a357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624192 Commit-Queue: Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#662596}
-
Robbie Gibson authored
Before, the favicon completion was always called asynchronously, leading to the original icon appearing for a split second when a favicon was found in the cache. Now, that completion will be displayed instantly. The asynchronicity was there to simplify the FaviconRetriever logic (the completion was always called asynchronously), but that isn't actually super important. Bug: 964918 Change-Id: I30b7d2f8d9fe0ed9324e48eb994ce677398b388b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626861 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#662595}
-
Mikel Astiz authored
The constructor takes ownership of the injected HttpPostProviderFactory so let's trivially adopt std::unique_ptr to make this obvious. While doing this, some member fields are trivially marked as const. Bug: None Change-Id: Ieb199dc48c71d68fe6354f1f075a7977f72e7299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626416 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#662594}
-
