1. 19 Jan, 2007 8 commits
    • bdash's avatar
      2007-01-18 Mitz Pettel <mitz@webkit.org> · 7815abee
      bdash authored
              Reviewed by Darin.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=11271
              REGRESSION (r12358): Text in display: table unselectable
      
              Test: editing/selection/display-table-text.html
      
              * editing/htmlediting.cpp:
              (WebCore::isTableElement): Changed to return false for text nodes.
      
      2007-01-18  Mitz Pettel  <mitz@webkit.org>
      
              Reviewed by Darin.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=11271
              REGRESSION (r12358): Text in display: table unselectable
      
              * editing/selection/display-table-text-expected.checksum: Added.
              * editing/selection/display-table-text-expected.png: Added.
              * editing/selection/display-table-text-expected.txt: Added.
              * editing/selection/display-table-text.html: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18968 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7815abee
    • beidson's avatar
      Reviewed by Adele · efc19ce1
      beidson authored
              <rdar://problem/4917290> - 
              Null deref in WebFrameLoaderClient::restoreScrollPositionAndViewState() 
              after regaining network connection
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::restoreScrollPositionAndViewState): Bail early with a null currentItem, preventing 
              a crash in release builds.  Leave the ASSERT to help find other cases where this might happen in debug builds.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18967 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      efc19ce1
    • bdash's avatar
      2007-01-18 Mitz Pettel <mitz@webkit.org> · 4683e2a7
      bdash authored
              Reviewed by Darin.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=6218
                CSS1: WebTextRenderer caches and re-uses fallback renderers that are based on family lists
      
              This patch takes character-to-glyph mapping out of FontData and instead makes
              each Font keep its own mapping, using a shared set of glyph page fallback trees.
      
              For each page number there is (at most) one tree. A path from the root to a
              node in the tree corresponds to a fallback list of FontDatas. The node points to
              a page (which may be shared with other nodes) that maps each character in its range
              to a glyph in the first FontData in the fallback list that has it, or to 0 if none of
              the FontDatas has a glyph for that character. A special kind of node, that can
              only occur as a leaf, corresponds to using system fallback fonts after the list
              has been exhausted. This prevents system fallback from polluting non-leaf
              nodes.
      
              Nodes and pages are initialized lazily and employ "copy on write".
      
              * CMakeLists.txt:
              * WebCore.pro:
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * platform/Font.cpp:
              (WebCore::WidthIterator::WidthIterator): Removed substituteFontData.
              (WebCore::WidthIterator::advance): Moved all character-to-glyph mapping logic out
              of here and replaced it with a call to Font::glyphDataForCharacter().
              (WebCore::Font::Font):
              (WebCore::Font::operator=):
              (WebCore::Font::glyphDataForCharacter): Added. This method performs the lookup in the
              page fallback trees, triggering lazy initialization as needed, and caching pointers to
              the retrieved page tree nodes in the font.
              (WebCore::Font::update):
              (WebCore::Font::drawSimpleText):
              (WebCore::Font::floatWidth):
              (WebCore::Font::floatWidthForSimpleText): Removed substituteFont argument.
              (WebCore::Font::offsetForPositionForSimpleText):
              * platform/Font.h:
              * platform/FontData.cpp:
              (WebCore::FontData::FontData):
              * platform/FontData.h:
              (WebCore::FontData::missingGlyphData): Added. Returns the "missing glyph" GlyphData for
              this FontData.
              * platform/GlyphMap.cpp: Removed.
              * platform/GlyphMap.h: Removed.
              * platform/GlyphPageTreeNode.cpp: Renamed GlyphMap.cpp to this.
              (WebCore::GlyphPageTreeNode::getRoot): Added. Returns the root of the page fallback tree for
              the given page number.
              (WebCore::GlyphPageTreeNode::initializePage): Added. Helper method that initializes the page
              pointer of a node, possibly to a pointer to another node's page or to 0.
              (WebCore::GlyphPageTreeNode::getChild): Added.
              * platform/GlyphPageTreeNode.h: Renamed GlyphMap.h to this.
              (WebCore::GlyphPage::glyphDataForCharacter):
              (WebCore::GlyphPage::setGlyphDataForCharacter):
              (WebCore::GlyphPage::setGlyphDataForIndex):
              (WebCore::GlyphPageTreeNode::GlyphPageTreeNode):
              (WebCore::GlyphPageTreeNode::getRootChild):
              (WebCore::GlyphPageTreeNode::parent):
              (WebCore::GlyphPageTreeNode::page):
              (WebCore::GlyphPageTreeNode::level):
              (WebCore::GlyphPageTreeNode::isSystemFallback): Added. Returns whether the node corresponds
              to the system providing fallback fonts, which is done on a character-by-character basis.
              * platform/gdk/GlyphMapGdk.cpp: Removed.
              * platform/gdk/GlyphPageTreeNodeGdk.cpp: Renamed GlyphMapGdk.cpp to this.
              (WebCore::GlyphPage::fill):
              * platform/mac/FontDataMac.mm:
              (WebCore::FontData::platformInit):
              * platform/mac/FontMac.mm:
              (WebCore::Font::Font):
              * platform/mac/GlyphMapMac.cpp: Removed.
              * platform/mac/GlyphPageTreeNodeMac.cpp: Renamed GlypMapMac.cpp to this.
              (WebCore::GlyphPage::fill): Changed to return false if the font has no glyphs in the page.
              * platform/qt/GlyphMapQt.cpp: Removed.
              * platform/qt/GlyphPageTreeNodeQt.cpp: Renamed GlyphMapQt.cpp to this.
              (WebCore::GlyphPage::fill):
              * platform/win/GlyphMapWin.cpp: Removed.
              * platform/win/GlyphPageTreeNodeWin.cpp: Renamed GlyphMapWin to this.
              (WebCore::GlyphPage::fill):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18966 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4683e2a7
    • bdash's avatar
      2007-01-18 Mitz Pettel <mitz@webkit.org> · d48e142c
      bdash authored
              Reviewed by Darin.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=9952
                REGRESSION: Repro crash when dragging an image from the window to the address bar
      
              * page/FrameView.cpp:
              (WebCore::FrameView::~FrameView): Removed the call to Document::detach(). If this
              view is the current view, then the Frame should have already detached the document.
              Added an assertion that this is the case. If this view is not the current view,
              then it cannot access its document, but the page cache should have detached it already.
              Similarly, changed to call RenderPart::setWidget() only if this is the current view
              in the frame.
              (WebCore::FrameView::adjustViewSize): Added an assertion that this view is the current
              view in the frame.
              (WebCore::FrameView::layout): Ditto.
              (WebCore::FrameView::scheduleRelayout): Ditto.
              (WebCore::FrameView::scheduleRelayoutOfSubtree): Ditto.
              (WebCore::FrameView::windowClipRect): Ditto.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18965 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d48e142c
    • eseidel's avatar
      2007-01-18 Eric Seidel <eric@webkit.org> · 94bd5356
      eseidel authored
              Reviewed by bdash.
      
              No test needed, removed bogus debug-only ASSERT.
      
              * rendering/RenderSVGContainer.cpp:
              (WebCore::RenderSVGContainer::paint):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18964 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      94bd5356
    • bdash's avatar
      2007-01-18 Sanjay Madhav <sanjay12@gmail.com> · 01c2b8cb
      bdash authored
              Reviewed by Darin.
      
              Add JavaScriptCore define to help with tracing of when objects are marked.
      
              * kjs/object.cpp:
              (KJS::JSObject::mark):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18963 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      01c2b8cb
    • aliceli1's avatar
      Build Fix · d36a4958
      aliceli1 authored
              * platform/mac/PasteboardMac.mm:
              (WebCore::Pasteboard::writeSelection):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18962 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d36a4958
    • aliceli1's avatar
      Reviewed by Mark Rowe. · 45f58e22
      aliceli1 authored
              Fixes the leaks from my last patch, except for the first change below which is a missing delegate call for Mail purposes
      
              * editing/Editor.cpp:
              (WebCore::Editor::cut):
              * platform/Pasteboard.h:
              * platform/mac/PasteboardMac.mm:
              (WebCore::Pasteboard::Pasteboard):
              (WebCore::Pasteboard::clear):
              (WebCore::Pasteboard::writeSelection):
              (WebCore::Pasteboard::writeURL):
              (WebCore::Pasteboard::plainText):
              (WebCore::Pasteboard::documentFragment):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18960 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      45f58e22
  2. 18 Jan, 2007 20 commits
    • kdecker's avatar
      Reviewed by John. · 007fd837
      kdecker authored
              <rdar://problem/4939511> WebKit should set the CG clip path for plug-ins that draw using CoreGraphics
      
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView drawRect:]):  Set the CG clip path to the plug-in dirty rect. This allows plug-ins to obtain their
              dirty rect using functions like CGContextGetClipBoundingBox().
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18957 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      007fd837
    • sullivan's avatar
      Removed accidentally-duplicated entries. · 2181d511
      sullivan authored
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18955 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2181d511
    • sullivan's avatar
      Reviewed by Darin · af444399
      sullivan authored
              
              - Tests for:
                <rdar://problem/4912002> REGRESSION: Series of words marked as a single misspelled word
                <rdar://problem/4462420> REGRESSION: Mail hangs during Replace All if the replacement string contains the search string
      
              * editing/spelling/spelling-expected.checksum: Added.
              * editing/spelling/spelling-expected.png: Added.
              * editing/spelling/spelling-expected.txt: Added.
              * editing/spelling/spelling.html: Added.
              * editing/execCommand/find-after-replace-expected.checksum: Added.
              * editing/execCommand/find-after-replace-expected.png: Added.
              * editing/execCommand/find-after-replace-expected.txt: Added.
              * editing/execCommand/find-after-replace.html: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18953 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      af444399
    • hyatt's avatar
      Make sure layer autoscrolling puts the event coordinates into the... · 6ed6d831
      hyatt authored
              Make sure layer autoscrolling puts the event coordinates into the layer's coordinate space before
              calling hitTest on it.  Fixes "flashy" selection in textareas.
      
              Reviewed by darin
      
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::autoscroll):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::nodeAtPoint):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18951 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6ed6d831
    • andersca's avatar
      Reviewed by Adam. · 95bb1970
      andersca authored
              Get rid of ResourceLoaderMac.mm and make willCacheResponse platform-independent.
              
              * loader/ResourceLoader.cpp:
              (WebCore::ResourceLoader::willCacheResponse):
              * loader/ResourceLoader.h:
              * loader/mac/ResourceLoaderMac.mm: Removed.
              * platform/network/ResourceHandleClient.h:
              (WebCore::):
              (WebCore::ResourceHandleClient::willCacheResponse):
              (WebCore::ResourceHandleClient::willStopBufferingData):
              * platform/network/mac/ResourceHandleMac.mm:
              (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18950 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      95bb1970
    • darin's avatar
      Reviewed by John Sullivan. · a38e6730
      darin authored
              * Scripts/run-webkit-tests: Fix handling of configuration so it
              does the right thing when no explicit configuration is passed in.
              The old code assumed that the result of setConfiguration() was the
              configuration, but it's undefined when no configuration is
              explicitly passed in. The correct function to use is
              configuration(), and I also streamlined the code.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18948 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a38e6730
    • mjs's avatar
      Reviewed by John. · 823a7d62
      mjs authored
              - fixed <rdar://problem/4887416> REGRESSION (SearchField): Assertion failure in HTMLInputElement::setValueFromRenderer when editing via drag and drop (11846)
              http://bugs.webkit.org/show_bug.cgi?id=11846
              
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply): Don't insert extra paragraph separators to avoid
              nesting blocks in plaintext mode, since that's not an issue under normal circumstances.
              * html/HTMLInputElement.h:
              * manual-tests/drag-move-in-search-field.html: Added.
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::subtreeHasChanged): constrain the value; we'd
              rather truncate it than end up with an illegal value here.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18944 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      823a7d62
    • hausmann's avatar
      parallel build fix · f66a9be7
      hausmann authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18941 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f66a9be7
    • darin's avatar
      LayoutTests: · 28764bff
      darin authored
              Reviewed by Darin and Mitz.
      
              - Test for http://bugs.webkit.org/show_bug.cgi?id=12305
                REGRESSION: Images do not load in video sections on CNN.com homepage
      
              * fast/dom/HTMLImageElement/image-lowsrc-getset-expected.txt: Added.
              * fast/dom/HTMLImageElement/image-lowsrc-getset.html: Added.
      
      WebCore:
      
              Reviewed by Darin and Mitz.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12305
                REGRESSION: Images do not load in video sections on CNN.com homepage
      
              <rdar://problem/4931480> REGRESSION: Images do not load in video sections on CNN.com homepage (12305)
      
              Test: fast/dom/HTMLImageElement/image-lowsrc-getset.html
      
              * html/HTMLAttributeNames.in: Added lowsrc.
              * html/HTMLImageElement.cpp:
              (WebCore::HTMLImageElement::isURLAttribute): Added lowsrc.
              (WebCore::HTMLImageElement::lowsrc): Added.
              (WebCore::HTMLImageElement::setLowsrc): Added.
              * html/HTMLImageElement.h: Added lowsrc and setLowsrc.
              * html/HTMLImageElement.idl: Added lowsrc.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18940 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      28764bff
    • hausmann's avatar
      fix make clean in the qt build to remove all generated files · 9130d7c1
      hausmann authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18933 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9130d7c1
    • zack's avatar
      Implementing some load progress tracking in the Qt port. · 07e006df
      zack authored
      Reviewed by Lars.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18932 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      07e006df
    • aliceli1's avatar
      WebCore: · fc2d14b4
      aliceli1 authored
              Reviewed by Harrison.
      
              Fix for <rdar://problem/4894155> REGRESSION: Extra line break is pasted with content into message body after choosing File - Paste
      
              Migration of some editing code from WebHTMView to WebCore::Editor
              resulted in not calling pasteboardTypesForSelection, which Mail was
              overriding for the special purpose of adding a type to the
              pasteboard after WebKit did.  This patch adds 2 separate code paths
              for Tiger and Leopard.  On Tiger we give in and call the WebView's
              pasteboardTypesForSelection.  On Leopard we call a delegate after
              the pasteboard types are set. 
      
              * bridge/EditorClient.h:
              * editing/Editor.h:
              * platform/Pasteboard.h:
              * platform/graphics/svg/SVGImageEmptyClients.h:
              (WebCore::SVGEmptyEditorClient::didSetSelectionTypesForPasteboard):
              (WebCore::SVGEmptyEditorClient::pasteboardTypesForSelection):
              * platform/mac/PasteboardMac.mm:
              (WebCore::Pasteboard::Pasteboard):
              (WebCore::Pasteboard::clear):
              (WebCore::Pasteboard::writeSelection):
              (WebCore::Pasteboard::writeURL):
              (WebCore::Pasteboard::plainText):
              (WebCore::Pasteboard::documentFragment):
      
      WebKit:
      
              Reviewed by Harrison.
      
              Fix for <rdar://problem/4894155> REGRESSION: Extra line break is pasted with content into message body after choosing File - Paste
      
              Migration of some editing code from WebHTMView to WebCore::Editor
              resulted in not calling pasteboardTypesForSelection, which Mail was
              overriding for the special purpose of adding a type to the
              pasteboard after WebKit did.  This patch adds 2 separate code paths
              for Tiger and Leopard.  On Tiger we give in and call the WebView's
              pasteboardTypesForSelection.  On Leopard we call a delegate after
              the pasteboard types are set. 
      
              * DefaultDelegates/WebDefaultEditingDelegate.m:
              (-[WebDefaultEditingDelegate webView:didSetSelectionTypesForPasteboard:]):
              * WebCoreSupport/WebEditorClient.h:
              * WebCoreSupport/WebEditorClient.mm:
              (WebEditorClient::didSetSelectionTypesForPasteboard):
              (WebEditorClient::pasteboardTypesForSelection):
              * WebView/WebEditingDelegate.h:
      
      WebKitQt:
      
              Added these stubs to keep the Qt build from failing.
      
              * WebCoreSupport/EditorClientQt.cpp:
              (WebCore::EditorClientQt::didSetSelectionTypesForPasteboard):
              * WebCoreSupport/EditorClientQt.h:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18931 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      fc2d14b4
    • sullivan's avatar
      WebCore: · 60f8fb75
      sullivan authored
              Reviewed by Darin
      
              - WebCore part of fix for <rdar://problem/4462420> REGRESSION: Mail hangs during 
                Replace All if the replacement string contains the search string
              
              * page/Frame.h:
              * page/Frame.cpp:
              (WebCore::Frame::findString):
              new startInSelection parameter -- if true, search starts looking in selection; if false,
              search starts looking after the selection
              
              * page/mac/WebCoreFrameBridge.h:
              * page/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge searchFor:direction:caseSensitive:wrap:startInSelection:]):
              new startInSelection parameter, passed through to Frame::findString()
      
              * editing/JSEditor.cpp:
              pass false for new findString parameter, to match old behavior
      
      WebKit:
      
              Reviewed by Darin
      
              - WebKit part of fix for <rdar://problem/4462420> REGRESSION: Mail hangs during 
                Replace All if the replacement string contains the search string
      
              * Misc/WebKitVersionChecks.h:
              Added extern "C" so this can be used from .mm files. I don't need this change anymore for
              this fix, but it's still worth fixing now so it doesn't bite anyone later.
      
              * WebView/WebDocumentPrivate.h:
              Invented new private protocol WebDocumentIncrementalSearching, that has one method. The one
              method is just like the one WebDocumentSearching method, but with an additional parameter.
              We hope to eliminate this dependence on protocols someday, but adding another one as SPI
              seems like it won't make anything worse.
              
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView searchFor:direction:caseSensitive:wrap:]):
              now calls through to new method that has one additional parameter, passing NO to match old behavior
              (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
              pass new parameter to bridge
              
              * WebView/WebPDFView.h:
              Declare conformance to WebDocumentIncrementalSearching protocol
              
              * WebView/WebPDFView.mm:
              (-[WebPDFView searchFor:direction:caseSensitive:wrap:]):
              now calls through to new method that has one additional parameter, passing NO to match old behavior
              (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
              new method, former guts of searchFor:direction:caseSensitive:wrap: but now handles startInSelection
              parameter
              
              * WebView/WebViewPrivate.h:
              Declare new searchFor:direction:caseSensitive:wrap:startInSelection: method, just like existing
              method but with one additional parameter
      
              * WebView/WebView.mm:
              (-[WebView searchFor:direction:caseSensitive:wrap:]):
              now calls through to new method that has one additional parameter, passing NO to match old behavior
              (-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]):
              new method, former guts of searchFor:direction:caseSensitive:wrap: but now handles startInSelection
              parameter
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18928 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      60f8fb75
    • beidson's avatar
      Removed an internal change I had I wasn't supposed to commit. *sigh* · 21584f0d
      beidson authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18927 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      21584f0d
    • beidson's avatar
      Reviewed by Deth Bakin and Brian Dash · 90cb8bdc
      beidson authored
              Drop Panther Support (?!?) and change the comment explaining some SPI forward decls
      
              * Misc/WebDownload.m:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18926 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      90cb8bdc
    • bdakin's avatar
      Adding comment. · c75a3a67
      bdakin authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18925 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c75a3a67
    • justing's avatar
      LayoutTests: · 2e1dbd68
      justing authored
              Reviewed by darin
      
              <rdar://problem/4920488>
              REGRESSION: A crash occurs at WebCore::Range::processContents () when removing formatting from selected text (that contains a link)
      
              * editing/execCommand/4920488-expected.checksum: Added.
              * editing/execCommand/4920488-expected.png: Added.
              * editing/execCommand/4920488-expected.txt: Added.
              * editing/execCommand/4920488.html: Added.
              * fast/dom/Range/compareBoundaryPoints-1-expected.txt: Added.
              * fast/dom/Range/compareBoundaryPoints-1.html: Added.
      
      WebCore:
      
              Reviewed by darin
              
              <rdar://problem/4920488>
              REGRESSION: A crash occurs at WebCore::Range::processContents () when removing formatting from selected text (that contains a link)
      
              * dom/Range.cpp:
              (WebCore::Range::commonAncestorContainer): Return null if the nodes
              don't have a common ancestor.  As a side effect, the public 
              commonAncestorContainer now sets an exception if the Range starts
              in one document and ends in another, or starts or ends in a tree
              that's been removed from the document.  The spec doesn't cover
              this and there is no precedent in other browsers for this case because
              they don't allow invalid Ranges (you can create one with WebCore
              by removing a node that contains the start/end of a Range).
              (WebCore::Range::compareBoundaryPoints): If the the two positions
              are in nodes that have no common ancestor, return null.  This doesn't
              change the behavior of the public compareBoundaryPoints: it already
              throws an exception if the two positions are in nodes that don't have
              a common ancestor.  This follows the spec.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18924 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2e1dbd68
    • sullivan's avatar
      The one word was typed by me, but only after debugging for a long time with Darin. · cf0547b6
      sullivan authored
              - fixed <rdar://problem/4912002> REGRESSION: Series of words marked as a single misspelled word
      
              * editing/TextIterator.cpp:
              (WebCore::WordAwareIterator::WordAwareIterator):
              We were creating a TextIterator with the default kind, but WordAwareIterator is designed to work
              in concert with CharacterIterator, so they need to use the same kind. CharacterIterator uses
              kind RUNFINDER, so WordAwareIterator needs to do so also.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18923 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      cf0547b6
    • adele's avatar
      Reviewed by Brady. · d5bffc33
      adele authored
              Fix for <rdar://problem/4900895> REGRESSION: onChange doesn't always fire for popups that have had value changed by JS
      
              No test case since you need to open up the menu to fire onChange.
      
              * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex):
                Keep track of m_lastOnChangeIndex even when we're not firing onChange.  Since
                the selected index has changed, we still want the m_lastOnChangeIndex to be up to date when we compare
                it later.  This matches our behavior in Safari 2.0.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18922 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d5bffc33
    • adele's avatar
      Reviewed by Darin and John. · 6944b1ab
      adele authored
              - Fix for <rdar://problem/4816550> REGRESSION: autoscrolling doesn't work after double-click
      
              * page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Set swallowEvent bool instead
                of returning early for double and triple clicks.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18921 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6944b1ab
  3. 17 Jan, 2007 12 commits
    • eseidel's avatar
      2007-01-17 Eric Seidel <eric@webkit.org> · 2621ed75
      eseidel authored
              Reviewed by Brady.
              
              Update results after SVG container hit testing changes.
      
              * svg/custom/pointer-events-text-expected.checksum:
              * svg/custom/pointer-events-text-expected.png:
              * svg/custom/pointer-events-text-expected.txt:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18920 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2621ed75
    • darin's avatar
      Reviewed by Hyatt. · 0f5d2d91
      darin authored
              * rendering/RenderObject.h: Removed unused nextEditable and previousEditable.
              * rendering/RenderObject.cpp: Ditto.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18919 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0f5d2d91
    • darin's avatar
      WebCore: · 3c566516
      darin authored
              Reviewed by Maciej.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12278
                <rdar://problem/4928705> REGRESSION(r13070): Dragged image size includes padding (12278)
      
              * WebCore.exp: Added HitTestResult::imageRect,
              removed HitTestResult::boundingBox.
      
              * rendering/HitTestResult.h:
              * rendering/HitTestResult.cpp: (WebCore::HitTestResult::imageRect):
              Added. Returns the content rectangle of the image.
      
              * rendering/RenderObject.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::absolutePosition): Made const.
              (WebCore::RenderObject::contentBox): Added.
              (WebCore::RenderObject::absoluteContentBox): Added.
      
              * rendering/RenderBox.h:
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::absolutePosition): Made const.
      
              * rendering/RenderTableCell.h:
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::absolutePosition): Made const.
      
              * rendering/RenderView.h:
              * rendering/RenderView.cpp:
              (WebCore::RenderView::absolutePosition): Made const.
      
      WebKit:
      
              Reviewed by Maciej.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12278
                <rdar://problem/4928705> REGRESSION(r13070): Dragged image size includes padding (12278)
      
              * Misc/WebElementDictionary.mm: (-[WebElementDictionary _imageRect]):
              Call HitTestResult::imageRect, not HitTestResult::boundingBox.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18918 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3c566516
    • lars's avatar
      Fix my last commit to actually work in all cases. · daa8a2da
      lars authored
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18917 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      daa8a2da
    • adele's avatar
      Reviewed by Mitz. · e58f9dd4
      adele authored
              Updating this new layout test so that it actually crashes before the last fix.
      
              * fast/css/pseudostyle-anonymous-text.html:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18916 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e58f9dd4
    • adele's avatar
      LayoutTests: · 0457804c
      adele authored
              Reviewed by Beth.
      
              Test for http://bugs.webkit.org/show_bug.cgi?id=10139
              <rdar://problem/4823028> REGRESSION: Reproducible crash when selecting a popup/button with ::selection pseudostyle
      
              * fast/css/pseudostyle-anonymous-text-expected.txt: Added.
              * fast/css/pseudostyle-anonymous-text.html: Added.
      
      WebCore:
      
              Reviewed by Beth.
      
              Fix for  http://bugs.webkit.org/show_bug.cgi?id=10139
              <rdar://problem/4823028> REGRESSION: Reproducible crash when selecting a popup/button with ::selection pseudostyle
      
              Test: fast/css/pseudostyle-anonymous-text.html
      
              * rendering/RenderObject.cpp: (WebCore::RenderObject::getPseudoStyle): Nil check the node.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18915 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0457804c
    • lars's avatar
      Reviewed by Maciej · ccdabaf2
      lars authored
              Make sure DumpRenderTree exits when run-webkit-tests
              is done.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18914 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ccdabaf2
    • adele's avatar
      LayoutTests: · 041a496f
      adele authored
              Reviewed by Anders and John.
      
              Test for http://bugs.webkit.org/show_bug.cgi?id=11278
              <rdar://problem/4826875> REGRESSION: Popup width doesn't change to accommodate dynamic changes to options
      
              * fast/forms/menulist-width-change-expected.checksum: Added.
              * fast/forms/menulist-width-change-expected.png: Added.
              * fast/forms/menulist-width-change-expected.txt: Added.
              * fast/forms/menulist-width-change.html: Added.
      
      WebCore:
      
              Reviewed by Anders and John.
      
              Fix for http://bugs.webkit.org/show_bug.cgi?id=11278
              <rdar://problem/4826875> REGRESSION: Popup width doesn't change to accommodate dynamic changes to options
      
              Test: fast/forms/menulist-width-change.html
      
              * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement):
                When the options change, call setNeedsLayoutAndMinMaxRecalc.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18913 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      041a496f
    • ap's avatar
      Reviewed by Maciej. · 6b02c313
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=12268
              Give object prototypes their own names
      
      JavaScriptCore:
              * kjs/lookup.h: Append "Prototype" to ClassName in KJS_IMPLEMENT_PROTOTYPE.
      
      WebCore:
              * bindings/scripts/CodeGeneratorJS.pm: Append "Proto" to interface name for the prototype's ClassInfo.
      
              * bindings/js/JSHTMLInputElementBase.cpp:
              (WebCore::JSHTMLInputElementBasePrototypeFunction::callAsFunction):
              (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase):
              * bindings/js/JSHTMLInputElementBase.h:
              * bindings/js/JSXMLHttpRequest.cpp:
              (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
              (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
              (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):
              * bindings/js/JSXMLHttpRequest.h:
              * bindings/js/JSXSLTProcessor.cpp:
              (KJS::JSXSLTProcessor::JSXSLTProcessor):
              (KJS::XSLTProcessorPrototypeFunction::callAsFunction):
              (KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp):
              * bindings/js/kjs_css.cpp:
              (KJS::DOMCSSStyleDeclaration::DOMCSSStyleDeclaration):
              (KJS::DOMCSSStyleDeclarationPrototypeFunction::callAsFunction):
              (KJS::DOMMediaList::DOMMediaList):
              (KJS::KJS::DOMMediaListPrototypeFunction::callAsFunction):
              (KJS::DOMCSSStyleSheet::DOMCSSStyleSheet):
              (KJS::DOMCSSStyleSheetPrototypeFunction::callAsFunction):
              (KJS::DOMCSSValue::DOMCSSValue):
              (KJS::DOMCSSValuePrototypeFunction::callAsFunction):
              * bindings/js/kjs_css.h:
              * bindings/js/kjs_dom.cpp:
              (KJS::DOMNode::DOMNode):
              (KJS::DOMNodePrototypeFunction::callAsFunction):
              (KJS::DOMEventTargetNode::DOMEventTargetNode):
              (KJS::DOMEventTargetNodePrototypeFunction::callAsFunction):
              (KJS::DOMNamedNodeMap::DOMNamedNodeMap):
              (KJS::DOMNamedNodeMapPrototypeFunction::callAsFunction):
              * bindings/js/kjs_dom.h:
              * bindings/js/kjs_domnode.h:
              * bindings/js/kjs_events.cpp:
              (KJS::DOMEvent::DOMEvent):
              (KJS::DOMEventPrototypeFunction::callAsFunction):
              (KJS::Clipboard::Clipboard):
              (KJS::ClipboardPrototypeFunction::callAsFunction):
              * bindings/js/kjs_events.h:
              * bindings/js/kjs_html.cpp:
              (KJS::JSHTMLDocumentPrototypeFunction::callAsFunction):
              (KJS::):
              (KJS::JSHTMLDocument::JSHTMLDocument):
              (KJS::JSHTMLElementPrototypeFunction::callAsFunction):
              (KJS::JSHTMLElement::JSHTMLElement):
              (KJS::JSHTMLCollection::JSHTMLCollection):
              (KJS::JSHTMLCollectionPrototypeFunction::callAsFunction):
              * bindings/js/kjs_html.h:
              * bindings/js/kjs_navigator.cpp:
              * bindings/js/kjs_traversal.cpp:
              (KJS::DOMNodeFilter::DOMNodeFilter):
              (KJS::DOMNodeFilterPrototypeFunction::callAsFunction):
              * bindings/js/kjs_window.cpp:
              (KJS::Window::clear):
              Changed Proto to Prototype, and ProtoFunc to PrototypeFunction.
      
      LayoutTests:
              * fast/dom/Window/window-properties-expected.txt:
              * fast/dom/prototype-chain-expected.txt:
              * fast/events/event-view-toString-expected.txt:
              * fast/events/mouseclick-target-and-positioning-expected.txt:
              * fast/tokenizer/external-script-document-write-expected.checksum:
              * fast/tokenizer/external-script-document-write-expected.png:
              * fast/tokenizer/external-script-document-write-expected.txt:
              Updated the results.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18912 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6b02c313
    • lars's avatar
      Reviewed by Zack and Darin · 843e7775
      lars authored
              Fix the Qt build again after the latest Image changes.
              Also make some of the methods implemented in ImageCG 
              crossplatform.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18911 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      843e7775
    • andersca's avatar
      Reviewed by John Sullivan. · 2d606248
      andersca authored
              
              Move all code in WebNetscapePluginEmbeddedView down to WebBaseNetscapePluginView.
              
              * Plugins/WebBaseNetscapePluginView.h:
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
              (-[WebBaseNetscapePluginView didStart]):
              (-[WebBaseNetscapePluginView dataSource]):
              (-[WebBaseNetscapePluginView dealloc]):
              (-[WebBaseNetscapePluginView pluginView:receivedResponse:]):
              (-[WebBaseNetscapePluginView pluginView:receivedData:]):
              (-[WebBaseNetscapePluginView pluginView:receivedError:]):
              (-[WebBaseNetscapePluginView pluginViewFinishedLoading:]):
              (-[WebBaseNetscapePluginView _redeliverStream]):
              * Plugins/WebNetscapePluginEmbeddedView.h:
              * Plugins/WebNetscapePluginEmbeddedView.mm:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18910 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2d606248
    • darin's avatar
      - quick attempt to fix the Qt build · f8ea7a15
      darin authored
              * platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::drawTiled):
              Remove obsolete parameters from this stub.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18909 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f8ea7a15