- 23 Oct, 2018 40 commits
-
-
Jordan Demeulenaere authored
Bug: 806868 Change-Id: I4f2d9729549a2a6502336c98d3450967d39181b3 Reviewed-on: https://chromium-review.googlesource.com/c/1288539 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#602126}
-
Becca Hughes authored
Move audio focus media internals to helper class. Move logic from content::AudioFocusObserver (which we want to remove) to this helper class. BUG=875004 Change-Id: I7c80f6b680bd23e71193438c32b68e55ea05b58e Reviewed-on: https://chromium-review.googlesource.com/c/1286904Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#602125}
-
Bret Sepulveda authored
TBR=dgozman@chromium.org,chenwilliam@chromium.org Bug: 849670 Change-Id: Ida277f1d6dcfa07502ee3e97227a7fd4a891de38 Reviewed-on: https://chromium-review.googlesource.com/c/1297232Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#602124}
-
Antonio Gomes authored
BUG=890770 Change-Id: I74bc630b9bf7616400808227f8536c7dec2f48da Reviewed-on: https://chromium-review.googlesource.com/c/1296871 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#602123}
-
Dan Harrington authored
As requested by dcheng@. In some places, this can avoid extra conversions / constructions. Change-Id: Ibe8e330e604386706d0683ccc8bee9d78f9d9f59 Reviewed-on: https://chromium-review.googlesource.com/c/1289998 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#602122}
-
Xiaocheng Hu authored
The test has an Android-specific baseline, which was missed out in crrev.com/c/1278210, causing bot failures. This patch fixes it. NoTry: True Tbr: tkent@chromium.org Bug: 887148, 896310 Change-Id: I1448139afce05792e72f659dd528bf6b90e3d993 Reviewed-on: https://chromium-review.googlesource.com/c/1297406Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#602121}
-
Scott Violet authored
Forgot to remove before landing. BUG=891489 TEST=none TBR=xiyuan@chromium.org Change-Id: Icc5df4d872a9fe5a08a275bf3a15bc0b7f9b8781 Reviewed-on: https://chromium-review.googlesource.com/c/1297056Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#602120}
-
vmpstr authored
We're careful not to update the image loader when it is inserted into but nothing has changed. However, if we're inserted into a subtree such that the base element is now different, we do need to schedule a new run since the final URL may be different. R=fs@opera.com, chrishtr@chromium.org Bug: 897545 Change-Id: Id84894049c52e8f28a7ae581c3a626da5550207f Reviewed-on: https://chromium-review.googlesource.com/c/1296506 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#602119}
-
Jon Mann authored
This ensures connection to the Android Messages backend is not taken if another device is active and the user closes the tab or PWA. When the service worker connects with the backend it needs to send a START_STREAMING message if the device wasn't previously connected in order to start receiving messages. If this message is sent when a different device is conencted, the other device will lose the connection. Closing the active tab or PWA is not an action which should take the connection from another device so in this case we don't want to send the start message. This new 'resume_streaming_connection' informs the service worker that it should connect and not send the START_STREAMING message. Bug: 896383 Change-Id: Ie0e27461d29679c7c969bfd45c39e1dfb39da515 Reviewed-on: https://chromium-review.googlesource.com/c/1287264Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#602118}
-
David Benjamin authored
Test: 1. Go to chrome://settings/certificates 2. Press IMPORT 3. Select a PKCS#12 file, e.g. net/data/ssl/certificates/client.p12 from Chromium (password is "12345") 4. FIX #1: Password dialog should focus the input field. 5. Type the password and import. 6. Expand the entry for the newly-imported certificate. Hit the "..." button and select "Export". 7. Pick some file to export it to. 8. FIX #2: Password dialog should focus the first input field. Bug: 897264 Change-Id: Ia9377d9c776e486c6745cc32e3228193c1a265b6 Reviewed-on: https://chromium-review.googlesource.com/c/1292603Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#602117}
-
Michael Spang authored
Logging in with a USB drive connected is enough to hit this NOTREACHED(). DiskMountManager re-fires "mounting" notifications inside RefreshAfterEnumerateMountEntries. Bug: 716635 Test: log in with dcheck_always_on=true build Change-Id: I70c3b7e8064c7465a78c53e6574b20c38b74c168 Reviewed-on: https://chromium-review.googlesource.com/c/1297234Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#602116}
-
Daniele Castagna authored
GLRenderer::GetBackdropTexture used to bind the same texture twice in a row, this patch removes an unnecessary glBindTexture. Additionally, the caller of GLRenderer::GetBackdropTexture would check the texture name was not 0. This is not necessary since we assume the texture name is valid in GetBackdropTexture. Change-Id: I4668d2ecebbc840cb2cae45baa45182c780e9898 Reviewed-on: https://chromium-review.googlesource.com/c/1296679Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#602115}
-
Scott Graham authored
This is to unblock the v8 roll, which consumes //build separately from Chromium. TBRing for DEPS include_rules change, because it's a straight move, not a new addition. TBR: jochen@chromium.org Bug: 898088 Change-Id: Ic93764169680fc4e0680cc28db327a04a59750c8 Reviewed-on: https://chromium-review.googlesource.com/c/1297078 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#602114}
-
Sarath Singapati authored
XRSession's selectstart event is fired on pointerdown event now. Bug: 887904 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib37fb8c46d9afd832b89499b14fa7baa741de727 Reviewed-on: https://chromium-review.googlesource.com/c/1244636 Commit-Queue: Sarath Singapati <sarath.singapati@huawei.com> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#602113}
-
CJ DiMeglio authored
We had incorrectly obmitted an update to the opacity when we first start sending frames. This CL adds that necessary call, and also neatens up the logic to update opacity and rotation, making the effect of these calls clearer. Bug: 893056 Change-Id: I1b6edb4292f1a3a25aa22b61e82c20381d395eb7 Reviewed-on: https://chromium-review.googlesource.com/c/1275525 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#602112}
-
Fredrik Hubinette authored
Note that this refactoring is not entirely without side effects. In some cases we will do a better job of reading the color space from the container. For VP9, we will no longer be using the resolution to guess color spaces. media: :ColorSpace is deprecated. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6ebd5b6f9a5fc579274032e17f84c53f1c63f6ad Reviewed-on: https://chromium-review.googlesource.com/c/1277838 Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#602111}
-
Shakti Sahu authored
Fixed the received_bytes field for offline pages to OfflineItem conversion. Also added all the missing fields to the conversion unit tests. Bug: 897841 Change-Id: I823a84bc36a9d07c2f955f756c91412d22fa59ae Reviewed-on: https://chromium-review.googlesource.com/c/1294404 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#602110}
-
Christopher Cameron authored
This fixes the bug where we see two titlebars for PWA windows, and fixes a longstanding TODO to add needed parameters to the CreateWindowParams structure. Update the mojo struct CreateWindowParams to include parameters used by the various NativeWidgetMac::CreateNSWindow overrides. Include in these parameters a WindowClass parameter to indicate the subclass of NativeWidgetMacNSWindow to use. Add the overrideable method NativeWidgetMac::PopulateCreateWindowParams to populate the CreateWindowParams structure. Add plumbing in BrowserWindowFrame to call back into the browser process to get the overridden titlebar height. Add similar plumbing to BrowserNativeWidgetWindow to implement _handleFocusToolbarHotKey. With this in place, BrowserWindowFrame et al no longer have any dependencies on browser-process classes. Move BrowserWindowFrame and NativeWidgetMacFramelessNSWindow from //chrome/browser/ui/views/ over to //ui/views_bridge_mac. Bug: 897866 Change-Id: I04d9dd57d2bb98f98899349f2810198103e286b8 Reviewed-on: https://chromium-review.googlesource.com/c/1295251Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#602109}
-
Aaron Krajeski authored
Bug: 894043 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id777b3e30ce6f9d84b2935630559c62a251d07af Reviewed-on: https://chromium-review.googlesource.com/c/1289749 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#602108}
-
Bill Orr authored
The bug here is that we were calling XRCanvasInputProvider::Stop() in our destructor (ie - during garbage collection), where we should not consume gc objects, since they may already be destroyed. The fix is simply to not call Stop at all during destruction. If the XRSession terminates, Stop() will be called through a different path. Otherwise, if XRCanvasInputProvider is destroyed, it means the canvas must also be destroyed because the canvas holds a strong reference to XRCanvasInputProvider. BUG=894718 Change-Id: Ic339769fb0207e6ac569709703760245c72974d1 Reviewed-on: https://chromium-review.googlesource.com/c/1294726Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Scott Violet authored
All of these tests now pass. BUG=889101,891489 TEST=test only change Change-Id: I3f71af680c57c6e4c584156d098fad07f351b27b Reviewed-on: https://chromium-review.googlesource.com/c/1297059Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#602106}
-
dpapad authored
MD Refresh style was missing. Bug: 897904 Change-Id: I89eff26e796db9c0c5b0e090c08fd2c00f419e17 Reviewed-on: https://chromium-review.googlesource.com/c/1295316Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#602105}
-
Henrik Grunell authored
* Removes the log state CHANNEL_CLOSING, which is actually not a log state. * Adds channel_is_closing_ flag instead. This way, it's possible to check in WebRtcLoggingHandlerHost::StoreLogInDirectory and WebRtcLoggingHandlerHost::DoUploadLogAndRtpDumps if the log is in closed state or not when channel is closing to avoid multiple upload/store attempts. Multiple stores/uploads could happen if channel is closing and a store or upload operation has been issued around the same time. Bug: 807547 Change-Id: I5e41d5a02095044582c06037d440d22a2edc0be2 Reviewed-on: https://chromium-review.googlesource.com/c/1296538Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#602104}
-
Fernando Serboncini authored
histogram_functions and single_sample_metrics Specifically: Change-Id: Ic60fd12e6d6b464240cc09398cd2faac02550770 Reviewed-on: https://chromium-review.googlesource.com/c/1296324Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
jonross authored
We'd like to be able to measure the impact of Surface Synchronization. To do this we want to know how long elapses from LocalSurfaceId allocation until the Surface is embedded by Viz. This change has both ParentLocalSurfaceIdAllocator and ChildLocalSurfaceIdAllocator also save the allocation time. Then adds piping so that the allocation time is forwarded all the way to Viz. Where the delta is calculated. Bug: 655231 TEST: Manual testing of histograms reports on Android, Windows, Mac, Linux, Chrome OS. And running all associated unit tests. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie3eb35cfe6b5e68b1c113824e3bc79ea99a989e8 Reviewed-on: https://chromium-review.googlesource.com/c/1281231 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#602102}
-
Etienne Bergeron authored
Add the "os-wow64" attribute to the metadata. Example: os-arch: "x86_64", os-name: "Windows NT", os-version: "10.0.16299", os-wow64: "enabled", On windows, it's possible to run a 32-bit version of chrome on a 64-bit arch. Unfortunately, there is no way to differentiate traces from these two scenarios. This is useful for slow-reports since stacksampling doesn't work in 32-bit. R=ssid@chromium.org Change-Id: I24c3ba21c9de9a93eb1fb6e8b19e4d34d11120e1 Reviewed-on: https://chromium-review.googlesource.com/c/1296812 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#602101}
-
Robert Flack authored
Backgrounds must paint under the border when the border is not solid even if the border color is opaque. Bug: 898247 Change-Id: I1eed15b9c17b22cd0ddba65073638a1f8a16c30d Reviewed-on: https://chromium-review.googlesource.com/c/1297173Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#602100}
-
Yue Cen authored
This is a refactor CL and it should not change any existing UI. The affected pages are as follows: - On startup site entry in chrome://settings - chrome://settings/siteData - chrome://settings/searchEngines - chrome://settings/content/zoomLevels - chrome://settings/handlers - chrome://settings/content/usbDevices - chrome://settings/content/all - All the pages in "Content settings" that use site-list-entry, such as chrome://settings/content/paymentHandler Bug: 890118 Change-Id: I35e00406999cf30012db557b10dd418cef67a69d Reviewed-on: https://chromium-review.googlesource.com/c/1277995 Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Reviewed-by:
-
rajendrant authored
When network service is enabled, data saver site-breakdown gets the services and downloads data usage from DataUseMeasurement. Bug: 808498 Change-Id: I9ec7c98e67b5e8db531a345de1f5f89824efa807 Reviewed-on: https://chromium-review.googlesource.com/c/1295729Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#602098}
-
Min Qin authored
When full browser is not launched, we should create InProgressDownloadManager to handle all the operations. BUG=842245 Change-Id: I2687000288c9459c8df8099ff4721a2b6755d96e Reviewed-on: https://chromium-review.googlesource.com/c/1297237 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#602097}
-
Lily Chen authored
This change adds several methods to PriorityQueue allowing comparison of Pointer positions, advancing a Pointer towards the beginning of the queue, and finding the first element matching a predicate. In addition, unique_ptr values are now supported. Bug: None Change-Id: If00616cabed9a30f8b8743335d63f0231442b3fe Reviewed-on: https://chromium-review.googlesource.com/c/1294297Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#602096}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c88cc779efdb..07055a3ee7ce git log c88cc779efdb..07055a3ee7ce --date=short --no-merges --format='%ad %ae %s' 2018-10-23 reed@google.com update dox for vertical-text demise 2018-10-23 jvanverth@google.com Check for valid initialization of ReflexHash 2018-10-23 mtklein@google.com add a few more ways to convert images to imgcvt 2018-10-23 brianosman@google.com Hoist color space xform creation out of GrTextureProducer 2018-10-23 jvanverth@google.com Check for finite segments when inserting into ActiveEdgeList 2018-10-23 pirama@google.com Add back -Wover-align Created with: gclient setdep -r src/third_party/skia@07055a3ee7ce The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:867813 TBR=brianosman@chromium.org Change-Id: Ic019cb3732c7d0131e372f8bb90dcead78146935 Reviewed-on: https://chromium-review.googlesource.com/c/1297014Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#602095}
-
Lei Zhang authored
It is not a general purpose substitute for the default std::string constructor. Do the same for base::EmptyString16() and base::string16(). Change-Id: I405b94dba0a761ba12bc3e40f712142ba3886d9b Reviewed-on: https://chromium-review.googlesource.com/c/1295312 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#602094}
-
Yi Gu authored
Findit suspects that it was caused by a v8 update. TBR owners for further investigation. TBR=kozy@chromium.org NOTRY=true Bug: 898062 Change-Id: I9a77f0d40f73d57f0fd54588ffd96a74d98dd2c1 Reviewed-on: https://chromium-review.googlesource.com/c/1297392Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#602093}
-
Scott Chen authored
This CL adds the step-indicator element that would show dots of different colors. The welcome_app element is responsible for setting the total and active index for each module's step-indicator. Bug: 874146 Change-Id: I7813d6d64f57759ceab5ce4b60e59a45db2dc161 Reviewed-on: https://chromium-review.googlesource.com/c/1285309 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#602092}
-
Becky Zhou authored
TBR=twellington@chromium.org Bug: 898165 Change-Id: Id519840866ae56a2ee795ee73ba505a1a3645559 Reviewed-on: https://chromium-review.googlesource.com/c/1297057Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#602091}
-
James Wallace-Lee authored
To prevent lag and stuttering, limit hittests on mousemove events to 50ms = 20Hz. Bug: 853581 Change-Id: I28f1f142df4c96be9c95d87cfd69c052d776a870 Reviewed-on: https://chromium-review.googlesource.com/c/1289297 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#602090}
-
Stephane Zermatten authored
This reverts commit 0602efcc. Reason for revert: We don't actually want to stop scripts when the overlay is tapped. Original change's description: > [Autofill Assistant] Initial impl of OnClickOverlay > > Bug: 806868 > Change-Id: I22b21ccbb386e89d5ac2b0cd8d80e53cc14b447a > Reviewed-on: https://chromium-review.googlesource.com/c/1282362 > Commit-Queue: Ganggui Tang <gogerald@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599980} TBR=rouslan@chromium.org,gogerald@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 806868 Change-Id: Id8b55687d2faead941f82ce0c4889606539dd9c6 Reviewed-on: https://chromium-review.googlesource.com/c/1296602Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
-
Emircan Uysaler authored
Bug: 898286 Change-Id: I4f3b40696968aabe712a95424d2bb725d35ef4e1 Reviewed-on: https://chromium-review.googlesource.com/c/1297252Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#602088}
-
Robert Liao authored
I helped start this, so I guess it's fair that I also do the reviews. BUG= Change-Id: Ic3622f28207380159626903ffbbe34f60bd73b43 Reviewed-on: https://chromium-review.googlesource.com/c/1297350 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
-
