GitLab

Approved Intent to ship:

https://groups.google.com/a/chromium.org/d/msg/blink-dev/bcD93CiIJHE/2a9_ibfbDQAJ

BUG=626101

Review-Url: https://codereview.chromium.org/2323823005
Cr-Commit-Position: refs/heads/master@{#417617}

BUG=631783

Review-Url: https://codereview.chromium.org/2321273002
Cr-Commit-Position: refs/heads/master@{#417616}

Split the LayoutOpportunityIterator class into separate source & header
files ng_layout_opportunity_iterator.h|cc from ng_constraint_space.h|cc

BUG=635619
TBR=glebl@chromium.org

Review-Url: https://codereview.chromium.org/2322293002
Cr-Commit-Position: refs/heads/master@{#417615}

This makes these two tests pass:

  ExtensionProtocolTest.AllowFrameRequests
  ExtensionProtocolTest.IncognitoRequest

They look somewhat comprehensive from looking back at crbug.com/312269
and crbug.com/576867.

But this change also feels vaguely wrong in that I feel like it should
probably be the ExtensionNavigationThrottle doing some blocking. If you
have any feedback on what the tests should be doing instead (creating a
NavigationHandle somehow instead of directly creating URLRequests so
that it gets a full complement of navigation throttles?) it would be
greatly appreciated. :)

R=nasko@chromium.org
BUG=510836

Review-Url: https://codereview.chromium.org/2316383002
Cr-Commit-Position: refs/heads/master@{#417614}

The search resolution response will potentially include thumbnail urls.
This patch adds support for fetching the thumbnail, using BitmapFetcher,
and displaying it whre the 'G' logo is currently displayed.

Also cleans up unused an unused field trial param for disabling sprite
animations.

Note that the work to parse the JSON and extract a thumbnail url has
not been completed yet. This CL adds the plumbing and UI changes
necessary to display once the parsing is implemented.

BUG=644932

Review-Url: https://codereview.chromium.org/2322793002
Cr-Commit-Position: refs/heads/master@{#417613}

Batch delete selected items in one AsyncTask rather than kicking
off a new AsyncTask for each file that needs to be deleted. This
moves the responsibility for deleting files associated with
download items from DownloadItemWrapper to DownloadManagerUi.

Android's THREAD_POOL_EXECUTOR has a finite number of AsyncTasks
that can be queued. If we queue too many AsyncTasks (e.g. 200
items are selected for deletion) an exception will be thrown.

BUG=643811

Review-Url: https://codereview.chromium.org/2305123002
Cr-Commit-Position: refs/heads/master@{#417612}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7a8b8fb4..858f8311

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2323333003
Cr-Commit-Position: refs/heads/master@{#417611}

Allow generating highbitdepth builds from the generate_gni.sh script.

Restrict the $DISABLE_AVX and --as=yasm settings to x86 builds because that is the only place they are required.

Review-Url: https://codereview.chromium.org/2319813002
Cr-Commit-Position: refs/heads/master@{#417610}

BUG=599584

Review-Url: https://codereview.chromium.org/2323913003
Cr-Commit-Position: refs/heads/master@{#417609}

For normally installed extensions, when the content verification system
detects corruption we just disable the extension and provide a "Repair"
button on the chrome://extensions page that users can click to manually
reinstall the extension. But for enterprise force-installed extensions
that are supposed to always remain enabled, we weren't sure how to
handle this (since we have had a few bugs over time which resulted in
false-positive corruption detection in various edge cases, and this can
happen as a result of minor disk corruption as well as malicious
changes). So we just let them keep running but recorded an UMA histogram
to measure how often this happens. Looking at the data for this, it
happens very rarely - around 0.5% of total enterprise policy extensions
seem to be affected.

In some recent conversations with Google's own internal IT folks, we
decided we'd like to attempt to automatically repair instead of just
doing nothing, so this CL implements that. It also includes new UMA
stats for measuring the number of repair attempts and successes, as well
as issuing a warning to the browser log which enterprise admins could
have automated systems watching for. Over time we'd like to implement a
separate log facility for these kinds of events that are of interest
just to enterprise admins so that they don't have to turn on the general
browser log.

BUG=447040

Review-Url: https://codereview.chromium.org/2299203004
Cr-Commit-Position: refs/heads/master@{#417608}

Extraction of common code also means some changes to the
Windows memory-monitor.

BUG=644397

Review-Url: https://codereview.chromium.org/2310193002
Cr-Commit-Position: refs/heads/master@{#417607}

The Views implementation of SadTab supports two big things that were
missing in the Mac implementation:

1. The reload button turns into a feedback button on repeated crashes.
2. Histograms for tracking different kinds of crashes.

This moves that logic up into the base SadTab, so that both
implementations can use it.

It also adds new histograms to count when a sad tab with a reload button
or feedback button is displayed, and clicks on the button or help link.

Other changes:

- HISTOGRAM_ENUMERATION_WITH_FLAG uses a new base::underlying_value()
  function to cast scoped enums to their underlying integral values.
  (Unlike classic enums, they don't implicitly convert).

- The Show() and Close() methods of SadTab are gone. Show() was always
  called right after construction, and Close() was always called right
  before destruction, so I merged them with the ctor+dtor.

- SadTabController is gone.

- SadTabView no longer gets a reference to the WebContents; SadTabCocoa
  is now responsible for sizing it and adding it to the view hierarchy.

- The help link text no longer selects when you right click it.

BUG=623690
TEST=Trigger sad tabs on each platform either with chrome://crash or by
killing processes in the task manager. Check that the first sad tab
shows a reload button and subsequent sad tabs show a feedback button.
Otherwise, the look and behavior of the sad tab should be the same.

Review-Url: https://codereview.chromium.org/2261793002
Cr-Commit-Position: refs/heads/master@{#417606}

BUG= internal b/31275665
TEST= gn check all the platforms

Review-Url: https://codereview.chromium.org/2306383004
Cr-Commit-Position: refs/heads/master@{#417605}

HttpNetworkTransaction::DescribeState was a debugging routine used to print out ascii names for state values, but it had bit-rotted.  Removing under the presumption that no-one is using it.

BUG=None
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2325643004
Cr-Commit-Position: refs/heads/master@{#417604}

We need to rewrite to tbm2 in order to get memory. We don't really look
at memory metrics anyway at this point, so remove for now.

BUG=632295
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2325153002
Cr-Commit-Position: refs/heads/master@{#417603}

This is to inform the spec discussion:
https://github.com/w3c/webrtc-pc/issues/709

R=guidou@chromium.org

Review-Url: https://codereview.chromium.org/2329433002
Cr-Commit-Position: refs/heads/master@{#417602}

This uses the generic allocator shim to hook into heap allocations.
When disabled and unused, there is no runtime penalty for this. When heap tracing is enabled, there's a small accounting overhead for every allocation.

Instantiating a ScopedThreadHeapUsage instance carries O(1) cost, whether or not heap tracing is enabled.

BUG=644385

Review-Url: https://codereview.chromium.org/2163783003
Cr-Commit-Position: refs/heads/master@{#417601}

This activity was inadvertently changed to exported in
https://codereview.chromium.org/2268323003/

BUG=645310

Review-Url: https://codereview.chromium.org/2328843002
Cr-Commit-Position: refs/heads/master@{#417600}

Review-Url: https://codereview.chromium.org/2323033002
Cr-Commit-Position: refs/heads/master@{#417599}

Also update the scroll an element into the view
as it may cause some internal div to scroll
and fail the test.

BUG=643215

Review-Url: https://codereview.chromium.org/2319133002
Cr-Commit-Position: refs/heads/master@{#417598}

Reverted in:
https://codereview.chromium.org/2327063002/

Reason for reland:
Now guards non-build import behind enable_java_templates

TBR=michaelbai,machenbach
BUG=622855

Review-Url: https://codereview.chromium.org/2326973003
Cr-Commit-Position: refs/heads/master@{#417597}

- One expectations was tentatively removed for Linux ANGLE but was
  needed
- One Mac test was marked as Flaky when it is actually failing
  consistently

BUG=angleproject:1492
BUG=644360
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2328973002
Cr-Commit-Position: refs/heads/master@{#417596}

https://chromium.googlesource.com/skia.git/+log/a42405aa522c..55bcc8e0af34

$ git log a42405aa5..55bcc8e0a --date=short --no-merges --format='%ad %ae %s'
2016-09-09 msarett Delete some LUTs from SkColorSpaceXform
2016-09-09 caryclark fix fuzzer

BUG=644680,644684

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=caryclark@google.com

Review-Url: https://codereview.chromium.org/2325133003
Cr-Commit-Position: refs/heads/master@{#417595}

The relevant WebGL2 CTS tests work fine on recent Intel drivers.

BUG=590870
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2319223004
Cr-Commit-Position: refs/heads/master@{#417594}

The Mojo service uses url::Origin, and that's the better way to be
storing origins, so converting over to using that instead of GURL. This
also does a bit of cleanup on the tests, which had a mix of methods which
took an origin argument and methods which created the origin internally.
Now the test has a member which is calculated once.

BUG=617971

Review-Url: https://codereview.chromium.org/2324133002
Cr-Commit-Position: refs/heads/master@{#417593}

BUG=645425

Review-Url: https://codereview.chromium.org/2320423002
Cr-Commit-Position: refs/heads/master@{#417592}

This CL introduces the core building blocks to read-back the
proto-encoded trace buffer. This will be used by next CLs
at trace finalization time to convert protobuf -> v1 JSON.

BUG=643674

Review-Url: https://codereview.chromium.org/2303343002
Cr-Commit-Position: refs/heads/master@{#417591}

Using update-w3c-deps in Chromium f15c309c.

BUG=

Review-Url: https://codereview.chromium.org/2322083002
Cr-Commit-Position: refs/heads/master@{#417590}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3e7af8dc..7a8b8fb4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2326063002
Cr-Commit-Position: refs/heads/master@{#417589}

The proxy override bubble had some UMA entries, but they weren't present
in histograms.xml. Add an entry and for the user action metric and
add an obsolete entry (for historical reasons) for the extension count
metric.

BUG=643531

Review-Url: https://codereview.chromium.org/2320013003
Cr-Commit-Position: refs/heads/master@{#417588}

BUG=644608
TBR=sebmarchand@chromium.org

Review-Url: https://codereview.chromium.org/2324463005
Cr-Commit-Position: refs/heads/master@{#417587}

Presently RenderFrameHostImpl::Send() does not use its own widget's
input router when sending message, meaning messages to subframes could
be sent to the wrong frame. This was discovered while trying to make
InputMsg_SelectRange/InputHostMsg_SelectRange_Ack work properly for
messages sent to an out-of-process iframe.

Note: this is a re-land of https://codereview.chromium.org/2012933002/
originally committed as

https://crrev.com/7a22bf01ea55475b295e40f5bbfd1add2bc73649
Cr-Commit-Position: refs/heads/master@{#396044}

TBR=creis@chromium.org
BUG=470662

Review-Url: https://codereview.chromium.org/2322233003
Cr-Commit-Position: refs/heads/master@{#417586}

We're currently starting the synchronization of memory mapped dmabufs only
for reading, which means the driver will not flush the CPU cache on
DMA_BUF_SYNC_END. As a result we tend to see cache lines on platforms
where we don't have an additional cache level like Atom platforms.

BUG=475633
TEST=run chrome on chromeos with --enable-native-gpu-memory-buffers and
     verify we don't have image corruptions when hovering the close/minimize
     buttons

Review-Url: https://codereview.chromium.org/2297783006
Cr-Commit-Position: refs/heads/master@{#417585}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/2e13422..afd388c

BUG=
TEST=bots
NOTRY=true
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2319903004
Cr-Commit-Position: refs/heads/master@{#417584}

Revert of Remove calls to MessageLoop::current() in ios. (patchset #1 id:1 of https://codereview.chromium.org/2079423002/ )

Reason for revert:
This causes crashes during browser startup.

Original issue's description:
> Remove calls to MessageLoop::current() in ios.
>
> Why?
> The fact that there's a MessageLoop on the thread is an
> unnecessary implementation detail. When browser threads
> are migrated to base/task_scheduler, tasks will no longer
> have access to a MessageLoop.
>
> These changes were generated manually.
>
> BUG=616447
> R=droger@chromium.org
>
> Committed: https://crrev.com/c5c127abb5f0d8ba0dd34cfbd6233bbf9209f0f2
> Cr-Commit-Position: refs/heads/master@{#401027}

TBR=sdefresne@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=616447

Review-Url: https://codereview.chromium.org/2326053002
Cr-Commit-Position: refs/heads/master@{#417583}

Review-Url: https://codereview.chromium.org/2324153002
Cr-Commit-Position: refs/heads/master@{#417582}

We report events to the activity log on the UI thread, which can involve
a thread hop. During this thread hop, it's possible the profile was
invalidated. Check the profile before using it.

BUG=643012

Review-Url: https://codereview.chromium.org/2326613003
Cr-Commit-Position: refs/heads/master@{#417581}

Revert of Make secondary abi work for component build (patchset #5 id:80001 of https://codereview.chromium.org/2319273002/ )

Reason for revert:
Broke v8 roller

Original issue's description:
> Make secondary abi work for component build
>
> Add secondary_abi_shared_libraries to pack all the secondary abi
> shared libraries into APK.
>
> BUG=622855
>
> Committed: https://crrev.com/3ac692c2e67e8030a30e4ebcd12240352944f898
> Cr-Commit-Position: refs/heads/master@{#417441}

TBR=machenbach@chromium.org,michaelbai@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=622855

Review-Url: https://codereview.chromium.org/2327063002
Cr-Commit-Position: refs/heads/master@{#417580}

https://chromium.googlesource.com/skia.git/+log/426a2459290a..a42405aa522c

$ git log 426a24592..a42405aa5 --date=short --no-merges --format='%ad %ae %s'
2016-09-09 borenet Fix issues in assets scripts
2016-09-09 halcanary SkPDF: implement drawTextBlob()

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=caryclark@google.com

Review-Url: https://codereview.chromium.org/2321403002
Cr-Commit-Position: refs/heads/master@{#417579}

Add a new mojo interface mojom::DisplayController to allow privileged
clients to make changes to the display state. The initial interface
contains methods needed by mash to provide display state related
keyboard accelerators that exist in cash currently.

Have PlatformScreenOzone implement this new interface and provide mostly
stub implementations. Right now the interface isn't wired up so that
will happen in a subsequent CL.

Also adds PlatformScreen::GetInstance() so PlatformScreen doesn't need
to be passed so many places.

BUG=611475

Review-Url: https://codereview.chromium.org/2310133002
Cr-Commit-Position: refs/heads/master@{#417578}