- 14 Jan, 2021 40 commits
-
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: I9e0a1e799c205728784e6dbfb1cc9c2bf67c8575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626782Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843599}
-
Ilya Nikolaevskiy authored
See discussion in crbug 1155426 for details. Changes: MediaStreamCaptureIndicator::UIDelegate: Ignore multiple calls to OnStarted(). TabSharingUIViews: Unconditionally execute clean-up tasks in destructor. MediaStreamUI and contents::MediaStreamUI: Now has SetStopCallback method which is used to remove the stop callback when MediaStreamUI is replaced on switching the tab source. Bug: 1155426, 1166260 Change-Id: I0482c82f921fdc2f20931ab83458deec2f2da30c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629278 Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#843598}
-
Curt Clemens authored
In the contact visibility dialog with "Some Contacts" selected, the toggle list for picking individual contacts was missing aria labels for the cr-toggle-buttons. Those are now added so that tabbing through the list correctly announces what the toggles represent. In the device name dialog, the help text underneath the cr-input had low contrast. The color of that text is now darkened to google-grey-700 to push the contrast ratio up to ~6.5. Fixed: 1165926, 1165977 Change-Id: I6a8c985ac9e264c0a4249cd314d28cc5e63c5a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628076Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#843597}
-
Curt Clemens authored
The receive confirmation page uses <nearby-progress> with "progress=0" to show a device preview while hiding the progressbar. This mostly works, unless there is an error, in which case the progress bar is shown in red at 100%. This CL allows explicitly turning off progress so that is is not shown regardless of the error state. Use "--iron-icon-fill-color" in <nearby-progress> instead of "color" to set the device icon color, since the "color" property was getting overridden. Finally, grey out the <nearby-preview> on the receive confirmation page when there's an error to match the behavior on the send confirmation page. Screenshot: https://screenshot.googleplex.com/4Nxb6o9tThi3obQ.png Bug: b/163036847 Change-Id: Ibda918fb3fb5c54f7c9c98f9b31f5edaf083e16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622900Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/94ca9a9578a7..320b6dfbe5e4 2021-01-14 fmayer@google.com Merge "Move CanProfile to src/profiling/common." 2021-01-14 fmayer@google.com Merge "Allow to start secondary heapprofd." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id042f389b359ecc429a95f61ce1bf025e1a35232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629647Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843595}
-
Lutz Vahl authored
This is a roll-back to 8.9.255. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. R=machenbach@chromium.org,vahl@chromium.org,hablich@chromium.org Binary-Size: Increase is temporary. Change-Id: I80b1acc551a11483664699717635ad5c4790beca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627326 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Lutz Vahl <vahl@chromium.org> Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#843594}
-
Monica Basta authored
The local profile name is strongly tied with |IsUsingDefaultName|, missing to update |IsUsingDefaultName| can lead to unexpected displayed profile name in the profile menu. Therefore this CL adds it as a parameter to |SetLocalProfileName|. This CL fixes the bug 1165914 except one corner case. The transition between a default local profile to a profile name equal to Gaia name does not lead to a change in the displayed name of the profile in the profile menu, as a result 'OnProfileNameChanged' won't be triggered. The profile state is then not updated on the picker, another observer needs to be added to fix this issue. Expectations for the profile menu after this CL: * If local profile name == Gaia name: 'Gaia name' * Otherwise (such as Work, email): 'Gaia name (Work)', 'Gaia name (email@user.com)'. Bug: 1165914 Change-Id: I296504fa015890d5933a399e3110da4546fba8cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627396 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#843593}
-
Xianzhu Wang authored
This reverts commit 6f895b07. Reason for revert: The reverted CL is supposed not to affect production, but it seems to cause crbug.com/1166540. Original change's description: > Add CullRect::ApplyPaintProperties() > > It will be called to map a cull rect from parent space to local space > in cull rect update during PrePaint. The purpose is to mark PaintLayers > needing repaint on cull rect changes before paint, instead of checking > interest rect / cull rect changes during paint, to avoid setting > PaintLayer needing repaint unnecessarily, especially for CAP during > composited scrolling. > > Besides the original features of CullRect::ApplyTransforms() which is > used in cull rect mapping for CompositeAfterPaint, it also implements > the following features to be on par with CompositedLayerMapping:: > ReComputeInterestRect(): > > - Considering clips in additional to scroll clips, > - Clipping expanded cull rect by scrolling contents rect for composited > scroll translations, > - Clamping extreme geometry values, > - Adaptive expansion distance for composited transforms. > > The next steps are: > 1. Add CullRectUpdater which updates cull rects during PrePaint when > runtime feature CullRectUpdate is enabled. > 2. Use the updated cull rect to replace interest rect in pre-CAP and > cull rect in CAP and pre-CAP, still behind the runtime feature. > 3. Enable CullRectUpdate for CAP > 4. Enable CullRectUpdate for pre-CAP. > 5. Remove old interest rect / cull rect code. > > Bug: 1046544 > Change-Id: I6e7e9f85bc0b4640e67de1732744e647b6f7e230 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620090 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843304} TBR=szager@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Idc3374d3d426b9f571e417b1acbbc18227fdf274 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046544, 1166540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628021Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843592}
-
Adithya Srinivasan authored
Looks like this wasn't disabled correctly the first time. Disabling for real (and also added OS_ANDROID due to large number of flakes there). Bug: 1156218 Change-Id: I2b308bf11505b1081ac9c3f88676bcc61e65fb38 Tbr: arthursonzogni@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627716Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#843591}
-
Sophie Chang authored
This is a reland of 1a291df2 Original change's description: > Re-enable PredictionManager browser tests on Win/Mac/CrOS > > And fix init issue on ChromeOS for sign in profiles > > Change-Id: I26b87d58f2eae2afecf67685690312a8aed70c60 > Bug: 1146151 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625157 > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843176} Bug: 1146151 Change-Id: Id9b0353b3f5e7d5ffc3d27f68aec612efad4e68e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626985Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#843590}
-
Alice Wang authored
This CL disables the flaky test FirstRunIntegrationTest#testExitFirstRunWithPolicy. Bug: 1166585 Change-Id: I83ce1d787b894fbfcb00d61b4cf4477729e461cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628953 Auto-Submit: Alice Wang <aliceywang@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843589}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d46475f87758..628b7f61f813 2021-01-14 chrome-bot@chromium.org Update config settings by config-updater. 2021-01-14 saklein@chromium.org cbuildbot/commands.py: Fix for python3/encoding issue. 2021-01-14 chrome-bot@chromium.org Update config settings by config-updater. 2021-01-14 inglorion@chromium.org cros_setup_toolchains: build post-cross packages after others 2021-01-13 pwang@chromium.org For *-borealis run suite:av-analysis_trace_per-build 2021-01-13 jwata@google.com Remove ISOLATESERVER from lib/constants.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I2ec6cfc8434c5aef685ac0ddc6d67bb8a198dc06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628601Reviewed-by:
-
Olivier Robin authored
Unittests trigger some shutdowns and SessionService is not built to handle multiple shutdowns correctly. Bug: 1166186 Change-Id: Ic3b1ca9b68af7d8b02eafed588b308f5f78c5610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627277Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843587}
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: Idf2906985b34d3b69556e55fb745a9d23acf526a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629567Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843586}
-
Becca Hughes authored
WebContentsDestroyed Destroys MediaSessionControllersManager when the web contents is destroyed to avoid a crash. At the moment when WebContentsImpl is destroyed it ends up calling GetMediaSessionInfoSync which calls the destroyed WebContentsImpl. This destroys the media session controllers before they can do that. BUG=1136465,1157779 Change-Id: I7a3d678c4011a818c0ca5ac8d53b8a3420e662fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626920 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#843585}
-
Egor Pasko authored
The LegacyLinker still wants to wait until RELRO arrives (because there is no atomic RELRO replacement support yet - but it is not hard). In order to accommodate both waiting and delayed use, the Linker.java looks whether the subclass waited for RELRO, and if there was no explicit waiting, assumes the atomic replacement is implemented. This parent/subclass coordination is a bit unfortunate, as it makes the state transitions hard to understand, but the implementation of it is small. I do not expect this to have a big impact on startup. My local testing did not reveal any evidence of faster renderer load time. Potentially in the future mLibInfo could be guarded by another lock, so that it could arrive *while* the native library is loading. Currently it is not done, as it would require a larger change. I think it would have a chance to help only if this change as-is provides some nontrivial help. New metrics are introduced to try to avoid the overhead of a fair A/B test. They would approximate how many times a cold browser process makes a shared RELRO region such that it arrives *after* the child has loaded the native library (in other words, the child is not blocked). These metrics do not account for being in background and such, so it is a very rough approximation. Lab performance testing summary: android-go-perf,android-pixel2-perf,android-nexus5x-perf: no change Bug: 1154224 Change-Id: I6d385280910424e1d6b09784650d72b598a1ba23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610030 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#843584}
-
Anders Hartvoll Ruud authored
This plumbs the StyleRecalcContext from OriginalStyleForLayoutObject, through StyleResolver and into ElementRuleCollector. Bug: 1145970 Change-Id: I301ab3b459db8ef65dce3793390ed53a95504f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627409 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#843583}
-
Robert Kaplow authored
Bug: 1053702 Change-Id: I123c2282008bd4312752e8f71f8d7d29aad580b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626777 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843582}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/069cce000b9e..9513255f7c36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC adithyas@google.com,andypaicu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1158445 Tbr: adithyas@google.com,andypaicu@google.com Change-Id: I688bb6a9b172543236e682c62b1f50f2f35ad9b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629398Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843581}
-
Alexander Surkov authored
Bug: 1160279 Change-Id: I90c4da626f364d2c47637c748cc1ba0b37333fb3 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598577Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#843580}
-
Minoru Chikamune authored
Before this CL, there was only a per-thread CompositorTaskRunner. So any compositor task was running on per-thread compositor task runner even when the task belongs to ASG. This CL introduces per-ASG CompositorTaskRunner to run ASG’s compositor tasks, and migrate MediaFactory to use per-ASG CompositorTaskRunner. The remaining callsites will be migrated on following CL. Bug: 1105403 Change-Id: I548e4aaeefee8c229d2f31c26a5a30b3d6386ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601019 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#843579}
-
Kevin Ellis authored
Presently the test with the highest flake score under Blink>Animation. The cause of the flake is text aliasing differences; however, the test is not specifically for antialiasing but merely ensuring that an animation containing a neutral keyframe takes effect. Replacing the text with a box addresses the flake. Bug: 1165833 Change-Id: Ic87010210eda9055c0f67d996267cd9a814ad5d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623819Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#843578}
-
Jesse Doherty authored
This action is logged at the same time as Search.ContextualSearch.All.ResultsSeen::true. The value is used as part of a high-level guiding metric. We're trying to consolidate these metrics as user actions to improve query speeds and enable new analysis. Bug: b/161525144 Change-Id: Ic272acac7e75d2666ae6d6815d1ff9d38f46727d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628150 Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#843577}
-
Avi Drissman authored
CF-style frameworks use the CF naming conventions, and calls named "Create" create objects whose lifetimes need to be managed. Bug: none Change-Id: I56a57f93627a9fcb874f9f90d1c1d637e1172664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626517 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#843576}
-
Peter Kasting authored
Bug: 1159562 Change-Id: Iad8ed010bb6ca7123f8a6a4fe2546712790a75ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628084 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#843575}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202101140600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/bx6pXjyY-3vkrBjpqnuCDbusE-Ui_g3xSzSffOHHktoC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/174321021 Tbr: help-app@grotations.appspotmail.com Change-Id: Id04cacd8e798e1b12249939ac113392ce3d70602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629396Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610614773-8fa72e139bfbe669301559d8a5dcb0f175d80f50.profdata to chrome-win64-master-1610625483-0e8af23579a6861bbbc901692aa081cb0bce75b1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9c2ca94a72349b0ce9e9ed88ee897132e6553f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628377Reviewed-by:
-
Etienne Bergeron authored
This CL is moving the computation of engaged sites to the worker pool. Move the worker model to a single static function to avoid any incorrect fields accesses. The worker compute the sites and pass it to the main thread. The callbacks are queued and executed when at the completion of the background computation. Bug: 1157596 Change-Id: I4021d87fde51d673f78154b6cd5fc94fa71356d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627758Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#843572}
-
Peter Kasting authored
Bug: 1159562 Change-Id: I1f6e904976a027ed870744c50ec1f6444deefd62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628498 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
-
Peter Kasting authored
Bug: 1159562 Change-Id: Ie757c300fe2f4c6ab30173d777b1abdacd979feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625960 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
-
danakj authored
When ThreatDetails starts up, it walks the frame tree to request the DOM details of each frame. However it also tries to request this from a RenderFrameHost that has not loaded and created a RenderFrame in a renderer process. Previously, this message would be held and eventually dropped when the RenderFrameHost is replaced in the commit of the safe browsing error page. Soon we will crash if we try to talk to a non- existent RenderFrame, so we avoid attempting to do so here. R=nparker@chromium.org Bug: 1158869 Change-Id: I394a3e1775761ec0e99cc63e7f8b3e2d194c4d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626177Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#843569}
-
Dominique Fauteux-Chapleau authored
This is a reland of crrev.com/c/2623812 that was reverted by crrev.com/c/2628041. The issue was that enabling per-profile in unrelated tests made for a bad combination with realtime URL checks (that landed in crrev.com/c/2615779) and resulted in the browser DM token reading code being used needlessly. The fix to this is to add an optimization to ConnectorsService::GetDMTokenForRealTimeUrlCheck and check the main policy value before calling the expensive DM token reading code. Aside from that change this reland is identical to crrev.com/c/2623812. Original change's description: > Add testing config for per-profile Connectors > > A small change in ConnectorsService is required to make this test config > work. When checking analysis/reporting settings, 2 things are required > to obtain settings: a policy set to a valid value and a DM token (from > the browser or the profile). The previous implementation checked the DM > token first, meaning the blocking BrowserDMTokenStorage::RetrieveDMToken > call would trigger on multiple tests and crash them (see patchset 1 > failures for examples of this). > > The solution is to simply switch the > order of checks and read the policy first. This is also a valid > optimization of Connectors logic, as reading prefs is faster than > potentially reading the DM token from local storage. > > Change-Id: Ie1026b57cf7a4fd66663530ec2a77a72f21d6d81 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623812 > Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> > Reviewed-by: Marc-André Decoste <mad@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843115} Change-Id: Ie2959239571905251081c39af7cc4b124863890d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628110 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Marc-André Decoste <mad@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#843568}
-
Marc Treib authored
This CL adds the account-indication footers also for single-account and for sync users. Bug: 1121258 Change-Id: Idc78aad4ccb3ae8173adb97e3011789f174d21d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627161 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#843567}
-
Mihai Sardarescu authored
The methods OnPrimaryAccount{Set|Cleared} were replaced by OnPrimaryAccountChanged(). This CL removes them. Bug: 1158855 Change-Id: I7652904a299a9edbffb5d1ff078c54f0f1cbeb66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627390 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#843566}
-
Leonard Grey authored
Looks like I missed these in r835679 Bug: 1152274 Change-Id: I9ab585c62c753b2945b88a77ad1c3938f6693dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626513Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#843565}
-
Michael Lippautz authored
The Oilpan library version does not require detaching manually from an Isolate as the heap is tied directly to V8's JS heap for its lifetime. Bug: 1056170 Change-Id: I61e7c9d017a523aaf4ad09430fc1e8363e2b2fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629307 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Peter Kasting authored
Bug: 1159562 Change-Id: I236611f9223a6a9172a6b29a16ca947b43a4561d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628085 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
-
Antonio Sartori authored
This is a small refactoring of the code in blink::CSPDirectiveList which is parsing new Content Security Policies. This change separates the raw parsing of the policies from the side effects (applying the policies and storing state). This is part of a project to harmonize the CSP code in Blink and in services/network, and will make it easier to synchronize Content Security Policies between the two. Bug: 1021462,1149272 Change-Id: Iace800247ef6165a47adef2601d336a09e930897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601368 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#843562}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202101140600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/DYU_0-Aok5UvqgV35z_dEgBIqBP98Ypx98hUZ8a8NcoC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/170172576,b/175344485,b/177365224,b/177375485,b/18961540 Tbr: media-app@grotations.appspotmail.com Change-Id: Idcf3c25bf23ced4a58cf644dcbb879717c4cff8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629395Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I87da04ea6e4088e695809d9973d1fa37a024c6c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629388Reviewed-by:
-
