Commits · 78434748d9e82a4e4cf3d98cf6a2a1f8d6168829 · eriksson monteiro / tangled

19 Nov, 2011 13 commits

avi@chromium.org authored Nov 19, 2011

BUG=104314
TEST=no change

Review URL: http://codereview.chromium.org/8548020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110807 0039d316-1c4b-4281-b951-d872f2087c98

78434748

Reverting this as it breaks (at least) the Windows Aura build. · 6bf0d930

wez@chromium.org authored Nov 19, 2011

Revert 110804 - Fixes bug where clock button wasn't updating in response to a timezone
change.

BUG=104667
TEST=none
R=stevenjb@chromium.org


Review URL: http://codereview.chromium.org/8600001

TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/8500005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110806 0039d316-1c4b-4281-b951-d872f2087c98

6bf0d930

Fixes bug where clock button wasn't updating in response to a timezone · 09619f4b

sky@chromium.org authored Nov 19, 2011

change.

BUG=104667
TEST=none
R=stevenjb@chromium.org


Review URL: http://codereview.chromium.org/8600001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110804 0039d316-1c4b-4281-b951-d872f2087c98

09619f4b

Get rid of last gpu_messages.h dependency in chrome by having chrome ask the... · e336f133

jam@chromium.org authored Nov 19, 2011

Get rid of last gpu_messages.h dependency in chrome by having chrome ask the GPUProcessHostUIShim to hang/crash/clean the gpu process.

BUG=98716
Review URL: http://codereview.chromium.org/8548014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110802 0039d316-1c4b-4281-b951-d872f2087c98

e336f133

Track how long a typical SafeBrowsing download protection request takes. · 54159b2b

noelutz@google.com authored Nov 19, 2011

This histogram will also tell us how often the server response got back
too late and the timeout was reached.

This CL also makes sure we always send back the file hash if the
enhanced download protection is enabled.

BUG=NONE
TEST=Run all unit-tests under DownloadProtectionServiceTest.

Review URL: http://codereview.chromium.org/8600006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110801 0039d316-1c4b-4281-b951-d872f2087c98

54159b2b

Retry 110725 - Remove legacy FILES files. · 85f74043

mmoss@chromium.org authored Nov 19, 2011

These should now be replaced by FILES.cfg in all active branches and
build scripts.

Review URL: http://codereview.chromium.org/8603001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110800 0039d316-1c4b-4281-b951-d872f2087c98

85f74043

clang fails compile on aura drag and drop code · 4cc1bdb8

dhollowa@chromium.org authored Nov 19, 2011

clang check for non-trivial destructors in headers.

BUG=none
TEST=compiles on mac clang
R=varunjain@chromium.org

Review URL: http://codereview.chromium.org/8558010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110799 0039d316-1c4b-4281-b951-d872f2087c98

4cc1bdb8

Fix compile error introduced on r110794 · ab21f2c2

nduca@chromium.org authored Nov 19, 2011

TBR=wez@chromium.org

Review URL: http://codereview.chromium.org/8604002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110798 0039d316-1c4b-4281-b951-d872f2087c98

ab21f2c2

ASAN timeout on OutOfProcessPPAPITest.Crypto · d2f4edf0

dhollowa@chromium.org authored Nov 19, 2011

Disables OutOfProcessPPAPITest.Crypto test on ASAN.

BUG=104832
TEST=ASAN bot runs green
TBR=dmichael@chromium.org, noelallen@chromium.org

Review URL: http://codereview.chromium.org/8549034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110797 0039d316-1c4b-4281-b951-d872f2087c98

d2f4edf0

Prepare Chromium for WebCompositor::initialize. · 028217e8

nduca@chromium.org authored Nov 19, 2011

Currently, we have two duplicate mechanisms for telling the compositor to go into threaded mode. First, you set WebCompositor::setThread, then you pass enableCompositorThread via WebPreferences.

We're moving to a global initialize/shutdown flow on the compositor. This is a breaking change on the WebKit API so this change prepares us for it.

Review URL: http://codereview.chromium.org/8558030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110794 0039d316-1c4b-4281-b951-d872f2087c98

028217e8

Add OVERRIDE to chrome/test/. · 679f9f3e

avi@chromium.org authored Nov 19, 2011

BUG=104314
TEST=no change

Review URL: http://codereview.chromium.org/8558032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110793 0039d316-1c4b-4281-b951-d872f2087c98

679f9f3e

GViewRequestInterceptorTest.DoNotInterceptDownload fails on Chromium OS Heapcheck · 3bb9614b

dhollowa@chromium.org authored Nov 19, 2011

Disables failing test on Heapcheck bots.

BUG=104826
TEST=Heapcheck on Chromium OS completes the unit_tests run.
TBR=rsesek@chromium.org, bauerb@chromium.org

Review URL: http://codereview.chromium.org/8602011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110792 0039d316-1c4b-4281-b951-d872f2087c98

3bb9614b

Add OVERRIDE to remoting/. · 6a6fe806

avi@chromium.org authored Nov 19, 2011

BUG=104314
TEST=no change

Review URL: http://codereview.chromium.org/8601011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110791 0039d316-1c4b-4281-b951-d872f2087c98

6a6fe806

18 Nov, 2011 27 commits

CrOS: Fix file_watchers_ DCHECK in SelectFileDialogExtensionBrowserTest · 0f9c4556

jamescook@chromium.org authored Nov 18, 2011

The CrOS file picker closes the dialog immediately, without running the page unload handler. This meant we were leaking file watcher objects, causing a DCHECK in SelectFileDialogExtensionBrowserTest. Fixed by calling it manually when needed.

Also, we need to clean up the current directory's watcher, because we don't have a directory-change event in the unload handler that we can use to look up the directory path.

BUG=104692,103491
TEST=browser_tests, also verify you can open a file with control-O

Review URL: http://codereview.chromium.org/8602009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110789 0039d316-1c4b-4281-b951-d872f2087c98

0f9c4556

Pepper: Remove ppapi/cpp/private/flash_tcp_socket.*. · 0cc6fc92

viettrungluu@chromium.org authored Nov 18, 2011

I've converted Flapper, so we don't need them any longer. However, we still need
to support the C interfaces for some time (for binary compatibility).

Review URL: http://codereview.chromium.org/8597018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110788 0039d316-1c4b-4281-b951-d872f2087c98

0cc6fc92

views: Delete bubble, events, focus, layout directories and its stubbed files. · 477ae05f

tfarina@chromium.org authored Nov 18, 2011

BUG=104039
R=ben@chromium.org

Review URL: http://codereview.chromium.org/8566052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110787 0039d316-1c4b-4281-b951-d872f2087c98

477ae05f

Remove --enable-video-logging and WebVideoRenderer. · 86b3f4b2

scherkus@chromium.org authored Nov 18, 2011

WebVideoRenderer was added in r40137 as part of my IPC-based video rendering experiment.

I later added --enable-video-logging in r43038 which was intended to log timestamps and do logs analysis to determine playback smoothness. This again was experimental and never used.

Also removed WebMediaPlayerProxy::SetRect() and VideoRendererImpl::SetRect() as they were not implemented.

Review URL: http://codereview.chromium.org/8601004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110786 0039d316-1c4b-4281-b951-d872f2087c98

86b3f4b2

Revert 110783 - Adds a bounds parameter to ui::Compositor::ReadPixels · b62eab12

shess@chromium.org authored Nov 18, 2011

Review URL: http://codereview.chromium.org/8561016

TBR=pkotwicz@chromium.org
Review URL: http://codereview.chromium.org/8558033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110785 0039d316-1c4b-4281-b951-d872f2087c98

b62eab12

Add DEPS grit include for bubble_border.cc. · eb8f5705

shess@chromium.org authored Nov 18, 2011

http://crrev.com/110761 fails check_deps on OSX 10.6
ERROR in /b/build/slave/Mac_10_6_Tests__dbg__2_/build/src/ui/views/bubble/bubble_border.cc
Illegal include: "grit/ui_resources_standard.h"
    Because of no rule applying

TBR=tfarina@chromium.org

Review URL: http://codereview.chromium.org/8561032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110784 0039d316-1c4b-4281-b951-d872f2087c98

eb8f5705

Adds a bounds parameter to ui::Compositor::ReadPixels · 5b170f55

pkotwicz@chromium.org authored Nov 18, 2011

Review URL: http://codereview.chromium.org/8561016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110783 0039d316-1c4b-4281-b951-d872f2087c98

5b170f55

wayland: do not include message_pump_x.h for use_wayland · e3f28e2d

msb@chromium.org authored Nov 18, 2011

BUG=102903
TEST=compile

Change-Id: I5bea343f65b9db676b0f07e1b41bb59cf4f7cf38

R=oshima@chromium.org,saintlou@chromium.org,dnicoara@chromium.org

Review URL: http://codereview.chromium.org/8596010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110782 0039d316-1c4b-4281-b951-d872f2087c98

e3f28e2d

Close video capture devices on the device thread. · 8a2cfaf3

mflodman@chromium.org authored Nov 18, 2011


Review URL: http://codereview.chromium.org/8589018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110780 0039d316-1c4b-4281-b951-d872f2087c98

8a2cfaf3

Fixed SavePageBrowser test on Aura/Chromeos · d9b46713

davemoore@chromium.org authored Nov 18, 2011

BUG=103500
TEST=browser_tests

Review URL: http://codereview.chromium.org/8561030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110779 0039d316-1c4b-4281-b951-d872f2087c98

d9b46713

Clear VideoRendererBase::current_frame_ when stopped. · 8b48900e

scherkus@chromium.org authored Nov 18, 2011

I previously assumed that PipelineImpl would go through a clean Pause/Flush/Stop on an error but it turns out that Stop() can be called at anytime. Fortunately a DCHECK() would catch this condition and was easily triggerable using the test case attached in bug 100434.

Review URL: http://codereview.chromium.org/8561019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110778 0039d316-1c4b-4281-b951-d872f2087c98

8b48900e

Convert a few ppapi dev interfaces to IDL. NaCl has tests for these · 03f41ec4

jvoung@google.com authored Nov 18, 2011

dev interfaces, and we want it to go through IDL so that the PNaCl shim
will know about them. There are few others dev and private interfaces
not yet converted to IDL, but this is a start.

TEST= ./generator.py
BUG= http://code.google.com/p/chromium/issues/detail?id=89968

Review URL: http://codereview.chromium.org/8586031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110777 0039d316-1c4b-4281-b951-d872f2087c98

03f41ec4

Revert 110361 - NaCl: preallocate shared-memory object on Linux as on MacOSX · ab88d154

mcgrathr@chromium.org authored Nov 18, 2011

Preallocating the shared memory object saves an IPC round trip.
It also makes the code path more similar for Linux and Mac.
It also lays the groundwork for changing the allocation method
later without having to replumb the proxying layer.

BUG= http://code.google.com/p/chromium/issues/detail?id=103377
TEST= nacl still works on Linux

R=mseaborn@chromium.org,jam@chromium.org

Review URL: http://codereview.chromium.org/8513018

TBR=mseaborn@chromium.org
Review URL: http://codereview.chromium.org/8598029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110776 0039d316-1c4b-4281-b951-d872f2087c98

ab88d154

Tsan: Disable HostResolverImplTest.OnlyAbortExistingRequestsOnIPAddressChange · f38b332e

jhawkins@chromium.org authored Nov 18, 2011

which crashes consistently.

BUG=104805
TEST=none

R=dhollowa@chromium.org

Review URL: http://codereview.chromium.org/8549029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110775 0039d316-1c4b-4281-b951-d872f2087c98

f38b332e

Send fake event when event_type is set to exit menu so that · b5a1864e

oshima@google.com authored Nov 18, 2011

nested loop can exit.

BUG=104684
TEST=BrowserTest.CloseWithAppMenuOpen passes on aura build

Review URL: http://codereview.chromium.org/8597010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110774 0039d316-1c4b-4281-b951-d872f2087c98

b5a1864e

Enable |ValidateAndConvertPepperFilePath()| for domain-absolute paths without ENABLE_FLAPPER_HACKS. · 3b73f527

viettrungluu@chromium.org authored Nov 18, 2011

TBR=darin@chromium.org

Review URL: http://codereview.chromium.org/8566047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110773 0039d316-1c4b-4281-b951-d872f2087c98

3b73f527

Don't use process isolation for bookmark apps. · 15877cac

creis@chromium.org authored Nov 18, 2011

BUG=104636
TEST=No process swap on a link to/from a bookmark app.


Review URL: http://codereview.chromium.org/8585016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110772 0039d316-1c4b-4281-b951-d872f2087c98

15877cac

wayland: use message_pump_observer common code · 9a1ae1f8

msb@chromium.org authored Nov 18, 2011

BUG=102903
TEST=compile

Change-Id: I96c63b55a6be4623f8edd202a1642ae6f7a6eb7a

R=mark@chromium.org,oshima@chromium.org,dnicoara@chromium.org


Review URL: http://codereview.chromium.org/8561018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110771 0039d316-1c4b-4281-b951-d872f2087c98

9a1ae1f8

Fix DownloadTests and change cros/aura to use shelf · eab8c0f8

davemoore@chromium.org authored Nov 18, 2011

BUG=103488
TEST=DownloadTests.* browser tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110765

Review URL: http://codereview.chromium.org/8585040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110770 0039d316-1c4b-4281-b951-d872f2087c98

eab8c0f8

Disable OutOfProcessPPAPITest.Flash_GetCommandLineArgs on Mac Valgrind · 21910131

dhollowa@chromium.org authored Nov 18, 2011

Disable more failing PPAPITests on Valgrind Mac bot.

BUG=104535
TEST=Valgrind on Mac goes green
TBR=yzshen@chromium.org

Review URL: http://codereview.chromium.org/8602008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110769 0039d316-1c4b-4281-b951-d872f2087c98

21910131

Fix top crash due to r110394 - TabContentsViewCocoa renderWidgetHostWasResized · 0a2b1723

mpcomplete@chromium.org authored Nov 18, 2011

crashes due to a NULL tabContents pointer.

BUG=104751
TEST=no

Review URL: http://codereview.chromium.org/8586056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110768 0039d316-1c4b-4281-b951-d872f2087c98

0a2b1723

Valgrind leaks reported in ThreadData::TallyABirthIfActive ThreadData::TallyADeath · 519c9be3

dhollowa@chromium.org authored Nov 18, 2011

Adds suppressions for ThreadData::TallyABirthIfActive ThreadData::TallyADeath

BUG=104806
TEST=Valgrind bots go green
TBR=jar@chromium.org

Review URL: http://codereview.chromium.org/8569016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110767 0039d316-1c4b-4281-b951-d872f2087c98

519c9be3

Revert 110765 - Fix DownloadTests and change cros/aura to use shelf · 9c16893f

davemoore@chromium.org authored Nov 18, 2011

BUG=103488
TEST=DownloadTests.* browser tests

Review URL: http://codereview.chromium.org/8585040

TBR=davemoore@chromium.org
Review URL: http://codereview.chromium.org/8569015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110766 0039d316-1c4b-4281-b951-d872f2087c98

9c16893f

Fix DownloadTests and change cros/aura to use shelf · 9fc2248c

davemoore@chromium.org authored Nov 18, 2011

BUG=103488
TEST=DownloadTests.* browser tests

Review URL: http://codereview.chromium.org/8585040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110765 0039d316-1c4b-4281-b951-d872f2087c98

9fc2248c

Just show the setting level bubble on the default monitor, since ChromeOS only... · 6b9360e8

ben@chromium.org authored Nov 18, 2011

Just show the setting level bubble on the default monitor, since ChromeOS only really supports one monitor right now anyway.

Code like this will end up living in aura_shell::Shell by the time we end up figuring out how to support multiple monitors.

For now, this removes a USE_AURA ifdef/NOTIMPLEMENTED() and some unnecessary complexity for cros.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8596013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110764 0039d316-1c4b-4281-b951-d872f2087c98

6b9360e8

Remove PPAPI Flash in-process from about:flags. · 23d06a97

viettrungluu@chromium.org authored Nov 18, 2011

It's definitely not something we want to expose to users.

Review URL: http://codereview.chromium.org/8590011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110763 0039d316-1c4b-4281-b951-d872f2087c98

23d06a97

aura: Add glib dependency when appropriate. · c53f112b

sadrul@chromium.org authored Nov 18, 2011

BUG=none
TEST=browser_tests, unit_tests etc. builds

Review URL: http://codereview.chromium.org/8599003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110762 0039d316-1c4b-4281-b951-d872f2087c98

c53f112b