- 22 Mar, 2020 32 commits
-
-
Jing Wang authored
This is a follow-up cl of https://crrev.com/c/2099343. Make the naming and description of zhuyinKeyboardLayout and koreanKeyboardLayout in a same fashion. This class is not used in production yet, so it is still safe to change field names. Test: tested with Linux emulator Bug: 1060906 Change-Id: I3305fd54a76e6f48ec6d3c3f4fb50b4cac7ad167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111811Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#752348}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/53d53c3216dd..670860a21d19 Created with: gclient setdep -r src-internal@670860a21d19 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If7a4f3021b9d5bdf585fdb7ff7c8fccd279347cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113209Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752347}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: If3d2ef4caf5eff498994f997a3d4e8039ee12469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114577Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752346}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic02e9c8e69f2f62d667562659ab69cbe85e009f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113208Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752345}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: Ia5f32e7caf3981edb30fd76dfb32ce6b4807b6c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113679Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752344}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0b13eaf1afdc..53d53c3216dd Created with: gclient setdep -r src-internal@53d53c3216dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I221b635fada4b595555c44b9cab49e0d72c44ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113203Reviewed-by:
-
James Cook authored
This reverts commit 68d57f1a. Reason for revert: Test is still flaky per Find-It. See bug or https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyQAsSBUZsYWtlIjVjaHJvbWl1bUBicm93c2VyX3Rlc3RzQE9TU2V0dGluZ3NDcm9zdGluaVBhZ2VUZXN0LkFsbAw Original change's description: > Re-enable Crostini settings browsertests > > Bug: 1056268 > Change-Id: Ie4cd3dc2769f1cac596d4e7eb75641e4b1563abd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107052 > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> > Auto-Submit: Nicholas Verne <nverne@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751382} TBR=khorimoto@chromium.org,nverne@chromium.org,davidmunro@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1056268 Change-Id: I0aab9c0da46ec1043e0dcd99ff263d2f760e373b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114447Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#752342}
-
Ehimare Okoyomon authored
Add focus-row-control to incognito tooltip icon. Bug: 1062534 Change-Id: I84aa1a50569da13f76cd4e414bacc7684b8df93a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110090Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#752341}
-
Saurabh Nijhara authored
In some cases, we use CRX cache to speed up extensions installation. But if the CRX file in the cache gets corrupted itself, the CRX verification process in crx_verify.cc returns an error and the unpacker fails. As a result of this, the culprit CRX file is removed from the cache so that the extension is freshly downloaded and installed when the update process triggers again. But till the update re-triggers, the extension (which might be in force install list) remains uninstalled. This CL fixes this problem by re-triggering the extension download if it CRX file in the cache is corrupted. Currently, the code to re-trigger the download only runs for one type of unpacker error which is not sufficient to handle the case of cache entry corruption. Bug: 1047637 Change-Id: Ia9eea880b88828f9ee58ff2d99070ddde82becca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074680 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#752340}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c0b8881050e7..0b13eaf1afdc Created with: gclient setdep -r src-internal@0b13eaf1afdc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I66d4e4eac236b775d56f8d261c394ed261cb6009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113199Reviewed-by:
-
Patrick Monette authored
This reverts commit b7526e4f. Reason for revert: Top crasher on canary and asan build Original change's description: > [Task Manager] Properly clear worker tasks on profile shutdown. > > Fixes PerProfileWorkerTaskTracker so that the WorkerTaskTracker is > notified when there are outstanding tasks that are about to be > deleted. > > Bug: 1060506 > Change-Id: Ic81ad1557c1e27a8fc96fc079f7447efcc2ce7f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110350 > Auto-Submit: Patrick Monette <pmonette@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751915} TBR=afakhry@chromium.org,pmonette@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1060506 Change-Id: Idea16f14178d9a5f147f4dc57b514eb814eaa23a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113333Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#752338}
-
Wez authored
This is a reland of ec7d2855, with fixes to //chromecast to fix some unreachable code there. Original change's description: > Enable -Wunreachable-code in Fuchsia builds. > > Depends on https://chromium-review.googlesource.com/c/angle/angle/+/2112281 > > Bug: 346399 > Change-Id: I6bf27dc15303c207be0ae85dd3256af217db005b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111833 > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752299} TBR: spang, thakis, kmarshall, sergeyu Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Bug: 346399, 1063669 Change-Id: I87ec7863c1e34e9dbdbde929d9863561c3f5f235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113971Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#752337}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1bba4c6de293..c0b8881050e7 Created with: gclient setdep -r src-internal@c0b8881050e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I433e20656bb3686fd58830aa2dde762de37b6e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113197Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ief84d0d11b23ffb60bd9eef5e59781a2af6e0b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114439Reviewed-by:
-
Wez authored
This reverts commit ec7d2855. Reason for revert: Breaks the Fuchsia Cast bots due to unreachable code under //chromecast. We'll need to fix //chromecast to re-land. Original change's description: > Enable -Wunreachable-code in Fuchsia builds. > > Depends on https://chromium-review.googlesource.com/c/angle/angle/+/2112281 > > Bug: 346399 > Change-Id: I6bf27dc15303c207be0ae85dd3256af217db005b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111833 > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752299} TBR=wez@chromium.org,thakis@chromium.org,kmarshall@chromium.org,sergeyu@chromium.org Change-Id: Id094305ad1df897b8a12bb93d76b5feca5d96f27 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 346399, 1063669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114271Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/631a8514b181..1bba4c6de293 Created with: gclient setdep -r src-internal@1bba4c6de293 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic985632c332d63d4613aaf31466d0c711581e44d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113195Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I1cf238ad3dbac979711809148f5db845df4a483f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114530Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Iaa929e51614672f36b331884b2493063f98a8864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113196Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/09b0ac719176..631a8514b181 Created with: gclient setdep -r src-internal@631a8514b181 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iaf0a410006e2c41ac22059e49b219fe303cbf195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114440Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/19abcdf39a20..09b0ac719176 Created with: gclient setdep -r src-internal@09b0ac719176 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I2c421642891183bd20066aa39ed7d13b4e811894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114431Reviewed-by:
-
Alexander Alekseev authored
ForceKeyboardDrivenUINavigation in input device settings. This fixes a focus issue when using keyboard navigation in CfM's. Bug: b:148967469 Change-Id: I20567ce2a4616d80a966401c5b506c98372bca27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088012 Commit-Queue: Juan Pablo De Lima <jpdelima@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#752328}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/68cbb339..4481dd59 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idc3d1e15c5d18cbbbefa2d55dcc89b15cc2bfb4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113181Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752327}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3102b783c504..4e36ac84996b git log 3102b783c504..4e36ac84996b --date=short --first-parent --format='%ad %ae %s' 2020-03-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@4e36ac84996b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3d0cded205d506f644ebe4b2c982c68f23d07617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114339Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/565fb1314c43..19abcdf39a20 Created with: gclient setdep -r src-internal@19abcdf39a20 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I65fdbe7d53792b10ad2b268a2000e5d75d50efce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114335Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/22aaf4fee937..3102b783c504 git log 22aaf4fee937..3102b783c504 --date=short --first-parent --format='%ad %ae %s' 2020-03-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@3102b783c504 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifca53a94815906a8c163fac267c7b7f5c6f4cb3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114336Reviewed-by:
-
Hui Wang authored
This will happens when a download was created by |CreateDownloadHandlerForNavigation| and we will call |OnUrlDownloadStarted| before |OnUrlDownloadHandlerCreated| due to we had got the response. Then there is a chance that the |cancel_request_callback| will called before |OnUrlDownloadHandlerCreated|. we will fail to cancel this request since we haven't add it into the |url_download_handlers_|. Bug:None Change-Id: Id6a0018a6ac06909ca7c8462a5a90555b61a4873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111515 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#752323}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I518635cc176f0708d896b3ff7cc5a44d80313a24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113741Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752322}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I371ad66ef0dd783f45681da5fc884fd30af8ccc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114245Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/862818b291bd..538e358b0d82 git log 862818b291bd..538e358b0d82 --date=short --first-parent --format='%ad %ae %s' 2020-03-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 dadeffa315e7..cb7e7387e61f (28 commits) Created with: gclient setdep -r src/third_party/skia@538e358b0d82 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I358533364f4599f9972ba4071fcf8e2f7a96f0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114332Reviewed-by:
-
Sushanth Rajasankar authored
This patch addresses a performance regressions introduced by https://chromium.googlesource.com/chromium/src/+/d9b56fbb6c14e83389dfff002d43ff06edacdde8 The root cause here was performance hit caused by additional page faults that were occurring because the CanvasResourceProvider was unnecessarily holding on to the last recording. The Canvas2DLayerBridge::FlushRecording would have previously cleared the recording right away inside if (!clear_frame_ || !resource_host_ || !resource_host_->IsPrinting()) { last_recording_ = nullptr; clear_frame_ = false; } because we moved the recording to the resource provider this was not happening anymore. Fix is to not hold on to the recording in the resource provider. Change-Id: I6e4c76bc18bc685dd24843c2ee0d73d9f6a72f8a Bug: 1056704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112967Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#752319}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1698b50877e0..565fb1314c43 Created with: gclient setdep -r src-internal@565fb1314c43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I137626f67e409a825d5217f49d0289f9776ba023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114331Reviewed-by:
-
Nathan Zabriskie authored
To transition to OOPR canvas we need to remove all references to ContextGL on the shared main thread context. Although RasterImplementation will not need this API we need it for now during the transition. Bug: 1018898 Change-Id: I65e0830125416e59fdd7f707357855566803b888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113818 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
-
- 21 Mar, 2020 8 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4b65869002d1..1698b50877e0 Created with: gclient setdep -r src-internal@1698b50877e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I9a950d3efc4c6e095716a400df24565a5f4aa935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114164Reviewed-by:
-
Rahul Singh (EDGE) authored
In this CL we change the value set when DropShadow EdgeEffect is detected in Win10 System Settings Also removing logging from caption_style_win.cc. There are no specific errors that we need logs for at the moment. See previous feedback here: https://crrev.com/c/chromium/src/+/1794002/3/ui/native_theme/caption_style_win.cc#192 Bug: 1063614 Change-Id: I301303ff43297dd1bb614423f6a9b94249b79721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113737 Commit-Queue: Rahul Singh <rahsin@microsoft.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#752315}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bd1db41bd809..862818b291bd git log bd1db41bd809..862818b291bd --date=short --first-parent --format='%ad %ae %s' 2020-03-21 reed@google.com add --skvm and '!' to viewer to toggle using skvm blitters Created with: gclient setdep -r src/third_party/skia@862818b291bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: egdaniel@google.com Change-Id: Ic24704950bb1195464c3001e081a69027dc276ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114162Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cf3594b60362..bd1db41bd809 git log cf3594b60362..bd1db41bd809 --date=short --first-parent --format='%ad %ae %s' 2020-03-21 reed@google.com Add gm to test HSL modes, esp. with src-alpha 2020-03-21 brianosman@google.com In GrDrawVerticesOp, don't allow CPU xform with perspective matrices Created with: gclient setdep -r src/third_party/skia@bd1db41bd809 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: egdaniel@google.com Change-Id: I665dee51093303fbaaaf766b5b86e4c4958bfd31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114158Reviewed-by:
-
chrome://conflictsPatrick Monette authored
Since chrome://conflicts is a internal debug page, it isn't localized so it doesn't make sense to change the direction depending on the locale of the user. Bug: 1051803 Change-Id: I53fd3fe4e9b4f16fbb108306cdb130ce40bf0ca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110811 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Auto-Submit: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#752312}
-
Xianzhu Wang authored
If an iframe has direct compositing reason, then prefer composited scrolling for the content LayoutView. Change-Id: Id257a5253ad792a4fc2acec8860940a612bc43f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107612Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#752311}
-
Rakib M. Hasan authored
The wpt runner uses metadata files to get test expectations. In the chromium repository we use test expectation files. This CL will translate the test expectation files into WPT metadata before running wpt on Android. TBR=lpz@chromium.org Bug: 1050754 Change-Id: I3c2ed6dc9b793242076ea2aa8fe617989928ec1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070826Reviewed-by:
Rakib Hasan <rmhasan@google.com> Reviewed-by:
Andrew Luo <aluo@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#752310}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2e8115324d66..4b65869002d1 Created with: gclient setdep -r src-internal@4b65869002d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I877e83341dd2c617beaa187091032e763134c754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114154Reviewed-by:
-
