- 20 Nov, 2018 40 commits
-
-
Jan Lamecki authored
View suffix doesn't make sense as it is not an Android view. I'm planning to introduce view showing CastWebContents, so freeing the name before makes sense. Also added @ColorInt to document what is expected encoding of argument. Bug: None. Change-Id: Ie8079383180801a37453ed8784085472d48345ad Reviewed-on: https://chromium-review.googlesource.com/c/1333468Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Jan Lamecki <jachor@google.com> Cr-Commit-Position: refs/heads/master@{#609638}
-
Sergio Villar Senin authored
It was using both SigninManager and ProfileOAuth2TokenService fake objects injected in the profile to signin the user with a refresh token. The IdentityTestEnvironmentProfileAdaptor could be used to create the testing profile followed by IdentityTestEnvironment::MakePrimaryAccountAvailable() to perform the signin. Bug: 882864 Change-Id: I6d546a722a0eda4f3d14d6234d819a3964c7d92e Reviewed-on: https://chromium-review.googlesource.com/c/1338107Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Elijah Taylor <elijahtaylor@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#609637}
-
Sam McNally authored
The paper-ripple elements use up and down events to decide whether to render a ripple. Allowing these events to propagate through the eject button causes both the button and the directory tree item to ripple, instead of just the eject button. Bug: 671987 Change-Id: I3fb9f6c1c1f1694810a497f967ec73378ba0e223 Reviewed-on: https://chromium-review.googlesource.com/c/1343871Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#609636}
-
Corentin Wallez authored
BUG=chromium:901830 Change-Id: I8cea07cc08ca559014cf68d75f4eef65a838efb0 Reviewed-on: https://chromium-review.googlesource.com/c/1341844Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#609635}
-
Sam McNally authored
Querying the board from the files app is only used for deciding which Drive promo to display: specifically, whether the board is link, which is now AUE. This is now unnecessary so remove it. Bug: 906983 Change-Id: Ia98c9e96b81609fdacd46a4d464da18a6cbd1fdc Reviewed-on: https://chromium-review.googlesource.com/c/1343591Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#609634}
-
Kai Ninomiya authored
Change-Id: I96a41c6b41f9094f704bc25193b53e6582669a68 Reviewed-on: https://chromium-review.googlesource.com/c/1343188Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#609633}
-
Yuta Kitamura authored
This CL tries to fix the test flakiness in gcm_unit_tests by using the mock NetworkChangeNotifier in tests, which avoids receiving real network status changes. Bug: 906769 Change-Id: I08227a6f303328fe2f44cecc84c0ea64bd145415 Tbr: rmcelrath@chromium.org Tbr: dimich@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1343592Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#609632}
-
Ben Wells authored
This should make debugging failing default and policy installs simpler. Bug: 906911 Change-Id: Ia8e893925d6d4d6b75acb1c1e23aef816f198d8a Reviewed-on: https://chromium-review.googlesource.com/c/1343579 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#609631}
-
Joel Hockey authored
Currently we only enter check select mode if 2 or more files are selected as part of select-all. This is now changed so that we always enter check select mode even if only a single file is selected. Bug: 903253 Change-Id: I15d05ea19570d7c83cfd77f20afa1370301b8b2a Reviewed-on: https://chromium-review.googlesource.com/c/1343586 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#609630}
-
Christian Dullweber authored
The SiteDataDeleteHelper in WebsiteSettingsPreferences is only used to delete cookies but creates a CookiesTreeModel for various data types. Instead, we can use CookieManager directly to fetch and delete cookies. Bug: 883701 Change-Id: I08efb5d1e4d96902c9f018ca673a019f1334d2a8 Reviewed-on: https://chromium-review.googlesource.com/c/1337617Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#609629}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a7460b8ab937..ed5a8caf60cf Created with: gclient setdep -r src-internal@ed5a8caf60cf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:904912 TBR=mmoss@chromium.org Change-Id: I2580d196491529946d11bce37742496819ff09a2 Reviewed-on: https://chromium-review.googlesource.com/c/1342784Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609628}
-
Michael Lippautz authored
Change-Id: Idc50ffc3633d48d703fb3abbc4d2de87b3c2ecb7 Reviewed-on: https://chromium-review.googlesource.com/c/1342617Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#609627}
-
Yuta Kitamura authored
This reverts commit 493db4b2. Reason for revert: Compile error on win-rel builder. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-rel/6451 Original change's description: > media/gpu/test: Initial version of the Test Video player. > > The test video player is created to improve the way VDA (video decode > accelerator) tests are created, and to allow more control of the test flow. > > This is an early prototype, that only supports playing a video from start to > finish. More complex tests and their required functionality will be added soon. > > TEST=ran new VDA tests on eve and kevin > > BUG=879065 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: Ida7396e7294c0e367417c352284e4a601daa0cba > Reviewed-on: https://chromium-review.googlesource.com/c/1179484 > Commit-Queue: David Staessens <dstaessens@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Alexandre Courbot <acourbot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609622} TBR=posciak@chromium.org,sandersd@chromium.org,tikuta@chromium.org,hiroh@chromium.org,acourbot@chromium.org,keiichiw@chromium.org,dstaessens@chromium.org Change-Id: Ic6ba5ba69c6ebae256d0e39d1b3af739e47b75da No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 879065 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1343870Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#609626}
-
Zhiqiang Zhang authored
This CL adds unit test for CafMediaRouteProvider. Also to clean up, the provider reads the sink directly from the session controller when onSessionStarted(). Bug: 711860 Change-Id: I9c4001bc4d6a59f764b71bf90f9fd96761454963 Reviewed-on: https://chromium-review.googlesource.com/c/1339461 Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#609625}
-
Yuki Shiino authored
It seemed like that there were cases that BindingSecurity didn't throw an exception although BindingSecurity::ShouldAllowAccessToXxx returned false. This patch makes BindingSecurity always throw an exception when it returns false. Also, BindingSecurity reports an error (print an error message) as best effort. This patch also supports the case that remote_object->CreationContext() returns the empty handle. Change-Id: I155f975af3c5d93f27ccb7e0ca0eb8d5bdc8d403 Reviewed-on: https://chromium-review.googlesource.com/c/1341785Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#609624}
-
Marc Treib authored
SyncUserSettings is a new class that encapsulates all the user-configurable knobs for Sync. It replaces a bunch of setters and getters directly on the SyncService. Bug: 884159 Change-Id: Ic69d65e6f4a2f6e74f8ca0fd3954aaf78b0992fa Reviewed-on: https://chromium-review.googlesource.com/c/1338100Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#609623}
-
David Staessens authored
The test video player is created to improve the way VDA (video decode accelerator) tests are created, and to allow more control of the test flow. This is an early prototype, that only supports playing a video from start to finish. More complex tests and their required functionality will be added soon. TEST=ran new VDA tests on eve and kevin BUG=879065 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ida7396e7294c0e367417c352284e4a601daa0cba Reviewed-on: https://chromium-review.googlesource.com/c/1179484 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#609622}
-
Sam McNally authored
Bug: 906969 Change-Id: I4412d79d9017ccaa13b7fcddd94f685a1d3ad10d Reviewed-on: https://chromium-review.googlesource.com/c/1343869Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#609621}
-
John Abd-El-Malek authored
Bug: 899268 Change-Id: Ie7ef8692828631894bf18bbb5272747ad543b55f Reviewed-on: https://chromium-review.googlesource.com/c/1341070 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#609620}
-
Zhuoyu Qian authored
This CL rename the enum class to FileErrorCode and move it out of the namespace file_error. Change-Id: I39ee10e35bbdcf0b3b0efdda159e21b255e477b1 Reviewed-on: https://chromium-review.googlesource.com/c/1328628Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#609619}
-
Martin Kreichgauer authored
This adds an |is_u2f_only_| field to CtapMakeCredentialRequest to make authenticators aware whether the current request originates from the cryptotoken (U2F) extensions. If it does, request handling changes as follows: - For Windows API requests, U2F-only mode is enabled. - FidoDeviceAuthenticators will only communicate via U2F, not CTAP. This is done to force the authenticator return a U2F-format attestation statement, rather than one in an (incompatible) CTAP2 format such as "packed". GetAssertionTask already implements a U2F fallback for all requests with an App ID extension (and CTAP need not be strictly avoided as is the case with MakeCredential); thus no separate boolean field is required for CtapGetAssertionRequest. Bug: 898718 Change-Id: I8f17655d8df530546b62e2237c73aaa997483060 Reviewed-on: https://chromium-review.googlesource.com/c/1338952 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#609618}
-
Sergei Datsenko authored
I still don't know what I'm doing, but I'm getting better at it. BUG=chromium:688895 Change-Id: Ia05a3506844b888579f4353c02b09b3bf4b95edd Reviewed-on: https://chromium-review.googlesource.com/c/1341732Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#609617}
-
Yuta Kitamura authored
Bug: 906952,906879 Change-Id: I0c7bec172a28b37c8b8c3c8e33c7e2f1630d8404 Tbr: kolos@chromium.org Tbr: pavely@chromium.org Tbr: hongjunchoi@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1343475Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#609616}
-
Tetsui Ohkubo authored
The condition in ArcImeService::RequestHideIme() didn't properly recognize if ARC++ window is focused. TEST=manual BUG=b/65635084 Change-Id: Ia8edb44af403e2ddafad17fbae90704919ffb21c Reviewed-on: https://chromium-review.googlesource.com/c/1343470Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#609615}
-
Kent Tamura authored
Add back nullptr check to FormData::Create(HTMLFormElement*). This CL fixes a regression caused by crrev.com/609210. According to standards, |new FormData(nullptr)| and |new FormData("string")| should throw TypeErrors. However this CL applies the behavior before crrev.com/609210. Bug: 906649 Change-Id: I78aa53559592ef0e14cc941175dc9f1b44342bb0 Reviewed-on: https://chromium-review.googlesource.com/c/1343414Reviewed-by:Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#609614}
-
Kent Tamura authored
CustomElement::Registry() can return nullptr. Bug: 906704 Change-Id: I5f3f87266526c97489b658668e15a38069fef033 Reviewed-on: https://chromium-review.googlesource.com/c/1343412Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#609613}
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I5b2f42d82e87042856980e112adf0381c9b6d4db Reviewed-on: https://chromium-review.googlesource.com/c/1341778 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#609612}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f85b6d24e13b..50b8426648f3 git log f85b6d24e13b..50b8426648f3 --date=short --no-merges --format='%ad %ae %s' 2018-11-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2f3cca90..7d53bc24 (609431:609559) Created with: gclient setdep -r src/third_party/webrtc@50b8426648f3 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibc410dc84870658aecc0af57499611c974e222d8 Reviewed-on: https://chromium-review.googlesource.com/c/1342842Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609611}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b01ce5fdb532..a7460b8ab937 Created with: gclient setdep -r src-internal@a7460b8ab937 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9fb29b2277d1925194d268df1e39985b5b33d72a Reviewed-on: https://chromium-review.googlesource.com/c/1343187Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609610}
-
Hiroshi Ichikawa authored
Also fix pointers commented as (weak) but were actually strong references. Change-Id: Ib3b72b7d94caee4ae8e3fcb125909e27cd8310fe Reviewed-on: https://chromium-review.googlesource.com/c/1331290Reviewed-by:
John Wu <jzw@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#609609}
-
Hiroshi Ichikawa authored
Sync on //ios/web_view only works for credit cards now anyway, but I want to make sure that we don't accidentally enable other data types in the future until we are ready. Change-Id: I5df9e1a706c3816eb222ba81c6e09ecbe354a0ce Reviewed-on: https://chromium-review.googlesource.com/c/1343403Reviewed-by:
John Wu <jzw@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#609608}
-
Minh X. Nguyen authored
This would allow us to have more time to analyze the Finch experiment of the new extension updater. Otherwise, these UMAs will expire in 2 weeks from today. Change-Id: Ia52694e283bc4dc718661ba0d1cb46cb5b9811b5 Bug: 899951 Change-Id: Ia52694e283bc4dc718661ba0d1cb46cb5b9811b5 Reviewed-on: https://chromium-review.googlesource.com/c/1334196Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Minh Nguyen <mxnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#609607}
-
Sergei Datsenko authored
If we select several files some of which are pinned and some not, show overall state as unpinned as it's less confusing. BUG=chromium:875473 Change-Id: I2d1cfe6b901b39bf2f20a8d1c766c405df22c565 Reviewed-on: https://chromium-review.googlesource.com/c/1343467Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#609606}
-
Victor Costan authored
https://crrev.com/c/1338177 relaxed the DCHECKs for sql::Database::GetCachedStatment by allowing the SQL statement argument to have leading and trailing whitespace when compared with the SQL statement reported by SQLite. This CL reverts the relaxed restriction. Instead, GetCachedStatement will also DCHECK that the SQL statement argument matches the SQL statement reported by SQLite when preparing the statement. This will help developers discover non-canonical statements on first use. Bug: 894884 Change-Id: I166f8cda8d5a3980d9858a26507f778bc87ee6cc Reviewed-on: https://chromium-review.googlesource.com/c/1341493 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#609605}
-
Yan,Shaobo authored
This patch implement a WebGL draft extension: WEBGL_video_texture. This extension will bring a new type of texture for WebGL and can share the video frame to WebGL texture directly. This should reduce on blit operation and should have performance improvement for uploading video to texture. Bug: 776222 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id052010bb726c328b0362c28d2486ce1986cc6e2 Reviewed-on: https://chromium-review.googlesource.com/c/1235335 Commit-Queue: Shaobo Yan <shaobo.yan@intel.com> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#609604}
-
Stuart Langley authored
Convert metadata_cache_item_unittest.js to be closure compiled. - Remove html file that is not auto generated. - Fix closure errors in the unittest file. As MetadataCacheItem requires a MetadataItem to be a parameter most of the unit test code needed to be re-written to use this type. No change in behaviour. Bug: 906919 Change-Id: Id903f8bec90abfa5256acb45d5eb3c3640d31acb Reviewed-on: https://chromium-review.googlesource.com/c/1343413 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#609603}
-
Alice Boxhall authored
This is showing up as a crash in AXNodeObject::TextAlternative(), which calls ComputedName() on each <option>'s accessibleNode. Bug: 905091 Change-Id: Ib3139b08e46eacd51a9f3e1cc6e376d9b6ab3d5d Reviewed-on: https://chromium-review.googlesource.com/c/1343398 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#609602}
-
Christopher Lam authored
This CL update MD Bookmarks to use async/await where appropriate. Bug: 905927 Change-Id: Ie428db7f543d16dd3b4203892e9f56cadf69ab73 Reviewed-on: https://chromium-review.googlesource.com/c/1339086Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#609601}
-
Peter Kasting authored
This was only used in two tests, and the static registration in one of them caused test failures when running multiple tests in the same process. Instead just get the test data path directly. Bug: none Change-Id: If1ece730314e4632bbb25d0524a480fc943c7fbc Reviewed-on: https://chromium-review.googlesource.com/c/1343503Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#609600}
-
James Hawkins authored
R=hansberry@chromium.org Bug: 903991 Test: none Change-Id: Ieb31e3458eccdf3ec168461a884bc7f8cdaee9d8 Reviewed-on: https://chromium-review.googlesource.com/c/1340682 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#609599}
-