- 30 Sep, 2020 40 commits
-
-
Shakti Sahu authored
Bug: 1132703 Change-Id: I603a02f5243c173fa88c2cb21d7f94b672638d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434551 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812204}
-
Siye Liu authored
We should call |ITfThreadMgr::SetFocus| to notify input service about focus change even if the input type has not changed. This issue is introduced by crrev.com/810350. Bug: 1133474 Bug: 1124612 Change-Id: I219fb624fb649b870bc081fbdac56373c1102d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438478Reviewed-by:
Siye Liu <siliu@microsoft.com> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#812203}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //build. Bug: 1113033 Change-Id: I9cf7592a3247c2a25990768644f7a699f2dac80c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438475Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#812202}
-
Xida Chen authored
TBR=jianli@chromium.org NOTRY=true Bug: 1133770 Change-Id: I02d7060cfb3049e4ac8f9b2ef930456491756ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441291Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#812201}
-
Siyu An authored
After discussion, we will stick to the GURL implementation for merchant domain. Therefore add missing logic to in offer data setter and validation checker regarding merchant domain Bug: 1112095 Change-Id: I60d021c034e68646720414bb808db3eaa46f6296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434466 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#812200}
-
Chris Sharp authored
WebUsbBlockedForUrls was removed a while ago so we don't need to mention it. Change-Id: I15e5b9cae7847867e07c8fc81491c464f59e2df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440848Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#812199}
-
Lei Zhang authored
Prior to this CL, chrome_pdf::RenderPDFPageToBitmap() always rendered PDFs for printing. With this new option, let the PDF Thumbnailer render PDFs for display. Bug: 903742 Change-Id: I708b83f449239ee147da818eecb419cc33be7b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430804 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#812198}
-
Ehimare Okoyomon authored
Add an observer for SingleWebsiteSettings. Implement the callbacks to record metrics and tell the PageInfoController to update permissions. Bug: 1077766 Change-Id: I2d4f9d234b66a312372cf68e5d9f9a2cd49af798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431665Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#812197}
-
Caleb Raitto authored
Bug: 973801 Change-Id: Ia2095b57b5d23f429a33cd99c00d0e90054082b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438480Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#812196}
-
Jesse Schettler authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/adefd526720b..d5ad6a50d168 $ git log adefd5267..d5ad6a50d --date=short --no-merges --format='%ad %ae %s' 2020-09-28 fletcherw lorgnette: pass source_name in ScanSettings 2020-09-14 clarkchung system_api,runtime_probe: add pci_subsystem in network fields Created with: roll-dep src/third_party/cros_system_api Change-Id: Ia268dfcc5c6a08ec950684c732bed0f4ee152681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439964 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#812195}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/26525f46199d..5b238b2e5f6e 2020-09-30 janscheffler@chromium.org [WebAuthn] Fix tab order 2020-09-30 aerotwist@chromium.org [ts] Type-check Help with TypeScript Compiler 2020-09-30 janscheffler@chromium.org [WebAuthn] Add continuation dots for length names 2020-09-30 sigurds@chromium.org Make load-through-target configurable 2020-09-30 wolfi@chromium.org Dark theme improvements for issues panel 2020-09-30 aerotwist@chromium.org [ts] Type-check HeapSnapshot.js with TypeScript Compiler 2020-09-30 szuend@chromium.org [ts] Type-check media/PlayerListView.js with TypeScript 2020-09-30 wolfi@chromium.org Correctly handle multiple frames with same URL in frame tree 2020-09-30 szuend@chromium.org [ts] Type-check media/EventTimelineView.js with TypeScript 2020-09-30 jec@google.com Update What's New UI for Chrome 87 2020-09-30 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1069378,chromium:1122511 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I978e2f7ab69cdb66d3adbdb6634609606f73516b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440466Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812194}
-
Michael Checo authored
Screenshots: - Diagnostics App (before) http://shortn/_DpVL35bnh7 - Diagnostics App (after) http://shortn/_xR51HdiefI Bug:1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ib16a145c3ef03fcf82b8e0ed2e6474671987e3a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436810 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#812193}
-
Eric Roman authored
Change-Id: Ic9d1afe2f1494c3a9e8c5aa2737e51ea7d029051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440850 Auto-Submit: Eric Roman <eroman@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#812192}
-
Avi Drissman authored
Bug: 1099072 Change-Id: I04279a29202f217a5ed838af9319874a3adb63b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438876 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#812191}
-
Scott Little authored
This CL adds support for overriding the translate language blocklist and the URL host blocklist (each behind separate flags) when a link is clicked that has hrefTranslate set. Each of these flags also supports a parameter to indicate how much behavior should override these blocklists: just the behavior of showing the translate UI, or the automatic translation behavior as well. Bug: 1131240 Change-Id: I1b4912ed1e369b04f1d326255c1a77763d825c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425085 Commit-Queue: Scott Little <sclittle@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#812190}
-
Roberto Moura authored
When the currentState is Peeked and a transition starts, if the user switched direction (from Revealed to Hidden and from Hidden to Revealed again), the layout switcher's collection view would start a new transition when one already existed: `'NSInternalInconsistencyException', reason: 'the collection is already in the middle of an interactive transition'` Create a bool property |layoutBeingInteractedWith|, which is YES when the user is scrubbing a layout transition. The layout transition progress is only updated if this property is YES. Create a bool property |gesturesEnabled|, which is set to NO when a pan gesture ends and set to YES when a gesture begins and |layoutInTransition| is NO. This is to prevent a gesture from being recognised if it starts while the layout is already transitioning but changes or ends after the layout transition is over. If that were to happen, the viewRevealngVerticalPanHandler would fail to notify the animatees that a view reveal would take place. Bug: 1130037, 1127604 Change-Id: Ifc5eb40843673ab3ce663ed23a3b2f8cf18d9564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421741Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Roberto Moura <mouraroberto@google.com> Cr-Commit-Position: refs/heads/master@{#812189}
-
Dan McArdle authored
This fixes a fuzzer-discovered integer overflow. The modified line was attempting to compute (1 - -2147483648). Bug: 1133024 Change-Id: I5193e61fe3a144cce760b836d41e6d802eaccd14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437483Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#812188}
-
Frank Li authored
- Added SandboxType::kMediaFoundationCdm and its corresponding sandbox switch of "mf_cdm" for the creation of MF Cdm LPAC Utility process. - SandboxWin::IsAppContainerEnabledForSandbox() is updated to opt-in SandboxType::kMediaFoundationCdm to be created as AppContainer process. - In SandboxWin::StartSandboxedProcess(), the MF Cdm is added with policies and LPAC capabilities to allow existing Windows platform compoenents to work properly. More details can be found in this doc: https://docs.google.com/document/d/19Y4Js5v3BlzA5uSuiVTvcvPNIOwmxcMSFJWtuc1A-w8/edit#heading=h.iqvhsrml3gl9 Bug: 999747 Change-Id: I8e0a0febb20b697c5631cf2561429305bf47b2e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401506 Commit-Queue: Frank Li <frankli@microsoft.com> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#812187}
-
Peter Kasting authored
Bug: 772945 Change-Id: Id3a3397a84cb630bb8f51b69bc9faad3dab76fe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438850Reviewed-by:
Angela Yoeurng <yoangela@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#812186}
-
Michael Checo authored
Screenshots: - Diagnostics App (before) http://shortn/_F7krCJQK2W - Diagnostics App (after) http://shortn/_D86kuHAMy8 Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I36218799b5f7574e54947dd894c92724ccc56c36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438710 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
-
Victor Hugo Vianna Silva authored
The Directory doesn't exist anymore, so this CL updates references [1] to it across the Sync codebase. For code that's already scheduled for cleanup, the CL just adds TODOs pointing to the corresponding bugs. [1] https://source.chromium.org/search?q=f:(components%7Cchrome).*sync%2F%20case:yes%20comment:Directory%20-f:%5Eout Bug: None Change-Id: I134fe4abe0a3d8e669686fed71d374da7be6f69c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440869 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#812184}
-
Xida Chen authored
[sheriff] Disable AutofillAssistantChromeTabIntegrationTest#interactingWithLocationBarHidesAutofillAssistant TBR=jianli@chromium.org NOTRY=true Bug: 1131835 Change-Id: I43caed398441d1eb9c39eb69742d6a8dc67ad40b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441312Reviewed-by:
-
Xida Chen authored
TBR=jianli@chromium.org NOTRY=true Bug: 1131836 Change-Id: Ia9cf8cf32287b70b75d42e27c0fff9baece5a7bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441315Reviewed-by:
-
Arthur Hemery authored
The crossOriginIsolated boolean is now implemented and we are enabling it by default. Intent to ship thread: https://groups.google.com/a/chromium.org/g/blink-dev/c/ZzngHwf2qyQ BUG=1018680 Change-Id: I6215a33bf90ae64ce89ac852309f99315d1a8fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424091Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#812181}
-
Xida Chen authored
TBR=jianli@chromium.org NOTRY=true Bug: 1131455 Change-Id: Icb7efcdebfc9335a9538915c88ec80bee7068031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441272Reviewed-by:
-
Keren Zhu authored
According to IPH UX spec, the text IPH bubble should always be white regardless of dark mode. This cl fixes the issue that the text in buttons will be greyed out in dark mode. Bug: 1121399 Change-Id: I3c0fdff07a3a3761787cfe8ad230fab729da9b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437731 Auto-Submit: Keren Zhu <kerenzhu@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812179}
-
Keren Zhu authored
This change is essential to add Builder support for MatchCountLabel. This is part of the effort to use View Builder in ToolBarView. Bug: 938501 Change-Id: I676932a568120d4350e642ba479bf67e272a0686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436281 Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#812178}
-
Ali Juma authored
This enables committed interstitials and hash-based Safe Browsing by default on trunk. Bug: 1034113, 1043382 Change-Id: Id5e08ddd24d6f693bb06ba189ae000be91bdedc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436350Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#812177}
-
Piotr Tworek authored
This is something I've found while running Vewd internal test suites on top of chromium 86.0.4240.x. I haven't managed to reproduce this on content_shell but since I believe I do understand the root cause pretty well I can say this also potentially affects chrome. What is also interesting about this is the fact that the test case which reproduced this quite consistently stopped doing so when using ASAN enabled build. This leads me to believe there has to be some timing factor involved here. As far as I can tell this was introduced recently by commit 4b7b3265, "Convert SyncHandleRegistry to use a CallbackList". The problem happens sometimes when SyncEventWatcher is destroyed. If we look at the declaration of this class we may notice that its registry_ member variable will be destroyed before subscription_. (NOTE: SyncEventRegistry::EventCallbackSubscription is a typedef to SyncEventRegistry::Subscription). The instance of Subscription is created in SyncEventRegistry::RegisterEvent. This function, among other things, creates binding for "remove_closure" lambda function. This binding stores a raw pointer to a EventCallbackList which is a raw pointer to a unique_ptr value stored in SyncHandleRegistry::events_. Given this information we can have the following scenario when the SyncEventWatcher is destroyed: 1. SyncEventWatcher DTOR calls SyncEventRegistry DTOR. 2. SyncEventRegitry DTOR destroys its member variables and among them events_ which destroys all the EventCallbackList values storred in this map. 3. SyncEventWatcher DTOR calls SyncHandlerRegistry::Subscription DTOR which in turn calls its remove_runner_ closure we created in SyncHandleRegistry::RegisterEvent. 4. The remove closure function (lambda function defined in SyncHandleRegistry::RegisterEvent) tries to use EventCallbackList (first argument, stored in a binding) we destroyed in step 2 leading to a use-after-free bug. The simplest fix is to reorder registry_ and subscription_ variables in SyncEventWatcher to ensure the registry is always destroyed after subscription. Bug: 1133668 Change-Id: I35be7818b184308ccfb7a01895062de087233abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438399 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
Irina Fedorova authored
This CL updates the UI in of the Password Check page and adds the "Check again" button for signed out users. It also adds a new message for users in the compromised section to indicate that passwords weren't checked for compromise because the user is signed out. Screenshots of the Password Check page after adding support for signed out users: https://bugs.chromium.org/p/chromium/issues/detail?id=1119752#c19 Bug: 1119752 Change-Id: Ie06f34050dbbe33ceca030936cfccf1674c15938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426502Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Irina Fedorova <irfedorova@google.com> Cr-Commit-Position: refs/heads/master@{#812175}
-
Ian Clelland authored
With an upcoming change to Feature/Permissions Policy, the header alone will no longer be sufficient to delegate permissions to use powerful features in subframes. The iframe allow attribute must be used in conjunction with it. The header can still be used to block delegation. This change updates the permission delegation unit tests to use the allow attribute when delegating permissions to cross-origin frames. Bug: 1095641 Change-Id: I47d6ab6ed04fdc75b2a7f51581f7213f6411cf89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424635Reviewed-by:
-
Joe DeBlasio authored
This CL changes what domains we consider for the lookalike interstitial. Previously, if Chrome saw a navigation that looked like A -> B -> C -> D (where site A is redirecting to B, etc.), the lookalike logic would inspect each stage, A through D, for lookalikes. It accomplished this by implementing DidRedirectNavigation() and DidFinishNavigation(). This added a bunch of complexity, but allowed us to stop a navigation mid-redirect. This CL changes that behavior to wait until the entire redirect chain has completed, and then inspect only sites A and D. These domains are the only ones visible to the user, and thus the only ones wherein a lookalike URL might be effective. This change also means that we no longer implement DidRedirectNavigation(). Bug: 1092690 Change-Id: I2cfa724b9793b60dd5200d1bf6847cc6919fa469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438888Reviewed-by:Livvie Lin <livvielin@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#812173}
-
Trent Begin authored
There are certain arm devices that do not populate the model name of the CPU in sysfs. This change makes the model_name field optional to reflect this. Bug: chromium:1132875 Change-Id: I7f8c814bf77c22cc7f7ca6f482d37f46097a4335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436383Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Commit-Queue: Trent Begin <tbegin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812172}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f7bee82a..b531fa82 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6f882a5cf5c01ed13c43f74b6380b37b8e721a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440237Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812171}
-
Eric Roman authored
This aligns with the best practices in the "Web Platform Team Bug SLOs" document. NOTRY=true Change-Id: If7a1116526f581fa79182c7f287baa3c2b0d6c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440196 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
-
Paula Vidas authored
This is needed for the field to show up chrome://sync-internals. Bug: 1082115 Change-Id: I94c59365486bcf3a30f5e57d171351fcbba8e181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440580Reviewed-by:
Rushan Suleymanov <rushans@google.com> Reviewed-by:
-
danakj authored
The Convert*ToDIP() and Convert*ToPixel() functions are problematic in that they hide what decision is being taken in the underlying code when moving from floating point to integer, and consumers should be thinking about what they want for correctness. They also act in inconsistent ways when converting a Rect vs its components. This removes the functions that perform float->int conversions in order to have callers show what they intend to happen and make it clear that data is being lost in some fashion. R=sky@chromium.org Bug: 1130050 Change-Id: I042735e7cc761da1a581ddb7b909bbedf4bd86be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429143 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Xida Chen authored
This reverts commit cd9c0f48. Reason for revert: Test is failing: https://ci.chromium.org/p/chromium/builders/ci/Cast%20Audio%20Linux/86822 Original change's description: > Record if the navigation's initiator is available. > > In NavigationRequest::BeginNavigation(), records whether the > navigation's initiator can be found using its ID or not. > > We suspect not finding it is a very rare event. This histogram will help > us figure out what kind of solution should be used to support > PolicyContainer for this edge case. > > Bug:1129416 > > Change-Id: I501bf0150935679667d5bd2a4cc351a70b6653ab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416450 > Reviewed-by: Camille Lamy <clamy@chromium.org> > Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Antonio Sartori <antoniosartori@chromium.org> > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812124} TBR=isherman@chromium.org,clamy@chromium.org,arthursonzogni@chromium.org,pmeuleman@chromium.org,antoniosartori@chromium.org Change-Id: I11e26c0b5c69063ebcb2e5bac8a5a09eb2202467 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1129416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440263Reviewed-by:
-
Sylvain Defresne authored
Instead of abusing set_sources_assignement_filter, use the two gn function filter_{exclude,include} to partition the list in two. Expected to be a no-op change. Bug: 1018739 Change-Id: If6d5e2d8c300358bb31b8773d629cdb95f09421b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440583 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#812166}
-
Xida Chen authored
TBR=jianli@chromium.org NOTRY=true Bug: 1131373 Change-Id: I2260778f2cdcee94665c33ec12cb8971d333c204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441111 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#812165}
-
