- 23 Aug, 2018 40 commits
-
-
Scott Little authored
Failing test: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-intrinsic-ratio-003v.html TBR=atotic@chromium.org Bug: 877183 Change-Id: If695ba1ac593ab265b72a9f0f09ec6ed987231ad Reviewed-on: https://chromium-review.googlesource.com/1187376Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#585619}
-
Michael Thiessen authored
Not sure if this was ever used - the CL that added it didn't make use of it, and nothing currently uses it. Change-Id: I9be36d1e36b088790c155ff95147357df10829f4 Reviewed-on: https://chromium-review.googlesource.com/1186550Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#585618}
-
Mohsen Izadi authored
These fields are not used on other platforms; so there is no need to send them: - |max_page_scale_factor|; - |root_layer_size|; - |root_overflow_y_hidden|. Note that |min_page_scale_factor| is used on Mac. BUG=859969 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I27d23f9b32e93805ab204b44a0999fb0c72e585f Reviewed-on: https://chromium-review.googlesource.com/1158856Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585617}
-
Xiyuan Xia authored
- kEmbedFlagEmbedderInterceptsEvents is not yet supported for ServerRemoveViewHost embedding. Change it to a DCHECK. - Use AppListEventTargeter for mash card like in classic ash. Bug: 812434 Change-Id: Ie2a952b6e60b66c4f87855fc85313505d0586a2b Reviewed-on: https://chromium-review.googlesource.com/1187185Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#585616}
-
Vikas Soni authored
This is a reland of dd9f811b with a bug fix for Bug: 875121 Original change's description: > Add support for reporting EGL Timestamps via > presentation feedback. > > This CL adds support for reporting egl_composite_interval and > presentation_time via the presentation feedabck. > GLSurfacePresentationHelper uses the new interface > EGLTImestampClient to query the egl timestamp info. > > Bug: 790761 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I7e1f3200bba41bf3252b8acedc68393eeeb76df5 > Reviewed-on: https://chromium-review.googlesource.com/1106600 > Commit-Queue: vikas soni <vikassoni@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583360} Bug: 790761 Change-Id: I498cde154a1926b61b683ad27f984d9552385146 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1185441 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#585615}
-
Reilly Grant authored
Somehow these changes didn't make into the last patchset uploaded for r581994 and so I have recreated them here. Change-Id: I54cf951d46ad12c23433996dee790ce25047c8a5 Reviewed-on: https://chromium-review.googlesource.com/1187020Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#585614}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a7fb87b3a3d1..7a1ed44d248a git log a7fb87b3a3d1..7a1ed44d248a --date=short --no-merges --format='%ad %ae %s' 2018-08-23 chiniforooshan@chromium.org Telemetry: fix a rendering benchmark failure Created with: gclient setdep -r src/third_party/catapult@7a1ed44d248a The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:877056 TBR=sullivan@chromium.org Change-Id: Ie77f89090cb2e0537baf011a3351c19f89e8c575 Reviewed-on: https://chromium-review.googlesource.com/1187341Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585613}
-
Sahel Sharify authored
This reverts commit 2e954351. Reason for revert: "fast/frames/crash-frameset-CSS-content-property.html" is flaky example failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/171496 Original change's description: > Fix fast/frames/crash-frameset-CSS-content-property.html > > This test switches a <frameset> to a <body>. For framesets, LayoutView::CalculateScrollbarModes > forces the user scrollable bit to be false. So, we need to make sure to call > LayoutView::SetNeedsPaintPropertyUpdate when the LayoutView's child changes to/from a frameset. > > > Bug: 875287 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > > Change-Id: I5ae0a7673ae8e325242465633749ffcd76ca705f > Reviewed-on: https://chromium-review.googlesource.com/1186181 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585493} TBR=pdr@chromium.org,chaopeng@chromium.org Change-Id: Ibbfd46388eedd04af20242e4c87413880b9d9718 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 875287, 877210 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1187283Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#585612}
-
Scott Little authored
This reverts commit be51aadb. Reason for revert: Looks like this caused a test to start flaking, https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/12367 Original change's description: > Consistent touchpad pinch behaviour for app windows and webviews > > Currently, app windows (possibly containing webviews): > 1) suppress all pinch events which also suppresses the > synthetic wheel event, but not touchscreen touch events, and > 2) allow "smart zoom" on Mac which can change the page scale even > though other means of changing the page scale are suppressed. > > As a result of (1), if we have, say, google maps in a webview, a > user can pinch zoom with a touchscreen, but not with a touchpad. > > We now suppress gesture events to app windows based on whether they > cause a scale change. So now touchscreen and touchpad pinching are > consistent since the page has access to the events so that it may > implement custom pinch zoom behaviour, but unhandled events still > do not result in a scale change for the app window. Also, smart > zoom is suppressed to be consistent with other touchpad pinching. > > Bug: 725970, 874132 > Change-Id: I03dd2048002d69dc7c8a822fc727140c67d64706 > Reviewed-on: https://chromium-review.googlesource.com/1174933 > Reviewed-by: Ben Wells <benwells@chromium.org> > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> > Commit-Queue: Kevin McNee <mcnee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585489} TBR=benwells@chromium.org,ekaramad@chromium.org,wjmaclean@chromium.org,mcnee@chromium.org Change-Id: I3a717517c60bbe22bbb3b93c64bea107ef191a5a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 725970, 874132 Reviewed-on: https://chromium-review.googlesource.com/1187167Reviewed-by:
-
Sahel Sharify authored
Failure example: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/9598 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 873045 Change-Id: I97f130469c20017f4fb4d336845bf89195729b1e Reviewed-on: https://chromium-review.googlesource.com/1187126Reviewed-by:
-
Michael Thiessen authored
More unused test threading code... Change-Id: I142035ceaa8b7f3126f5c375b12c0356d2d6eb40 Reviewed-on: https://chromium-review.googlesource.com/1186552Reviewed-by:
-
Scott Little authored
This CL makes the Data Reduction Proxy bypass logic get applied to a response that has the Data Reduction Proxy Via header even if the response didn't seem to come from a configured Data Reduction Proxy. This same workaround was previously present in Chrome, but removed in https://chromium-review.googlesource.com/c/chromium/src/+/1040827. This CL re-adds it since it turns out it's still necessary in some cases, see the bug for more details. Bug: 876776 Change-Id: I0bb9a4f8018c9f21c056f169fb934bc08d37f139 Reviewed-on: https://chromium-review.googlesource.com/1186123Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#585608}
-
gogerald authored
Also implements ElementExists interface. Should put these files in a shared place if there are other components want to use them. Bug: 806868 Change-Id: Ib889ee85226d0560b49b968cd0838a19a10f0cd0 Reviewed-on: https://chromium-review.googlesource.com/1168147 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#585607}
-
Dominic Mazzoni authored
With this change, creating an AXContext for a Document is the only way to enable accessibility. As long as there's at least one AXContext associated with a Document, it will have an AXObjectCache, and as soon as the last AXContext goes out of scope, the Document will destroy its AXObjectCache. This completely replaces the accessibilityEnabled setting and ScopedAXObjectCache, which interacted poorly with each other. See bug and mini design doc (go/axcontext) for more details. Bug: 867324 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia84372ec49c93931ea8c2de11ab909475893277c Reviewed-on: https://chromium-review.googlesource.com/1150824 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#585606}
-
David Benjamin authored
SHA-1 enforcement has shipped and stuck. Unwind the escape hatch. Bug: none Change-Id: I7eafada1c4bd81251edf8fa2c50a135455e125c5 Reviewed-on: https://chromium-review.googlesource.com/1186706Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#585605}
-
Daniel Rubery authored
We can't rely on the target_url to be valid when looking for a retargeting event, since the new tab may be navigated away from its original destination before anything commits. This CL should be safe since it seems impossible to make the current URL empty, except for the initial empty URL when opening a new window. Bug: 876768 Change-Id: I72860d3e5404a86511e3f247b94fdf6a6a12c2b4 Reviewed-on: https://chromium-review.googlesource.com/1187278Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#585604}
-
Kevin Marshall authored
WebrunnerMainDelegate has a DCHECK for context channel handle, but the handle won't be used for any processes except the browser/Context. The DCHECK blows up when child processes like renderers and GPU are launched. This CL removes those DCHECKs. Change-Id: I405d9e53a26543b0042e43c41c57d9098fd1c02e Reviewed-on: https://chromium-review.googlesource.com/1187374 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#585603}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ee0c9aa66269..ce6a1cc587a7 git log ee0c9aa66269..ce6a1cc587a7 --date=short --no-merges --format='%ad %ae %s' 2018-08-23 hnakashima@chromium.org Reorder RenderResult and RenderDeviceResult in CBC_TwoDimWriter. 2018-08-23 tsepez@chromium.org Remove bool bPromptCJK argument (several places) 2018-08-23 hnakashima@chromium.org Remove m_bTruncated flag from CBC_PDF417Writer. 2018-08-23 tsepez@chromium.org Fold CPDF_Document::LoadDocInternal() into caller. 2018-08-23 tsepez@chromium.org BUILD.gn - put cfx_windowsrenderdevice.h in win-specific section. Created with: gclient setdep -r src/third_party/pdfium@ce6a1cc587a7 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I06a60b719cbd6372e0d7eab4e7740b94205292db Reviewed-on: https://chromium-review.googlesource.com/1187282Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585602}
-
Andrew Xu authored
Apply the same logic of tab refreshing in original code to each selected tab. Before modification, Only one tab was refreshed after pressing Ctrl-R regardless of how many tabs you selected. But pressing Ctrl-W was able to close several tabs. R=afakhry@chromium.org Bug: 862102 Test: browser tests Change-Id: I8f038c0bffccde3b57f071046fbca99f5e9d7ed4 Reviewed-on: https://chromium-review.googlesource.com/1180516 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#585601}
-
Stephen Martinis authored
This is a reland of 2db41802 This CL will not schedule builds on the bots initially. This will let me test what's going wrong without breaking the waterfall and confusing sheriffs. Original change's description: > Add debug chromium bots > > These are mirrors of the existing release bots > > Bug: 867725 > Change-Id: I6f59d04a82103572e801273e294534e822d3e03d > Reviewed-on: https://chromium-review.googlesource.com/1159172 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: Nodir Turakulov <nodir@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582390} Bug: 867725 Change-Id: Ic401e310241bb986f3fbba4666e2e9bfa191be5a Reviewed-on: https://chromium-review.googlesource.com/1184120 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Aldo Culquicondor authored
VrShellGl no longer inherits from RenderLoop, instead it's owned by it. VrShellGl implements both SchedulerDelegate and CompositorDelegate. All communication to the delegates from VrShell go through the RenderLoop. Bug: 875291 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ifb9def1ea748648e3eea2dac1c80b48d7da07e5c Reviewed-on: https://chromium-review.googlesource.com/1185380 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#585599}
-
Robert Ogden authored
Prevents navigations to media URLs (like an mp4 or jpg) from triggering HTTPS Server Previews. This blacklist is a comma separated string that is controlled via field trial. Bug: 864637 Change-Id: Iff545d975c8c17aa433a95f57d8a01d86cf73279 Reviewed-on: https://chromium-review.googlesource.com/1187200Reviewed-by:
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I73274f6ea1965347f555af835fcb079331e178f9 Reviewed-on: https://chromium-review.googlesource.com/1187325Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585597}
-
Douglas Creager authored
This lets non-browser native apps preconfigure a list of domain names under their control, and allow Reporting and NEL to collect reports about those domains before receiving configuration headers from actual responses. (Note that once a policy header is received in an actual response, that will take precedence over any preconfigured headers.) Bug: 811472 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5e64020e5f75485c676dd0751f1dc444fb07e472 Reviewed-on: https://chromium-review.googlesource.com/1171112Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Douglas Creager <dcreager@chromium.org> Cr-Commit-Position: refs/heads/master@{#585596}
-
Zhongyi Shi authored
Changes to make quic::simulator usable in Quartc tests: - Make //third_party/quic/test_tools/simulator visible to //media/webrtc/quartc - Make the QuicClock* passed to QuartcFactory const Quartc has its own transport simulators, but these run in real-time, making them less useful for writing consistent unit tests. In particular, it's much easier to test deadlines and execution of alarm-based async code using a controlled environment with a fake clock. The QUIC simulator provides this. Merge internal change: 208743968 https://chromium-review.googlesource.com/c/chromium/src/+/1186095 Switch QuartcSessionTest to use QUIC's simulator components rather than its own. QuartcSessionTest contains a rudimentary implementation of network link simulation. This is basically the same thing that QUIC's Simulator provides. Now that we've implemented a Simulator-compatible QuartcPacketTransport, we can use the Simulator and its utilities rather than rolling our own. The only requirements to do this are: 1. Implement a packet filter to drop packets (to test cancel-on-loss) 2. Intercept packet numbers in the simulated transport (to test our packet-number hack) The former is far simpler than implementing all our own test facilities. The latter should be temporary (until we can move this test somewhere else or QUIC provides packet numbers through the writer interface). Merge internal change: 208705925 https://chromium-review.googlesource.com/c/chromium/src/+/1186090 Create a QuartcPacketTransport implementation that uses QUIC's test simulator. This implementation uses the simulator interfaces in quic/test_tools/simulator to send and receive packets. The QUIC network simulator uses a fake clock to schedule all network events. It should make it possible to write deterministic component tests for quic/quartc code. The simulated transport is a quic::simulator::Endpoint which can be connected to other endpoints through a fabric of quic::simulator:: links and switches. It implements the UnconstrainedPortInterface to receive packets. Received packets are passed to the Delegate. The transport keeps a queue for outgoing packets (to simulate an OS or NIC queue before the local link). When this queue is full, it rejects calls to Write(). It implements Queue::ListenerInterface to observe dequeue events and calls Delegate::OnTransportCanWrite() to unblock the caller whenever room is available for more packets. Finally, Quartc packet writers will not start writing until they observe an initial OnTransportCanWrite() signal. The packet transport schedules a call to this method as soon as the delegate is set. This is similar to the behavior of real Quartc transport implementations such as ICE, which makes an initial call to OnTransportReadyToSend() after ICE establishes a connection. Merge internal change: 208570696 https://chromium-review.googlesource.com/c/chromium/src/+/1186079 Change-Id: I19a8a62838c7080fc4e644c039c389253df61cac Reviewed-on: https://chromium-review.googlesource.com/1186096Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#585595}
-
Kurt Horimoto authored
This CL updates CRWWebViewContentView to utilize the normal UIView layout flow to resize the WKWebView rather than explicitly calling |-updateWebViewFrame|. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8e4a3c464483818c9799424c097f5ed7711d6d8e Reviewed-on: https://chromium-review.googlesource.com/1186099Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#585594}
-
Krishna Govind authored
R=abdulsyed@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0c6dfe3a70c996789a01500b4186a9574613f938 Reviewed-on: https://chromium-review.googlesource.com/1187369Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#585593}
-
Cole Winstanley authored
This reverts commit 7464a454. Reason for revert: Causing waterfall failures. Going to rethink test structure. Original change's description: > [ChromeDriver] Reland with fix: add replay tests to run_all_tests.py > > Bug: chromedriver:2553 > Change-Id: I4c8d50c819f128ced652bc397bb294de3984ed2e > Reviewed-on: https://chromium-review.googlesource.com/1185783 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Cole Winstanley <cwinstanley@google.com> > Cr-Commit-Position: refs/heads/master@{#585267} TBR=johnchen@chromium.org,cwinstanley@google.com Change-Id: I544dbfa8e5fc68d0c60a70a15b328c805300daec No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromedriver:2557 Reviewed-on: https://chromium-review.googlesource.com/1187087Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Cole Winstanley <cwinstanley@google.com> Cr-Commit-Position: refs/heads/master@{#585592}
-
Eugene But authored
Do not create radial progress path until the view is added to the hierarchy. Bug: 875932 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic4bfab416cdc6dd4cf3e7a1b4c1f4624b7cab0bf Reviewed-on: https://chromium-review.googlesource.com/1182867Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#585591}
-
Nico Weber authored
https://chromium-review.googlesource.com/706280 resolved it. Bug: none Change-Id: Ifedb80be1c3a8ad2af17552e024d7b6e0228ff03 Reviewed-on: https://chromium-review.googlesource.com/1187198Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#585590}
-
Wez authored
Delete the AsyncLayerTreeFrameSink from the |bg_thread|, on which the test actually uses it. Bug: 729716 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id1fd667d44bb2a8e1b6cbd973f1ec0708f47ee99 Reviewed-on: https://chromium-review.googlesource.com/1186186Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#585589}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/81db1d50324a..d06cc78ec8cc git log 81db1d50324a..d06cc78ec8cc --date=short --no-merges --format='%ad %ae %s' 2018-08-23 tandrii@chromium.org git cl: use project~number on Gerrit in more RPCs. Created with: gclient setdep -r src/third_party/depot_tools@d06cc78ec8cc The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:876910 TBR=agable@chromium.org Change-Id: Id8cdcbed896cfc23f316a78e1dbccbd6699e2503 Reviewed-on: https://chromium-review.googlesource.com/1187201Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585588}
-
W. James MacLean authored
Adds logging to SitePerProcessEmulatedTouchBrowserTest.EmulatedTouchShowPressHasTouchID to verify the gesture stream when the test times out. Bug: 833380 Change-Id: I8cf2e92a6f13aa38e3294f4511d53ce658cd62a5 Reviewed-on: https://chromium-review.googlesource.com/1187280Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#585587}
-
Drew Davenport authored
Some use cases, such as some implementations of realpath(), require calling stat() on all intermediate dirs of a path, but otherwise do not need to open or read those directories. Bug=b:112486795 Test=sandbox_linux_unittests passed Change-Id: Iea0bad8be9e238a854de383ac6dc5124f462ead3 Reviewed-on: https://chromium-review.googlesource.com/1185376Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Drew Davenport <ddavenport@chromium.org> Cr-Commit-Position: refs/heads/master@{#585586}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/132145aa..6d5c73cf Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6825e1d5079de8edf509d1cbf5234d2263135f6d Reviewed-on: https://chromium-review.googlesource.com/1187184Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585585}
-
Becky Zhou authored
Bug: 851981 Change-Id: I2e97155353f2119661df92cdd023e2e086328d18 Reviewed-on: https://chromium-review.googlesource.com/1157441 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#585584}
-
James Cook authored
Now that ash and the ui service are in the same process we don't need to use PointerWatcher in ash anymore. This is a partial manual revert of: https://codereview.chromium.org/1934123004/ Bug: 595851, 872450 Test: ash_unittests Change-Id: Ifbbb407210d0b3ec8d20993bff7a0f2cf44ba38e Reviewed-on: https://chromium-review.googlesource.com/1186032 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#585583}
-
Miguel Casas authored
This CL folds VaapiJpegDecoder, a class with only one static method, into its only caller VaapiJpegDecodeAccelerator. The static method, VaapiJpegDecoder::Decode(), is renamed to DoDecode(). This method and the bunch of file-static ones are moved verbatim -- untouched. It also takes the chance to clean up: removes unused includes and member variables, and forward declares as much as possible (otherwise va/va.h, a pretty large file was transitively included, ugh). All in all, less lines ! Test: jpeg_decode_accelerator_unittests passing as before. Bug: 876810 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1f37f378121840d6d1eb83018c5122bb0ed6b01c Reviewed-on: https://chromium-review.googlesource.com/1185218Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#585582}
-
Jinho Bang authored
Related spec change: https://github.com/w3c/payment-request/pull/721 Tests: chrome/browser/ui/views/payments/contact_info_editor_view_controller_browsertest.cc chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc components/payments/content/payment_request_spec_unittest.cc components/payments/content/payment_request_state_unittest.cc Manual tests: wpt/payment-request/payment-response/retry-method-manual.https.html wpt/payment-request/PaymentValidationErrors/retry-shows-shippingAddress-member-manual.https.html wpt/payment-request/PaymentValidationErrors/retry-shows-payer-member-manual.https.html Demo: https://youtu.be/_mbcGkbwfw8 Bug: 861704 Change-Id: I12c2d74f7b170626d2c9a41ecfc9116bfe75c2b7 Reviewed-on: https://chromium-review.googlesource.com/1144587 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#585581}
-
John Z Wu authored
Currently all CSP errors are reported wrongly as INITIALIZATION_ERROR, this change will report it as BAD_ORIGIN. Change-Id: I2cc09d9dcd722ab0657605e540acac69e142eb6c Bug: 686364 Reviewed-on: https://chromium-review.googlesource.com/1141047 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
-
